From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore Date: Wed, 21 Dec 2016 11:07:12 +0000 Message-ID: References: <8760mr26dr.fsf@openmailbox.org> <87eg13b4jk.fsf@users.sourceforge.net> <878tr9c4bn.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c043920a14d3e05442927b2 X-Trace: blaine.gmane.org 1482318514 2161 195.159.176.226 (21 Dec 2016 11:08:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Dec 2016 11:08:34 +0000 (UTC) Cc: Mark Karpov , 25157@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 21 12:08:30 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJeks-0007UX-KQ for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Dec 2016 12:08:18 +0100 Original-Received: from localhost ([::1]:56281 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJekx-0004ac-46 for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Dec 2016 06:08:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJekh-0004Wz-EM for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2016 06:08:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJekc-0004Yk-Fb for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2016 06:08:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34304) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cJekc-0004Yg-7x for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2016 06:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cJekc-0005a9-2g for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2016 06:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Dec 2016 11:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25157 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 25157-submit@debbugs.gnu.org id=B25157.148231843921405 (code B ref 25157); Wed, 21 Dec 2016 11:08:02 +0000 Original-Received: (at 25157) by debbugs.gnu.org; 21 Dec 2016 11:07:19 +0000 Original-Received: from localhost ([127.0.0.1]:49703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJejv-0005ZB-Lw for submit@debbugs.gnu.org; Wed, 21 Dec 2016 06:07:19 -0500 Original-Received: from mail-qk0-f178.google.com ([209.85.220.178]:36226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJeju-0005Yz-7C for 25157@debbugs.gnu.org; Wed, 21 Dec 2016 06:07:18 -0500 Original-Received: by mail-qk0-f178.google.com with SMTP id n21so72399351qka.3 for <25157@debbugs.gnu.org>; Wed, 21 Dec 2016 03:07:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=iMlXc/8aFUnurN1O7ChWQTKSXC460VYClI3sHifzMO0=; b=hpZuo7CFaDiytJ/S8+HVwf/X1sNQwbYvW0BewDqY/c8wjKrlIHa85I2pk9mh/3hXu/ ugVOr4NASmFY5cihrn6Y7Y36jJR7HHjyv32UykkuxlMQdWbM8ZtcNxoQhf/DyRCd84a0 elnG3P7ETsEYJ2O1OT3eu0M6q0sNWRgFppKR8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iMlXc/8aFUnurN1O7ChWQTKSXC460VYClI3sHifzMO0=; b=c3eYq7XyIJxKPlxRNkwOvl2hYUpLLWDpwbh95fv1HM3equ6d96ehIreAPyipOOo8qR 4aNytFUg4EuFb/StDWC8iOAthR2yx4ivOHq7iFC2UNipPE1S4HrfjzkeAUHaQbQzaaun iZ19XLzlZDEo0GHOX88pMZNGgoyRXa63LQDMAmeweHR27vTghYV0UA6UCOAS8SwgJNqo Sgn8DE4n505XIwjDVP0unQijJWucariYiB8jcvAX7l+T2bijQ3GAp3Hj0+6kvnamDc8t WHT6Uzt74tatNiLb3/VE78tKAIzEHfrSgc4stwrd04zAtrJKLoXudNtD1aQ8nUjtjgC6 F/3g== X-Gm-Message-State: AIkVDXJfAgPlH1cAx+qVwG/QcN5j4BM2w9vVXbxUX2RFMAgmoi7ksof/H0qz+cPuGwoFtfnVJ4G60BzYHURqQWGT X-Received: by 10.55.185.133 with SMTP id j127mr3867975qkf.39.1482318432748; Wed, 21 Dec 2016 03:07:12 -0800 (PST) Original-Received: by 10.140.88.51 with HTTP; Wed, 21 Dec 2016 03:07:12 -0800 (PST) In-Reply-To: <878tr9c4bn.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127287 Archived-At: --94eb2c043920a14d3e05442927b2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 21 December 2016 at 04:07, wrote: > > Sorry I didn't get around to looking at this before you wrote a patch, > but I think you're overthinking this. I confirm that your patch seems to work, thanks very much. Adding some tests is particularly helpful: if I'd done that, I wouldn't have gotten in this mess in the first place! How can one overthink a logical problem? It's possible to underthink, but in this case, I believe I misunderstood what the whitespace-empty-at-eob-regexp was supposed to match: only empty lines, not trailing space at the end of non-empty lines (as one of your comments mentions). (I was trying to make it match ALL the whitespace at the end of the buffer, as you probably realised.) The only thing I'd change in your match is, as in mine, remove the FIXME after save-match-data.=E2=80=8B --94eb2c043920a14d3e05442927b2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On = 21 December 2016 at 04:07, <npostavs@users.sourceforge.net> wrote:

Sorry I didn't get around to looking at this before you wrote a = patch,
but I think you're overthinking this.


How can one overthink a logical problem? It's possible to un= derthink, but in this case, I believe I misunderstood what the whitespace-e= mpty-at-eob-regexp was supposed to match: only empty lines, not trailing sp= ace at the end of non-empty lines (as one of your comments mentions). (I wa= s trying to make it match ALL the whitespace at the end of the buffer, as y= ou probably realised.)

Th= e only thing I'd change in your match is, as in mine, remove the FIXME = after save-match-data.=E2=80=8B

--94eb2c043920a14d3e05442927b2--