From: Reuben Thomas <rrt@sc3d.org>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: Mark Karpov <markkarpov@openmailbox.org>, 25157@debbugs.gnu.org
Subject: bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore
Date: Wed, 21 Dec 2016 11:07:12 +0000 [thread overview]
Message-ID: <CAOnWdoizDVm0zWCpOnXin5bhKDywTmj-4mDJMwcrW_X8O5Nm4Q@mail.gmail.com> (raw)
In-Reply-To: <878tr9c4bn.fsf@users.sourceforge.net>
[-- Attachment #1: Type: text/plain, Size: 868 bytes --]
On 21 December 2016 at 04:07, <npostavs@users.sourceforge.net> wrote:
>
> Sorry I didn't get around to looking at this before you wrote a patch,
> but I think you're overthinking this.
I confirm that your patch seems to work, thanks very much. Adding some
tests is particularly helpful: if I'd done that, I wouldn't have gotten in
this mess in the first place!
How can one overthink a logical problem? It's possible to underthink, but
in this case, I believe I misunderstood what the
whitespace-empty-at-eob-regexp was supposed to match: only empty lines, not
trailing space at the end of non-empty lines (as one of your comments
mentions). (I was trying to make it match ALL the whitespace at the end of
the buffer, as you probably realised.)
The only thing I'd change in your match is, as in mine, remove the FIXME
after save-match-data.
[-- Attachment #2: Type: text/html, Size: 1561 bytes --]
next prev parent reply other threads:[~2016-12-21 11:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 14:41 bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore Mark Karpov
2016-12-20 4:36 ` npostavs
2016-12-20 18:37 ` Reuben Thomas
2016-12-21 0:51 ` Reuben Thomas
2016-12-21 4:07 ` npostavs
2016-12-21 11:07 ` Reuben Thomas [this message]
2016-12-22 2:18 ` npostavs
2016-12-22 12:53 ` Reuben Thomas
2016-12-23 0:03 ` npostavs
2016-12-23 10:44 ` Reuben Thomas
2016-12-24 15:34 ` npostavs
2016-12-26 22:37 ` Reuben Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOnWdoizDVm0zWCpOnXin5bhKDywTmj-4mDJMwcrW_X8O5Nm4Q@mail.gmail.com \
--to=rrt@sc3d.org \
--cc=25157@debbugs.gnu.org \
--cc=markkarpov@openmailbox.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.