From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 690512d: Fix a FIXME with an exegetical comment Date: Fri, 25 Aug 2017 22:20:03 +0100 Message-ID: References: <20170825125953.23848.98653@vcs0.savannah.gnu.org> <20170825125953.D61F420EC0@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1503696083 15154 195.159.176.226 (25 Aug 2017 21:21:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 25 Aug 2017 21:21:23 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 25 23:21:18 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlM2G-0002oH-0D for ged-emacs-devel@m.gmane.org; Fri, 25 Aug 2017 23:21:05 +0200 Original-Received: from localhost ([::1]:55120 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlM2M-0006Kt-LH for ged-emacs-devel@m.gmane.org; Fri, 25 Aug 2017 17:21:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlM1P-0006H7-T8 for emacs-devel@gnu.org; Fri, 25 Aug 2017 17:20:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dlM1O-0008CO-Gs for emacs-devel@gnu.org; Fri, 25 Aug 2017 17:20:07 -0400 Original-Received: from mail-oi0-x235.google.com ([2607:f8b0:4003:c06::235]:36662) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dlM1O-00087B-96 for emacs-devel@gnu.org; Fri, 25 Aug 2017 17:20:06 -0400 Original-Received: by mail-oi0-x235.google.com with SMTP id r9so8585894oie.3 for ; Fri, 25 Aug 2017 14:20:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=X12mK5ggnRlX2TjMm09XY0e0DQadASjvMR0KgLDRzK8=; b=B6N72ElZl5UetBJRVdab0wDA8GBWdelSIn9Cb3/sEJxquhleykM/pjq1kY/CrurYX8 z98SuwVoCTnib3zqZG9+ajcyGxDxDuvbo6OlgTZbuFgeIczPE60RHboJY5Y5PJplLBno E+7spcGhBn5jn7rzstA+/CQn6sMy2Np/aIsxI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=X12mK5ggnRlX2TjMm09XY0e0DQadASjvMR0KgLDRzK8=; b=XQ+Vk049VFLXnadSRF+HxSmdqVZjoMiz+FzgLYuja5EQqaJR3Ltm0v/6ck7RQcjtru uE7/pk8S9n02FBMV41DAK8KYg59M7s91LDP9SRXI4HYQ8iETNetHKkiIQmqEA5akG71h WOqAuaF0l1K7/JNaIlNNFE+ppk2c3XM7wsxkEqMaV8ejFP++7gUEJ84JtY6AcALaXJ8U oH66HA8+Qxbl5dHp5Ri5+ekY4z0r1aCFiI+i3QGf+85PgTuqE56Nly+RcMzt+oup9NKU liFRhPzYEzkVC6Uh3vtuifTvSzRveMwm8+B+scKBtW/uMDkZbRvwcKql/tDi6jcl+fZV 7c0Q== X-Gm-Message-State: AHYfb5jDNhnfaw42hj2vY7EeJrtGMT+6DwRc3civ+bpf/NcypNGFAYfx +T5eyZmHZOFA47t7e73K9CuJuNBDxfYb X-Received: by 10.202.230.4 with SMTP id d4mr15762040oih.148.1503696004047; Fri, 25 Aug 2017 14:20:04 -0700 (PDT) Original-Received: by 10.157.53.86 with HTTP; Fri, 25 Aug 2017 14:20:03 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217822 Archived-At: On 25 August 2017 at 22:02, Stefan Monnier wrote: >> (wksh sh-append ksh88 >> - ;; FIXME: This looks too much like a regexp. --Stef >> + ;; wksh has X toolkit APIs as built-ins! >> "Xt[A-Z][A-Za-z]*") > > But AFAICT sh-builtins is passed to `regexp-opt', so the above will > simply treat the command with name "Xt[A-Z][A-Za-z]*" as a builtin, > instead of recognizing any command that matches this regexp. I'm sorry, I misunderstood what regexp-opt does; I should have looked it up. Since wksh is as far as I can tell a historical curiosity, the simplest thing would be to remove the setting for it. Does that seem reasonable? -- https://rrt.sc3d.org