From: Reuben Thomas <rrt@sc3d.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 690512d: Fix a FIXME with an exegetical comment
Date: Fri, 25 Aug 2017 22:20:03 +0100 [thread overview]
Message-ID: <CAOnWdoirCOGtQdko-3tGuBkyxQ5EvU4EnpT4g2v7V7-rogPQCw@mail.gmail.com> (raw)
In-Reply-To: <jwvinhb4b2q.fsf-monnier+emacsdiffs@gnu.org>
On 25 August 2017 at 22:02, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> (wksh sh-append ksh88
>> - ;; FIXME: This looks too much like a regexp. --Stef
>> + ;; wksh has X toolkit APIs as built-ins!
>> "Xt[A-Z][A-Za-z]*")
>
> But AFAICT sh-builtins is passed to `regexp-opt', so the above will
> simply treat the command with name "Xt[A-Z][A-Za-z]*" as a builtin,
> instead of recognizing any command that matches this regexp.
I'm sorry, I misunderstood what regexp-opt does; I should have looked it up.
Since wksh is as far as I can tell a historical curiosity, the
simplest thing would be to remove the setting for it. Does that seem
reasonable?
--
https://rrt.sc3d.org
next prev parent reply other threads:[~2017-08-25 21:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170825125953.23848.98653@vcs0.savannah.gnu.org>
[not found] ` <20170825125953.D61F420EC0@vcs0.savannah.gnu.org>
2017-08-25 21:02 ` [Emacs-diffs] master 690512d: Fix a FIXME with an exegetical comment Stefan Monnier
2017-08-25 21:20 ` Reuben Thomas [this message]
2017-08-26 7:41 ` Eli Zaretskii
2017-08-26 8:02 ` Reuben Thomas
2017-08-26 8:10 ` Paul Eggert
2017-08-26 23:29 ` Reuben Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOnWdoirCOGtQdko-3tGuBkyxQ5EvU4EnpT4g2v7V7-rogPQCw@mail.gmail.com \
--to=rrt@sc3d.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.