From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore Date: Fri, 23 Dec 2016 10:44:54 +0000 Message-ID: References: <8760mr26dr.fsf@openmailbox.org> <87eg13b4jk.fsf@users.sourceforge.net> <878tr9c4bn.fsf@users.sourceforge.net> <8760mcbta2.fsf@users.sourceforge.net> <87tw9va4uu.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113572ba9a604a05445113d5 X-Trace: blaine.gmane.org 1482489981 15558 195.159.176.226 (23 Dec 2016 10:46:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Dec 2016 10:46:21 +0000 (UTC) Cc: Mark Karpov , 25157@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 23 11:46:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKNMY-0002Z6-10 for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Dec 2016 11:46:10 +0100 Original-Received: from localhost ([::1]:38425 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKNMa-0008UN-Sq for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Dec 2016 05:46:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKNMU-0008U3-72 for bug-gnu-emacs@gnu.org; Fri, 23 Dec 2016 05:46:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKNMR-0000Ks-16 for bug-gnu-emacs@gnu.org; Fri, 23 Dec 2016 05:46:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36685) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cKNMQ-0000Kl-Og for bug-gnu-emacs@gnu.org; Fri, 23 Dec 2016 05:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cKNMQ-000168-Dl for bug-gnu-emacs@gnu.org; Fri, 23 Dec 2016 05:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Dec 2016 10:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25157 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 25157-submit@debbugs.gnu.org id=B25157.14824899034139 (code B ref 25157); Fri, 23 Dec 2016 10:46:02 +0000 Original-Received: (at 25157) by debbugs.gnu.org; 23 Dec 2016 10:45:03 +0000 Original-Received: from localhost ([127.0.0.1]:52083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKNLS-00014g-MR for submit@debbugs.gnu.org; Fri, 23 Dec 2016 05:45:02 -0500 Original-Received: from mail-qt0-f172.google.com ([209.85.216.172]:33384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKNLR-00013v-2J for 25157@debbugs.gnu.org; Fri, 23 Dec 2016 05:45:01 -0500 Original-Received: by mail-qt0-f172.google.com with SMTP id p16so255192278qta.0 for <25157@debbugs.gnu.org>; Fri, 23 Dec 2016 02:45:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Owu4Py1Kykyjgez2mTeIMrkarEiO+Sy3cayco2KtF8o=; b=fbA/LobcHCDpT9fucloB4tfX7MeVTMFaQbDBAgFUggF8J0PPB+XC9OV8hVAwDsxHyg OdBHfsIEzFJRWdvmf0ba0Yyi1cb0Sf9w+dfzCFlNjeNFHdWMoBeOpSiWNn3KWUQUQDhQ JqhT4j/Mn/S5Cj18tASRh4k8c+szMxm5RJslA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Owu4Py1Kykyjgez2mTeIMrkarEiO+Sy3cayco2KtF8o=; b=qGL060zOmE2UI2SEqIs2zmUeidGtoFreBHZDNtTwZMgo6CBp5nWmVICXjpeKDZYaND hbrcm1PGlMmtHDgNLz2YubtX+fHqHrhSMnsiebfmHLx7XZyZo718uDrGQsX6xwCV6AjW JcSf64qcVSyN9t4fhY+gpzFXdjszGuinjCBYDBMfSIqk3rs80dJGDcspqSKWY5/byc/3 Wy2GXKCxKIzcSq1Ynd5zoqDKypaj8d3Z2S7C243aiBgrV86qtieRoskpetbBBrLE3Z91 LhkDw3Iy7/xH6AD6V3tPQBp39RT4yDGA7olF4jGC2Pd2nFJDqsAxwtsCRy0ssGViFYZD HEmQ== X-Gm-Message-State: AIkVDXInAFBJxllUHgChTq9Avrjs1XiAiYgZ8CWKFRU1mJBFn/wG6+yyCR7SqAhdTC4InbgIKI6oTlH/siyqD2CZ X-Received: by 10.200.44.202 with SMTP id 10mr11386228qtx.156.1482489895464; Fri, 23 Dec 2016 02:44:55 -0800 (PST) Original-Received: by 10.140.88.51 with HTTP; Fri, 23 Dec 2016 02:44:54 -0800 (PST) In-Reply-To: <87tw9va4uu.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127356 Archived-At: --001a113572ba9a604a05445113d5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 23 December 2016 at 00:03, wrote: > Reuben Thomas writes: > > > On Dec 22, 2016 2:17 AM, wrote: > >> > > >> > The only thing I'd change in your match is, as in mine, remove the > FIXME after save-match-data.=E2=80=8B > >> > >> (whitespace-cleanup): Remove a FIXME: the reason for save-match-data > >> is the call of re-search-forward. > >> > >> I'm not sure this is a sufficient explanation of why save-match-data i= s > >> needed. Usually in Emacs the caller is responsible for saving the matc= h > >> data, if it needs to. I don't really see the need here. > > > > Can it be removed then? > > Probably yes. =E2=80=8BGreat; can you then install a suitable patch, please? --=20 http://rrt.sc3d.org --001a113572ba9a604a05445113d5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On = 23 December 2016 at 00:03, <npostavs@users.sourceforge.net> wrote:
Reuben Thomas <= rrt@sc3d.org> writes:

> On Dec 22, 2016 2:17 AM, <npostavs@users.sourceforge.net> wrote:
>> >
>> > The only thing I'd change in your= match is, as in mine, remove the FIXME after save-match-data.=E2=80=8B
>>
>> (whitespace-cleanup): Remove a FIXME: the reason for save-match-da= ta
>> is the call of re-search-forward.
>>
>> I'm not sure this is a sufficient explanation of why save-matc= h-data is
>> needed. Usually in Emacs the caller is responsible for saving the = match
>> data, if it needs to. I don't really see the need here.
>
> Can it be removed then?

Probably yes.

=E2=80=8BGreat; can you then install a suitable= patch, please?

--
http://rrt.sc3d.org
--001a113572ba9a604a05445113d5--