bug#17009: Please add a hook to visual-line-mode

bug#17009: Please add a hook to visual-line-mode

[Reuben Thomas]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

It would be nice to be able to activate window-margin-mode when
visual-line-mode is turned on:

https://github.com/aculich/window-margin.el

-- 
http://rrt.sc3d.org

[-- Attachment #2: Type: text/html, Size: 318 bytes --]

bug#17009: Please add a hook to visual-line-mode

[Glenn Morris]

Modes defined with define-minor-mode have hooks.

C-h v visual-line-mode-hook

    visual-line-mode-hook is a variable defined in `simple.el'.
    Its value is (visual-line-mode-set-explicitly)

    This variable may be risky if used as a file-local variable.

    Documentation:
    Hook run after entering or leaving `visual-line-mode'.
    No problems result if this variable is not bound.
    `add-hook' automatically binds it.  (This is true for all hook
    variables.)

bug#17009: Please add a hook to visual-line-mode

[Reuben Thomas]

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

On 14 March 2014 07:50, Glenn Morris <rgm@gnu.org> wrote:

>
> Modes defined with define-minor-mode have hooks.
>
> C-h v visual-line-mode-hook
>
>     visual-line-mode-hook is a variable defined in `simple.el'.
>     Its value is (visual-line-mode-set-explicitly)
>
>     This variable may be risky if used as a file-local variable.
>
>     Documentation:
>     Hook run after entering or leaving `visual-line-mode'.
>     No problems result if this variable is not bound.
>     `add-hook' automatically binds it.  (This is true for all hook
>     variables.)
>

Great! Is this new in 24.4, because this doesn't work for me?

-- 
http://rrt.sc3d.org

[-- Attachment #2: Type: text/html, Size: 1118 bytes --]

bug#17009: Please add a hook to visual-line-mode

[Stefan Monnier]

> Great! Is this new in 24.4, because this doesn't work for me?

No, it's been there from the very beginning.  What do you mean by
"doesn't work"?


        Stfean

bug#17009: Please add a hook to visual-line-mode

[Reuben Thomas]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

On 14 March 2014 13:39, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> > Great! Is this new in 24.4, because this doesn't work for me?
>
> No, it's been there from the very beginning.  What do you mean by
> "doesn't work"?
>

C-h v visual-line-mode-hook [No match]

So this is a hook that magically comes into existence if I assign to it:
having done so, C-h v now works.

This is all rather confusing; thanks for straightening me out.

-- 
http://rrt.sc3d.org

[-- Attachment #2: Type: text/html, Size: 932 bytes --]

bug#17009: Please add a hook to visual-line-mode

[Dmitry Gutov]

Reuben Thomas <rrt@sc3d.org> writes:

> So this is a hook that magically comes into existence if I assign to it:
> having done so, C-h v now works.

That's true of all hooks: a hook variable doesn't have to be defined for
`add-hook' or `run-hooks' to work. Of course, the latter won't do
anything in that case.

bug#17009: Please add a hook to visual-line-mode

[Stefan]

> C-h v visual-line-mode-hook [No match]

Who cares?  Use it anyway: it will work.

Quoting the message Glenn send you earlier:

>     No problems result if this variable is not bound.
>     `add-hook' automatically binds it.  (This is true for all hook
>     variables.)


-- Stefan

bug#17009: Please add a hook to visual-line-mode

[Reuben Thomas]

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

On 14 March 2014 16:49, Stefan <monnier@iro.umontreal.ca> wrote:

> > C-h v visual-line-mode-hook [No match]
>
> Who cares?  Use it anyway: it will work.
>

Even from a careful reading of the documentation, it's not obvious that the
variable not being bound means that its documentation will not be
available: it's reasonable to think that C-h v not working means that
something is wrong. Sure, it works, but discoverability is not great.

-- 
http://rrt.sc3d.org

[-- Attachment #2: Type: text/html, Size: 878 bytes --]

bug#17009: Please add a hook to visual-line-mode

[Glenn Morris]

Reuben Thomas wrote:

> Even from a careful reading of the documentation, it's not obvious that the
> variable not being bound means that its documentation will not be
> available: it's reasonable to think that C-h v not working means that
> something is wrong. Sure, it works, but discoverability is not great.

That's the part that will be different in 24.4.


2013-05-27  Stefan Monnier  <monnier@iro.umontreal.ca>

            * emacs-lisp/easy-mmode.el (define-minor-mode):
            * emacs-lisp/derived.el (define-derived-mode): Always defvar
            the mode hook and provide a docstring.

bug#17009: Please add a hook to visual-line-mode

[Kevin Rodgers]

On 3/14/14 11:12 AM, Glenn Morris wrote:
> Reuben Thomas wrote:
>
>> Even from a careful reading of the documentation, it's not obvious that the
>> variable not being bound means that its documentation will not be
>> available: it's reasonable to think that C-h v not working means that
>> something is wrong. Sure, it works, but discoverability is not great.
>
> That's the part that will be different in 24.4.
>
>
> 2013-05-27  Stefan Monnier<monnier@iro.umontreal.ca>
>
>              * emacs-lisp/easy-mmode.el (define-minor-mode):
>              * emacs-lisp/derived.el (define-derived-mode): Always defvar
>              the mode hook and provide a docstring.

:-)

http://lists.gnu.org/archive/html/help-gnu-emacs/2008-03/msg00136.html

-- 
Kevin Rodgers
Denver, Colorado, USA

bug#17009: Please add a hook to visual-line-mode

[Stefan Monnier]

> http://lists.gnu.org/archive/html/help-gnu-emacs/2008-03/msg00136.html

Oh, yes, I know, this is a very long standing issue, both with
define-derived-mode and define-minor-mode.


        Stefan