From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#24745: 25.1.50; whitespace.el: fix beginning/end of buffer checks Date: Tue, 25 Oct 2016 19:44:27 +0100 Message-ID: References: <87pomv6w1h.fsf@sc3d.org> <83402aab-73d0-eeae-1df1-c717caf198ba@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a114113b2f43c0e053fb4e5ce X-Trace: blaine.gmane.org 1477421167 25245 195.159.176.226 (25 Oct 2016 18:46:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 25 Oct 2016 18:46:07 +0000 (UTC) Cc: 24745@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 25 20:46:01 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bz6iq-0001Jl-3V for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Oct 2016 20:45:16 +0200 Original-Received: from localhost ([::1]:57551 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz6is-0008VE-Cj for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Oct 2016 14:45:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz6if-0008QM-E7 for bug-gnu-emacs@gnu.org; Tue, 25 Oct 2016 14:45:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bz6ic-0002BK-6N for bug-gnu-emacs@gnu.org; Tue, 25 Oct 2016 14:45:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41277) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bz6ib-0002BD-UI for bug-gnu-emacs@gnu.org; Tue, 25 Oct 2016 14:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bz6ib-0006bt-ME for bug-gnu-emacs@gnu.org; Tue, 25 Oct 2016 14:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Oct 2016 18:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24745 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24745-submit@debbugs.gnu.org id=B24745.147742107725359 (code B ref 24745); Tue, 25 Oct 2016 18:45:01 +0000 Original-Received: (at 24745) by debbugs.gnu.org; 25 Oct 2016 18:44:37 +0000 Original-Received: from localhost ([127.0.0.1]:56675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bz6iD-0006ax-6Z for submit@debbugs.gnu.org; Tue, 25 Oct 2016 14:44:37 -0400 Original-Received: from mail-lf0-f54.google.com ([209.85.215.54]:40047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bz6iA-0006ai-Hj for 24745@debbugs.gnu.org; Tue, 25 Oct 2016 14:44:36 -0400 Original-Received: by mail-lf0-f54.google.com with SMTP id o16so15629957lff.7 for <24745@debbugs.gnu.org>; Tue, 25 Oct 2016 11:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vRGHUVp+tG/A4iYE/SRaVBVQk6H58W1p7R8hDe60cM8=; b=Q3kMkYfObpxvfeiWBjtiR6FtOK3wbrs/KmfqGRcCIcbhUwICx+h19s9yvoqAwhU0ly QOg2M/tvnqj8EfJuMb2Lws8QTImhU1FRzlbyWGlQWY20+wiKBhycrAQZ0jIuJWyNBJMe XmFU/CNfHdLGHQCQuLKVuMi1alq01RS6QWuPs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vRGHUVp+tG/A4iYE/SRaVBVQk6H58W1p7R8hDe60cM8=; b=dC5zUjD3cI6VIkw8fBhTHFIDyGqB5sHejX6B18+PmzElT3inAm1iEelttZgYW+hRbr 1q+TDx9BotPzw9dnngABDKWfy2ljuNF25+Q902imL9OLEdbRjsapxgUx/A3zeg9Po7rB CfeSwO+FWvF5hhtzhKBNvWuJmMa6a+sSUmqAxE5HpcZOfkFLfz2UgBDRFmfHzD/J0JDI LKNkXBFa5zRB/otZv72rwC+L3DsOQRwGbNdAz55WB6RDS/wrWYReXOC0w7RXOii23CpX ywAS4Po8WFRcVisUseF56e25QrGLKGIcROXl6FRf+KYF40u829KnI9pkEIx6nhthnJoN R2JA== X-Gm-Message-State: ABUngvfblZX1MVUy0SzP0ep1rCMz3611jME1hUWtB4sR1WyvjyZvAS7dG00RlO/xNv1r6Qxr0H9/QLHCrlMCsa9h X-Received: by 10.25.37.20 with SMTP id l20mr8360697lfl.88.1477421068190; Tue, 25 Oct 2016 11:44:28 -0700 (PDT) Original-Received: by 10.25.158.206 with HTTP; Tue, 25 Oct 2016 11:44:27 -0700 (PDT) In-Reply-To: <83402aab-73d0-eeae-1df1-c717caf198ba@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125012 Archived-At: --001a114113b2f43c0e053fb4e5ce Content-Type: multipart/alternative; boundary=001a114113b2f43c09053fb4e5cc --001a114113b2f43c09053fb4e5cc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 25 October 2016 at 00:36, Dmitry Gutov wrote: > =E2=80=8B=E2=80=8B > > A few comments on the patches themselves: > =E2=80=8BThanks very much for the review.=E2=80=8B - "remove duplicate documentation from the Commentary" sounds fine to me, > but maybe we should leave something in its stead. The first part can be > replaced with a reference to the `whitespace-style' docstring. The second > one... is it really that out of date? The list of variables seems like it > can be useful. > I should check some context: my understanding is that inline documentation in .el files is mainly useful for high-level documentation for standalone packages. Packages that form part of Emacs should be documented in the manual (as whitespace.el is); details of functions and variables should be in docstrings (as is the case for whitespace.el). The docstrings of customizable options are readable in the customize interface. I have updated my patch to provide a cross-reference to the documentation for whitespace-style, as you suggest. The other section of documentation that I removed is for customizable options, which are fully documented in the defcustom docstrings. (I have now checked this exhaustively.) > - The commit messages don't follow the ChangeLog format, see > https://www.gnu.org/prep/standards/html_node/Change-Logs.html, or simply > the existing commit messages. > =E2=80=8BApologies. As far as I could see, the main things that were wrong = were the summary lines and the lack of function names (or equivalent) in the detailed log. I have rewritten all of them. I have rebased the patch series against master and attach the new version. --=20 http://rrt.sc3d.org --001a114113b2f43c09053fb4e5cc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On = 25 October 2016 at 00:36, Dmitry Gutov <dgutov@yandex.ru> wro= te:
=E2=80=8B=E2=80=8B

A few comments on the patches themselves:

=E2=80=8BThanks v= ery much for the review.=E2=80=8B

- "remove duplicate documentation from the Commentary&= quot; sounds fine to me, but maybe we should leave something in its stead. = The first part can be replaced with a reference to the `whitespace-style= 9; docstring. The second one... is it really that out of date? The list of = variables seems like it can be useful.

=
I should check some = context: my understanding is that inline documentation in .el files is main= ly useful for high-level documentation for standalone packages. Packages th= at form part of Emacs should be documented in the manual (as whitespace.el = is); details of functions and variables should be in docstrings (as is the = case for whitespace.el). The docstrings of customizable options are readabl= e in the customize interface.

I have updated my patch to provide a cross-reference to the documentat= ion for whitespace-style, as you suggest. The other section of documentatio= n that I removed is for customizable options, which are fully documented in= the defcustom docstrings. (I have now checked this exhaustively.)
=C2=A0
- The commit messages do= n't follow the ChangeLog format, see https://www.gnu.org/prep/standards/html_node/Change-Logs.html, or simply the existing commit messages.

=E2=80=8BApologies. As far as I could see, the main things that were wro= ng were the summary lines and the lack of function names (or equivalent) in= the detailed log. I have rewritten all of them.

I have rebased the patch series against master and = attach the new version.

--
http://rrt.sc3d.org
--001a114113b2f43c09053fb4e5cc-- --001a114113b2f43c0e053fb4e5ce Content-Type: text/x-patch; charset=US-ASCII; name="0001-Fix-bob-eob-checks.patch" Content-Disposition: attachment; filename="0001-Fix-bob-eob-checks.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iupubxyl0 RnJvbSA3MmMxMmM2NTc0MzA1Mjg1MjE5YmZmOTRhYWI3OWNmNDVlMzdhYzEzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFRo dSwgMjAgT2N0IDIwMTYgMTM6MTc6NTggKzAxMDAKU3ViamVjdDogW1BBVENIIDEvNF0gRml4IGJv Yi9lb2IgY2hlY2tzCgoqIGxpc3Avd2hpdGVzcGFjZS5lbCAod2hpdGVzcGFjZS1lbXB0eS1hdC1i b2ItcmVnZXhwLAp3aGl0ZXNwYWNlLWVtcHR5LWF0LWVvYi1yZWdleHAsIHdoaXRlc3BhY2UtY2xl YW51cCk6IG1ha2UgYGVtcHR5JyBjaGVja3MKd29yayBhdCBiZWdpbm5pbmcgJiBlbmQgb2YgYnVm ZmVyIGluIHdoaXRlc3BhY2UtcmVwb3J0LXJlZ2lvbiwgYW5kIG9ubHkKdGhlcmUgKGkuZS4gdGhl eSB3aWxsIG5ldmVyIG1hdGNoIGluIHJlZ2lvbnMgdGhhdCBkb24ndCBpbmNsdWRlIHRoZQpzdGFy dCBvciBlbmQgb2YgdGhlIGJ1ZmZlcikuCi0tLQogbGlzcC93aGl0ZXNwYWNlLmVsIHwgNiArKyst LS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvbGlzcC93aGl0ZXNwYWNlLmVsIGIvbGlzcC93aGl0ZXNwYWNlLmVsCmluZGV4IDBm NmI4ZGYuLjYxNjQ1ODUgMTAwNjQ0Ci0tLSBhL2xpc3Avd2hpdGVzcGFjZS5lbAorKysgYi9saXNw L3doaXRlc3BhY2UuZWwKQEAgLTgyOCw3ICs4MjgsNyBAQCB3aGl0ZXNwYWNlLWluZGVudGF0aW9u LXJlZ2V4cAogICA6Z3JvdXAgJ3doaXRlc3BhY2UpCiAKIAotKGRlZmN1c3RvbSB3aGl0ZXNwYWNl LWVtcHR5LWF0LWJvYi1yZWdleHAgIl5cXChcXChbIFx0XSpcblxcKStcXCkiCisoZGVmY3VzdG9t IHdoaXRlc3BhY2UtZW1wdHktYXQtYm9iLXJlZ2V4cCAiXFxgXFwoXFwoWyBcdF0qXG5cXCkrXFwp IgogICAiU3BlY2lmeSByZWdleHAgZm9yIGVtcHR5IGxpbmVzIGF0IGJlZ2lubmluZyBvZiBidWZm ZXIuCiAKIFVzZWQgd2hlbiBgd2hpdGVzcGFjZS1zdHlsZScgaW5jbHVkZXMgYGVtcHR5Jy4iCkBA IC04MzYsNyArODM2LDcgQEAgd2hpdGVzcGFjZS1lbXB0eS1hdC1ib2ItcmVnZXhwCiAgIDpncm91 cCAnd2hpdGVzcGFjZSkKIAogCi0oZGVmY3VzdG9tIHdoaXRlc3BhY2UtZW1wdHktYXQtZW9iLXJl Z2V4cCAiXlxcKFsgXHRcbl0rXFwpIgorKGRlZmN1c3RvbSB3aGl0ZXNwYWNlLWVtcHR5LWF0LWVv Yi1yZWdleHAgIl5cXChbIFx0XG5dKlxcKFxuXFx7MixcXH1cXHxbIFx0XStcXClcXClcXCciCiAg ICJTcGVjaWZ5IHJlZ2V4cCBmb3IgZW1wdHkgbGluZXMgYXQgZW5kIG9mIGJ1ZmZlci4KIAogVXNl ZCB3aGVuIGB3aGl0ZXNwYWNlLXN0eWxlJyBpbmNsdWRlcyBgZW1wdHknLiIKQEAgLTE1MTUsNyAr MTUxNSw3IEBAIHdoaXRlc3BhY2UtY2xlYW51cAogCSAgICAod2hlbiAobG9va2luZy1hdCB3aGl0 ZXNwYWNlLWVtcHR5LWF0LWJvYi1yZWdleHApCiAJICAgICAgKGRlbGV0ZS1yZWdpb24gKG1hdGNo LWJlZ2lubmluZyAxKSAobWF0Y2gtZW5kIDEpKSkKIAkgICAgKHdoZW4gKHJlLXNlYXJjaC1mb3J3 YXJkCi0JCSAgIChjb25jYXQgd2hpdGVzcGFjZS1lbXB0eS1hdC1lb2ItcmVnZXhwICJcXCciKSBu aWwgdCkKKyAgICAgICAgICAgICAgICAgICB3aGl0ZXNwYWNlLWVtcHR5LWF0LWVvYi1yZWdleHAg bmlsIHQpCiAJICAgICAgKGRlbGV0ZS1yZWdpb24gKG1hdGNoLWJlZ2lubmluZyAxKSAobWF0Y2gt ZW5kIDEpKSkpKSkpCiAgICAgOzsgUFJPQkxFTSAzOiA4IG9yIG1vcmUgU1BBQ0VzIGF0IGJvbAog ICAgIDs7IFBST0JMRU0gNDogU1BBQ0VzIGJlZm9yZSBUQUIKLS0gCjIuNy40Cgo= --001a114113b2f43c0e053fb4e5ce Content-Type: text/x-patch; charset=US-ASCII; name="0002-Remove-duplicate-documentation.patch" Content-Disposition: attachment; filename="0002-Remove-duplicate-documentation.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iupubxyw1 RnJvbSBkMDFjOTc3NDViYWQ4NTk5OWIzMDRhOTZjNGZjMTM3MmExYzJjY2U4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IEZy aSwgMjEgT2N0IDIwMTYgMTU6MjA6MDcgKzAxMDAKU3ViamVjdDogW1BBVENIIDIvNF0gUmVtb3Zl IGR1cGxpY2F0ZSBkb2N1bWVudGF0aW9uCgoqIHdoaXRlc3BhY2UuZWw6IHJlbW92ZSBkdXBsaWNh dGUgZG9jdW1lbnRhdGlvbiBmcm9tIHRoZSBDb21tZW50YXJ5CiAgc2VjdGlvbiB3aGljaCBkdXBs aWNhdGUgYW5kIGluIHNvbWUgcGxhY2VzIGNvbnRyYWRpY3QgKGR1ZSB0byBiZWluZwogIG91dCBv ZiBkYXRlKSB0aGUgZG9jc3RyaW5ncy4KLS0tCiBsaXNwL3doaXRlc3BhY2UuZWwgfCAxMTcgKy0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIDEgZmls ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMTE2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2xpc3Avd2hpdGVzcGFjZS5lbCBiL2xpc3Avd2hpdGVzcGFjZS5lbAppbmRleCA2MTY0NTg1Li5h ZmZkZGMzIDEwMDY0NAotLS0gYS9saXNwL3doaXRlc3BhY2UuZWwKKysrIGIvbGlzcC93aGl0ZXNw YWNlLmVsCkBAIC0xNzgsNDkgKzE3OCwxMSBAQAogOzsKIDs7IGB3aGl0ZXNwYWNlLWNsZWFudXAn CiA7OyAgICBDbGVhbnVwIHNvbWUgYmxhbmsgcHJvYmxlbXMgaW4gYWxsIGJ1ZmZlciBvciBhdCBy ZWdpb24uCis7OyAgICBTZWUgdGhlIGZ1bmN0aW9uJ3MgZG9jc3RyaW5nIGZvciBtb3JlIGluZm9y bWF0aW9uLgogOzsKIDs7IGB3aGl0ZXNwYWNlLWNsZWFudXAtcmVnaW9uJwogOzsgICAgQ2xlYW51 cCBzb21lIGJsYW5rIHByb2JsZW1zIGF0IHJlZ2lvbi4KIDs7Ci07OyBUaGUgcHJvYmxlbXMsIHdo aWNoIGFyZSBjbGVhbmVkIHVwLCBhcmU6Ci07OwotOzsgMS4gZW1wdHkgbGluZXMgYXQgYmVnaW5u aW5nIG9mIGJ1ZmZlci4KLTs7IDIuIGVtcHR5IGxpbmVzIGF0IGVuZCBvZiBidWZmZXIuCi07OyAg ICBJZiBgd2hpdGVzcGFjZS1zdHlsZScgaW5jbHVkZXMgdGhlIHZhbHVlIGBlbXB0eScsIHJlbW92 ZSBhbGwKLTs7ICAgIGVtcHR5IGxpbmVzIGF0IGJlZ2lubmluZyBhbmQvb3IgZW5kIG9mIGJ1ZmZl ci4KLTs7Ci07OyAzLiA4IG9yIG1vcmUgU1BBQ0VzIGF0IGJlZ2lubmluZyBvZiBsaW5lLgotOzsg ICAgSWYgYHdoaXRlc3BhY2Utc3R5bGUnIGluY2x1ZGVzIHRoZSB2YWx1ZSBgaW5kZW50YXRpb24n OgotOzsgICAgcmVwbGFjZSA4IG9yIG1vcmUgU1BBQ0VzIGF0IGJlZ2lubmluZyBvZiBsaW5lIGJ5 IFRBQnMsIGlmCi07OyAgICBgaW5kZW50LXRhYnMtbW9kZScgaXMgbm9uLW5pbDsgb3RoZXJ3aXNl LCByZXBsYWNlIFRBQnMgYnkKLTs7ICAgIFNQQUNFcy4KLTs7ICAgIElmIGB3aGl0ZXNwYWNlLXN0 eWxlJyBpbmNsdWRlcyB0aGUgdmFsdWUgYGluZGVudGF0aW9uOjp0YWInLAotOzsgICAgcmVwbGFj ZSA4IG9yIG1vcmUgU1BBQ0VzIGF0IGJlZ2lubmluZyBvZiBsaW5lIGJ5IFRBQnMuCi07OyAgICBJ ZiBgd2hpdGVzcGFjZS1zdHlsZScgaW5jbHVkZXMgdGhlIHZhbHVlIGBpbmRlbnRhdGlvbjo6c3Bh Y2UnLAotOzsgICAgcmVwbGFjZSBUQUJzIGJ5IFNQQUNFcy4KLTs7Ci07OyA0LiBTUEFDRXMgYmVm b3JlIFRBQi4KLTs7ICAgIElmIGB3aGl0ZXNwYWNlLXN0eWxlJyBpbmNsdWRlcyB0aGUgdmFsdWUg YHNwYWNlLWJlZm9yZS10YWInOgotOzsgICAgcmVwbGFjZSBTUEFDRXMgYnkgVEFCcywgaWYgYGlu ZGVudC10YWJzLW1vZGUnIGlzIG5vbi1uaWw7Ci07OyAgICBvdGhlcndpc2UsIHJlcGxhY2UgVEFC cyBieSBTUEFDRXMuCi07OyAgICBJZiBgd2hpdGVzcGFjZS1zdHlsZScgaW5jbHVkZXMgdGhlIHZh bHVlCi07OyAgICBgc3BhY2UtYmVmb3JlLXRhYjo6dGFiJywgcmVwbGFjZSBTUEFDRXMgYnkgVEFC cy4KLTs7ICAgIElmIGB3aGl0ZXNwYWNlLXN0eWxlJyBpbmNsdWRlcyB0aGUgdmFsdWUKLTs7ICAg IGBzcGFjZS1iZWZvcmUtdGFiOjpzcGFjZScsIHJlcGxhY2UgVEFCcyBieSBTUEFDRXMuCi07Owot OzsgNS4gU1BBQ0VzIG9yIFRBQnMgYXQgZW5kIG9mIGxpbmUuCi07OyAgICBJZiBgd2hpdGVzcGFj ZS1zdHlsZScgaW5jbHVkZXMgdGhlIHZhbHVlIGB0cmFpbGluZycsIHJlbW92ZSBhbGwKLTs7ICAg IFNQQUNFcyBvciBUQUJzIGF0IGVuZCBvZiBsaW5lLgotOzsKLTs7IDYuIDggb3IgbW9yZSBTUEFD RXMgYWZ0ZXIgVEFCLgotOzsgICAgSWYgYHdoaXRlc3BhY2Utc3R5bGUnIGluY2x1ZGVzIHRoZSB2 YWx1ZSBgc3BhY2UtYWZ0ZXItdGFiJzoKLTs7ICAgIHJlcGxhY2UgU1BBQ0VzIGJ5IFRBQnMsIGlm IGBpbmRlbnQtdGFicy1tb2RlJyBpcyBub24tbmlsOwotOzsgICAgb3RoZXJ3aXNlLCByZXBsYWNl IFRBQnMgYnkgU1BBQ0VzLgotOzsgICAgSWYgYHdoaXRlc3BhY2Utc3R5bGUnIGluY2x1ZGVzIHRo ZSB2YWx1ZSBgc3BhY2UtYWZ0ZXItdGFiOjp0YWInLAotOzsgICAgcmVwbGFjZSBTUEFDRXMgYnkg VEFCcy4KLTs7ICAgIElmIGB3aGl0ZXNwYWNlLXN0eWxlJyBpbmNsdWRlcyB0aGUgdmFsdWUKLTs7 ICAgIGBzcGFjZS1hZnRlci10YWI6OnNwYWNlJywgcmVwbGFjZSBUQUJzIGJ5IFNQQUNFcy4KLTs7 CiA7OwogOzsgSG9va3MKIDs7IC0tLS0tCkBAIC0yMzcsODMgKzE5OSw2IEBACiA7OyAgICBJdCBp cyBldmFsdWF0ZWQgYWZ0ZXIgd2hpdGVzcGFjZSBwYWNrYWdlIGlzIGxvYWRlZC4KIDs7CiA7Owot OzsgT3B0aW9ucwotOzsgLS0tLS0tLQotOzsKLTs7IEJlbG93IGl0J3Mgc2hvd24gYSBicmllZiBk ZXNjcmlwdGlvbiBvZiB3aGl0ZXNwYWNlIG9wdGlvbnMsIHBsZWFzZSwKLTs7IHNlZSB0aGUgb3B0 aW9ucyBkZWNsYXJhdGlvbiBpbiB0aGUgY29kZSBmb3IgYSBsb25nIGRvY3VtZW50YXRpb24uCi07 OwotOzsgYHdoaXRlc3BhY2Utc3R5bGUnCQlTcGVjaWZ5IHdoaWNoIGtpbmQgb2YgYmxhbmsgaXMK LTs7CQkJCXZpc3VhbGl6ZWQuCi07OwotOzsgYHdoaXRlc3BhY2Utc3BhY2UnCQlGYWNlIHVzZWQg dG8gdmlzdWFsaXplIFNQQUNFLgotOzsKLTs7IGB3aGl0ZXNwYWNlLWhzcGFjZScJCUZhY2UgdXNl ZCB0byB2aXN1YWxpemUgSEFSRCBTUEFDRS4KLTs7Ci07OyBgd2hpdGVzcGFjZS10YWInCQlGYWNl IHVzZWQgdG8gdmlzdWFsaXplIFRBQi4KLTs7Ci07OyBgd2hpdGVzcGFjZS1uZXdsaW5lJwkJRmFj ZSB1c2VkIHRvIHZpc3VhbGl6ZSBORVdMSU5FIGNoYXIKLTs7CQkJCW1hcHBpbmcuCi07OwotOzsg YHdoaXRlc3BhY2UtdHJhaWxpbmcnCUZhY2UgdXNlZCB0byB2aXN1YWxpemUgdHJhaWxpbmcKLTs7 CQkJCWJsYW5rcy4KLTs7Ci07OyBgd2hpdGVzcGFjZS1saW5lJwkJRmFjZSB1c2VkIHRvIHZpc3Vh bGl6ZSAibG9uZyIgbGluZXMuCi07OwotOzsgYHdoaXRlc3BhY2Utc3BhY2UtYmVmb3JlLXRhYicJ RmFjZSB1c2VkIHRvIHZpc3VhbGl6ZSBTUEFDRXMKLTs7CQkJCQliZWZvcmUgVEFCLgotOzsKLTs7 IGB3aGl0ZXNwYWNlLWluZGVudGF0aW9uJwlGYWNlIHVzZWQgdG8gdmlzdWFsaXplIDggb3IgbW9y ZQotOzsJCQkJU1BBQ0VzIGF0IGJlZ2lubmluZyBvZiBsaW5lLgotOzsKLTs7IGB3aGl0ZXNwYWNl LWJpZy1pbmRlbnQnCUZhY2UgdXNlZCB0byB2aXN1YWxpemUgYmlnIGluZGVudGF0aW9uLgotOzsK LTs7IGB3aGl0ZXNwYWNlLWVtcHR5JwkJRmFjZSB1c2VkIHRvIHZpc3VhbGl6ZSBlbXB0eSBsaW5l cyBhdAotOzsJCQkJYmVnaW5uaW5nIGFuZC9vciBlbmQgb2YgYnVmZmVyLgotOzsKLTs7IGB3aGl0 ZXNwYWNlLXNwYWNlLWFmdGVyLXRhYicJRmFjZSB1c2VkIHRvIHZpc3VhbGl6ZSA4IG9yIG1vcmUK LTs7CQkJCVNQQUNFcyBhZnRlciBUQUIuCi07OwotOzsgYHdoaXRlc3BhY2Utc3BhY2UtcmVnZXhw JwlTcGVjaWZ5IFNQQUNFIGNoYXJhY3RlcnMgcmVnZXhwLgotOzsKLTs7IGB3aGl0ZXNwYWNlLWhz cGFjZS1yZWdleHAnCVNwZWNpZnkgSEFSRCBTUEFDRSBjaGFyYWN0ZXJzIHJlZ2V4cC4KLTs7Ci07 OyBgd2hpdGVzcGFjZS10YWItcmVnZXhwJwlTcGVjaWZ5IFRBQiBjaGFyYWN0ZXJzIHJlZ2V4cC4K LTs7Ci07OyBgd2hpdGVzcGFjZS10cmFpbGluZy1yZWdleHAnCVNwZWNpZnkgdHJhaWxpbmcgY2hh cmFjdGVycyByZWdleHAuCi07OwotOzsgYHdoaXRlc3BhY2Utc3BhY2UtYmVmb3JlLXRhYi1yZWdl eHAnCVNwZWNpZnkgU1BBQ0VzIGJlZm9yZSBUQUIKLTs7CQkJCQlyZWdleHAuCi07OwotOzsgYHdo aXRlc3BhY2UtaW5kZW50YXRpb24tcmVnZXhwJwlTcGVjaWZ5IHJlZ2V4cCBmb3IgOCBvciBtb3Jl Ci07OwkJCQkJU1BBQ0VzIGF0IGJlZ2lubmluZyBvZiBsaW5lLgotOzsKLTs7IGB3aGl0ZXNwYWNl LWJpZy1pbmRlbnQtcmVnZXhwJwlTcGVjaWZ5IGJpZyBpbmRlbnRhdGlvbiBhdCBiZWdpbm5pbmcg b2YgbGluZQotOzsJCQkJCXJlZ2V4cC4KLTs7Ci07OyBgd2hpdGVzcGFjZS1lbXB0eS1hdC1ib2It cmVnZXhwJwlTcGVjaWZ5IHJlZ2V4cCBmb3IgZW1wdHkgbGluZXMKLTs7CQkJCQlhdCBiZWdpbm5p bmcgb2YgYnVmZmVyLgotOzsKLTs7IGB3aGl0ZXNwYWNlLWVtcHR5LWF0LWVvYi1yZWdleHAnCVNw ZWNpZnkgcmVnZXhwIGZvciBlbXB0eSBsaW5lcwotOzsJCQkJCWF0IGVuZCBvZiBidWZmZXIuCi07 OwotOzsgYHdoaXRlc3BhY2Utc3BhY2UtYWZ0ZXItdGFiLXJlZ2V4cCcJU3BlY2lmeSByZWdleHAg Zm9yIDggb3IgbW9yZQotOzsJCQkJCVNQQUNFcyBhZnRlciBUQUIuCi07OwotOzsgYHdoaXRlc3Bh Y2UtbGluZS1jb2x1bW4nCVNwZWNpZnkgY29sdW1uIGJleW9uZCB3aGljaCB0aGUgbGluZQotOzsJ CQkJaXMgaGlnaGxpZ2h0ZWQuCi07OwotOzsgYHdoaXRlc3BhY2UtZGlzcGxheS1tYXBwaW5ncycJ U3BlY2lmeSBhbiBhbGlzdCBvZiBtYXBwaW5ncwotOzsJCQkJCWZvciBkaXNwbGF5aW5nIGNoYXJh Y3RlcnMuCi07OwotOzsgYHdoaXRlc3BhY2UtZ2xvYmFsLW1vZGVzJwlNb2RlcyBmb3Igd2hpY2gg Z2xvYmFsCi07OwkJCQlgd2hpdGVzcGFjZS1tb2RlJyBpcyBhdXRvbWFnaWNhbGx5Ci07OwkJCQl0 dXJuZWQgb24uCi07OwotOzsgYHdoaXRlc3BhY2UtYWN0aW9uJwkJU3BlY2lmeSB3aGljaCBhY3Rp b24gaXMgdGFrZW4gd2hlbiBhCi07OwkJCQlidWZmZXIgaXMgdmlzaXRlZCBvciB3cml0dGVuLgot OzsKLTs7CiA7OyBBY2tub3dsZWRnbWVudHMKIDs7IC0tLS0tLS0tLS0tLS0tLQogOzsKLS0gCjIu Ny40Cgo= --001a114113b2f43c0e053fb4e5ce Content-Type: text/x-patch; charset=US-ASCII; name="0003-Fix-whitespace-space-after-tab-regexp.patch" Content-Disposition: attachment; filename="0003-Fix-whitespace-space-after-tab-regexp.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iupubxz22 RnJvbSBiMDNmNjZhY2NlZDA2ZmRhNWVjYzY5NGUzN2IyNWJiZjMyY2U0ZGEyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IEZy aSwgMjEgT2N0IDIwMTYgMTU6MjM6MDggKzAxMDAKU3ViamVjdDogW1BBVENIIDMvNF0gRml4IHdo aXRlc3BhY2Utc3BhY2UtYWZ0ZXItdGFiLXJlZ2V4cAoKKiBsaXNwL3doaXRlc3BhY2UuZWwgKHdo aXRlc3BhY2Utc3BhY2UtYWZ0ZXItdGFiLXJlZ2V4cCwKICB3aGl0ZXNwYWNlLXJlZ2V4cCk6IG1h dGNoIGFsbCB0aGUgc3BhY2VzIGFmdGVyIHRhYnMgZm9yIGhpZ2hsaWdodGluZywKICBub3QganVz dCB0aGUgZmlyc3QgdGFiLXdpZHRoLiBGaXggd2hpdGVzcGFjZS1zcGFjZS1hZnRlci10YWI6OnNw YWNlCiAgdmVyc2lvbiBzbyB0aGF0IGl0IHJlcXVpcmVzIGF0IGxlYXN0IHRhYi13aWR0aCBzcGFj ZXMsIG5vdCBqdXN0IDEuCi0tLQogbGlzcC93aGl0ZXNwYWNlLmVsIHwgMjAgKysrKysrKysrKyst LS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2xpc3Avd2hpdGVzcGFjZS5lbCBiL2xpc3Avd2hpdGVzcGFjZS5lbApp bmRleCBhZmZkZGMzLi5mOGRjOTUwIDEwMDY0NAotLS0gYS9saXNwL3doaXRlc3BhY2UuZWwKKysr IGIvbGlzcC93aGl0ZXNwYWNlLmVsCkBAIC03MzAsOCArNzMwLDggQEAgd2hpdGVzcGFjZS1lbXB0 eS1hdC1lb2ItcmVnZXhwCiAKIAogKGRlZmN1c3RvbSB3aGl0ZXNwYWNlLXNwYWNlLWFmdGVyLXRh Yi1yZWdleHAKLSAgJygiXHQrXFwoXFwoIFxceyVkXFx9XFwpK1xcKSIKLSAgICAuICJcXChcdCtc XCkgKyIpCisgICcoIlx0K1xcKFxcKCBcXHslZCxcXH1cXCkrXFwpIgorICAgIC4gIlxcKFx0K1xc KSBcXHslZCxcXH0iKQogICAiU3BlY2lmeSByZWdleHAgZm9yIDggb3IgbW9yZSBTUEFDRXMgYWZ0 ZXIgVEFCLgogCiBJdCBpcyBhIGNvbnMgd2hlcmUgdGhlIGNvbnMgY2FyIGlzIHVzZWQgZm9yIFNQ QUNFcyB2aXN1YWxpemF0aW9uCkBAIC0xNTU5LDEzICsxNTU5LDE1IEBAIHdoaXRlc3BhY2UtcmVw bGFjZS1hY3Rpb24KIAogKGRlZnVuIHdoaXRlc3BhY2UtcmVnZXhwIChyZWdleHAgJm9wdGlvbmFs IGtpbmQpCiAgICJSZXR1cm4gUkVHRVhQIGRlcGVuZGluZyBvbiBgd2hpdGVzcGFjZS1pbmRlbnQt dGFicy1tb2RlJy4iCi0gIChjb25kCi0gICAoKG9yIChlcSBraW5kICd0YWIpCi0Jd2hpdGVzcGFj ZS1pbmRlbnQtdGFicy1tb2RlKQotICAgIChmb3JtYXQgKGNhciByZWdleHApIHdoaXRlc3BhY2Ut dGFiLXdpZHRoKSkKLSAgICgob3IgKGVxIGtpbmQgJ3NwYWNlKQotCShub3Qgd2hpdGVzcGFjZS1p bmRlbnQtdGFicy1tb2RlKSkKLSAgICAoY2RyIHJlZ2V4cCkpKSkKKyAgKGZvcm1hdAorICAgKGNv bmQKKyAgICAoKG9yIChlcSBraW5kICd0YWIpCisgICAgICAgICB3aGl0ZXNwYWNlLWluZGVudC10 YWJzLW1vZGUpCisgICAgIChjYXIgcmVnZXhwKSkKKyAgICAoKG9yIChlcSBraW5kICdzcGFjZSkK KyAgICAgICAgIChub3Qgd2hpdGVzcGFjZS1pbmRlbnQtdGFicy1tb2RlKSkKKyAgICAgKGNkciBy ZWdleHApKSkKKyAgIHdoaXRlc3BhY2UtdGFiLXdpZHRoKSkKIAogCiAoZGVmdW4gd2hpdGVzcGFj ZS1pbmRlbnRhdGlvbi1yZWdleHAgKCZvcHRpb25hbCBraW5kKQotLSAKMi43LjQKCg== --001a114113b2f43c0e053fb4e5ce Content-Type: text/x-patch; charset=US-ASCII; name="0004-Make-whitespace-report-region-respect-current-settin.patch" Content-Disposition: attachment; filename="0004-Make-whitespace-report-region-respect-current-settin.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iupubxz73 RnJvbSBlYzkzZWNhNjdiZGE1NDk4ODY3MDlmZjhjMTNkNTYzNTYwYzg4Yzk5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IEZy aSwgMjEgT2N0IDIwMTYgMTU6MjU6MTIgKzAxMDAKU3ViamVjdDogW1BBVENIIDQvNF0gTWFrZSB3 aGl0ZXNwYWNlLXJlcG9ydC1yZWdpb24gcmVzcGVjdCBjdXJyZW50IHNldHRpbmdzCgoqIHdoaXRl c3BhY2UuZWwgKHdoaXRlc3BhY2UtcmVwb3J0LXJlZ2lvbik6IG1ha2UgaXQgcmVzcGVjdAogIHdo aXRlc3BhY2Utc3R5bGUsIGluY2x1ZGluZyBhbnkgYWRkaXRpb25zIG1hZGUgYnkgdGhlIGZvcmNl IHBhcmFtZXRlci4KICBUaGlzIG1lYW5zIHRoYXQgdGhlIGZ1bmN0aW9uIGRvZXMgbm90IHJldHVy biB0IHVubGVzcyBhIHdoaXRlc3BhY2UKICBwcm9ibGVtIHRoYXQgdGhlIHVzZXIgY2FyZXMgYWJv dXQgaXMgcmVwb3J0ZWQuCi0tLQogbGlzcC93aGl0ZXNwYWNlLmVsIHwgNiArKysrLS0KIDEgZmls ZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv bGlzcC93aGl0ZXNwYWNlLmVsIGIvbGlzcC93aGl0ZXNwYWNlLmVsCmluZGV4IGY4ZGM5NTAuLmJi ZWMwNmUgMTAwNjQ0Ci0tLSBhL2xpc3Avd2hpdGVzcGFjZS5lbAorKysgYi9saXNwL3doaXRlc3Bh Y2UuZWwKQEAgLTE3MzMsOCArMTczMywxMCBAQCB3aGl0ZXNwYWNlLXJlcG9ydC1yZWdpb24KIAkJ CSAgICAod2hpdGVzcGFjZS1zcGFjZS1hZnRlci10YWItcmVnZXhwICdzcGFjZSkpCiAJCQkgICAo dAogCQkJICAgIChjZHIgb3B0aW9uKSkpKSkKLQkJICAgICAoYW5kIChyZS1zZWFyY2gtZm9yd2Fy ZCByZWdleHAgcmVuZCB0KQotCQkJICAoc2V0cSBoYXMtYm9ndXMgdCkpKSkKKwkJICAgICAod2hl biAocmUtc2VhcmNoLWZvcndhcmQgcmVnZXhwIHJlbmQgdCkKKyAgICAgICAgICAgICAgICAgICAg ICAgKHVubGVzcyBoYXMtYm9ndXMKKyAgICAgICAgICAgICAgICAgICAgICAgICAoc2V0cSBoYXMt Ym9ndXMgKG1lbXEgKGNhciBvcHRpb24pIHdoaXRlc3BhY2Utc3R5bGUpKSkKKyAgICAgICAgICAg ICAgICAgICAgICAgdCkpKQogCSAgICAgICB3aGl0ZXNwYWNlLXJlcG9ydC1saXN0KSkpCiAJKHdo ZW4gKHBjYXNlIHJlcG9ydC1pZi1ib2d1cyAoYG5pbCB0KSAoYG5ldmVyIG5pbCkgKF8gaGFzLWJv Z3VzKSkKIAkgICh3aGl0ZXNwYWNlLWtpbGwtYnVmZmVyIHdoaXRlc3BhY2UtcmVwb3J0LWJ1ZmZl ci1uYW1lKQotLSAKMi43LjQKCg== --001a114113b2f43c0e053fb4e5ce--