From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#18237: Small fix for MSDOS Date: Sun, 10 Aug 2014 19:19:24 +0100 Message-ID: References: <83mwbcjk8f.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11345e0e60834705004a7a9c X-Trace: ger.gmane.org 1407694819 9321 80.91.229.3 (10 Aug 2014 18:20:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 10 Aug 2014 18:20:19 +0000 (UTC) Cc: 18237@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 10 20:20:14 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XGXj4-000645-30 for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Aug 2014 20:20:14 +0200 Original-Received: from localhost ([::1]:60600 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGXj3-0005JN-M2 for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Aug 2014 14:20:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGXiw-0005GW-Qh for bug-gnu-emacs@gnu.org; Sun, 10 Aug 2014 14:20:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGXis-0000sW-KL for bug-gnu-emacs@gnu.org; Sun, 10 Aug 2014 14:20:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGXis-0000s2-Hl for bug-gnu-emacs@gnu.org; Sun, 10 Aug 2014 14:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XGXir-0001Xn-Ub for bug-gnu-emacs@gnu.org; Sun, 10 Aug 2014 14:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Aug 2014 18:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18237-submit@debbugs.gnu.org id=B18237.14076947755897 (code B ref 18237); Sun, 10 Aug 2014 18:20:01 +0000 Original-Received: (at 18237) by debbugs.gnu.org; 10 Aug 2014 18:19:35 +0000 Original-Received: from localhost ([127.0.0.1]:37951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGXiQ-0001X2-8o for submit@debbugs.gnu.org; Sun, 10 Aug 2014 14:19:35 -0400 Original-Received: from mail-la0-f49.google.com ([209.85.215.49]:61444) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGXiM-0001Wm-V7 for 18237@debbugs.gnu.org; Sun, 10 Aug 2014 14:19:32 -0400 Original-Received: by mail-la0-f49.google.com with SMTP id hz20so5892503lab.8 for <18237@debbugs.gnu.org>; Sun, 10 Aug 2014 11:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=+ObAp3HMlAI4fORBQyXC02g0XSZGWGU85jQ0MSmSjlU=; b=kAV1TjEOqRma16EFb5DcxDK1gab8bX6N0z0xshFjxE8D5ZFCjEAUdh1f/3E2S1gYKJ 9iLbVBVwmUagCznSq2Mc5Fbn/7we05kgSFcH+rI77Qa22skrnj/vWi7Z1aqXEiiN36SA ThTpN1WBorEm1s2KtyVmmAyamZU2TPwIGS+b0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=+ObAp3HMlAI4fORBQyXC02g0XSZGWGU85jQ0MSmSjlU=; b=OsMNjSnVlaEnRtyv68JAgbAi9pXIFuCoAvP+l2bnEK0b4WwGxP44CjgHvp/sTQJJDQ 2Ovs/yaPL5CTBoIwpPM0IkFUsl/wJ05b9epk5AV3ioKqof7OoxNkByjqhKo9c2hWc3+k FtOgKfuKpRIZCH7/9UyG8YuzajDctATykPH0uLC1Eb3ZAeIOC0x68ilzGJALV3flLoCT 9vlUqp8I1ycbD9NCJ+NICBS2iiNMUxHrFS/k9TwxtgQAH+avXyh4KgDzTY4cCAKK+xKC fK/NcZbZZRrWHI8ka6gkMNXv7iGOad7+B8gIecLVvobTvELRyZIgfFsBFeKmgdJbobz6 8uJA== X-Gm-Message-State: ALoCoQnw1lS6SNOHYTjKB0ZoxUKPy71V9woJC7LGew840htcO7LBKyk3JqBn693RGwwTA7MDJDs1 X-Received: by 10.152.236.43 with SMTP id ur11mr3743399lac.74.1407694764269; Sun, 10 Aug 2014 11:19:24 -0700 (PDT) Original-Received: by 10.152.246.10 with HTTP; Sun, 10 Aug 2014 11:19:24 -0700 (PDT) In-Reply-To: <83mwbcjk8f.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92386 Archived-At: --001a11345e0e60834705004a7a9c Content-Type: text/plain; charset=UTF-8 On 10 August 2014 19:02, Eli Zaretskii wrote: > > Date: Sun, 10 Aug 2014 17:40:24 +0100 > > From: Reuben Thomas > > > > The following patch helps in the case when a sockets library is > installed; > > in my case, ls080b.zip from the DJGPP site: > > > > === modified file 'src/msdos.c' > > --- src/msdos.c 2014-08-09 16:12:33 +0000 > > +++ src/msdos.c 2014-08-09 21:51:56 +0000 > > @@ -4016,7 +4017,7 @@ > > #endif > > > > > > -#ifndef HAVE_SELECT > > +#ifndef HAVE_SYS_SELECT_H > > #include "sysselect.h" > > > > /* This yields the rest of the current time slice to the task manager. > > > > > > The reasoning is that having select doesn't imply having the sys/select.h > > functionality that the following code emulates. > > > > Does that look OK to install? > > You didn't tell enough details, so I don't understand why the change > is needed, and why it is OK not to test HAVE_SELECT at all here. (I > don't have ls080b.zip installed.) Please tell what problems did you > see with the original code, and let's take it from there. > libsocket is a sockets implementation: http://rich.phekda.org/richdawe/lsck/lsck_dl.htm When it is installed, configure correctly detects that select is available, and sets HAVE_SELECT. However, libsocket has no sys/select.h, nor does it implement sys_select. Hence, at present, when I build using ./configure && make for DOS with libsocket installed, HAVE_SELECT is defined to 1, so the MS-DOS implementation of sys_select in msdos.c is not compiled. Later, the linker is unable to find sys_select, and the build fails. I think you're also saying that I should test both HAVE_SELECT && HAVE_SYS_SELECT_H therefore? You're probably right, I (incorrectly?) assumed that if HAVE_SYS_SELECT_H is true, then HAVE_SELECT would be too. -- http://rrt.sc3d.org --001a11345e0e60834705004a7a9c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On 1= 0 August 2014 19:02, Eli Zaretskii <eliz@gnu.org> wrote:
> Date: Sun, 10 Aug 2014 17:40:24 +0100
> From: Reuben Thomas <rrt@sc3d.org>
>
> The following patch helps in the case when a sockets library is instal= led;
> in my case, ls080b.zip from the DJGPP site:
>
> =3D=3D=3D modified file 'src/msdos.c'
> --- src/msdos.c =C2=A0 =C2=A02014-08-09 16:12:33 +0000
> +++ src/msdos.c =C2=A0 =C2=A02014-08-09 21:51:56 +0000
> @@ -4016,7 +4017,7 @@
> =C2=A0#endif
>
>
> -#ifndef HAVE_SELECT
> +#ifndef HAVE_SYS_SELECT_H
> =C2=A0#include "sysselect.h"
>
> =C2=A0/* This yields the rest of the current time slice to the task ma= nager.
>
>
> The reasoning is that having select doesn't imply having the sys/s= elect.h
> functionality that the following code emulates.
>
> Does that look OK to install?

You didn't tell enough details, so I don't understand why the chang= e
is needed, and why it is OK not to test HAVE_SELECT at all here. =C2=A0(I don't have ls080b.zip installed.) =C2=A0Please tell what problems did y= ou
see with the original code, and let's take it from there.

When it is installed, configure correctly detects that selec= t is available, and sets HAVE_SELECT. However, libsocket has no sys/select.= h, nor does it implement sys_select.

Hence, at present, w= hen I build using ./configure && make for DOS with libsocket instal= led, HAVE_SELECT is defined to 1, so the MS-DOS implementation of sys_selec= t in msdos.c is not compiled. Later, the linker is unable to find sys_selec= t, and the build fails.

I think you're also sa= ying that I should test both HAVE_SELECT && HAVE_SYS_SELECT_H there= fore? You're probably right, I (incorrectly?) assumed that if HAVE_SYS_= SELECT_H is true, then HAVE_SELECT would be too.

--
http://rrt.sc3d.org
--001a11345e0e60834705004a7a9c--