From: Reuben Thomas <rrt@sc3d.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 13837@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#13837: 24.2; Make it possible to turn whitespace-mode only when there are no existing problems
Date: Tue, 28 Jan 2014 00:48:21 +0000 [thread overview]
Message-ID: <CAOnWdoh1Pcs8-M13Z3RBUMTHHmoTy-9r0yp2wiOGWocBO34VtQ@mail.gmail.com> (raw)
In-Reply-To: <jwvlhy1dk84.fsf-monnier+emacsbugs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]
On 28 January 2014 00:32, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> > -(defun whitespace-report (&optional force report-if-bogus)
> > +(defun whitespace-report (&optional force report)
>
> I'd leave the name unchanged. Will make for a cleaner diff and the
> name "report" is not convincingly better.
>
Sure, OK.
> > +If REPORT is t, it reports only when there are any whitespace
> > +problems in buffer; if it is 'never, it does not report problems.
> ^^^^^^
> should be `never'
>
> > +problems in buffer; if it is 'never, it does not report problems.
> ^^^^^^
> should be `never'
>
> > * If `indent-tabs-mode' is non-nil:
> > + indentation 6. 8 or more SPACEs at beginning of line.
> > * If `indent-tabs-mode' is nil:
> > + indentation 6. TABS at beginning of line.
>
> Why not
>
> indentation 6. if `indent-tabs-mode':
> 8 or more SPACEs at beginning of line
> else: TABS at beginning of line.
>
OK.
> > - (when (if report-if-bogus has-bogus t)
> > + (when (if (equal report t) has-bogus (null report))
>
> For better backward compatibility, this should check for `never' and
> treat any other non-nil value as t. IOW
>
> (when (pcase report-if-bogus (`nil t) (`never nil) (_ has-bogus))
>
Fine, revised patch to follow.
--
http://rrt.sc3d.org
[-- Attachment #2: Type: text/html, Size: 2570 bytes --]
next prev parent reply other threads:[~2014-01-28 0:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 21:41 bug#13837: 24.2; Make it possible to turn whitespace-mode only when there are no existing problems Reuben Thomas
2013-02-28 2:00 ` bug#13837: Update to code Reuben Thomas
2013-02-28 16:23 ` bug#13837: 24.2; Make it possible to turn whitespace-mode only when there are no existing problems Stefan Monnier
2013-02-28 16:32 ` Stefan Monnier
2013-03-01 22:02 ` Reuben Thomas
2013-03-02 3:02 ` Stefan Monnier
2013-03-02 7:46 ` Reuben Thomas
2013-03-03 23:36 ` Stefan Monnier
2013-03-01 22:21 ` Reuben Thomas
2013-03-02 3:01 ` Stefan Monnier
2013-03-02 7:49 ` Reuben Thomas
2013-04-10 0:50 ` Reuben Thomas
2013-10-17 23:09 ` Reuben Thomas
2014-01-26 23:12 ` Reuben Thomas
2014-01-26 23:29 ` Dmitry Gutov
2014-01-26 23:31 ` Reuben Thomas
2014-01-27 0:27 ` Dmitry Gutov
2014-01-27 0:41 ` Reuben Thomas
2014-01-27 1:52 ` Stefan Monnier
2014-01-27 13:25 ` Reuben Thomas
2014-01-27 15:00 ` Stefan Monnier
2014-01-27 21:19 ` Reuben Thomas
2014-01-28 0:32 ` Stefan Monnier
2014-01-28 0:48 ` Reuben Thomas [this message]
2014-05-29 17:26 ` Stefan Monnier
2014-05-29 19:01 ` Reuben Thomas
2014-05-29 20:28 ` Stefan Monnier
2014-05-29 22:53 ` Reuben Thomas
2014-05-30 2:01 ` Glenn Morris
2014-05-29 19:02 ` Reuben Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOnWdoh1Pcs8-M13Z3RBUMTHHmoTy-9r0yp2wiOGWocBO34VtQ@mail.gmail.com \
--to=rrt@sc3d.org \
--cc=13837@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.