From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Reuben Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#46331: provided-mode-derived-p doesn't work on aliases Date: Sat, 6 Feb 2021 11:22:31 +0000 Message-ID: References: <8735y9e9u9.fsf@gnus.org> Reply-To: Reuben Thomas Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000cc86b805baa92742" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5426"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46331@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 06 12:23:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l8LgD-0001Hl-Qc for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Feb 2021 12:23:09 +0100 Original-Received: from localhost ([::1]:32782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l8LgC-0003Zi-St for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Feb 2021 06:23:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8Lg6-0003ZW-DM for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2021 06:23:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33663) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l8Lg6-0002LC-6E for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2021 06:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l8Lg6-0005oz-3D for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2021 06:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Feb 2021 11:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46331 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 46331-submit@debbugs.gnu.org id=B46331.161261057422344 (code B ref 46331); Sat, 06 Feb 2021 11:23:02 +0000 Original-Received: (at 46331) by debbugs.gnu.org; 6 Feb 2021 11:22:54 +0000 Original-Received: from localhost ([127.0.0.1]:45208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8Lfy-0005oJ-LV for submit@debbugs.gnu.org; Sat, 06 Feb 2021 06:22:54 -0500 Original-Received: from mail-oi1-f180.google.com ([209.85.167.180]:35979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8Lft-0005o1-9t for 46331@debbugs.gnu.org; Sat, 06 Feb 2021 06:22:52 -0500 Original-Received: by mail-oi1-f180.google.com with SMTP id k204so8846576oih.3 for <46331@debbugs.gnu.org>; Sat, 06 Feb 2021 03:22:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UdeGz9DYLHUWpFIJfcPS7uSbBchX7mtQICPJaW3+HJ0=; b=2RsTNkpVvRHyBqlIHhlaX/asDdZb5LK6fnMNYencCnha/dnnFuLzXjBgC0AF547PN0 g7rhTje78rAPTCrJOZrYqtl8r2hlOEvuNARV2chaBeDeXP0x+4EL9jWpxatajIQZAoQT +/ySuc6h/Pwpe32YMxqwsgWkGzWMd561Xis4Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UdeGz9DYLHUWpFIJfcPS7uSbBchX7mtQICPJaW3+HJ0=; b=dx7VfkoQS6ci/OcINHou/p7b8mhAf2GWGYLQlXWBdNRYup8+wwOnkugP6iLohBCoge CS/ym5Nl535J0NemX0aDMHxX/NsvQGuovekrMeqaFPjq2FvIZKnMqSt9qjqT+D0Eu1ec x+fnJ4dCRsiHtT7QYdtuj+693370n3g5xE+zG+3sgtTBBm+jA5HF1SHiBQgAuN0qzEKj V5Beg53BNsw/OAz3OeBqpA1tSDAHp8OEeUuS8SYzyu+irlVnFYHnT2MABUY019wf5dzO vOSmaXtqQoHDRoTEFspALFlrpZLDt28ZlofQJhRZ3bbNS5XrE3kU0OLzKOs3iIRPUaHB wKhQ== X-Gm-Message-State: AOAM530qUlXDr/1sRetCklKRbFJAiNgWm8rwbpfs5CIKcLtsBkfJXcfw CtTJnxUXbWLHxC9QgCn2JBKw7TyB9w9HpjYWZunI8A== X-Google-Smtp-Source: ABdhPJzkEhEghlx3BY0N+zSiIDAh9uDIfgqUmlKEPHpQ/MWNEK9EY7YsC04Lfl95+wouuOfnXmb511ZCsJhw2P5aQT4= X-Received: by 2002:aca:5b46:: with SMTP id p67mr5837875oib.179.1612610563501; Sat, 06 Feb 2021 03:22:43 -0800 (PST) In-Reply-To: <8735y9e9u9.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199414 Archived-At: --000000000000cc86b805baa92742 Content-Type: text/plain; charset="UTF-8" On Sat, 6 Feb 2021 at 11:04, Lars Ingebrigtsen wrote: > Reuben Thomas writes: > > > javascript-mode is an alias for js-mode, and some third-party modes (e.g. > > json-mode) derive from it. > > > > (provided-mode-derived-p 'js-mode 'prog-mode) == t > > > > but > > > > (provided-mode-derived-p 'javascript-mode 'prog-mode) == nil > > > > Hence in json-mode, (derived-mode-p 'prog-mode) evaluates to nil, which > seems > > unfortunate. > > Yup. I've now changed the function to also work on MODE parameters that > are function aliases. > Many thanks! -- https://rrt.sc3d.org --000000000000cc86b805baa92742 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, 6 Feb 2021 at 11:04, Lars Ingebrigtsen <larsi@gnus.org> wrote:
Reuben Thomas <rrt@sc3d.org> writes:

> javascript-mode is an alias for js-mode, and some third-party modes (e= .g.
> json-mode) derive from it.
>
> (provided-mode-derived-p 'js-mode 'prog-mode) =3D=3D t
>
> but
>
> (provided-mode-derived-p 'javascript-mode 'prog-mode) =3D=3D n= il
>
> Hence in json-mode, (derived-mode-p 'prog-mode) evaluates to nil, = which seems
> unfortunate.

Yup.=C2=A0 I've now changed the function to also work on MODE parameter= s that
are function aliases.

Many thanks!

--
--000000000000cc86b805baa92742--