From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Reuben Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#14502: 24.3; dired-load-hook should not be customizable Date: Fri, 16 Aug 2019 09:13:31 +0100 Message-ID: References: <87k3mirl7x.fsf@sc3d.org> <8736i32g5y.fsf@mouse.gnus.org> <871rxlsxs3.fsf@mouse.gnus.org> Reply-To: Reuben Thomas Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000099288f05903791c1" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="179010"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 14502@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 16 10:22:27 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hyXVD-000kPA-3w for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Aug 2019 10:22:27 +0200 Original-Received: from localhost ([::1]:51660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyXVB-0001D7-Vi for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Aug 2019 04:22:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47327) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyXN6-0008Kr-2b for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2019 04:14:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyXN4-0006nS-R7 for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2019 04:14:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44210) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hyXN4-0006nC-LG for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2019 04:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hyXN4-0004EJ-DZ for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2019 04:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Aug 2019 08:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14502 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 14502-submit@debbugs.gnu.org id=B14502.156594323116235 (code B ref 14502); Fri, 16 Aug 2019 08:14:02 +0000 Original-Received: (at 14502) by debbugs.gnu.org; 16 Aug 2019 08:13:51 +0000 Original-Received: from localhost ([127.0.0.1]:53031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyXMt-0004Dn-5g for submit@debbugs.gnu.org; Fri, 16 Aug 2019 04:13:51 -0400 Original-Received: from mail-ot1-f41.google.com ([209.85.210.41]:43652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyXMr-0004Da-K2 for 14502@debbugs.gnu.org; Fri, 16 Aug 2019 04:13:50 -0400 Original-Received: by mail-ot1-f41.google.com with SMTP id e12so8829284otp.10 for <14502@debbugs.gnu.org>; Fri, 16 Aug 2019 01:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nNM4+PVUvgwEMq7i9By242HJRyuuuzAaVhKBlsvzvDo=; b=e3BUGJ+6JMGWdHZhVpviFVehsMiA86ANbrn9WSFsc+1S6Vx89DZ2khNuW+v+kdPPCj AeXEQsBYWRqTD0cAyqCvJAebM+1nnSScZMAMe02xZTWjPEUC0h4nEREzHH4kEGxRVwuE UmrIolvtrQyWPs+WTT/ZInrZTlHfQXkcDLdyA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nNM4+PVUvgwEMq7i9By242HJRyuuuzAaVhKBlsvzvDo=; b=GW+IyiLkvw/pHYVc5kRaRZbiKs4jm0bAXS+gX58MdC/tQtxfFSCEdhFvei1i6i0b75 1IadYD3NFiOnh994kj/ea+FBArVFPdZiaULyQdvGUqkuQeyVm0Sz3At4HapIXF2zlMEO pguuaoZ85P1ztJHFcIx7BaRZHb9iG2BDzDwi/nJEoCi/hqG/7UEGaFy3RPtOWihMwNmZ WFq18G0o5DGQjQ72aGPhIztK3iFUggLdrALdjg8gOREeTz/VR7ImBLoxIt/0bplF9lau 7/L0Tdc7AjIGL7Z2lyC2NmP72mj3XRKWx+4wKRBuiinzeeFZtsI2Y7E09jIMo7od+dDA pKmw== X-Gm-Message-State: APjAAAX55kyeAZnZotmcmPPX2+JES+NhgRbQMe+TVJucruokwFpAI5WF z67ELKUml39bSyWgSUQm5Hd57qoU4Dxo2EjEyZp5Sw== X-Google-Smtp-Source: APXvYqzTemGx8uE8JyLq2y8mcCYqVbuRVDTYbHBhcXbxEPyrqzJ+bxCl7ReBgwYmUB6JZYxVeEMbW2XkLCMrbiZFtac= X-Received: by 2002:a05:6830:15d9:: with SMTP id j25mr3182278otr.76.1565943223881; Fri, 16 Aug 2019 01:13:43 -0700 (PDT) In-Reply-To: <871rxlsxs3.fsf@mouse.gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165193 Archived-At: --00000000000099288f05903791c1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 16 Aug 2019 at 02:29, Lars Ingebrigtsen wrote: > (Please keep the debbugs address in the Cc header.) > Sorry! The problem in #13780 is that if you mix add-hook with Customize > settings of a hook, then (depending on load order), the Customize value > for the hook may overwrite those add-hooks. The solution proposed is > that one shouldn't have defcustoms on the hooks one may somehow expect > that packages add stuff to. > > But dired-load-hook doesn't seem like one of those hooks, and if you > use Customize to be > > (load-x) > > where load-x is > > (defun load-x () > (require 'dired-x)) > > then surely dired-x will be loaded with dired is loaded? (Not that I've > tried myself.) > dired-x adds dired-extra-startup to dired-mode-hook=E2=80=A6 dired-mode-hook in my setup also has sml/set-buffer-identification added by smart-mode-line, so yes, it is "one of those hooks" --=20 https://rrt.sc3d.org --00000000000099288f05903791c1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, 16 Aug 2019 at 02:29, Lars Ingebrigtsen <larsi@gnus.org> wrote:
(Please keep the debbugs address in the Cc= header.)

Sorry!
The problem in #13780 is that if you mix add-hook with Customize
settings of a hook, then (depending on load order), the Customize value
for the hook may overwrite those add-hooks.=C2=A0 The solution proposed is<= br> that one shouldn't have defcustoms on the hooks one may somehow expect<= br> that packages add stuff to.

But dired-load-hook doesn't seem like one of those hooks, and if you use Customize to be

(load-x)

where load-x is

(defun load-x ()
=C2=A0 (require 'dired-x))

then surely dired-x will be loaded with dired is loaded?=C2=A0 (Not that I&= #39;ve
tried myself.)

dired= -x adds dired-extra-startup to dired-mode-hook=E2=80=A6
dired-mode-hook in my setup also has sml/set-buff= er-identification added by smart-mode-line, so yes, it is "one of thos= e hooks"

--
--00000000000099288f05903791c1--