From: Reuben Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 14502@debbugs.gnu.org
Subject: bug#14502: 24.3; dired-load-hook should not be customizable
Date: Fri, 16 Aug 2019 09:13:31 +0100 [thread overview]
Message-ID: <CAOnWdogW0rsZ6UOGtvi-ODGoUkVob1_FjsOdMWrDodbQ2b1KLw@mail.gmail.com> (raw)
In-Reply-To: <871rxlsxs3.fsf@mouse.gnus.org>
[-- Attachment #1: Type: text/plain, Size: 966 bytes --]
On Fri, 16 Aug 2019 at 02:29, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> (Please keep the debbugs address in the Cc header.)
>
Sorry!
The problem in #13780 is that if you mix add-hook with Customize
> settings of a hook, then (depending on load order), the Customize value
> for the hook may overwrite those add-hooks. The solution proposed is
> that one shouldn't have defcustoms on the hooks one may somehow expect
> that packages add stuff to.
>
> But dired-load-hook doesn't seem like one of those hooks, and if you
> use Customize to be
>
> (load-x)
>
> where load-x is
>
> (defun load-x ()
> (require 'dired-x))
>
> then surely dired-x will be loaded with dired is loaded? (Not that I've
> tried myself.)
>
dired-x adds dired-extra-startup to dired-mode-hook…
dired-mode-hook in my setup also has sml/set-buffer-identification added by
smart-mode-line, so yes, it is "one of those hooks"
--
https://rrt.sc3d.org
[-- Attachment #2: Type: text/html, Size: 2035 bytes --]
next prev parent reply other threads:[~2019-08-16 8:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 13:04 bug#14502: 24.3; dired-load-hook should not be customizable Reuben Thomas
2019-08-15 4:42 ` Lars Ingebrigtsen
[not found] ` <CAOnWdoh8TJRpPTiizOZf+RT=wKA45ztc+q_j+dq-9_190=gMWg@mail.gmail.com>
2019-08-16 1:29 ` Lars Ingebrigtsen
2019-08-16 8:13 ` Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2019-08-16 20:50 ` Lars Ingebrigtsen
2020-10-28 8:53 ` Stefan Kangas
2019-12-31 13:41 ` Mauro Aranda
2020-01-22 12:27 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOnWdogW0rsZ6UOGtvi-ODGoUkVob1_FjsOdMWrDodbQ2b1KLw@mail.gmail.com \
--to=bug-gnu-emacs@gnu.org \
--cc=14502@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.