all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#13567: 24.1; New remember back-end for storing data in multiple files
@ 2013-01-27 18:09 Reuben Thomas
  2013-04-11 20:13 ` Reuben Thomas
  2013-04-14  7:06 ` bug#13567: " Bastien
  0 siblings, 2 replies; 15+ messages in thread
From: Reuben Thomas @ 2013-01-27 18:09 UTC (permalink / raw)
  To: 13567

I prefer to store my ideas in individual files rather than one big file;
a simplified version of remember-store-in-mailbox achieves this:

;; Remember support for storing remember data in individual files.
(defcustom remember-directory "~/remember"
  "The directory in which to store remember data as files."
  :type 'file
  :group 'remember)

(defcustom remember-directory-file-name-format "%Y-%m-%d_%T-%z"
  "The file in which to store unprocessed data."
  :type 'file
  :group 'remember)

(defcustom remember-handler-functions '(remember-append-to-file)
  "Functions run to process remember data.
Each function is called with the current buffer narrowed to what the
user wants remembered.
If any function returns non-nil, the data is assumed to have been
recorded somewhere by that function. "
  :type 'hook
  :options '(remember-store-in-mailbox
             remember-append-to-file
             remember-store-in-files
             remember-diary-extract-entries
             org-remember-handler)
  :group 'remember)

(defun remember-store-in-files ()
  "Store remember data in a file in the directory `remember-directory',
in a file named by `remember-directory-file-name-format' fed through
`format-time-string'."
  (let ((moment (format-time-string remember-directory-file-name-format (current-time)))
        (text (buffer-string)))
    (with-temp-buffer
      (insert text)
      (write-file (convert-standard-filename
                   (format "%s/%s" remember-directory moment))))))

If you can use this code, I've already signed an Emacs copyright waiver.


In GNU Emacs 24.1.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.12)
 of 2012-09-22 on batsu, modified by Debian
Windowing system distributor `The X.Org Foundation', version 11.0.11300000
Configured using:
 `configure '--build' 'x86_64-linux-gnu' '--build' 'x86_64-linux-gnu'
 '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib'
 '--localstatedir=/var/lib' '--infodir=/usr/share/info'
 '--mandir=/usr/share/man' '--with-pop=yes'
 '--enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.1/site-lisp:/usr/share/emacs/site-lisp'
 '--with-crt-dir=/usr/lib/x86_64-linux-gnu' '--with-x=yes'
 '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars'
 'build_alias=x86_64-linux-gnu' 'CFLAGS=-g -O2 -fstack-protector
 --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -O2'
 'CPPFLAGS=-D_FORTIFY_SOURCE=2''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: en_GB.UTF-8
  value of $LC_NUMERIC: en_GB.UTF-8
  value of $LC_TIME: en_GB.UTF-8
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  recentf-mode: t
  show-paren-mode: t
  server-mode: t
  savehist-mode: t
  minibuffer-electric-default-mode: t
  iswitchb-mode: t
  icomplete-mode: t
  global-auto-revert-mode: t
  desktop-save-mode: t
  TeX-PDF-mode: t
  TeX-source-correlate-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<down-mouse-5> <mouse-5> C-x b C-s <return> M-< C-s 
a p p e n d - t o - f i l e C-a C-n C-n C-p C-p C-SPC 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
M-w C-x b C-s C-s <return> C-p C-p C-p C-p C-p C-p 
C-p C-p C-p C-y <up> <up> <up> <up> <down> <up> C-e 
<up> C-e <return> r e m e m b e r - s t o r e - i n 
- f i l e s C-n C-n C-n C-x C-e C-x C-s M-x c u s t 
o m i z e - f <backspace> g r o u i p [ <backspace> 
<backspace> <backspace> p <return> <up> <return> <help-echo> 
<help-echo> <down-mouse-1> <mouse-1> <double-down-mouse-1> 
<double-mouse-1> <down-mouse-1> <mouse-1> <help-echo> 
<help-echo> <down-mouse-1> <mouse-1> <help-echo> <down-mouse-1> 
<mouse-1> <help-echo> <help-echo> <down-mouse-1> <help-echo> 
<down-mouse-1> <help-echo> <help-echo> M-x r e m e 
m b e r <return> F O o C-x C-s <help-echo> <down-mouse-1> 
<mouse-1> <help-echo> <right> <backspace> SPC <left> 
C-k <help-echo> <help-echo> <down-mouse-1> C-x b <return> 
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-a C-p C-p C-p 
C-p C-n C-SPC C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n M-w M-x r e m e m b e r - <M-backspace> r e p o 
r t - e m c a s - b u g f <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
c a s = b <backspace> <backspace> <backspace> <backspace> 
<backspace> a c s - b u f <return> <backspace> g <
return>

Recent messages:
Saving file /home/rrt/.emacs.d/funs.el...
Wrote /home/rrt/.emacs.d/funs.el
Saving file /home/rrt/.emacs.d/custom.el...
Wrote /home/rrt/.emacs.d/custom.el [2 times]
Use C-c C-c to remember the data.
Saving file /home/rrt/Notes/2013-01-27 18:06:42-+0000...
Wrote /home/rrt/Notes/2013-01-27 18:06:42-+0000
Saving file /home/rrt/.emacs.d/custom.el...
Wrote /home/rrt/.emacs.d/custom.el [2 times]
Mark set

Load-path shadows:
/home/rrt/local/share/emacs/site-lisp/browse-kill-ring hides /usr/share/emacs24/site-lisp/emacs-goodies-el/browse-kill-ring
/home/rrt/local/share/emacs/site-lisp/dict hides /usr/share/emacs24/site-lisp/emacs-goodies-el/dict
/home/rrt/.emacs.d/elpa/dictionary-1.8.7/dictionary-init hides /usr/share/emacs24/site-lisp/dictionary-el/dictionary-init
/home/rrt/.emacs.d/elpa/dictionary-1.8.7/dictionary hides /usr/share/emacs24/site-lisp/dictionary-el/dictionary
/home/rrt/.emacs.d/elpa/dictionary-1.8.7/link hides /usr/share/emacs24/site-lisp/dictionary-el/link
/home/rrt/.emacs.d/elpa/dictionary-1.8.7/connection hides /usr/share/emacs24/site-lisp/dictionary-el/connection
/usr/share/emacs24/site-lisp/auctex/tex-style hides /usr/share/emacs/site-lisp/auctex/tex-style
/usr/share/emacs24/site-lisp/auctex/tex-mik hides /usr/share/emacs/site-lisp/auctex/tex-mik
/usr/share/emacs24/site-lisp/auctex/multi-prompt hides /usr/share/emacs/site-lisp/auctex/multi-prompt
/usr/share/emacs24/site-lisp/auctex/tex-jp hides /usr/share/emacs/site-lisp/auctex/tex-jp
/usr/share/emacs24/site-lisp/auctex/tex-info hides /usr/share/emacs/site-lisp/auctex/tex-info
/usr/share/emacs24/site-lisp/auctex/plain-tex hides /usr/share/emacs/site-lisp/auctex/plain-tex
/usr/share/emacs24/site-lisp/auctex/latex hides /usr/share/emacs/site-lisp/auctex/latex
/usr/share/emacs24/site-lisp/auctex/preview hides /usr/share/emacs/site-lisp/auctex/preview
/usr/share/emacs24/site-lisp/auctex/tex hides /usr/share/emacs/site-lisp/auctex/tex
/usr/share/emacs24/site-lisp/auctex/texmathp hides /usr/share/emacs/site-lisp/auctex/texmathp
/usr/share/emacs24/site-lisp/auctex/context-nl hides /usr/share/emacs/site-lisp/auctex/context-nl
/usr/share/emacs24/site-lisp/auctex/tex-font hides /usr/share/emacs/site-lisp/auctex/tex-font
/usr/share/emacs24/site-lisp/auctex/toolbar-x hides /usr/share/emacs/site-lisp/auctex/toolbar-x
/usr/share/emacs24/site-lisp/auctex/tex-buf hides /usr/share/emacs/site-lisp/auctex/tex-buf
/usr/share/emacs24/site-lisp/auctex/bib-cite hides /usr/share/emacs/site-lisp/auctex/bib-cite
/usr/share/emacs24/site-lisp/auctex/context-en hides /usr/share/emacs/site-lisp/auctex/context-en
/usr/share/emacs24/site-lisp/auctex/tex-fold hides /usr/share/emacs/site-lisp/auctex/tex-fold
/usr/share/emacs24/site-lisp/auctex/tex-bar hides /usr/share/emacs/site-lisp/auctex/tex-bar
/usr/share/emacs24/site-lisp/auctex/context hides /usr/share/emacs/site-lisp/auctex/context
/usr/share/emacs24/site-lisp/auctex/prv-emacs hides /usr/share/emacs/site-lisp/auctex/prv-emacs
/usr/share/emacs24/site-lisp/auctex/font-latex hides /usr/share/emacs/site-lisp/auctex/font-latex
/usr/share/emacs/site-lisp/golang-mode/go-mode-load hides /usr/share/emacs/24.1/site-lisp/golang-mode/go-mode-load
/usr/share/emacs/site-lisp/golang-mode/go-mode hides /usr/share/emacs/24.1/site-lisp/golang-mode/go-mode
/usr/share/emacs/24.1/site-lisp/cmake-data/cmake-mode hides /usr/share/emacs/site-lisp/cmake-mode
/usr/share/emacs/24.1/site-lisp/cdargs hides /usr/share/emacs/site-lisp/cdargs
/usr/share/emacs/site-lisp/rst hides /usr/share/emacs/24.1/lisp/textmodes/rst
/usr/share/emacs24/site-lisp/dictionaries-common/ispell hides /usr/share/emacs/24.1/lisp/textmodes/ispell
/usr/share/emacs24/site-lisp/dictionaries-common/flyspell hides /usr/share/emacs/24.1/lisp/textmodes/flyspell

Features:
(ebnf2ps ps-print ps-def lpr qp newcomment shadow sort mail-extr
emacsbug message format-spec rfc822 mml mml-sec mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc2045 ietf-drums mail-utils cus-edit multi-isearch pp
help-mode view texmathp remember lua-mode cperl-mode latexenc todoo
vc-git preview prv-emacs noutline outline tex-buf font-latex latex
tex-style flymake compile comint ansi-color ring face-remap flyspell
ispell smart-quotes jka-compr auto-dictionary-autoloads
c-eldoc-autoloads dictionary-autoloads diff-git-autoloads
dired-isearch-autoloads full-ack-autoloads guess-style-autoloads
kill-ring-search-autoloads magit-autoloads mv-shell-autoloads
tumble-autoloads http-post-simple-autoloads package tabulated-list
completing-help recentf tree-widget wid-edit uniquify paren server
savehist minibuf-eldef iswitchb icomplete autorevert desktop cus-start
cus-load ropemacs pymacs warnings url-util url-parse auth-source eieio
byte-opt bytecomp byte-compile cconv macroexp gnus-util password-cache
url-vars mm-util mail-prsvr tex dbus xml regexp-opt user-site-loaddefs
advice advice-preload yasnippet help-fns derived edmacro kmacro easymenu
assoc cl muse-autoloads go-mode-load emacs-goodies-el
emacs-goodies-custom emacs-goodies-loaddefs easy-mmode preview-latex
tex-site auto-loads time-date tooltip ediff-hook vc-hooks
lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image fringe
lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer loaddefs button faces cus-face files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind
dynamic-setting system-font-setting font-render-setting move-toolbar gtk
x-toolkit x multi-tty emacs)

-- 
http://rrt.sc3d.org/





^ permalink raw reply	[flat|nested] 15+ messages in thread

* bug#13567: 24.1; New remember back-end for storing data in multiple files
  2013-01-27 18:09 bug#13567: 24.1; New remember back-end for storing data in multiple files Reuben Thomas
@ 2013-04-11 20:13 ` Reuben Thomas
  2013-04-11 20:20   ` bug#13567: Fwd: " Reuben Thomas
  2013-04-14  7:06 ` bug#13567: " Bastien
  1 sibling, 1 reply; 15+ messages in thread
From: Reuben Thomas @ 2013-04-11 20:13 UTC (permalink / raw)
  To: 13567

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

Ping? If there's no interest in this I could release it as an extension.
I'd rather it went into remember itself, however, and I do have an Emacs
copyright assignment on file!

-- 
http://rrt.sc3d.org

[-- Attachment #2: Type: text/html, Size: 306 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* bug#13567: Fwd: 24.1; New remember back-end for storing data in multiple files
  2013-04-11 20:13 ` Reuben Thomas
@ 2013-04-11 20:20   ` Reuben Thomas
  0 siblings, 0 replies; 15+ messages in thread
From: Reuben Thomas @ 2013-04-11 20:20 UTC (permalink / raw)
  To: 13567

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

Ping? If there's no interest in this I could release it as an extension.
I'd rather it went into remember itself, however, and I do have an Emacs
copyright assignment on file!

-- 
http://rrt.sc3d.org

[-- Attachment #2: Type: text/html, Size: 276 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* bug#13567: 24.1; New remember back-end for storing data in multiple files
  2013-01-27 18:09 bug#13567: 24.1; New remember back-end for storing data in multiple files Reuben Thomas
  2013-04-11 20:13 ` Reuben Thomas
@ 2013-04-14  7:06 ` Bastien
  2013-04-14 20:16   ` Reuben Thomas
  1 sibling, 1 reply; 15+ messages in thread
From: Bastien @ 2013-04-14  7:06 UTC (permalink / raw)
  To: Reuben Thomas; +Cc: 13567

Hi,

Reuben Thomas <rrt@sc3d.org> writes:

> I prefer to store my ideas in individual files rather than one big file;
> a simplified version of remember-store-in-mailbox achieves this:
>
> ;; Remember support for storing remember data in individual files.
> (defcustom remember-directory "~/remember"
>   "The directory in which to store remember data as files."
>   :type 'file
>   :group 'remember)

Better use remember-data-directory since there is remember-data-file?

> (defcustom remember-directory-file-name-format "%Y-%m-%d_%T-%z"
>   "The file in which to store unprocessed data."
>   :type 'file
>   :group 'remember)

The docstring needs an update.

> (defcustom remember-handler-functions '(remember-append-to-file)
>   "Functions run to process remember data.
> Each function is called with the current buffer narrowed to what the
> user wants remembered.
> If any function returns non-nil, the data is assumed to have been
> recorded somewhere by that function. "
>   :type 'hook
>   :options '(remember-store-in-mailbox
>              remember-append-to-file
>              remember-store-in-files
>              remember-diary-extract-entries
>              org-remember-handler)
>   :group 'remember)
>
> (defun remember-store-in-files ()
>   "Store remember data in a file in the directory `remember-directory',
> in a file named by `remember-directory-file-name-format' fed through
> `format-time-string'."

The first line of the docstring should be a sentence.
You can use M-x checkdoc RET to catch those docstring errors.

>   (let ((moment (format-time-string remember-directory-file-name-format (current-time)))
>         (text (buffer-string)))
>     (with-temp-buffer
>       (insert text)
>       (write-file (convert-standard-filename
>                    (format "%s/%s" remember-directory moment))))))
>
> If you can use this code, I've already signed an Emacs copyright
> waiver.

Looks okay to me -- can you provide the change as a patch against
current remember.el?

Thanks,

-- 
 Bastien





^ permalink raw reply	[flat|nested] 15+ messages in thread

* bug#13567: 24.1; New remember back-end for storing data in multiple files
  2013-04-14  7:06 ` bug#13567: " Bastien
@ 2013-04-14 20:16   ` Reuben Thomas
  2013-04-24 14:37     ` Bastien
  0 siblings, 1 reply; 15+ messages in thread
From: Reuben Thomas @ 2013-04-14 20:16 UTC (permalink / raw)
  To: Bastien; +Cc: 13567

[-- Attachment #1: Type: text/plain, Size: 4069 bytes --]

On 14 April 2013 08:06, Bastien <bzg@altern.org> wrote:

> Hi,
>
> Reuben Thomas <rrt@sc3d.org> writes:
>
> > I prefer to store my ideas in individual files rather than one big file;
> > a simplified version of remember-store-in-mailbox achieves this:
> >
> > ;; Remember support for storing remember data in individual files.
> > (defcustom remember-directory "~/remember"
> >   "The directory in which to store remember data as files."
> >   :type 'file
> >   :group 'remember)
>
> Better use remember-data-directory since there is remember-data-file?
>
> > (defcustom remember-directory-file-name-format "%Y-%m-%d_%T-%z"
> >   "The file in which to store unprocessed data."
> >   :type 'file
> >   :group 'remember)
>
> The docstring needs an update.
>
> > (defcustom remember-handler-functions '(remember-append-to-file)
> >   "Functions run to process remember data.
> > Each function is called with the current buffer narrowed to what the
> > user wants remembered.
> > If any function returns non-nil, the data is assumed to have been
> > recorded somewhere by that function. "
> >   :type 'hook
> >   :options '(remember-store-in-mailbox
> >              remember-append-to-file
> >              remember-store-in-files
> >              remember-diary-extract-entries
> >              org-remember-handler)
> >   :group 'remember)
> >
> > (defun remember-store-in-files ()
> >   "Store remember data in a file in the directory `remember-directory',
> > in a file named by `remember-directory-file-name-format' fed through
> > `format-time-string'."
>
> The first line of the docstring should be a sentence.
> You can use M-x checkdoc RET to catch those docstring errors.
>
> >   (let ((moment (format-time-string remember-directory-file-name-format
> (current-time)))
> >         (text (buffer-string)))
> >     (with-temp-buffer
> >       (insert text)
> >       (write-file (convert-standard-filename
> >                    (format "%s/%s" remember-directory moment))))))
> >
> > If you can use this code, I've already signed an Emacs copyright
> > waiver.
>
> Looks okay to me -- can you provide the change as a patch against
> current remember.el?
>

I guess it's lucky I failed to push my commit earlier! Thanks very much for
the review, modified patch below against bzr master tip.

=== modified file 'lisp/textmodes/remember.el'
--- lisp/textmodes/remember.el    2013-03-12 02:08:21 +0000
+++ lisp/textmodes/remember.el    2013-04-14 20:07:22 +0000
@@ -216,10 +216,11 @@
 Each function is called with the current buffer narrowed to what the
 user wants remembered.
 If any function returns non-nil, the data is assumed to have been
-recorded somewhere by that function. "
+recorded somewhere by that function."
   :type 'hook
   :options '(remember-store-in-mailbox
              remember-append-to-file
+             remember-store-in-files
              remember-diary-extract-entries
              org-remember-handler)
   :group 'remember)
@@ -429,6 +430,30 @@
         (run-hook-with-args-until-success 'remember-handler-functions))
       (remember-destroy))))

+;; Remembering to individual files
+
+(defcustom remember-data-directory "~/remember"
+  "The directory in which to store remember data as files."
+  :type 'file
+  :group 'remember)
+
+(defcustom remember-directory-file-name-format "%Y-%m-%d_%T-%z"
+  "A `format-time-string' format for the file name in which to store
+unprocessed data."
+  :type 'file
+  :group 'remember)
+
+(defun remember-store-in-files ()
+  "Store remember data in a file in `remember-data-directory'.
+The file is named by `remember-directory-file-name-format' fed through
+`format-time-string'."
+  (let ((moment (format-time-string remember-directory-file-name-format
(current-time)))
+        (text (buffer-string)))
+    (with-temp-buffer
+      (insert text)
+      (write-file (convert-standard-filename
+                   (format "%s/%s" remember-data-directory moment))))))
+
 ;;;###autoload
 (defun remember-clipboard ()
   "Remember the contents of the current clipboard.


-- 
http://rrt.sc3d.org

[-- Attachment #2: Type: text/html, Size: 5212 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* bug#13567: 24.1; New remember back-end for storing data in multiple files
  2013-04-14 20:16   ` Reuben Thomas
@ 2013-04-24 14:37     ` Bastien
  2013-04-24 16:50       ` Glenn Morris
  0 siblings, 1 reply; 15+ messages in thread
From: Bastien @ 2013-04-24 14:37 UTC (permalink / raw)
  To: Reuben Thomas; +Cc: 13567-done

Hi,

Reuben Thomas <rrt@sc3d.org> writes:

> I guess it's lucky I failed to push my commit earlier! Thanks very
> much for the review, modified patch below against bzr master tip.

Applied under your name, with some minor stylistic modifications.

Thanks!

-- 
 Bastien





^ permalink raw reply	[flat|nested] 15+ messages in thread

* bug#13567: 24.1; New remember back-end for storing data in multiple files
  2013-04-24 14:37     ` Bastien
@ 2013-04-24 16:50       ` Glenn Morris
  2013-04-25 17:42         ` Bastien
  0 siblings, 1 reply; 15+ messages in thread
From: Glenn Morris @ 2013-04-24 16:50 UTC (permalink / raw)
  To: 13567; +Cc: bzg, rrt


This is missing a NEWS entry, if you want people to know it exists, and
:version tags for the new defcustoms. Also, the custom :types seem
wrong. There is 'directory for directories, and
remember-directory-file-name-format should presumably be 'string rather
than 'file.

PS please try to use --author when committing changes by others.





^ permalink raw reply	[flat|nested] 15+ messages in thread

* bug#13567: 24.1; New remember back-end for storing data in multiple files
  2013-04-24 16:50       ` Glenn Morris
@ 2013-04-25 17:42         ` Bastien
  2013-04-26  0:51           ` Glenn Morris
  0 siblings, 1 reply; 15+ messages in thread
From: Bastien @ 2013-04-25 17:42 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 13567, rrt

Hi Glenn,

Glenn Morris <rgm@gnu.org> writes:

> This is missing a NEWS entry, if you want people to know it exists, and
> :version tags for the new defcustoms. Also, the custom :types seem
> wrong. There is 'directory for directories, and
> remember-directory-file-name-format should presumably be 'string rather
> than 'file.

I just fixed the issues above.  Thanks!

> PS please try to use --author when committing changes by others.

Yes, I will pay more attention.

-- 
 Bastien





^ permalink raw reply	[flat|nested] 15+ messages in thread

* bug#13567: 24.1; New remember back-end for storing data in multiple files
  2013-04-25 17:42         ` Bastien
@ 2013-04-26  0:51           ` Glenn Morris
  2013-04-26  7:01             ` Bastien
  2013-04-26 23:57             ` Reuben Thomas
  0 siblings, 2 replies; 15+ messages in thread
From: Glenn Morris @ 2013-04-26  0:51 UTC (permalink / raw)
  To: Bastien; +Cc: 13567, rrt

Bastien wrote:

> I just fixed the issues above.  Thanks!

No, thank you. (Note that rrt has commit rights IIUC, so should be able
to fix these things himself.)

Continuing the petty griping:

Shouldn't remember-data-directory default to
(locate-user-emacs-file "remember")?

It isn't documented that remember-directory-file-name-format is passed
through format-time-string.





^ permalink raw reply	[flat|nested] 15+ messages in thread

* bug#13567: 24.1; New remember back-end for storing data in multiple files
  2013-04-26  0:51           ` Glenn Morris
@ 2013-04-26  7:01             ` Bastien
  2013-04-26  7:44               ` Reuben Thomas
  2013-04-26 23:57             ` Reuben Thomas
  1 sibling, 1 reply; 15+ messages in thread
From: Bastien @ 2013-04-26  7:01 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 13567, rrt

Glenn Morris <rgm@gnu.org> writes:

> Continuing the petty griping:
>
> Shouldn't remember-data-directory default to
> (locate-user-emacs-file "remember")?

I guess so.

> It isn't documented that remember-directory-file-name-format is passed
> through format-time-string.

I over-simplified the docstring that Reuben provided first.

Reuben, please let us know if you can make these changes yourself.

Thanks,

-- 
 Bastien





^ permalink raw reply	[flat|nested] 15+ messages in thread

* bug#13567: 24.1; New remember back-end for storing data in multiple files
  2013-04-26  7:01             ` Bastien
@ 2013-04-26  7:44               ` Reuben Thomas
  2013-04-26  7:47                 ` Bastien
  0 siblings, 1 reply; 15+ messages in thread
From: Reuben Thomas @ 2013-04-26  7:44 UTC (permalink / raw)
  To: Bastien; +Cc: 13567

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

On Apr 26, 2013 8:01 AM, "Bastien" <bzg@altern.org> wrote:
>
> Glenn Morris <rgm@gnu.org> writes:
>
> > Continuing the petty griping:
> >
> > Shouldn't remember-data-directory default to
> > (locate-user-emacs-file "remember")?
>
> I guess so.
>
> > It isn't documented that remember-directory-file-name-format is passed
> > through format-time-string.
>
> I over-simplified the docstring that Reuben provided first.
>
> Reuben, please let us know if you can make these changes yourself.

Sure.

[-- Attachment #2: Type: text/html, Size: 753 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* bug#13567: 24.1; New remember back-end for storing data in multiple files
  2013-04-26  7:44               ` Reuben Thomas
@ 2013-04-26  7:47                 ` Bastien
  0 siblings, 0 replies; 15+ messages in thread
From: Bastien @ 2013-04-26  7:47 UTC (permalink / raw)
  To: Reuben Thomas; +Cc: 13567

Reuben Thomas <rrt@sc3d.org> writes:

> Sure.

Okay, thanks in advance,

-- 
 Bastien





^ permalink raw reply	[flat|nested] 15+ messages in thread

* bug#13567: 24.1; New remember back-end for storing data in multiple files
  2013-04-26  0:51           ` Glenn Morris
  2013-04-26  7:01             ` Bastien
@ 2013-04-26 23:57             ` Reuben Thomas
  2013-04-27 15:38               ` Josh
  1 sibling, 1 reply; 15+ messages in thread
From: Reuben Thomas @ 2013-04-26 23:57 UTC (permalink / raw)
  To: Glenn Morris; +Cc: Bastien, 13567

[-- Attachment #1: Type: text/plain, Size: 627 bytes --]

On 26 April 2013 01:51, Glenn Morris <rgm@gnu.org> wrote:

> Bastien wrote:
>
> > I just fixed the issues above.  Thanks!
>
> No, thank you. (Note that rrt has commit rights IIUC, so should be able
> to fix these things himself.)
>
> Continuing the petty griping:
>
> Shouldn't remember-data-directory default to
> (locate-user-emacs-file "remember")?
>

No: these are ordinary text files, not Emacs configuration files, and
shouldn't be hidden away in a configuration directory.

It isn't documented that remember-directory-file-name-format is passed
> through format-time-string.
>

I've fixed this.

-- 
http://rrt.sc3d.org

[-- Attachment #2: Type: text/html, Size: 1281 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* bug#13567: 24.1; New remember back-end for storing data in multiple files
  2013-04-26 23:57             ` Reuben Thomas
@ 2013-04-27 15:38               ` Josh
  2013-04-27 15:43                 ` Reuben Thomas
  0 siblings, 1 reply; 15+ messages in thread
From: Josh @ 2013-04-27 15:38 UTC (permalink / raw)
  To: Reuben Thomas; +Cc: 13567, Bastien

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

On Fri, Apr 26, 2013 at 4:57 PM, Reuben Thomas <rrt@sc3d.org> wrote:

> On 26 April 2013 01:51, Glenn Morris <rgm@gnu.org> wrote:
>
>> Shouldn't remember-data-directory default to
>> (locate-user-emacs-file "remember")?
>>
>
> No: these are ordinary text files, not Emacs configuration files, and
> shouldn't be hidden away in a configuration directory.
>

The form Glenn suggested would place remember-data-directory under
user-emacs-directory, which is documented to contain "additional per-user
Emacs-specific files", not merely configuration files.  It's better to make
this the default location instead of cluttering up users' home directories,
especially with non-hidden files, without their permission.  See also bug
13870 for a recent precedent.

[-- Attachment #2: Type: text/html, Size: 1576 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* bug#13567: 24.1; New remember back-end for storing data in multiple files
  2013-04-27 15:38               ` Josh
@ 2013-04-27 15:43                 ` Reuben Thomas
  0 siblings, 0 replies; 15+ messages in thread
From: Reuben Thomas @ 2013-04-27 15:43 UTC (permalink / raw)
  To: Josh; +Cc: 13567, Bastien

[-- Attachment #1: Type: text/plain, Size: 832 bytes --]

On 27 April 2013 16:38, Josh <josh@foxtail.org> wrote:

>
> The form Glenn suggested would place remember-data-directory under
> user-emacs-directory, which is documented to contain "additional per-user
> Emacs-specific files", not merely configuration files.
>

These are not Emacs-specific files.

 It's better to make this the default location instead of cluttering up
> users' home directories, especially with non-hidden files, without their
> permission.
>

It's data they've specifically entered, and a remember back-end they've
specifically configured.


>  See also bug 13870 for a recent precedent.
>

The wrong solution, I think, though since the previous value was a
dot-file, the new one may as well be considered Emacs-specific (although by
comparison with .tagline or .project, perhaps not).

-- 
http://rrt.sc3d.org

[-- Attachment #2: Type: text/html, Size: 1804 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2013-04-27 15:43 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-27 18:09 bug#13567: 24.1; New remember back-end for storing data in multiple files Reuben Thomas
2013-04-11 20:13 ` Reuben Thomas
2013-04-11 20:20   ` bug#13567: Fwd: " Reuben Thomas
2013-04-14  7:06 ` bug#13567: " Bastien
2013-04-14 20:16   ` Reuben Thomas
2013-04-24 14:37     ` Bastien
2013-04-24 16:50       ` Glenn Morris
2013-04-25 17:42         ` Bastien
2013-04-26  0:51           ` Glenn Morris
2013-04-26  7:01             ` Bastien
2013-04-26  7:44               ` Reuben Thomas
2013-04-26  7:47                 ` Bastien
2013-04-26 23:57             ` Reuben Thomas
2013-04-27 15:38               ` Josh
2013-04-27 15:43                 ` Reuben Thomas

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.