From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#18716: Patch for this bug Date: Fri, 2 Dec 2016 16:10:01 +0000 Message-ID: References: <8761fm903w.fsf@sc3d.org> <83a8d9hh62.fsf@gnu.org> <83lgwsfntd.fsf@gnu.org> <83y40rdyku.fsf@gnu.org> <3cd1ba7a-1aa4-359c-a817-dac9b567157e@cornell.edu> <8360n2oej1.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=f403045ea68a9fbbb10542af2b1b X-Trace: blaine.gmane.org 1480695637 14629 195.159.176.226 (2 Dec 2016 16:20:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 2 Dec 2016 16:20:37 +0000 (UTC) Cc: 18716@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 02 17:20:30 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCqZX-0002Lp-56 for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Dec 2016 17:20:27 +0100 Original-Received: from localhost ([::1]:35406 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCqZb-0001Jd-34 for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Dec 2016 11:20:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCqQU-0003v9-MC for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 11:11:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCqQQ-0001BO-5B for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 11:11:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35104) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cCqQQ-0001B5-0d for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 11:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cCqQP-0000ix-OW for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 11:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2016 16:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18716 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18716-submit@debbugs.gnu.org id=B18716.14806950092720 (code B ref 18716); Fri, 02 Dec 2016 16:11:01 +0000 Original-Received: (at 18716) by debbugs.gnu.org; 2 Dec 2016 16:10:09 +0000 Original-Received: from localhost ([127.0.0.1]:50503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCqPY-0000hn-P9 for submit@debbugs.gnu.org; Fri, 02 Dec 2016 11:10:09 -0500 Original-Received: from mail-lf0-f54.google.com ([209.85.215.54]:33819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCqPX-0000hb-T4 for 18716@debbugs.gnu.org; Fri, 02 Dec 2016 11:10:08 -0500 Original-Received: by mail-lf0-f54.google.com with SMTP id o141so198467685lff.1 for <18716@debbugs.gnu.org>; Fri, 02 Dec 2016 08:10:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aK/DpShSk1ZBiRLcea1FVVtdRs0sbOxG6Z5KI6kGCCU=; b=PvJbohMvVMCc6WXpNsZd5tWVj4Y3wm+VoBVX8dSu13I19dPhxBdAO9d7YBbaAMRa1D uvGhjK1sed37SGzWzO8sWQC/S9Z4rdpBZGU48OxNavr1fDy0zXWksBIdJefPrGkwRPw+ ey/bJpKcY/dbB+gaR3XdDx7boKbY01+bcianQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aK/DpShSk1ZBiRLcea1FVVtdRs0sbOxG6Z5KI6kGCCU=; b=giEebntTlJ6A3qpOBFq3c8CdY6pFbEk2zT5t/0me2dqDVpVJgeo5n8zG2NUUyqaKYE g+dVKNTPx/LoPRceoDLH09OhyJ2ylcrbG3hfGF5xhX1R5LLdkib+TGclrgbpJntB60Dy x0p/XTC0BFbv4RG45eaFb0qJWYwe/Zo+ATkAHKSFtAiRUWD3IphvaBcc6PAQM2ZoBi3T kspIQ4mXkthG9URR56L125KJZK1lErcgHGDubdVnoqLuDJ6FFlAR5caMumYxUGAinLVd CBarNNtPmTONLPBaNebqhwhVpx16sjnb5U6/7OZbuXn4dfRT39ECYJdJE7lcgLuw3h9I OrCg== X-Gm-Message-State: AKaTC00cj6GBk2wwmPIO3uERueaM7XJpb9ZrvnhMBCPaXz9ryeglfzQ2fEifU3F1YFpKpbPQtaP3p0wLCsraSVu2 X-Received: by 10.25.56.65 with SMTP id d1mr16756880lfj.171.1480695002137; Fri, 02 Dec 2016 08:10:02 -0800 (PST) Original-Received: by 10.25.190.2 with HTTP; Fri, 2 Dec 2016 08:10:01 -0800 (PST) In-Reply-To: <8360n2oej1.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126425 Archived-At: --f403045ea68a9fbbb10542af2b1b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2 December 2016 at 09:40, Eli Zaretskii wrote: > > From: Reuben Thomas > > Date: Mon, 28 Nov 2016 21:32:03 +0000 > > Cc: Eli Zaretskii , 18716@debbugs.gnu.org > > > > =E2=80=8BThanks for the heads up, that's great news! It bothered me tha= t there > was no easy way to do this previously. > > > > =E2=80=8BI updated my patch so that dired-omit-case-fold is now a three= -valued > variable which defaults to 'filesystem, > > and a helper function that checks (filename-case-sensitive-p > dired-directory) when this value is used. > > > > I've added info and NEWS documentation for dired-omit-case-fold. > > Thanks, a few comments below. With those fixed, please push to > master. > Done; thanks for the review.=E2=80=8B > + Set to > > +@code{nil} to be always case-sensitive, and @code{t} to be always > > +case-sensitive. > > So which is it? ;-) > =E2=80=8BI had quite a lot of struggles with these! Well spotted.=E2=80=8B =E2=80=8B=E2=80=8B > Bonus points for avoiding passive tense altogether ("... allows > customization of case-sensitivity ..."). > Bonus points earned! > > +(defcustom dired-omit-case-fold 'filesystem > > + "Whether `dired-omit-mode' will use case-folding to match the > > +regexp of files to omit. When nil, always be case-sensitive; when > > The first line of a doc string should be a complete sentence. > =E2=80=8BOK, I fixed this one.=E2=80=8B > > +(defun dired-omit-case-fold-p (dir) > > + "Return t if, according to `dired-omit-case-fold', > > + `dired-omit-mode' should use case folding to interpret its > > + regexp in directory DIR." > > Likewise. > =E2=80=8BI'm a bit puzzled here: this is a complete sentence. I wondered wh= ether you expected an "else" clause, so I added one: "=E2=80=A6, or nil otherwise= ." --=20 http://rrt.sc3d.org --f403045ea68a9fbbb10542af2b1b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On = 2 December 2016 at 09:40, Eli Zaretskii <eliz@gnu.org> wrote:
=
> From: Reuben Thomas <rrt@sc3d.org>
> Date: Mon, 28 Nov 2016 21:32:03 +0000
> Cc: Eli Zaretskii <eliz@gnu.org>, 18716@debbugs.gnu.org
>
> =E2=80=8BThanks for the heads up, that's great news! It bothered m= e that there was no easy way to do this previously.
>
> =E2=80=8BI updated my patch so that dired-omit-case-fold is now a thre= e-valued variable which defaults to 'filesystem,
> and a helper function that checks (filename-case-sensitive-p dired-dir= ectory) when this value is used.
>
> I've added info and NEWS documentation for dired-omit-case-fold.
Thanks, a few comments below.=C2=A0 With those fixed, please push to=
master.

Done; thanks for the review.=E2=80=8B

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Set to > +@code{nil} to be always case-sensitive, and @code{t} to be always
> +case-sensitive.

So which is it? ;-)

=E2=80=8BI had quite a lot of struggles= with these! Well spotted.=E2=80=8B

=E2=80=8B=E2=80=8B
Bonus points for avoiding passive tens= e altogether ("... allows
customization of case-sensitivity ...").

Bonus points = earned!
=C2=A0<= br>
> +(defcustom dired-omit-c= ase-fold 'filesystem
> +=C2=A0 "Whether `dired-omit-mode' will use case-folding to m= atch the
> +regexp of files to omit.=C2=A0 When nil, always be case-sensitive; wh= en

The first line of a doc string should be a complete sentence.

=E2=80=8BOK, I fixed this one.=E2=80=8B
=C2=A0
> +(defun dired-omit-case-fold-p (dir)
> +=C2=A0 "Return t if, according to `dired-omit-case-fold', > +=C2=A0 `dired-omit-mode' should use case folding to interpret its=
> +=C2=A0 regexp in directory DIR."

Likewise.

=E2=80=8BI'm a bit puzzled here: this is a complete sentence. I wond= ered whether you expected an "else" clause, so I added one: "= ;=E2=80=A6, or nil otherwise."

--
http://rrt.sc3d.org=
--f403045ea68a9fbbb10542af2b1b--