From: Reuben Thomas <rrt@sc3d.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 18716@debbugs.gnu.org
Subject: bug#18716: Patch for this bug
Date: Fri, 2 Dec 2016 16:10:01 +0000 [thread overview]
Message-ID: <CAOnWdog3_w24kr9grec7hWRX2oN1AgF-FFKZmgd7m84+EeMn7A@mail.gmail.com> (raw)
In-Reply-To: <8360n2oej1.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1880 bytes --]
On 2 December 2016 at 09:40, Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Reuben Thomas <rrt@sc3d.org>
> > Date: Mon, 28 Nov 2016 21:32:03 +0000
> > Cc: Eli Zaretskii <eliz@gnu.org>, 18716@debbugs.gnu.org
> >
> > Thanks for the heads up, that's great news! It bothered me that there
> was no easy way to do this previously.
> >
> > I updated my patch so that dired-omit-case-fold is now a three-valued
> variable which defaults to 'filesystem,
> > and a helper function that checks (filename-case-sensitive-p
> dired-directory) when this value is used.
> >
> > I've added info and NEWS documentation for dired-omit-case-fold.
>
> Thanks, a few comments below. With those fixed, please push to
> master.
>
Done; thanks for the review.
> + Set to
> > +@code{nil} to be always case-sensitive, and @code{t} to be always
> > +case-sensitive.
>
> So which is it? ;-)
>
I had quite a lot of struggles with these! Well spotted.
> Bonus points for avoiding passive tense altogether ("... allows
> customization of case-sensitivity ...").
>
Bonus points earned!
> > +(defcustom dired-omit-case-fold 'filesystem
> > + "Whether `dired-omit-mode' will use case-folding to match the
> > +regexp of files to omit. When nil, always be case-sensitive; when
>
> The first line of a doc string should be a complete sentence.
>
OK, I fixed this one.
> > +(defun dired-omit-case-fold-p (dir)
> > + "Return t if, according to `dired-omit-case-fold',
> > + `dired-omit-mode' should use case folding to interpret its
> > + regexp in directory DIR."
>
> Likewise.
>
I'm a bit puzzled here: this is a complete sentence. I wondered whether
you expected an "else" clause, so I added one: "…, or nil otherwise."
--
http://rrt.sc3d.org
[-- Attachment #2: Type: text/html, Size: 3761 bytes --]
next prev parent reply other threads:[~2016-12-02 16:10 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 14:50 bug#18716: 24.3; dired-omit-extensions's default value omits COPYING.LIB Reuben Thomas
2014-10-14 23:41 ` Stefan Monnier
2014-10-14 23:51 ` Reuben Thomas
2014-10-15 7:56 ` Andreas Schwab
2014-10-15 14:21 ` Stefan Monnier
2014-10-15 14:26 ` Reuben Thomas
2014-10-15 14:27 ` Reuben Thomas
2014-10-15 17:59 ` Stefan Monnier
2014-10-15 19:05 ` Reuben Thomas
2014-10-15 22:42 ` Stefan Monnier
2014-10-15 23:00 ` Reuben Thomas
2014-10-16 3:10 ` Stefan Monnier
2014-10-15 14:26 ` Andreas Schwab
2014-10-15 17:57 ` Stefan Monnier
2014-10-15 20:57 ` Andreas Schwab
2014-10-15 22:44 ` Stefan Monnier
2014-10-15 22:54 ` Glenn Morris
2014-10-16 3:06 ` Stefan Monnier
2014-10-16 7:13 ` Andreas Schwab
2014-10-16 13:15 ` Stefan Monnier
2014-10-16 2:01 ` Richard Stallman
2014-10-16 3:09 ` Stefan Monnier
2014-10-16 18:14 ` Richard Stallman
2014-10-16 20:17 ` Stefan Monnier
2016-11-08 17:51 ` bug#18716: Patch for this bug Reuben Thomas
2016-11-08 20:04 ` Eli Zaretskii
2016-11-08 22:16 ` Reuben Thomas
2016-11-09 19:36 ` Eli Zaretskii
2016-11-09 22:00 ` Reuben Thomas
2016-11-09 22:52 ` Drew Adams
2016-11-09 23:29 ` Reuben Thomas
2016-11-10 17:38 ` Eli Zaretskii
2016-11-26 17:54 ` Reuben Thomas
2016-11-26 18:29 ` Ken Brown
2016-11-28 21:32 ` Reuben Thomas
2016-12-02 9:40 ` Eli Zaretskii
2016-12-02 16:10 ` Reuben Thomas [this message]
2016-12-02 16:16 ` Eli Zaretskii
2016-12-02 16:31 ` Reuben Thomas
2016-12-03 0:22 ` bug#18716: Reuben Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOnWdog3_w24kr9grec7hWRX2oN1AgF-FFKZmgd7m84+EeMn7A@mail.gmail.com \
--to=rrt@sc3d.org \
--cc=18716@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.