From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for CASECHARS in built-in dictionaries Date: Wed, 21 Dec 2016 17:31:46 +0000 Message-ID: References: <831sx36g75.fsf@gnu.org> <837f6u4nmx.fsf@gnu.org> <83eg122xzf.fsf@gnu.org> <83a8bp2ogg.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a114f5c2efdce1f05442e86ed X-Trace: blaine.gmane.org 1482341550 26392 195.159.176.226 (21 Dec 2016 17:32:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Dec 2016 17:32:30 +0000 (UTC) Cc: 25230@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 21 18:32:23 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJkkS-0005Ju-Ca for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Dec 2016 18:32:16 +0100 Original-Received: from localhost ([::1]:58230 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJkkW-0003Vx-VK for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Dec 2016 12:32:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJkkK-0003T8-FO for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2016 12:32:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJkkG-0002xV-5b for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2016 12:32:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35065) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cJkkG-0002xH-2e for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2016 12:32:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cJkkE-0001g8-EI for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2016 12:32:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Dec 2016 17:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25230-submit@debbugs.gnu.org id=B25230.14823415156439 (code B ref 25230); Wed, 21 Dec 2016 17:32:02 +0000 Original-Received: (at 25230) by debbugs.gnu.org; 21 Dec 2016 17:31:55 +0000 Original-Received: from localhost ([127.0.0.1]:50464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJkk6-0001fn-Oo for submit@debbugs.gnu.org; Wed, 21 Dec 2016 12:31:55 -0500 Original-Received: from mail-qk0-f173.google.com ([209.85.220.173]:35001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJkk5-0001fZ-1z for 25230@debbugs.gnu.org; Wed, 21 Dec 2016 12:31:53 -0500 Original-Received: by mail-qk0-f173.google.com with SMTP id u25so78049487qki.2 for <25230@debbugs.gnu.org>; Wed, 21 Dec 2016 09:31:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+1YAvM2n2T9fwANnLdInN552sNbRPadqTsVlFb4cuLU=; b=zC4YtdjyxXGHUV0xwOLIQPrGOStPD9cVySNDFOCakHJ/hmBRhVwBNr7EqE6nbvepjY USYssZQuDOW0HqWzde7UJkvxJxIYufHBAkz3ZpwHKI81AnXojamU4md/YqSO7Z86knXw LAW80a0juSbK3kTTvecGA9+3Ukd7rb0tDz9q8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+1YAvM2n2T9fwANnLdInN552sNbRPadqTsVlFb4cuLU=; b=TRxfqT358YfQixmMh4dzz1YmM9Z19yd7WwgHnxiu6JdraCbwN4SkRZBJ8c1riejRKi cDwsqFPC6WCrNguR7mgnosebGsir/FsoSzYa6MAHEz000Cfiw7VkB9Q20kF8tBtSDp2J KoDpXMVUFYvUalIPsTlMOidSY/yneQk0oGgb/XcfyAzA6ARDCNnP6W3oMg32gapDavpJ jQMTTp8K8hUy82GLYHyuT0bnSe1oPRjMZCCkgaX8coZ5oBjWdnxlWLZVfdnG8fRGXsba wgoEYzA0/Ypru9mvKojZVp1PyYxmAsuUIaMIhY+Q7TqV9R2fz3yYdOxz0/tUjRhAa2av /zmQ== X-Gm-Message-State: AIkVDXIsFJDsXloHvQC+nqijgINt0uesxZcjEkFP5agx6ZMJNTod6w0G7PrNBDtymBeIxGAzKsrwdMO7HNRMwf/K X-Received: by 10.55.115.71 with SMTP id o68mr6431170qkc.270.1482341507473; Wed, 21 Dec 2016 09:31:47 -0800 (PST) Original-Received: by 10.140.88.51 with HTTP; Wed, 21 Dec 2016 09:31:46 -0800 (PST) In-Reply-To: <83a8bp2ogg.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127298 Archived-At: --001a114f5c2efdce1f05442e86ed Content-Type: multipart/alternative; boundary=001a114f5c2efdce1a05442e86eb --001a114f5c2efdce1a05442e86eb Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 21 December 2016 at 17:15, Eli Zaretskii wrote: > > From: Reuben Thomas > > Date: Wed, 21 Dec 2016 00:20:27 +0000 > > Cc: 25230@debbugs.gnu.org > > > > Here's an updated patch, which simply removes the overriding of the > built-in > > CASECHARS/NOT-CASECHARS settings for ispell dictionaries. It assumes > that all other dictionaries (either > > configured by the user or found by the various auto-scanning functions) > will have sensible > > CASECHARS/NOT-CASECHARS values, which is expected to be the case at > present. > > Looks like you sent the wrong patch, as this: > > > diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el > > index 23ee412..82e5c2b 100644 > > --- a/lisp/textmodes/ispell.el > > +++ b/lisp/textmodes/ispell.el > > @@ -436,114 +436,70 @@ ispell-dictionary-base-alist > > ;; The default dictionary. It may be English.aff, or any other > > ;; dictionary depending on locale and such things. We should > probably > > ;; ask ispell what dictionary it's using, but until we do that, > let's > > - ;; just use a minimal regexp. [:alpha:] will later be set if > possible. > > - "[A-Za-z]" "[^A-Za-z]" "[']" nil ("-B") nil iso-8859-1) > > + ;; just use a minimal regexp. > > + "[[:alpha:]]" "[^[:alpha:]]" "[']" nil ("-B") nil iso-8859-1) > > ("american" ; Yankee English > > - "[A-Za-z]" "[^A-Za-z]" "[']" nil ("-B") nil iso-8859-1) > > + "[[:alpha:]]" "[^[:alpha:]]" "[']" nil ("-B") nil iso-8859-1) > > ("brasileiro" ; Brazilian mode > > - "[A-Z\301\311\315\323\332\300\310\314\322\331\303\325\307\ > 334\302\312\324a-z\341\351\355\363\372\340\350\354\362\ > 371\343\365\347\374\342\352\364]" > > - "[^A-Z\301\311\315\323\332\300\310\314\322\331\303\325\ > 307\334\302\312\324a-z\341\351\355\363\372\340\350\354\ > 362\371\343\365\347\374\342\352\364]" > > - "[']" nil nil nil iso-8859-1) > > + "[[:alpha:]]" "[^[:alpha:]]" "[']" nil nil nil iso-8859-1) > > leaves the overriding in place. Am I missing something? > =E2=80=8BI'm baffled, I somehow inverted the sense of what I meant to do, discarding the correct bit of the patch and keeping the incorrect bit. Sorry about that. I attach what should now be the correct patch. --=20 http://rrt.sc3d.org --001a114f5c2efdce1a05442e86eb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On = 21 December 2016 at 17:15, Eli Zaretskii <eliz@gnu.org> wrote:
> From: Reuben Thomas <rrt@sc3d.org>
> Date: Wed, 21 Dec 2016 00:20:27 +0000
> Cc: 25230@debbugs.gnu.org=
>
> Here's an updated patch, which simply removes the overriding of th= e built-in
> CASECHARS/NOT-CASECHARS settings for ispell dictionaries. It assumes t= hat all other dictionaries (either
> configured by the user or found by the various auto-scanning functions= ) will have sensible
> CASECHARS/NOT-CASECHARS values, which is expected to be the case at pr= esent.

Looks like you sent the wrong patch, as this:

> diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el
> index 23ee412..82e5c2b 100644
> --- a/lisp/textmodes/ispell.el
> +++ b/lisp/textmodes/ispell.el
> @@ -436,114 +436,70 @@ ispell-dictionary-base-alist
>=C2=A0 =C2=A0 =C2=A0 =C2=A0;; The default dictionary.=C2=A0 It may be E= nglish.aff, or any other
>=C2=A0 =C2=A0 =C2=A0 =C2=A0;; dictionary depending on locale and such t= hings.=C2=A0 We should probably
>=C2=A0 =C2=A0 =C2=A0 =C2=A0;; ask ispell what dictionary it's using= , but until we do that, let's
> -=C2=A0 =C2=A0 =C2=A0;; just use a minimal regexp. [:alpha:] will late= r be set if possible.
> -=C2=A0 =C2=A0 =C2=A0"[A-Za-z]" "[^A-Z= a-z]" "[']" nil ("-B") nil iso-8859-1)
> +=C2=A0 =C2=A0 =C2=A0;; just use a minimal regexp.
> +=C2=A0 =C2=A0 =C2=A0"[[:alpha:]]" "[^[:alpha:]]" = "[']" nil ("-B") nil iso-8859-1)
>=C2=A0 =C2=A0 =C2=A0 ("american"=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 ; Yankee English
> -=C2=A0 =C2=A0 =C2=A0"[A-Za-z]" "[^A-Z= a-z]" "[']" nil ("-B") nil iso-8859-1)
> +=C2=A0 =C2=A0 =C2=A0"[[:alpha:]]" &= quot;[^[:alpha:]]" "[']" nil ("-B") nil iso-88= 59-1)
>=C2=A0 =C2=A0 =C2=A0 ("brasileiro"=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ; Brazil= ian mode
> -=C2=A0 =C2=A0 =C2=A0"[A-Z\301\311\315\323\332\300\310\314\3= 22\331\303\325\307\334\302\312\324a-z\341\351\355\363\372\340\350= \354\362\371\343\365\347\374\342\352\364]"
> -=C2=A0 =C2=A0 =C2=A0"[^A-Z\301\311\315\323\332\300\310\314\= 322\331\303\325\307\334\302\312\324a-z\341\351\355\363\372\340\35= 0\354\362\371\343\365\347\374\342\352\364]"
> -=C2=A0 =C2=A0 =C2=A0"[']" nil nil nil iso-8859-1)
> +=C2=A0 =C2=A0 =C2=A0"[[:alpha:]]" "[^[:alpha:]]" = "[']" nil nil nil iso-8859-1)

leaves the overriding in place.=C2=A0 Am I missing something?

=E2=80=8BI'm baffled, I somehow inverted the sense of what I meant t= o do, discarding the correct bit of the patch and keeping the incorrect bit= . Sorry about that. I attach what should now be the correct patch.

--
http://rrt.sc3d= .org
--001a114f5c2efdce1a05442e86eb-- --001a114f5c2efdce1f05442e86ed Content-Type: text/x-patch; charset=US-ASCII; name="0001-Keep-default-CASECHARS-NOT-CASECHARS-for-ispell-buil.patch" Content-Disposition: attachment; filename="0001-Keep-default-CASECHARS-NOT-CASECHARS-for-ispell-buil.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iwz7uvsr0 RnJvbSBiZGM1OGVjNDNjN2NhNmZjYjIzMmJhMDBhYzkzNmZjNjJjY2ZmNThkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFdl ZCwgMjEgRGVjIDIwMTYgMTc6MzA6NDQgKzAwMDAKU3ViamVjdDogW1BBVENIIDEvNl0gS2VlcCBk ZWZhdWx0IENBU0VDSEFSUy9OT1QtQ0FTRUNIQVJTIGZvciBpc3BlbGwgYnVpbHQtaW4KIGRpY3Rp b25hcmllcwoKKiBsaXNwL3RleHRtb2Rlcy9pc3BlbGwuZWwgKGlzcGVsbC1zZXQtc3BlbGxjaGVj a2VyLXBhcmFtcyk6IERvIG5vdApvdmVycmlkZSBDQVNFQ0hBUlMgYW5kIE5PVC1DQVNFQ0hBUlMu ICBUaGUgaXNwZWxsIGRpY3Rpb25hcmllcwpyZXRhaW4gdGhlaXIgaGFyZHdpcmVkIHZhbHVlcywg YW5kIGFsbCBvdGhlciBkaWN0aW9uYXJpZXMgYXJlIGdpdmVuCnNlbnNpYmxlIGRlZmF1bHRzLgot LS0KIGxpc3AvdGV4dG1vZGVzL2lzcGVsbC5lbCB8IDQgKystLQogMSBmaWxlIGNoYW5nZWQsIDIg aW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3RleHRtb2Rl cy9pc3BlbGwuZWwgYi9saXNwL3RleHRtb2Rlcy9pc3BlbGwuZWwKaW5kZXggMjNlZTQxMi4uNzU1 MWQyZiAxMDA2NDQKLS0tIGEvbGlzcC90ZXh0bW9kZXMvaXNwZWxsLmVsCisrKyBiL2xpc3AvdGV4 dG1vZGVzL2lzcGVsbC5lbApAQCAtMTI5MCw4ICsxMjkwLDggQEAgaXNwZWxsLXNldC1zcGVsbGNo ZWNrZXItcGFyYW1zCiAgICAgICAgIChjbC1wdXNobmV3IChpZiAoY2FkciBhZGljdCkgOzsgRG8g bm90IHRvdWNoIGh1bnNwZWxsIHVuaW5pdGlhbGl6ZWQgZW50cmllcwogICAgICAgICAgICAgICAg ICAgICAgICAgKGxpc3QKICAgICAgICAgICAgICAgICAgICAgICAgICAobnRoIDAgYWRpY3QpICAg OyBkaWN0IG5hbWUKLSAgICAgICAgICAgICAgICAgICAgICAgICAiW1s6YWxwaGE6XV0iICAgOyBj YXNlY2hhcnMKLSAgICAgICAgICAgICAgICAgICAgICAgICAiW15bOmFscGhhOl1dIiAgOyBub3Qt Y2FzZWNoYXJzCisgICAgICAgICAgICAgICAgICAgICAgICAgKG50aCAxIGFkaWN0KSAgIDsgY2Fz ZWNoYXJzCisgICAgICAgICAgICAgICAgICAgICAgICAgKG50aCAyIGFkaWN0KSAgIDsgbm90LWNh c2VjaGFycwogICAgICAgICAgICAgICAgICAgICAgICAgIChudGggMyBhZGljdCkgICA7IG90aGVy Y2hhcnMKICAgICAgICAgICAgICAgICAgICAgICAgICAobnRoIDQgYWRpY3QpICAgOyBtYW55LW90 aGVyY2hhcnMtcAogICAgICAgICAgICAgICAgICAgICAgICAgIChudGggNSBhZGljdCkgICA7IGlz cGVsbC1hcmdzCi0tIAoyLjcuNAoK --001a114f5c2efdce1f05442e86ed--