From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
Received: from mp12.migadu.com ([2001:41d0:8:6d80::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms5.migadu.com with LMTPS
	id 2FofIUKV2WJvgQAAbAwnHQ
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Thu, 21 Jul 2022 20:04:50 +0200
Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp12.migadu.com with LMTPS
	id iLYEIUKV2WL1QQAAauVa8A
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Thu, 21 Jul 2022 20:04:50 +0200
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 3BC3F1886A
	for <larch@yhetil.org>; Thu, 21 Jul 2022 20:04:50 +0200 (CEST)
Received: from localhost ([::1]:33452 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	id 1oEaXZ-0006Of-1P
	for larch@yhetil.org; Thu, 21 Jul 2022 14:04:49 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:41034)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <bhavin7392@gmail.com>)
 id 1oEaX0-0006ON-Tx
 for emacs-orgmode@gnu.org; Thu, 21 Jul 2022 14:04:15 -0400
Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:40646)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <bhavin7392@gmail.com>)
 id 1oEaWz-0005Wp-7Y
 for emacs-orgmode@gnu.org; Thu, 21 Jul 2022 14:04:14 -0400
Received: by mail-ed1-x535.google.com with SMTP id r6so3121136edd.7
 for <emacs-orgmode@gnu.org>; Thu, 21 Jul 2022 11:04:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=H9EPiOWoricnZeNhaHz12U5QFRSWs4vyQ3TkxZqUaoM=;
 b=Wrj6mlQfMaSGmXh7+IMkwo16j8rhDGm7azXA4SLLQJ/kWHePMCR10QxCrhbrDlBFN0
 d+01UnP3dz3K7UMBSpKs9BaTXYjCfSah4YXVGgnBcHVtkxdpwFTzyj6TSXsjatkVQyX4
 KHLHdOu/9LmYVWx6A2qgg4LaOu2kTzAzMwnzCNGIHM+NaYvsSU3Lm3+PJDbv8i0GSASx
 SiOLZ3d95UrJq1JcUE0tY+MEuXkRznwRvW3h8Qi1NFxedxOaXr9Urk3nNFnVFKYaK4Xw
 js5UTMI86nxC3iwsbgmRUD3IpoIivxBOgadnT7M3oi6s22LHhR43HOnl6IHShWMOTw3o
 7kgQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=H9EPiOWoricnZeNhaHz12U5QFRSWs4vyQ3TkxZqUaoM=;
 b=RLo8H/35Dq4hZk46IwBNHyjqEgHLDAjQBQDiDKQnvDddfvRNovG8HMGJLbgfdNQ1ls
 KuMEHHKwGq6IcyOBgRZOuvrgHGRBMqU9BOL348BIdqJZ5lp+p2IxedrqUC+htPaw2zDI
 jF9GflBY3b4nYPlRQdKWFT91WourqbYfLyCDxJx9y96cVa15yDnt5+a5ndsD02MJELIz
 bOKxl71jQp8dor442bZo3tsUmmdLWu296caV6pVk/MiQaOE5FebknNmfQPDAA+W7FR7x
 w7l9HOVsP4K1OnicjaPjg9pXd4qRCQI48QGWWQprGfXOyUxxN2q3Kk+PQ8/yB2ZAEYeM
 5PiA==
X-Gm-Message-State: AJIora8x8K956txLfNXPYwggwItsGDYKtLaNF6QfWwqfofFJcKfuqjq7
 HK5iPdz6W2+O/QxrtmSi/nNXHMPMIXNVH0LSocU=
X-Google-Smtp-Source: AGRyM1sd6jiqpNswDgSv02+qB4HN3b2Jb7pmSAEVJKSUb1g8NBk+Zch39ddAWyEzIMqv9sh8z6AxmiAJr4FgcygmTz0=
X-Received: by 2002:a05:6402:2497:b0:437:a341:9286 with SMTP id
 q23-20020a056402249700b00437a3419286mr58590937eda.156.1658426650010; Thu, 21
 Jul 2022 11:04:10 -0700 (PDT)
MIME-Version: 1.0
References: <413e82eb-db3b-8fac-7edb-35aded973dfd@ctpowe.net>
 <CAOn=hbfOhhCtxiDdc_3gJD=paKqpVdP=3ZkWP45g0viVB=br3g@mail.gmail.com>
 <CAOn=hbcRa4qrYK85p+g1BHv4B=QnvAZs-RJ0mdLn7PMjADfDbg@mail.gmail.com>
 <CAOn=hbcsOCO++We0XgRHFoxxCEXROCpyGd1nCjzKYy-9LckQZg@mail.gmail.com>
 <87y1xdk2a7.fsf@localhost>
 <CAOn=hbdvjjJP04Tv2MtdjtEMhHCZmfXJ+ACGKrZWk=KaNoCC8A@mail.gmail.com>
 <87bku5nkz2.fsf@localhost>
 <CAOn=hbeDKkvpjkkqk2uw-1dm_5+YgY+sdc9=uZnBfxjA0FhW3g@mail.gmail.com>
 <8735f8s96b.fsf@localhost>
 <CAOn=hbd5vxgOojTnLxZ76v0ZR=WxapT+1jaKYVg77_EDJtYhtQ@mail.gmail.com>
 <87zgh9ct01.fsf@localhost>
In-Reply-To: <87zgh9ct01.fsf@localhost>
From: Bhavin Gandhi <bhavin7392@gmail.com>
Date: Thu, 21 Jul 2022 23:33:31 +0530
Message-ID: <CAOn=hbeXHJodZewn+DtDA6-jB30s8az0NXGM+FuX+EV5F2qiFg@mail.gmail.com>
Subject: =?UTF-8?Q?Re=3A_=5BBUG=5D_org=2Dauto=2Drepeat=2Dmaybe=3A_error_=22Can=E2=80=99t_expa?=
 =?UTF-8?Q?nd_minibuffer_to_full_frame=22_and_missing_log_note?=
To: Ihor Radchenko <yantar92@gmail.com>
Cc: emacs-orgmode@gnu.org
Content-Type: multipart/mixed; boundary="0000000000005cc41505e4548b69"
Received-SPF: pass client-ip=2a00:1450:4864:20::535;
 envelope-from=bhavin7392@gmail.com; helo=mail-ed1-x535.google.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-orgmode@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
Sender: "Emacs-orgmode" <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
X-Migadu-Flow: FLOW_IN
X-Migadu-To: larch@yhetil.org
X-Migadu-Country: US
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1658426690;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=H9EPiOWoricnZeNhaHz12U5QFRSWs4vyQ3TkxZqUaoM=;
	b=kQmVGFlEhzPqBHTXAs3xXoqhi2s+bX1YVEDLhgv6B2nTINADuDNPbxY9NanUfvRQRynXU1
	r8CJpjRbnwCm6yt//RrrC0clGb9T00w0UBtj6oxTwsjUi0S7whIdpN6WdnAkd2tW+cH4yG
	xILXKgk00G8xkiSlM6SU51WC8VGttk3iwvQ2KjPlGsy+7bewwDn3o2Es1Tw5/EWIrhgXzV
	vTo8BGpawVAVDc3eZTMjB+KGqCQVh5yq5LjK6GpGHF+gZGZiVzLvwlktYvqnU20O/MEqpg
	r6R0xnBEZL02IRIOFs5lD7kRhJlpkcoip+aFAZK0R+PqG5FZdMNAELbGcoyF8A==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658426690; a=rsa-sha256; cv=none;
	b=A7AofHaFMrjhZWO9sycmU1zlX+hcfi5mhtWsZcT1HDvttKzBaWsGzXczihIzW9dPQ5hKjg
	ALrTFBpRHvLnlmzVe+LSlF3gAeavpzJpNsJxl4t0WKq8yNYPeqP+WoiYA1ohHiIL5mKPOA
	85s9P6/xUv5vfXk05RFfBvez/kIjqGEzjeAsGZ94RU1JfousJkY3C87I+Sn8U0f0NaRK6U
	zOwS16ZY4jfpmFjOTrHq6fNuVrl2+cID3vDUyrOiAuz50LZ5/cV0fnsCdN9cJRa9dwp9f5
	48vwZ4hlOBgeR7+phKar6YVScgMyXGSB56po0JcZPEcIxuswcCIw/XVmZ5gP2g==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=pass header.d=gmail.com header.s=20210112 header.b=Wrj6mlQf;
	dmarc=pass (policy=none) header.from=gmail.com;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Spam-Score: -4.14
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=gmail.com header.s=20210112 header.b=Wrj6mlQf;
	dmarc=pass (policy=none) header.from=gmail.com;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Queue-Id: 3BC3F1886A
X-Spam-Score: -4.14
X-Migadu-Scanner: scn0.migadu.com
X-TUID: y75wbi4F/0Ut

--0000000000005cc41505e4548b69
Content-Type: text/plain; charset="UTF-8"

On Sat, 16 Jul 2022 at 14:50, Ihor Radchenko <yantar92@gmail.com> wrote:
> > Seems like soon I will cross the TINYCHANGE limit, so I will get the
> > FSF copyright assignment done.
>
> Note that FSF should reply within 5 working days. If not, we can help
> you to push them.

Thanks! I received the PDF to sign the next day after my email, this
will probably take a couple of days more from my side as I'm talking
with my employer.

> Thanks for the idea, I'm exploring (recursion-depth),
> (minibuffer-depth). I will come up with a patch to fix this bug.

So, I saved this-command and (recursion-depth) value, and I'm checking
for it in the org-add-log-note (attaching diff of my changes). But this
doesn't guarantee that we are not in the minibuffer when the
post-command-hook runs.

This is what I did, and it failed after answering the question about 10
repeated intervals:
1. M-: (y-or-n-p "Some question")
2. Now I switched to Org mode buffer.
3. Did C-c C-t on the entry.

When org-log-add-setup runs, (recursion-depth) is 1, and
(minibuffer-depth) is also 1.
Now, the question about 10 repeated intervals is asked, once I answer
it, post-command-hook runs. And it runs while we are in the minibuffer
waiting for 'Some question'.

So, I changed the second condition to (= (minibuffer-depth) 0).
This has a different effect when org-todo finishes the execution and we
are still in minibuffer:
this-command won't be org-todo again unless it is invoked again by the
user. org-add-log-note post-command-hook is never removed, and it keeps
executing as the condition is not fulfilled.

I'm going through the code of org-add-log-note to see if we can avoid
calling (delete-other-windows) in the minibuffer. Or move out of minibuffer
and then proceed.

--0000000000005cc41505e4548b69
Content-Type: text/x-patch; charset="US-ASCII"; name="org-add-log-note-minibuffer.diff"
Content-Disposition: attachment; filename="org-add-log-note-minibuffer.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_l5vcdj080>
X-Attachment-Id: f_l5vcdj080

ZGlmZiAtLWdpdCBhL2xpc3Avb3JnLmVsIGIvbGlzcC9vcmcuZWwKaW5kZXggM2Q0ZGU1YjRmLi45
Nzg4NTAxOTkgMTAwNjQ0Ci0tLSBhL2xpc3Avb3JnLmVsCisrKyBiL2xpc3Avb3JnLmVsCkBAIC0x
MDE0Niw2ICsxMDE0Niw4IEBAIEVYVFJBIGlzIGFkZGl0aW9uYWwgdGV4dCB0aGF0IHdpbGwgYmUg
aW5zZXJ0ZWQgaW50byB0aGUgbm90ZXMgYnVmZmVyLiIKIAlvcmctbG9nLW5vdGUtaG93IGhvdwog
CW9yZy1sb2ctbm90ZS1leHRyYSBleHRyYQogCW9yZy1sb2ctbm90ZS1lZmZlY3RpdmUtdGltZSAo
b3JnLWN1cnJlbnQtZWZmZWN0aXZlLXRpbWUpCisgICAgICAgIG9yZy1sb2ctbm90ZS10aGlzLWNv
bW1hbmQgdGhpcy1jb21tYW5kCisgICAgICAgIG9yZy1sb2ctbm90ZS1yZWN1cnNpb24tZGVwdGgg
KHJlY3Vyc2lvbi1kZXB0aCkKICAgICAgICAgb3JnLWxvZy1zZXR1cCB0KQogICAoYWRkLWhvb2sg
J3Bvc3QtY29tbWFuZC1ob29rICdvcmctYWRkLWxvZy1ub3RlICdhcHBlbmQpKQogCkBAIC0xMDE3
NCw2ICsxMDE3Niw4IEBAIEVYVFJBIGlzIGFkZGl0aW9uYWwgdGV4dCB0aGF0IHdpbGwgYmUgaW5z
ZXJ0ZWQgaW50byB0aGUgbm90ZXMgYnVmZmVyLiIKIAogKGRlZnVuIG9yZy1hZGQtbG9nLW5vdGUg
KCZvcHRpb25hbCBfcHVycG9zZSkKICAgIlBvcCB1cCBhIHdpbmRvdyBmb3IgdGFraW5nIGEgbm90
ZSwgYW5kIGFkZCB0aGlzIG5vdGUgbGF0ZXIuIgorICAod2hlbiAoYW5kIChlcXVhbCBvcmctbG9n
LW5vdGUtdGhpcy1jb21tYW5kIHRoaXMtY29tbWFuZCkKKyAgICAgICAgICAgICAoPSBvcmctbG9n
LW5vdGUtcmVjdXJzaW9uLWRlcHRoIChyZWN1cnNpb24tZGVwdGgpKSkKICAgKHJlbW92ZS1ob29r
ICdwb3N0LWNvbW1hbmQtaG9vayAnb3JnLWFkZC1sb2ctbm90ZSkKICAgKHNldHEgb3JnLWxvZy1z
ZXR1cCBuaWwpCiAgIChzZXRxIG9yZy1sb2ctbm90ZS13aW5kb3ctY29uZmlndXJhdGlvbiAoY3Vy
cmVudC13aW5kb3ctY29uZmlndXJhdGlvbikpCkBAIC0xMDIwNCw3ICsxMDIwOCw3IEBAIEVYVFJB
IGlzIGFkZGl0aW9uYWwgdGV4dCB0aGF0IHdpbGwgYmUgaW5zZXJ0ZWQgaW50byB0aGUgbm90ZXMg
YnVmZmVyLiIKIAkJICAgICAgKHQgKGVycm9yICJUaGlzIHNob3VsZCBub3QgaGFwcGVuIikpKSkp
CiAgICAgKHdoZW4gb3JnLWxvZy1ub3RlLWV4dHJhIChpbnNlcnQgb3JnLWxvZy1ub3RlLWV4dHJh
KSkKICAgICAoc2V0cS1sb2NhbCBvcmctZmluaXNoLWZ1bmN0aW9uICdvcmctc3RvcmUtbG9nLW5v
dGUpCi0gICAgKHJ1bi1ob29rcyAnb3JnLWxvZy1idWZmZXItc2V0dXAtaG9vaykpKQorICAgIChy
dW4taG9va3MgJ29yZy1sb2ctYnVmZmVyLXNldHVwLWhvb2spKSkpCiAKIChkZWZ2YXIgb3JnLW5v
dGUtYWJvcnQgbmlsKSA7IGR5bmFtaWNhbGx5IHNjb3BlZAogKGRlZnVuIG9yZy1zdG9yZS1sb2ct
bm90ZSAoKQo=
--0000000000005cc41505e4548b69--