From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Matthew Fidler Newsgroups: gmane.emacs.bugs Subject: bug#17952: Compatability for eieio between 24.4 and 24.3 Date: Sun, 6 Jul 2014 07:24:43 -0500 Message-ID: References: <874myuj2ic.fsf@engster.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=90e6ba61360680255e04fd857102 X-Trace: ger.gmane.org 1404649526 3773 80.91.229.3 (6 Jul 2014 12:25:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 6 Jul 2014 12:25:26 +0000 (UTC) Cc: 17952@debbugs.gnu.org To: David Engster Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 06 14:25:18 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X3lVL-0006YG-RS for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Jul 2014 14:25:16 +0200 Original-Received: from localhost ([::1]:45843 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3lVL-0004yY-53 for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Jul 2014 08:25:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3lVE-0004uo-2m for bug-gnu-emacs@gnu.org; Sun, 06 Jul 2014 08:25:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3lV9-00058j-4m for bug-gnu-emacs@gnu.org; Sun, 06 Jul 2014 08:25:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3lV9-000581-0e for bug-gnu-emacs@gnu.org; Sun, 06 Jul 2014 08:25:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X3lV8-0002Qa-3f for bug-gnu-emacs@gnu.org; Sun, 06 Jul 2014 08:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Matthew Fidler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Jul 2014 12:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17952 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17952-submit@debbugs.gnu.org id=B17952.14046494939305 (code B ref 17952); Sun, 06 Jul 2014 12:25:01 +0000 Original-Received: (at 17952) by debbugs.gnu.org; 6 Jul 2014 12:24:53 +0000 Original-Received: from localhost ([127.0.0.1]:44558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3lUy-0002Q1-CT for submit@debbugs.gnu.org; Sun, 06 Jul 2014 08:24:52 -0400 Original-Received: from mail-ie0-f174.google.com ([209.85.223.174]:49764) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3lUv-0002Pi-9v for 17952@debbugs.gnu.org; Sun, 06 Jul 2014 08:24:50 -0400 Original-Received: by mail-ie0-f174.google.com with SMTP id rd18so2677518iec.5 for <17952@debbugs.gnu.org>; Sun, 06 Jul 2014 05:24:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=m+cIXG9HCKRkTT1Noeig07VkkDHOBkq0HuG0JQ8KXeg=; b=OqJmh2ynxW6Cb/uqIDkzRM/sdkCF3Rg++R8tmMfY1QXt8MDlpn5xvbWl63Xt/3HaPN nCGw9ETuLLOS0pF++Y8caEjcMkUMaZotM4zCzOdsXX7fJWKQfZXsCFeZvTEuoHzKVfEj K3UI7Pz2/8MS/CHa1KK8Zyxq5g7LDAPXNsKI1pczF+AfIVdi86GfxkznyJQq+0p2ZzTK m+cpBd6pvQDQ6/4HAezIKMPw8nTS/DihialO39IYsrZrQHWNQ4s5Ral6EW3Dv5Po9vBG pCQIXVnY1cQqL4T8b7I1OWZdoEM89A0XYcdR1I5xRxpSBhkqjdU6rtmaviB296rJDLo3 xTbQ== X-Received: by 10.42.147.201 with SMTP id o9mr372183icv.89.1404649483541; Sun, 06 Jul 2014 05:24:43 -0700 (PDT) Original-Received: by 10.64.126.2 with HTTP; Sun, 6 Jul 2014 05:24:43 -0700 (PDT) Original-Received: by 10.64.126.2 with HTTP; Sun, 6 Jul 2014 05:24:43 -0700 (PDT) In-Reply-To: <874myuj2ic.fsf@engster.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91237 Archived-At: --90e6ba61360680255e04fd857102 Content-Type: text/plain; charset=UTF-8 Thanks David I don't believe object-set-name-string was marked as a depreciated function. I may have not been running against the trunk, but I believe my compile failed instead of issued a warning. I think the authors intent is that people access the object name with eieio-named so using this function directly was not supported. I have changed my code to solely use eieio-named, so compile warnings on either 24.3 or 24.4 are not issued. Matt On Jul 6, 2014 3:49 AM, "David Engster" wrote: > Matthew Fidler writes: > > The object-set-name-string function of eieio has changed to > > eieio-object-set-name-string, at one point my > code (ergoemacs-mode) depended on > > that function, so I had to use a macro to pick the right version for > different > > versions of emacs. > > The usual way for renaming a function in Emacs is to mark it as > deprecated and make it an alias for the new name, and after a few more > Emacs releases remove it altogether. So if you want to stay compatible > with older Emacsen, simply continue to use `object-set-name-string' for > the time being. You will get a warning on byte-compilation, but just > ignore it (or turn off the deprecation warning if it bothers you too > much). > > -David > --90e6ba61360680255e04fd857102 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Thanks David

I don't believe object-set-name-string was marked as a d= epreciated function. I may have not been running against the trunk, but I b= elieve my compile failed instead of issued a warning.

I think the authors intent is that people access the object = name with eieio-named so using this function directly was not supported.

I have changed my code to solely use eieio-named, so compile= warnings on either 24.3 or 24.4 are not issued.

Matt

On Jul 6, 2014 3:49 AM, "David Engster"= ; <deng@randomsample.de> = wrote:
Matthew Fidler writes:
> The object-set-name-string function of eieio has changed to
> eieio-object-set-name-string, at one point my code=C2=A0(ergoemacs-mod= e)=C2=A0depended on
> that function, so I had to use a macro=C2=A0to pick the right version = for different
> versions of emacs.=C2=A0

The usual way for renaming a function in Emacs is to mark it as
deprecated and make it an alias for the new name, and after a few more
Emacs releases remove it altogether. So if you want to stay compatible
with older Emacsen, simply continue to use `object-set-name-string' for=
the time being. You will get a warning on byte-compilation, but just
ignore it (or turn off the deprecation warning if it bothers you too
much).

-David
--90e6ba61360680255e04fd857102--