bug#17952: Compatability for eieio between 24.4 and 24.3

bug#17952: Compatability for eieio between 24.4 and 24.3

[Matthew Fidler]

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

The object-set-name-string function of eieio has changed to
eieio-object-set-name-string, at one point my
code (ergoemacs-mode) depended on that function, so I had to use a macro to
pick the right version for different versions of emacs.

You may keep it or change it as you wish.  Today ergoemacs-mode no longer
uses this function.

Just an FYI, prompted by Stefan.

Matt

[-- Attachment #2: Type: text/html, Size: 480 bytes --]

bug#17952: Compatability for eieio between 24.4 and 24.3

[David Engster]

Matthew Fidler writes:
> The object-set-name-string function of eieio has changed to
> eieio-object-set-name-string, at one point my code (ergoemacs-mode) depended on
> that function, so I had to use a macro to pick the right version for different
> versions of emacs. 

The usual way for renaming a function in Emacs is to mark it as
deprecated and make it an alias for the new name, and after a few more
Emacs releases remove it altogether. So if you want to stay compatible
with older Emacsen, simply continue to use `object-set-name-string' for
the time being. You will get a warning on byte-compilation, but just
ignore it (or turn off the deprecation warning if it bothers you too
much).

-David

bug#17952: Compatability for eieio between 24.4 and 24.3

[Matthew Fidler]

[-- Attachment #1: Type: text/plain, Size: 1255 bytes --]

Thanks David

I don't believe object-set-name-string was marked as a depreciated
function. I may have not been running against the trunk, but I believe my
compile failed instead of issued a warning.

I think the authors intent is that people access the object name with
eieio-named so using this function directly was not supported.

I have changed my code to solely use eieio-named, so compile warnings on
either 24.3 or 24.4 are not issued.

Matt
On Jul 6, 2014 3:49 AM, "David Engster" <deng@randomsample.de> wrote:

> Matthew Fidler writes:
> > The object-set-name-string function of eieio has changed to
> > eieio-object-set-name-string, at one point my
> code (ergoemacs-mode) depended on
> > that function, so I had to use a macro to pick the right version for
> different
> > versions of emacs.
>
> The usual way for renaming a function in Emacs is to mark it as
> deprecated and make it an alias for the new name, and after a few more
> Emacs releases remove it altogether. So if you want to stay compatible
> with older Emacsen, simply continue to use `object-set-name-string' for
> the time being. You will get a warning on byte-compilation, but just
> ignore it (or turn off the deprecation warning if it bothers you too
> much).
>
> -David
>

[-- Attachment #2: Type: text/html, Size: 1639 bytes --]

bug#17952: Compatability for eieio between 24.4 and 24.3

[Glenn Morris]

emacs-24.3.92 -Q -l eieio

C-h f object-set-name-string

    object-set-name-string is an alias for `eieio-object-set-name-string'
    in `eieio.el'.

    (object-set-name-string OBJ NAME)

    This function is obsolete since 24.4;
    use `eieio-object-set-name-string' instead.

bug#17952: Compatability for eieio between 24.4 and 24.3

[Matthew Fidler]

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

My misunderstanding.
On Jul 6, 2014 1:01 PM, "Glenn Morris" <rgm@gnu.org> wrote:

>
> emacs-24.3.92 -Q -l eieio
>
> C-h f object-set-name-string
>
>     object-set-name-string is an alias for `eieio-object-set-name-string'
>     in `eieio.el'.
>
>     (object-set-name-string OBJ NAME)
>
>     This function is obsolete since 24.4;
>     use `eieio-object-set-name-string' instead.
>

[-- Attachment #2: Type: text/html, Size: 684 bytes --]