From: John Mastro <john.b.mastro@gmail.com>
To: "help-gnu-emacs@gnu.org" <help-gnu-emacs@gnu.org>
Subject: Re: never use `eval' (was: Re: How to mapcar or across a list?)
Date: Wed, 15 Jul 2015 16:27:54 -0700 [thread overview]
Message-ID: <CAOj2CQSEn6=TFX2tJmsuinCgefMz5p1wMTr+0XOXxv7a7TzRSw@mail.gmail.com> (raw)
In-Reply-To: <87vbdlt4g3.fsf_-_@nl106-137-147.student.uu.se>
> Tho some of this code I wrote several years ago, I'd
> be happy to correct it. Any hints - general or
> specific - are appreciated.
> (defun set-color-face (name front &optional bold back)
> (eval `(defvar ,(make-symbol name)))
> (eval `(setq ,(intern name)
> `((t (:foreground ,front
> :background ,back
> :bold ,bold) )))))
>
> (defvar cf-black) (set-color-face "cf-black" "black")
> (defvar cf-red) (set-color-face "cf-red" "red")
I would use something like this:
(defmacro define-color-face (name front &optional bold back)
`(defvar ,name
(quote ((t (:foreground ,front
:background ,back
:bold ,bold))))))
(define-color-face cf-black "black")
> (defun book-page-to-bibtex ()
> (interactive)
> (save-excursion
> (goto-char (point-min))
> (let ((title (get-title))
> (data (mapcar 'key-value
> '("authors?" "publisher" "published" "isbn-10")) ))
> (eval `(create-book nil ,title ,@data) )))) ; don't INSERT
For this (and others like it) it looks like you could instead simply
use e.g. (apply #'create-book nil title data)
--
john
next prev parent reply other threads:[~2015-07-15 23:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 20:14 How to mapcar or across a list? Marcin Borkowski
2015-07-15 20:42 ` Rasmus
2015-07-15 20:55 ` Marcin Borkowski
2015-07-15 22:21 ` Emanuel Berg
2015-07-15 22:21 ` John Mastro
[not found] ` <mailman.6977.1436998965.904.help-gnu-emacs@gnu.org>
2015-07-15 22:28 ` Pascal J. Bourguignon
2015-07-15 22:36 ` Emanuel Berg
2015-07-15 22:57 ` never use `eval' (was: Re: How to mapcar or across a list?) Emanuel Berg
2015-07-15 23:27 ` John Mastro [this message]
2015-07-15 23:57 ` Emanuel Berg
2015-07-16 0:18 ` John Mastro
[not found] ` <mailman.6984.1437004760.904.help-gnu-emacs@gnu.org>
2015-07-16 0:04 ` Barry Margolin
[not found] ` <mailman.6982.1437001117.904.help-gnu-emacs@gnu.org>
2015-07-16 0:01 ` Barry Margolin
2015-07-16 1:13 ` Emanuel Berg
2015-07-17 0:55 ` Emanuel Berg
[not found] ` <mailman.7027.1437094623.904.help-gnu-emacs@gnu.org>
2015-07-17 1:39 ` never use `eval' Pascal J. Bourguignon
2015-07-17 2:16 ` Emanuel Berg
2015-07-17 8:36 ` Barry Margolin
2015-07-17 8:55 ` Pascal J. Bourguignon
2015-07-16 0:22 ` Pascal J. Bourguignon
2015-07-16 1:11 ` Emanuel Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOj2CQSEn6=TFX2tJmsuinCgefMz5p1wMTr+0XOXxv7a7TzRSw@mail.gmail.com' \
--to=john.b.mastro@gmail.com \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.