From: John Mastro <john.b.mastro@gmail.com>
To: 26317@debbugs.gnu.org
Subject: bug#26317: 26.0.50; Small incompatibility in ibuffer.el (ibuffer-compile-format)
Date: Thu, 30 Mar 2017 16:07:59 -0700 [thread overview]
Message-ID: <CAOj2CQRNBnpN+=kwca+_uBy6JNmA70Z8nsrtuXDKPwm-YJpLmg@mail.gmail.com> (raw)
In commit 7e2a8b1, ibuffer.el was change to use `string-width' in a couple
places where it previously used `length'. The result is that custom columns
which can return nil, which worked in Emacs 25, will now cause an error.
To reproduce, run `emacs -Q', yank the following into *scratch*, and evaluate
it:
(require 'ibuffer)
(define-ibuffer-column my-column
(:name "X")
(and (equal (buffer-name) "*scratch*") "Y"))
(setq ibuffer-formats '((mark modified read-only
" " (name 18 18 :left :elide)
" " (my-column 5 5 :left)
" " filename-and-process)))
(ibuffer)
It works in Emacs 25, but in Emacs 26 an error is signaled:
Debugger entered--Lisp error: (wrong-type-argument stringp nil)
string-width(nil)
I came across this because I use the `ibuffer-vc' package, which defines a
column (`vc-status') whose implementation returns nil for some buffers (by
default, non-file-visiting buffers and buffers visiting remote files).
I will follow up with a patch in a separate email (so I can include the bug
number in the commit message).
John
next reply other threads:[~2017-03-30 23:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 23:07 John Mastro [this message]
2017-03-30 23:15 ` bug#26317: 26.0.50; Small incompatibility in ibuffer.el (ibuffer-compile-format) John Mastro
2017-03-31 0:25 ` Mark Oteiza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOj2CQRNBnpN+=kwca+_uBy6JNmA70Z8nsrtuXDKPwm-YJpLmg@mail.gmail.com' \
--to=john.b.mastro@gmail.com \
--cc=26317@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.