From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Filippo Argiolas Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] new package: clangd-inactive-regions Date: Sun, 3 Nov 2024 09:08:54 +0100 Message-ID: References: <87plnd2rin.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36647"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Felician Nemeth , emacs-devel@gnu.org, Eli Zaretskii , =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 03 09:10:01 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t7VgO-0009OX-AQ for ged-emacs-devel@m.gmane-mx.org; Sun, 03 Nov 2024 09:10:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t7Vfb-0007Dv-N4; Sun, 03 Nov 2024 03:09:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7VfZ-0007Di-H9 for emacs-devel@gnu.org; Sun, 03 Nov 2024 03:09:09 -0500 Original-Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t7VfX-0001KQ-Vk; Sun, 03 Nov 2024 03:09:09 -0500 Original-Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-20c70abba48so28329555ad.0; Sun, 03 Nov 2024 01:09:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730621346; x=1731226146; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1BU5h0GGEYS/pbtdBhEaeKpTxVw4vrzlY0EkQ3OhnNg=; b=LGpCJUReRk38RzaSf5HXkVBAIUg4CinImJs5RBOdWuA6u31C7M59OYI12VvK1PXlkL MGhEa9ZrdFM+kh1koPMrdq15AyuiKgo5JtYYBsBMFhSUXcPxHBPOHr+CDjXgnjtnxJYa R0PXl4X4pYZQ3LA25kXhR3p6GTLFyRtcY0Pi4SbVbNxZ5c9H/KWNpL3oPz4i3fYtnKdp 7bSxq9xciuOglH7oEfxEDQRleka5umGqS+enxSskiwv/VBWbhR/dNePsJsdAekitm0MN V5qOe6PyjkRJN1y05RuQLQHQi4kLx/Y5GoBSErta/XXWfVqSyQAV7uk39OpCeBXBwc0O Zx0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730621346; x=1731226146; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1BU5h0GGEYS/pbtdBhEaeKpTxVw4vrzlY0EkQ3OhnNg=; b=kFcC59Qj+T74dcYd7Us/4K2d9y1rhWLW4Ngp4K2+tZnhhsyfMlmz2Yf4nz0dTSPgCG yXPVg/6vXQVBcYMgQY0hAvIo3aNJnbPSa/WZuVI/cdfMpv1fB6g3l0v/WGnymn/9WrNC 9wwsP9Rv+TbmPfb9mZkUEWErx79LAp3t83V+eF9W5Xmfzsg5dlHzOxIWf7NlG313In46 478a/lzAnFwxd3pdN8OwnFiJstd3fGaJT9CyEg3sVV0zMaEa2IiN9EE0dBkvlHh55OFv kYQDimhifR3vDg+guOi/PARnQGIwrv+S0Osz2tl9g6RCGJAEh+EpjWhmYlWHvGsU41eB mTYA== X-Forwarded-Encrypted: i=1; AJvYcCVav43UcoAdob8nsYttcAaIZVxLZX/pvg5p/8awjfN+JEY30bWeDe2qvfKmxeIfRhROoMbD@gnu.org, AJvYcCXgWj/Gk2iAevz8EcR9/+trHOlTDzB8CW8RlDRPkZfMXiWspWH0gf7+jcvw04sfCYjsS5ksd55N/UXYUvc=@gnu.org X-Gm-Message-State: AOJu0YypTPZyGBp0w/XWmhw7TLqbxh+WRqXy1yRN/5/McvejdRHFSSm8 +wI4GjrWkhIMohQOKNsQHfpPn5UWr1DJxSl0VXl5bCnBElAYFOHcuBnSXlOzx2lRzoaYqU0Gvci hIi5nvlZ/NzIwTo9E8A9C3mE7osU= X-Google-Smtp-Source: AGHT+IFrujiLdzMQ7E8QYRNOEQm7iT8WdnY8YCrNf160g3bx2cGDbMsSjHpkT/8j5UOJJ4iJE4qEmjr+VT3yMbvjMIc= X-Received: by 2002:a17:903:187:b0:20c:9ed7:673f with SMTP id d9443c01a7336-2111af6bfa8mr111706965ad.32.1730621346092; Sun, 03 Nov 2024 01:09:06 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=filippo.argiolas@gmail.com; helo=mail-pl1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325051 Archived-At: On Sun, Nov 3, 2024 at 2:22=E2=80=AFAM Stefan Kangas wrote: > > Felician Nemeth writes: > > > There is an open pull request by Slava Akhmechet in eglot-x that > > implements a similar feature for clangd and ccls (which uses a differne= t > > LSP extension) [1]. There I wondered its compatibility with the > > built-in hide-ifdef-mode. > > > > Slava originally sent the pull request to the Eglot's repository [2], > > but Jo=C3=A3o said "Eglot is, by design, only for LSP nor for extension= s to > > the protocol." > > I see the logic in Jo=C3=A3o's arguments for wanting to limit eglot.el to= the > LSP standard only. But then the natural question is: where does > functionality covering LSP extensions belong? > > One option is to have separate packages for every LSP extension out > there, or indeed a catch-all like eglot-x.el. Maybe this is okay. > However, does Eglot's design goals really mean that we will _never_ want > these features in Emacs core? I'm not so sure. > > This is why I'm proposing to submit the new clangd-inactive-regions > package to GNU ELPA instead. That way we could more easily integrate > this into Emacs later (i.e. without having to worry about copyright > assignments). We would still need to figure some things out, of course, > such as where this functionality goes: to some new `eglot-extras.el', to > various major modes, or what. > > Regarding eglot-x.el, of which you Felician seems to be the only major > contributor, I would actually say the exact same thing. Why isn't this > package on GNU ELPA? I suggest that you to submit it. :-) > > I'm copying in Jo=C3=A3o, in case he has anything to add here. Thanks everyone for the feedback! Before creating this package I had some discussion about this with Jo=C3=A3o, don't remember if it was in debbugs or here. His stance then too was that this was server specific and did not belong in eglot. The output from that discussion was adding a section into eglot manual[1] that describes how to extend eglot using this very same use case as an example. If one wanted to just use the shadow face the code is all there and it's the same I'm using. Most of the code in my package is for the trick to darken the inactive regions after fontification. But I'd say a proper opacity attribute would be way more suited to emacs core than my ugly hack :-) About GNU ELPA, I can look into it, could you send the paperwork off-list? I'm ok with it as long as I don't need to involve my employer. 1. https://joaotavora.github.io/eglot/#Extending-Eglot-1