From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Filippo Argiolas Newsgroups: gmane.emacs.bugs Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Date: Sat, 2 Sep 2023 10:14:26 +0200 Message-ID: References: <87edjw6wtz.fsf@betli.tmit.bme.hu> <87zg2fnwm0.fsf@gmail.com> <873504d1oe.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9253"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65418@debbugs.gnu.org, Philip Kaludercic , Felician Nemeth To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 02 10:15:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcLmq-0002Ci-Q3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Sep 2023 10:15:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcLmS-0001nr-BM; Sat, 02 Sep 2023 04:14:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcLmQ-0001ck-3H for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 04:14:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcLmP-0006yD-2M for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 04:14:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcLmY-0004qR-Fa for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 04:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Filippo Argiolas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Sep 2023 08:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.169364249718595 (code B ref 65418); Sat, 02 Sep 2023 08:15:02 +0000 Original-Received: (at 65418) by debbugs.gnu.org; 2 Sep 2023 08:14:57 +0000 Original-Received: from localhost ([127.0.0.1]:35084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcLmT-0004pr-2U for submit@debbugs.gnu.org; Sat, 02 Sep 2023 04:14:57 -0400 Original-Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:44178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcLmQ-0004pe-NJ for 65418@debbugs.gnu.org; Sat, 02 Sep 2023 04:14:55 -0400 Original-Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-565e395e7a6so1619187a12.0 for <65418@debbugs.gnu.org>; Sat, 02 Sep 2023 01:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693642479; x=1694247279; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xIKnfDW8H+CXeBvozSyIHdKxY70gf3HxMp12XV7piw8=; b=cPZciI4ojXKOBNETuRtrYvlgVUDGQvj5J887rQXBDY2QmRxde+AwCVNV2wFv7fHj6c 7z1GLvc+WUnB8hsMvpusoy7q1Udr6pIVhVZF8kC1kPfp8nga/FP0No+HbM21hxLj84u1 O7hwn9qRIZyUi1oiEl5W7vYw4zolkKq+5W5EGqipPYhySgW5lHhCmOWp455x211dI3Az 2a/62AHbSup4NskDeTSW/onYfMjoeKEuaS21dJYW/1zXNKPm57RjWb3XVfnCxKEWiH/D yuhQMQ0v82WL9Z8uWDkN5q4wO2dEmZ8vvulwMAa7ghsi1SppBziWHNErpqJcbJDVyI16 kLcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693642479; x=1694247279; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xIKnfDW8H+CXeBvozSyIHdKxY70gf3HxMp12XV7piw8=; b=a8hcgEYY4kc7xZSgopSzBZRXJvdx9vO6cJ+XNrXRKrBNC1asDac4CoZdugFtpvClAe Ho3i6h7OIteIrkHH2BJVlbnyNFSdhC0XRc8YvCVfATcizawE7gdoOC7QLqUDon8qmZa7 EnYtKkcpexqJJWAvqp7CmQfH1RwNfISDhIXrt7fjtDCGi+94TNA5uiBD8Z72vmM7QjtJ 7+mQ9hlhZ//eZkCAKlyy8r9kQ3j/youtHguV4iqpfV378OfW8PUim+YA2so2L4A8H2rm VjNeiZEy2Qmt3WcL2kwiSJalBn1U9GKab+QBtwnZ0RHkxT+wLQWx7MxvfnQEEGeK7FuX cHrA== X-Gm-Message-State: AOJu0YzLm6NiTyuEfarP9sbxJEHHKeItcvvKgUrF4cIod8HsVTSA4Wk3 1LQJWMmg402ILMGhiRplabspsMQINjTl95DtDq8= X-Google-Smtp-Source: AGHT+IEZ1BCi8uQnJXV/tcwP8udbU+aHtnvR+M3sGKfxMnSQd1iGOdKplFFYlvuJO/DIlltV2RSfSDrQLa/XEfeiQ6Y= X-Received: by 2002:a05:6a20:a10c:b0:137:23f1:4281 with SMTP id q12-20020a056a20a10c00b0013723f14281mr4636695pzk.12.1693642478787; Sat, 02 Sep 2023 01:14:38 -0700 (PDT) In-Reply-To: <873504d1oe.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268966 Archived-At: On Sun, Aug 27, 2023 at 3:58=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > One thing about UI, all the themes I tried seem to render shadow as > > grey-ish but it was my impression reading the docs that it would be a > > dim version of the current face, so it would still have syntax > > highlighting. Is it just a theme limitation (probably because shadow > > wasn't used for something like this before) or it's not technically > > possible? > > I'm fairly sure it's technically possible, even if perhaps not easy. > You can investigate or ask this on emacs-devel. Hi again, I ended up investigating this on my own and managed to get something workin= g. https://github.com/fargiolas/eglot-clangd-inactive-regions/blob/master/eglo= t-clangd-inactive-regions.el Still experimenting on it, the idea is to iterate over each inactive region, detect face changes and create an overlay with a darkened version of them, blending foreground and background colors. No idea if that's the best approach but it works so far and I'm loving the result! Comments/criticisms/patches/PRs welcome (maybe outside of this bug report). Despite being an emacs user for maybe 15+ years, that's the first time I ever wrote more than two lines of elisp. Thanks, Filippo