all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Troels Nielsen <bn.troels@gmail.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 12371@debbugs.gnu.org
Subject: bug#12371: macroexp--funcall-if-compiled broke bootstrap for me
Date: Thu, 20 Sep 2012 10:21:00 +0200	[thread overview]
Message-ID: <CAOdE5WSgiNr27WWDdi8bW_xLpOqVbpkPZsBsuap0fvOWJYXxaw@mail.gmail.com> (raw)
In-Reply-To: <505AA58D.9060808@cs.ucla.edu>

I've run into the same problems this morning, and this patch solves
the problems for me:

The first one I think just is a line gone missing. The next chunk
extracts (car form) before it's to late, as form goes about being
changed before the closure is being called.

Kind Regards
Troels Nielsen

=== modified file 'lisp/calc/calc.el'
--- lisp/calc/calc.el	2012-09-20 03:44:57 +0000
+++ lisp/calc/calc.el	2012-09-20 07:50:18 +0000
@@ -914,9 +914,9 @@

 ;; Set up the autoloading linkage.
 (let ((name (and (fboundp 'calc-dispatch)
-                 (autoloadp (symbol-function 'calc-dispatch))))
+                 (autoloadp (symbol-function 'calc-dispatch))
+                 (nth 1 (symbol-function 'calc-dispatch))))
       (p load-path))
   ;; If Calc files exist on the load-path, we're all set.
   (while (and p (not (file-exists-p
                       (expand-file-name "calc-misc.elc" (car p)))))

=== modified file 'lisp/emacs-lisp/macroexp.el'
--- lisp/emacs-lisp/macroexp.el	2012-09-20 03:29:41 +0000
+++ lisp/emacs-lisp/macroexp.el	2012-09-20 07:51:54 +0000
@@ -148,10 +148,11 @@
                      (car-safe form)
                      (symbolp (car form))
                      (get (car form) 'byte-obsolete-info))
-                (macroexp--funcall-and-return
-                 (lambda () (byte-compile-warn-obsolete (car form)))
-                 #'ignore      ;FIXME: We should `message' something.
-                 new-form)
+                (let ((sym (car form)))
+                  (macroexp--funcall-and-return
+                   (lambda () (byte-compile-warn-obsolete sym))
+                   #'ignore      ;FIXME: We should `message' something.
+                   new-form))
               new-form)))
     (pcase form
       (`(cond . ,clauses)





  reply	other threads:[~2012-09-20  8:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-06 13:58 bug#12371: 24.2.50; macroexpand-all reporting warnings to *Compile-Log* Christopher Schmidt
2012-09-06 16:46 ` Christopher Schmidt
2012-09-19 20:01 ` Stefan Monnier
2012-09-20  1:00 ` bug#12371: macroexp--funcall-if-compiled broke bootstrap for me Paul Eggert
2012-09-20  3:30   ` Stefan Monnier
2012-09-20  4:56     ` Paul Eggert
2012-09-20  5:11       ` Paul Eggert
2012-09-20  8:21         ` Troels Nielsen [this message]
2012-09-20 12:43           ` Stefan Monnier
2012-09-20 14:16             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOdE5WSgiNr27WWDdi8bW_xLpOqVbpkPZsBsuap0fvOWJYXxaw@mail.gmail.com \
    --to=bn.troels@gmail.com \
    --cc=12371@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.