From: Troels Nielsen <bn.troels@gmail.com>
To: Tobias Bading <tbading@web.de>
Cc: 11567@debbugs.gnu.org
Subject: bug#11567: 24.0.97; WTF? ROFL! (hilarious bug)
Date: Mon, 28 May 2012 00:33:14 +0200 [thread overview]
Message-ID: <CAOdE5WReMTB56Vx4UM=Nn6LcRa3mdnJ6OxPanHL0--vUkG94TA@mail.gmail.com> (raw)
In-Reply-To: <8CBD82E7-3C0F-4E08-9127-9DAE6A1AFC9D@web.de>
On Sun, May 27, 2012 at 4:59 PM, Tobias Bading <tbading@web.de> wrote:
> Boys & girls, please *do* try this at home! (Or whereever your Emacs is :-). Works with r108017 of the emacs-24 branch on GNU/Linux as well as Mac OS for me.)
>
> emacs -Q:
> C-h v TAB C-x o C-x 0
>
> Your Emacs frame should now contain a single window with a completion list of variables.
> Take your pick: Select any variable either with your mouse, trackpad or keyboard.... Oooops! :-D
Well, it looks as though the *Completions* buffer only wants to be a
little thorough when hiding itself.
I don't really know the origin of the behavior, but I think it's
natural if there had been opened a special frame just for the
*Completions* buffer, so I suppose that's why it has been put there.
I propose the following patch, which does a little more checking if
it's likely that emacs has been opening a special frame for the
*Completions*-buffer. With some effort you could probably still get
emacs to iconify an unexpecting frame, but I don't think many people
would, if not for playing hide and seek that is... ;)
Regards
Troels
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog 2012-05-27 01:06:44 +0000
+++ lisp/ChangeLog 2012-05-27 22:18:53 +0000
@@ -1,3 +1,8 @@
+2012-05-27 Troels Nielsen <bn.troels@gmail.com>
+
+ * simple.el (choose-completion): Be a little more particular
+ before iconifying a frame, when a completion has been chosen.
+
2012-05-27 Eli Zaretskii <eliz@gnu.org>
* mail/sendmail.el (mail-yank-region): Recognize
=== modified file 'lisp/simple.el'
--- lisp/simple.el 2012-05-04 23:16:47 +0000
+++ lisp/simple.el 2012-05-27 22:15:15 +0000
@@ -6214,7 +6215,11 @@
(error "Destination buffer is dead"))
(select-window (posn-window (event-start event)))
(if (and (one-window-p t 'selected-frame)
- (window-dedicated-p (selected-window)))
+ (window-dedicated-p (selected-window))
+ (let ((buffer-name (buffer-name
+ (window-buffer (selected-window)))))
+ (and (not (same-window-p buffer-name))
+ (special-display-p buffer-name))))
;; This is a special buffer's frame
(iconify-frame (selected-frame))
(or (window-dedicated-p (selected-window))
next prev parent reply other threads:[~2012-05-27 22:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-27 14:59 bug#11567: 24.0.97; WTF? ROFL! (hilarious bug) Tobias Bading
2012-05-27 22:33 ` Troels Nielsen [this message]
2012-05-28 10:26 ` martin rudalics
2012-05-28 14:14 ` Stefan Monnier
2012-05-28 18:19 ` martin rudalics
2012-05-28 22:49 ` Troels Nielsen
2012-05-29 9:42 ` martin rudalics
2012-05-29 12:23 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOdE5WReMTB56Vx4UM=Nn6LcRa3mdnJ6OxPanHL0--vUkG94TA@mail.gmail.com' \
--to=bn.troels@gmail.com \
--cc=11567@debbugs.gnu.org \
--cc=tbading@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.