From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: 2a73673 Change how thread-first/thread-last indent the first argument Date: Wed, 6 Oct 2021 06:32:49 -0500 Message-ID: References: <87ee90vtye.fsf@alphapapa.net> <87czoj7wlk.fsf@gnus.org> <875yubx3rj.fsf@alphapapa.net> <87bl42frku.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34717"; mail-complaints-to="usenet@ciao.gmane.io" To: Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 06 13:34:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mY5Bk-0008nh-Qb for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Oct 2021 13:34:20 +0200 Original-Received: from localhost ([::1]:33920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mY5Bj-00043v-5l for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Oct 2021 07:34:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY5AW-0003K2-8M for emacs-devel@gnu.org; Wed, 06 Oct 2021 07:33:04 -0400 Original-Received: from mail-lf1-f43.google.com ([209.85.167.43]:39696) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mY5AU-0006BE-Oj for emacs-devel@gnu.org; Wed, 06 Oct 2021 07:33:03 -0400 Original-Received: by mail-lf1-f43.google.com with SMTP id n8so8978209lfk.6 for ; Wed, 06 Oct 2021 04:33:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=25LWJjFAlyrNtD+L0WAfmCMIw3eVDnn6Yk5y8MT2rB8=; b=VZ7EujTvxIfmK93/iFThs0pbyfuY5kDojyAehDislRv2X31XgNaHdg9B+IqtNWETTz sdfalPtf6Wak/uMtnP6bkjKVmCmFKH4pPyLJghOhiuqseAJ7YQHOASI5Ralvi1tate41 Urxtd5Z4F+c8Mr0wqi9mZMm1eVjE8pLrgh+kyh2cXWkPVqIHXi7wolS5Ciq4zD1l6/4i E8FY+Kix14AtRsvadROj4qbA132eLNNphfMEPqSk9YID+RPOy72Mu1oDrVBBvH/jY61A KByoAfUFqVP05rTug9fcxobReMJPetgKywbJy+lCgSWl2BIKH0N3Vh/6bJgy3sWG47lX ndWA== X-Gm-Message-State: AOAM532wxgYHAGdx5WbV1ZTyVdUzUndiAAVHKZNitr6JLwQ00FkvW3qC 5Nw0kU5Ph7brmV1Le+BgtPEpQNR9IHIzrZRxiQ5TyJTu X-Google-Smtp-Source: ABdhPJwFX30UFxZOJ6hLzqZiLrZjTFRrpFnmy9Y8q7zuDAefInqQizedTMfKYDDKxWCQwEMzwMOs9ZCY8xKl5bfdkwE= X-Received: by 2002:ac2:51cc:: with SMTP id u12mr8839074lfm.522.1633519980333; Wed, 06 Oct 2021 04:33:00 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=209.85.167.43; envelope-from=alphadeltapapa@gmail.com; helo=mail-lf1-f43.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276422 Archived-At: On Wed, Oct 6, 2021 at 5:27 AM Stefan Kangas wrote: > > Lars Ingebrigtsen writes: > > > I don't really have much of an opinion here -- but the old indentation > > looks like a bug to me. If the thread-first/last community disagrees > > with this, I'm open to reverting the patch. Does anybody else have an > > opinion here? > > I don't have a strong opinion, but I'm personally not too concerned > about some churn given that "git blame" has an option to ignore > whitespace changes. (Magit uses that flag by default, and if I'm not > mistaken VC does too.) FWIW, the burden for me comes when I review changes in Magit before committing: even whitespace-change-only hunks have to be examined and discarded. > As for aggressive-indent, it does sound like a somewhat unusual > use-case. I only re-indent code specifically when it makes sense. > When looking over my diff before committing, I usually double-check to > see that I'm not accidentally doing some random re-indenting unless > I'm also changing those lines, or otherwise have some specific reason > to do it (for example, if it substantially improves readability). When editing other projects, I may disable aggressive-indent-mode if it's causing too much churn. Regardless, I review changes in Magit, and if there are indentation fixes to be made, I commit them separately from the changes I'm making (so if the changes need to be reverted later, the whitespace fixes remain). I generally recommend using aggressive-indent-mode for Elisp projects, because IME (limited compared to that of others present here, of course), patches submitted by contributors who don't use it very often have incorrectly indented forms (sometimes subtly so, only off by a character, which can go unnoticed until much later, or which can be obscured depending on whether tabs have snuck in). And when I'm coding, it saves me from having to think about whether code is indented correctly, having to manually reindent forms after minor changes, etc. It just DTRT so the code is always indented correctly, which is a relief.