From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Use vtable for eww-bookmarks Date: Tue, 7 Jan 2025 06:59:58 -0600 Message-ID: References: <87ldx0vufd.fsf@sebasmonia.com> <8fde5a67-f778-f0c8-bcdd-ece08c95d369@gmail.com> <87h67nm4su.fsf@sebasmonia.com> <28ba395f-5c52-1fc8-a99a-9bae461520d8@gmail.com> <36a57a48-76ab-4254-b3bc-af1fff2d9b98@app.fastmail.com> <87ttb9k04u.fsf@sebasmonia.com> <86wmfkt6ei.fsf@gnu.org> <39071ad9-a369-2e2f-aa1c-779f8103b566@gmail.com> <87cyh8z9tg.fsf@sebasmonia.com> <87seq1alkl.fsf@sebasmonia.com> <36ff480e-0155-479d-87fb-9a85232dac47@app.fastmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000028a8bf062b1d53f5" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4368"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jim Porter , Eli Zaretskii , emacs-devel To: =?UTF-8?B?U2ViYXN0acOhbiBNb27DrWE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 07 14:01:01 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tV9Ce-0000sg-Jx for ged-emacs-devel@m.gmane-mx.org; Tue, 07 Jan 2025 14:01:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tV9Bz-0003tE-GW; Tue, 07 Jan 2025 08:00:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tV9Bu-0003p0-2J for emacs-devel@gnu.org; Tue, 07 Jan 2025 08:00:14 -0500 Original-Received: from mail-qk1-f177.google.com ([209.85.222.177]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tV9Br-00067v-W2; Tue, 07 Jan 2025 08:00:13 -0500 Original-Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7b6e9317a2aso1364926285a.0; Tue, 07 Jan 2025 05:00:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736254809; x=1736859609; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Wp4EG5QOTL8yqfj7KzIROTXpiEhI4b8ix64GOi9DVW0=; b=n7rzotyL2QDXqdOVAoLmtV0oAgpZoDJZ0LdeqhGVZEXpEiLDrP2Kt92SzSVAmwJA+c g0p6CPSUHqsrMiUjZ3WoXG/oNq2qTDruDtmYL1nAMd+Gw1ilE3r4vMSaOdK0T06rMdEV aCZFIzLd3LECkoD8NUz/ZuqL1ZTOpoHHSTk7AsCnjqzXAjPS0/PEz+4mfGZkbJhrq0IA 9VLdQ7hs/kCHnM49sYruUVOGJeImggcjncYtsddQ0GIbTtw+/HmN4qJY793X5/3Xqvc4 q8gsCS4xQsF+kmrKhyF3xeJavTwF74n5itXaLg4frb3qdXB00HfKp5NmzJv83CkfDxMY 9Kew== X-Forwarded-Encrypted: i=1; AJvYcCVn00Lls+qQx1sJS1BIBohTC5bzovV3zB+5iEssBEb98vISjIFe2YwsjMV6fuuKMyBxAx6PrzwV+67YKPY=@gnu.org, AJvYcCWtDk+ckXpd+8KLwT/bcg9nQY75WRFd6kfJSBLtLZoFBw2CHuDgxHA1xEtBUyZ7mgIS0F+l@gnu.org X-Gm-Message-State: AOJu0YzkwDAsNotZ9w27GyvxJlFPWr1VXYzFrwVNFGokT13CODpyFpZf 70uV2jArEXLqniRrCPvs4R2LhOCgKvmqVApFM4g25SWY3gvoZL8fLtfb9KDGmI4BH+wGTmn11b6 vDLOEzSe8bqYSKtq59IY+hfbqLds= X-Gm-Gg: ASbGnct85GmBHTssGyjar7xDhpQ5GtSQ6JYJurSVG353uJSm1grr6VyjFdDp/u2wBNG sio+QmMmWvFBWeBXCRk9TYP1EwjDyy9nf3uXfdsCL4pOlznWsufi0fbv1xUoCxHxJsyB4Dkq5 X-Google-Smtp-Source: AGHT+IELy7D8kt1u5+lG+Ag5k///lEPAE1VUm8/kgQsgVtsCaMl+mhYTFDug/pmw5nvM74nO3e/+du5ghwFq+kulGMs= X-Received: by 2002:a05:6214:518b:b0:6d8:f005:b573 with SMTP id 6a1803df08f44-6df8e7c0fabmr41818086d6.1.1736254809481; Tue, 07 Jan 2025 05:00:09 -0800 (PST) In-Reply-To: <36ff480e-0155-479d-87fb-9a85232dac47@app.fastmail.com> X-Gm-Features: AbW1kvYZyOxE7quEM2VvLI9kVS22kEVmyoUUq5GEzXV4O5aAHoyScTIsqwS4i-A Received-SPF: pass client-ip=209.85.222.177; envelope-from=alphadeltapapa@gmail.com; helo=mail-qk1-f177.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.24, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327763 Archived-At: --00000000000028a8bf062b1d53f5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I don't think it's necessary to retire it. Your patch is an improvement, no? If it's a step in the right direction, then why not proceed? Further improvements can be made later. AFAIK we're not talking about grand features that would be a crime to make changes to later. Most development in Emacs doesn't happen with full consensus anyway, right? Usually someone has an itch to scratch, and unless someone really objects or a procedure is seriously violated, it gets scratched. I've made some suggestions, but they're only suggestions; they aren't conditions for merging. Am I missing something here? :) On Tue, Jan 7, 2025, 06:23 Sebasti=C3=A1n Mon=C3=ADa wrote: > Hello everyone! > > I am ok to retire the patch, with no consensus on how to progress. > > Regards, > Seb > > On Wed, Jan 1, 2025, at 11:25 PM, Sebasti=C3=A1n Mon=C3=ADa wrote: > > > > Adam Porter writes: > > > Also FWIW, I think the long-term goal ought to be to replace EWW's > > > bespoke bookmarks with Emacs bookmarks (i.e. any Emacs bookmark to a= n > > > HTTP(S) URL ought to be usable by EWW, and it ought to create such > > > bookmarks; EWW should be just another way of opening them). > > > > You can create Emacs bookmarks or EWW bookmarks. I use one or the other > > for different cases. But that's more a peculiarity of how I work, than > > proof that we need both, being honest. > > > > We could deprecate EWW-only bookmarks, I guess. If we plan to do that, > > merging this patch makes no sense. > > And then also drop the feature to re-arrange bookmarks, or make it work > > in the context of standard bookmarks. Ditto for M-n and M-p to navigate > > next/prev bookmark in EWW. > > > > -- > > Sebasti=C3=A1n Mon=C3=ADa > > https://site.sebasmonia.com/ > > > > > --00000000000028a8bf062b1d53f5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

I don't think it's necessary to re= tire it. Your patch is an improvement, no? If it's a step in the right = direction, then why not proceed? Further improvements can be made later.=C2= =A0 AFAIK we're not talking about grand features that would be a crime = to make changes to later.=C2=A0 Most development in Emacs doesn't happe= n with full consensus anyway, right? Usually someone has an itch to scratch= , and unless someone really objects or a procedure is seriously violated, i= t gets scratched.=C2=A0 I've made some suggestions, but they're onl= y suggestions; they aren't conditions for merging.=C2=A0

Am I missing something here?=C2=A0 :)


On Tue, Jan 7, 2025, 06:23 Seb= asti=C3=A1n Mon=C3=ADa <seba= stian@sebasmonia.com> wrote:
Hello everyone!

I am ok to retire the patch, with no consensus on how to progress.

Regards,
Seb

On Wed, Jan 1, 2025, at 11:25 PM, Sebasti=C3=A1n Mon=C3=ADa wrote:
>
> Adam Porter <adam@alphapapa.net> writes:
> >=C2=A0 Also FWIW, I think the long-term goal ought to be to replac= e EWW's
> >=C2=A0 bespoke bookmarks with Emacs bookmarks (i.e. any Emacs book= mark to an
> >=C2=A0 HTTP(S) URL ought to be usable by EWW, and it ought to crea= te such
> >=C2=A0 bookmarks; EWW should be just another way of opening them).=
>
> You can create Emacs bookmarks or EWW bookmarks. I use one or the othe= r
> for different cases. But that's more a peculiarity of how I work, = than
> proof that we need both, being honest.
>
> We could deprecate EWW-only bookmarks, I guess. If we plan to do that,=
> merging this patch makes no sense.
> And then also drop the feature to re-arrange bookmarks, or make it wor= k
> in the context of standard bookmarks. Ditto for M-n and M-p to navigat= e
> next/prev bookmark in EWW.
>
> --
> Sebasti=C3=A1n Mon=C3=ADa
> https://site.sebasmonia.com/
>
>
--00000000000028a8bf062b1d53f5--