From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] New tab-bar-detach-tab command Date: Wed, 6 Oct 2021 06:23:59 -0500 Message-ID: References: <87h7e4ikkz.fsf@alphapapa.net> <87pmsrrh7y.fsf@mail.linkov.net> <875yujizgi.fsf@alphapapa.net> <87o88bb21y.fsf@mail.linkov.net> <871r57i2cz.fsf@alphapapa.net> <87k0iu6n6x.fsf@mail.linkov.net> <87lf388zo5.fsf@mail.linkov.net> <87r1d0woq1.fsf@alphapapa.net> <878rz8aruo.fsf@mail.linkov.net> <87a6jovt2e.fsf@alphapapa.net> <87ee8z5swg.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7112"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 06 13:28:40 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mY56G-0001da-Nw for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Oct 2021 13:28:40 +0200 Original-Received: from localhost ([::1]:57060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mY56E-0000VR-Me for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Oct 2021 07:28:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY520-000411-Cs for emacs-devel@gnu.org; Wed, 06 Oct 2021 07:24:16 -0400 Original-Received: from mail-lf1-f54.google.com ([209.85.167.54]:37585) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mY51y-0006p9-P5 for emacs-devel@gnu.org; Wed, 06 Oct 2021 07:24:16 -0400 Original-Received: by mail-lf1-f54.google.com with SMTP id z11so846192lfj.4 for ; Wed, 06 Oct 2021 04:24:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kYfowYMBUDXzweQ3luX35DrQRuqBqcw7rJatBZXw1TM=; b=3KaarYYxBgFU3etSvqv+mylaAg+/Q3biu5q1w+A9JNxBNbnEmn5dFfU/J6i3sl+Mu/ f7O3YXLP90fevxPX1a3ToRXZlJchR2kxN/43XbWpUD3EOD+mAQYZSCAITeFqBKvoJI68 7FsLpAtjQFAiplLfL94TUSR+Sfkr4Y0ps9JviSLv3rKQ/d9O8LlqNU+XTChCoiW3olI1 MHrk3KcY63wG2psbnIgXx1iYGLmm/QBqbd3BCEZE/XFxHxMtlD/g7sLv1fofzwMNOk9j C2x0W5GzuQK8jkYv0OfhvRKrc2g0coJ3a8hYu8kvVaU+BzzqDbTnMIjrccjdupZEJlT1 FI3A== X-Gm-Message-State: AOAM5315iWyMTyt3ac+KN2Nj+DUhfxLko/FN4lKGg3gZrM2Ygs1p03yT L5wvlMwhc6EGKwFVEnlKlB12Czwfe6jkhyR1lRc= X-Google-Smtp-Source: ABdhPJxc0Lv3Yva6k9hadFflu9ZKtoUNQzCb8PqS2+1tth6ER65tdHDCQ/6ZxTN7+21FzAfuKrVVCZ8UnvTt/89Jc1I= X-Received: by 2002:a05:651c:1693:: with SMTP id bd19mr22993766ljb.443.1633519451331; Wed, 06 Oct 2021 04:24:11 -0700 (PDT) In-Reply-To: <87ee8z5swg.fsf@mail.linkov.net> Received-SPF: pass client-ip=209.85.167.54; envelope-from=alphadeltapapa@gmail.com; helo=mail-lf1-f54.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276420 Archived-At: On Tue, Oct 5, 2021 at 12:01 PM Juri Linkov wrote: > > >> The command was named "duplicate" because web browsers > >> provide the menu item "Duplicate tab". > > > > Of course, that makes sense. But since "clone" seems to already be a > > term used in Emacs for this sort of thing, maybe we should consider > > using it, instead. > > Maybe there is no problem when the command name will contain the word > "clone", but its menu item will be like in web browsers: > > `(menu-item "Duplicate" (lambda () (interactive) > (tab-bar-clone-tab I'd vote for naming the menu item to match the command, but I don't feel strongly about it. Maybe the menu could be seen as a place to use terms more common in other software, in which case the disparity would make sense. > And wouldn't it be too error-prone when the name 'tab-bar-clone-tab' > will differ only by one letter from another name 'tab-bar-close-tab'? Seems okay to me. It's probably not the only case in which two commands' names differ by a letter. > > For example, `clone-buffer' and `clone-process' both > > "Create a twin copy of...". > > 'tab-duplicate' is bound to 'C-x t n' and not to 'C-x t c' because > 'clone-buffer' is bound to 'C-x x n' and not 'C-x x c'. Hm, "C-x x c" is unbound by default, so I'd vote for moving `clone-buffer' to it. :) But, again, I don't feel strongly about this, as these aren't commands I use often.