all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Adam Porter <adam@alphapapa.net>
To: Philip Kaludercic <philipk@posteo.net>
Cc: "Nicolas P. Rougier \(inria\)" <nicolas.rougier@inria.fr>,
	emacs-devel <emacs-devel@gnu.org>
Subject: Re: ELPA: new package nano-agenda
Date: Mon, 18 Oct 2021 17:50:32 -0500	[thread overview]
Message-ID: <CAO_b3FVWH4DNZB6S1=0iUWf8JnUjb7qNU4gmXNQHF8yZJ-uMRw@mail.gmail.com> (raw)
In-Reply-To: <87pmsaghed.fsf@posteo.net>

Hi Philip, Nicolas, et al,

On Tue, Oct 12, 2021 at 2:41 PM Philip Kaludercic <philipk@posteo.net> wrote:
>
> "Nicolas P. Rougier (inria)" <nicolas.rougier@inria.fr> writes:
>
> > Philip Kaludercic <philipk@posteo.net> writes:
> >
> >> It seems you are using ts.el, which isn't on ELPA, and additionally
> >> depends
> >> on s.el that also (famously) isn't on ELPA.
> >>
> >> That being said, ts seems to only have a weak dependency on s (two
> >> usages of s-join), so maybe ts could be added to ELPA -- in one form
> >> or
> >> another -- as it seems to have a few useful improvements over the
> >> default time and duration functions.
> >
> > Thanks for the review, I didn't pay attention to this point
> > actually. I confirm than ts would be a very nice addition to ELPA
> > since it really simplifies time management for user and comes with a
> > very clean API. I guess only Adam Porter can answer if he want to add
> > it to ELPA or not.
>
> As he is the only major contributor, this might be worth considering.
> I've Cc'ed Adam to see what he thinks.

Yes, I'd be glad to have ts.el in GNU ELPA.

And I'd be glad to remove the dependency on s.el to facilitate that.

The only potential issue that I can see is that it currently emits
extra warnings at load time (or is it compile time?  I forget...) on
Emacs 28 due to more strict checking in the byte compiler.  The
warnings are harmless, and everything works correctly in spite of
them.  The last time I tried to find the cause of them, I wasn't
successful despite some effort.  I don't know if that would or should
keep it out of GNU ELPA; I would guess that it wouldn't, and that the
warnings can always be fixed or worked around later.

> What might be an issue is if the "ts-" namespace is considered to be
> "too valuable", as was the issue with "s-" and "f-". The maintainers
> would have to decide on that, I can only speculate.

I hope that wouldn't be the case.  In fact, I've already "defended"
the "ts-" prefix against other packages.  (That sounds aggressive or
confrontational, which I don't intend, but I'm not sure how else to
put it.  Actually, the maintainer of the elisp-tree-sitter repo,
Tuấn-Anh Nguyễn (@ubolonton), was very kind to rename his package's
prefix to `tsc-` to avoid conflicts when I asked him last year.  See
https://github.com/emacs-tree-sitter/elisp-tree-sitter/issues/35 )
And it's already used as a dependency in several other Elisp packages.

-- 
Thanks,
Adam



  reply	other threads:[~2021-10-18 22:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12 17:01 ELPA: new package nano-agenda Nicolas P. Rougier (inria)
2021-10-12 19:19 ` Philip Kaludercic
2021-10-12 19:29   ` Nicolas P. Rougier (inria)
2021-10-12 19:41     ` Philip Kaludercic
2021-10-18 22:50       ` Adam Porter [this message]
2021-10-18 23:05         ` Stefan Monnier
2021-10-19 11:55           ` Philip Kaludercic
2021-10-19 12:07             ` Stefan Kangas
2021-10-19 12:24               ` Philip Kaludercic
2021-10-21 14:28                 ` Philip Kaludercic
2021-10-19  6:39 ` Joost Kremers
2021-10-19 10:19   ` Nicolas P. Rougier (inria)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAO_b3FVWH4DNZB6S1=0iUWf8JnUjb7qNU4gmXNQHF8yZJ-uMRw@mail.gmail.com' \
    --to=adam@alphapapa.net \
    --cc=emacs-devel@gnu.org \
    --cc=nicolas.rougier@inria.fr \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.