From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Use vtable for eww-bookmarks Date: Wed, 8 Jan 2025 09:52:52 -0600 Message-ID: References: <87ldx0vufd.fsf@sebasmonia.com> <8fde5a67-f778-f0c8-bcdd-ece08c95d369@gmail.com> <87h67nm4su.fsf@sebasmonia.com> <28ba395f-5c52-1fc8-a99a-9bae461520d8@gmail.com> <36a57a48-76ab-4254-b3bc-af1fff2d9b98@app.fastmail.com> <87ttb9k04u.fsf@sebasmonia.com> <86wmfkt6ei.fsf@gnu.org> <39071ad9-a369-2e2f-aa1c-779f8103b566@gmail.com> <87cyh8z9tg.fsf@sebasmonia.com> <87seq1alkl.fsf@sebasmonia.com> <36ff480e-0155-479d-87fb-9a85232dac47@app.fastmail.com> <875xmpzvvr.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005a098f062b33dbdc" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8770"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , =?UTF-8?B?U2ViYXN0acOhbiBNb27DrWE=?= , Jim Porter , Eli Zaretskii , emacs-devel To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 08 16:53:56 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tVYNW-0002A2-TW for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Jan 2025 16:53:54 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVYMo-0000JF-0p; Wed, 08 Jan 2025 10:53:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVYMm-0000In-6b for emacs-devel@gnu.org; Wed, 08 Jan 2025 10:53:08 -0500 Original-Received: from mail-qk1-f175.google.com ([209.85.222.175]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVYMk-0006Vm-5W; Wed, 08 Jan 2025 10:53:07 -0500 Original-Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-7b6f7d7e128so87104685a.1; Wed, 08 Jan 2025 07:53:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736351583; x=1736956383; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pK0T1ueS2wTkyL6/Y4wjYKqS/5uPx/Zf2fKwfy2j8Sc=; b=XpJEDwAHYq1KGLHWaGmGkVUSe1zK3swkcbKYC1SxMKba9m16xmlPCHekG1YxRoCM1O Nm50fph8gBIsNcxs8KDENXUDPc++ePoH7OOOU/ZWOpvtvk+srnSDTSS39vz+8Hg0jh+J HywfEGh1rZ7p7RaG9zIwGXorU7QNgbYu96J6K7UZZDlEB2KOhta2DOSnG+NlD31OLlfV ye+McSjco68nFMm/cl7NIXL8MjJBp125uHBoaCWXv9UaIhY3cOYlgPddKRV27mrQx9hO BL6oAGKLwzOl+bJRKMacG9uqDJWrBhlPSGjra4ZHUG99qpKS+RVFoBfxTfjwo7F9OFsx Lc5g== X-Forwarded-Encrypted: i=1; AJvYcCUYI6OaO5q9FTqOyvEY1NAmjYPcTriANlDu+1WDJhCOyZnLeTi8DAiN4glD80oJjcHgVTqI@gnu.org, AJvYcCW3iaSyJE8t5cbO8ZEjG3cSfqlPkjq9iIoybXfaR7T28afiap7uS3UoMIB3uwCAaSMRiJzJKPj8+mWyqto=@gnu.org X-Gm-Message-State: AOJu0YwnbC24NX2RWUWhFmWXapxeE4nuJOZYrsQ48BFzip9HhJRDR7fx HGobqZyxIpo3LTFzS59kUnl/Z9twNtz78foctJ85qxywJf8G5bZtI2kdI70OhJZL6krBZev/vtj YKFB6HUKlOZfBV7pDDlBe11yTkuw= X-Gm-Gg: ASbGnctr56AtCnXMK1LFWlq0vtOwR1A4pNVC4pp50AycCIkly5PzjrpLjwhuqKfoEMZ 8KP5NBhQ75KXVgYuDxieowcpcOzbbfKXxEOL73bHZo7xgNI9WR5uJ1MRt15H+29KbMwgsmxJx X-Google-Smtp-Source: AGHT+IGSaSnJPLSFkxFgnBiAyUsyERyXjdiy6+mSjwAXBxacLziJ3sJ4pbWE0g6PTUpW53AETq5BEyceZAr3TcwFAWo= X-Received: by 2002:a05:6214:5783:b0:6d8:a9a6:83ef with SMTP id 6a1803df08f44-6df9ae4fe7amr64347306d6.20.1736351583700; Wed, 08 Jan 2025 07:53:03 -0800 (PST) In-Reply-To: <875xmpzvvr.fsf@posteo.net> X-Gm-Features: AbW1kvYUEqz4G3oM4hWszDrCgMNaJl-Cq1WOd9t2wSvkS4D5bwNu0mRS9JTKICo Received-SPF: pass client-ip=209.85.222.175; envelope-from=alphadeltapapa@gmail.com; helo=mail-qk1-f175.google.com X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327796 Archived-At: --0000000000005a098f062b33dbdc Content-Type: text/plain; charset="UTF-8" > > If you plan to move to emacs bookmarks, I see no reasons to use vtable, > it will complicate conversion of eww bookmarks to bookmarks which is > actually trivial. > I'm not sure what you mean. Vtable should keep the presentation separate from the underlying object type, so changing that later shouldn't be much trouble. ISTM that switching EWW bookmarks into Emacs bookmarks would be a bigger project, because it requires conversion at runtime, likely some UI, documentation, and testing. That's why I suggest not letting that idea stall this patch, because it may or may not even happen, depending on whether anyone feels like doing it anytime soon. > --0000000000005a098f062b33dbdc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
If you plan to move to emacs bookmarks, I see no r= easons to use vtable,
it will complicate conversion of eww bookmarks to bookmarks which is
actually trivial.

<= div dir=3D"auto">I'm not sure what you mean. Vtable should keep the pre= sentation separate from the underlying object type, so changing that later = shouldn't be much trouble.

ISTM that switching EWW bookmarks into Emacs bookmarks would be a bi= gger project, because it requires conversion at runtime, likely some UI, do= cumentation, and testing.=C2=A0 That's why I suggest not letting that i= dea stall this patch, because it may or may not even happen, depending on w= hether anyone feels like doing it anytime soon.=C2=A0
--0000000000005a098f062b33dbdc--