From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Wilhelm Kirschbaum Newsgroups: gmane.emacs.bugs Subject: bug#75192: [PATCH] Update fontification for attribute values in heex-ts-mode Date: Thu, 2 Jan 2025 12:13:27 +0200 Message-ID: References: <86zfk9k3xr.fsf@gnu.org> <86ttahk2j2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000074fde8062ab66a99" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12891"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 75192@debbugs.gnu.org, Stefan Kangas To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 02 11:14:21 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTIDd-00039k-7U for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Jan 2025 11:14:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTIDL-00088y-VV; Thu, 02 Jan 2025 05:14:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTIDK-00088k-TG for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 05:14:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTIDK-0002Ck-KM for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 05:14:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=srQRJvv8AZihkE4oyxy+02Yu8RuwNqrs0IQQV45Z1Mg=; b=UajIKz3LmGgWuSFyswzU9KNe3xBLg3FMugc13vI9A/xxrC+L/gGlz+iYbybmcA4jHSwHPu6HQqU2oSta6uq0YHbbum1znwxdnfSTEHh5zwyakXIR1+2Mt9SD1HyzhPhaA+fXb70cK37WpruDJafs8kaowFdcrRd3o/otZrsHY8sIzBEejvswUTl3317N/qxeU+w2k4cQU+F3xR9PHCNICorBUkYAiliO+odpe2mMOxVFj1N9Rcnxrzqxgm2Q1xVBjz7RQrHh5CL+NLuK1pU7rN9tuEII3gFGdvuk2Q0oLPZF1hT9PsX/ZzbFj+7+EbGlWbZDYQGbaNbYmzynBXtzbg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tTIDK-0008UY-60 for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 05:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Wilhelm Kirschbaum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Jan 2025 10:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75192 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 75192-submit@debbugs.gnu.org id=B75192.173581282132609 (code B ref 75192); Thu, 02 Jan 2025 10:14:02 +0000 Original-Received: (at 75192) by debbugs.gnu.org; 2 Jan 2025 10:13:41 +0000 Original-Received: from localhost ([127.0.0.1]:42826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTICz-0008Ts-1A for submit@debbugs.gnu.org; Thu, 02 Jan 2025 05:13:41 -0500 Original-Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]:53295) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tTICx-0008Tl-EA for 75192@debbugs.gnu.org; Thu, 02 Jan 2025 05:13:40 -0500 Original-Received: by mail-qt1-x835.google.com with SMTP id d75a77b69052e-467a6781bc8so80659151cf.2 for <75192@debbugs.gnu.org>; Thu, 02 Jan 2025 02:13:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735812818; x=1736417618; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=srQRJvv8AZihkE4oyxy+02Yu8RuwNqrs0IQQV45Z1Mg=; b=ZzryF4rB5tuF+0D8Kr9Nmolba2ZJkU5uEfIZovr11h7b/zHbgefkHzTzI1Kdiv1Oc3 qV8s3D6w3VyDw/Xp+47qC8JtiIzBYk+v8WFx5rKibG4E8mfX5KvOXrNJfn6YfQFXwGZX AeLpN7tlUJld6juWOAiy0VHo/Al8OtryyRdCMbPkxHCnnT8Oopt/BxWZ8euaU0+5HL1k Boh9zUXmjGIitCEfzy0nYDiP7qQ83PYbH99aByFuJANLMor0a8L6Gd5Mev/TkDCBPYO3 wlaoobiZH0mprjUf0p7boXuj0iiZHq4Rg4iU+kQxiVCvP0XHwJJlz1y3vCXu+ksevHsK jPpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735812818; x=1736417618; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=srQRJvv8AZihkE4oyxy+02Yu8RuwNqrs0IQQV45Z1Mg=; b=jJzZKxFWb7jRlwBhL6YhqbUS6wX/ASCC/hYEW853w4uYqa6cusbvNF2IoXCLw2QVCn /12Zbw7sMMVc3dd4jPA1/s99kF5/ryf1ovm7dOqENKSgrN5dIbZ2SSyFmP/qd4Om+Zsb PAL3ZT0OWybrIigC7gLpk1Rs38n8PHCu0vSGz8WEWdHZv0eu3zH4Q1B34HH2qVM6Dn3x LTKEajgbiuIx9YiSsSmgD5t61wo2kiyvzSZRuIfFbwBr9vOCGG2uehLLtolEQ6/u3mNA 63RR14/jGRh9eUQAlolcL8mb4Win7SmIvPJPJNeHHovXNhtiPausYtEm9XqaMCib3+gD 9xnA== X-Forwarded-Encrypted: i=1; AJvYcCXHIcIC4I4xP/3n9egX5GiWlDerG2/trHLzuN+crst7OXEFyDn1nBdxSv/nN+wshJf5uudZsA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzZgm9HxSivVgghGuEHIHIplq3tmbiHbpalvoXujAiZaHwZ0Liz P0XhQQhrEuJyi+fntSyiLgjnXbXN82TE7sYLpzduSHflwjoFckYxl8cFA5SsE/952HI3QePZmRP cQDJ+u+gW7ooMee+4cjliCvBbxAY= X-Gm-Gg: ASbGnctw14sjfuToNGRHXNWx4sOSPPl7PTQMhgovc9m9FzYFkd2C8acVpjhMo80pce3 1n4+9kXWhPoMKkKvd4U2BbYcdzz5mo0uw/n+pItg= X-Google-Smtp-Source: AGHT+IE4k20xM+HRfOAmFVCr7ynpHmdpNFvzgIWZ5K63/yrCf+NPEKFWyvdg/ZnSsOOyH+Kbvr+utShwydcufta4BHY= X-Received: by 2002:ac8:5852:0:b0:467:6c61:b70a with SMTP id d75a77b69052e-46a4a8c9e2bmr780738621cf.17.1735812818729; Thu, 02 Jan 2025 02:13:38 -0800 (PST) In-Reply-To: <86ttahk2j2.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298156 Archived-At: --00000000000074fde8062ab66a99 Content-Type: text/plain; charset="UTF-8" > > > attribute be highlighted as a string? > > > > I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I > > simply noted that the code directly above the change said > > > > :feature 'heex-string > > > > which is why I assumed that using a string face should make sense. > > So we think that the current face is just a typo? > Originally I was not sure what would be more appropriate, but got a comment from a user and saw html-ts-mode uses string so thought it would be good to change before it gets released. --00000000000074fde8062ab66a99 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

> > attribute be highlighted as a string?
>
> I'm not familiar with HEEx and can't share a useful opinion, b= ut FWIW, I
> simply noted that the code directly above the change said
>
>=C2=A0 =C2=A0 =C2=A0:feature 'heex-string
>
> which is why I assumed that using a string face should make sense.

So we think that the current face is just a typo?

=
Originally I was not sure what would be more appropriate, but go= t a comment from a user and saw html-ts-mode uses string so thought it woul= d be good to change before it gets released.
--00000000000074fde8062ab66a99--