From: Wilhelm Kirschbaum <wkirschbaum@gmail.com>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 75192@debbugs.gnu.org, casouri@gmail.com
Subject: bug#75192: [PATCH] Update fontification for attribute values in heex-ts-mode
Date: Thu, 2 Jan 2025 10:56:35 +0200 [thread overview]
Message-ID: <CAOS0-34y-G3nPX8Fa7dQ_WxWsn732rpOd=Zi35Dq_no5Sm5zXw@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmmHCUYa8kypE19Y2biGmdw0UO6GVYYGCdcst8m=nttO1A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 458 bytes --]
>
>
> >> > This updates heex-ts-mode to use font-lock-string-face to be
> consistent
> >> > with html-ts-mode on attribute values.
> >>
> >> Should we install this change on master or emacs-30? Eli, Yuan, WDYT?
> >
> > Are we all in agreement with the change itself? Why should an
> > attribute be highlighted as a string?
>
It's the value of an attribute as in <div attribute="attribute_value">. It
matches html-ts-mode which I believe is more correct.
[-- Attachment #2: Type: text/html, Size: 788 bytes --]
next prev parent reply other threads:[~2025-01-02 8:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-30 10:59 bug#75192: [PATCH] Update fontification for attribute values in heex-ts-mode Wilhelm Kirschbaum
2025-01-02 7:45 ` Stefan Kangas
2025-01-02 8:36 ` Eli Zaretskii
2025-01-02 8:41 ` Stefan Kangas
2025-01-02 8:56 ` Wilhelm Kirschbaum [this message]
2025-01-02 9:06 ` Eli Zaretskii
2025-01-02 10:13 ` Wilhelm Kirschbaum
2025-01-02 15:24 ` Eli Zaretskii
2025-01-03 5:49 ` Yuan Fu
2025-01-03 15:14 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOS0-34y-G3nPX8Fa7dQ_WxWsn732rpOd=Zi35Dq_no5Sm5zXw@mail.gmail.com' \
--to=wkirschbaum@gmail.com \
--cc=75192@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.