From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0_?= =?UTF-8?Q?=E0=A4=B8=E0=A4=BF=E0=A4=82=E0=A4=B9?= Sameer Singh Newsgroups: gmane.emacs.bugs Subject: bug#55970: 29.0.50; Emacs crashes when dragging the scroll bar with "--with-pgtk" and "--without-toolkit-scroll-bars" configure flags Date: Wed, 15 Jun 2022 19:31:02 +0530 Message-ID: References: <83v8t3rvh7.fsf@gnu.org> <83sfo7rtc4.fsf@gnu.org> <83o7yvrshd.fsf@gnu.org> <87h74m91xz.fsf@yahoo.com> <875yl2yr0s.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000045930905e17cf402" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22087"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , 55970@debbugs.gnu.org, Eli Zaretskii To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 15 16:02:28 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1TbI-0005SN-IM for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jun 2022 16:02:28 +0200 Original-Received: from localhost ([::1]:50056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1TbG-0007rf-TO for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jun 2022 10:02:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1Tas-0007qf-Ha for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2022 10:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45449) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o1Tas-0006la-91 for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2022 10:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o1Tas-0006xx-49 for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2022 10:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0_?= =?UTF-8?Q?=E0=A4=B8=E0=A4=BF=E0=A4=82=E0=A4=B9?= Sameer Singh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jun 2022 14:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55970 X-GNU-PR-Package: emacs Original-Received: via spool by 55970-submit@debbugs.gnu.org id=B55970.165530168326725 (code B ref 55970); Wed, 15 Jun 2022 14:02:02 +0000 Original-Received: (at 55970) by debbugs.gnu.org; 15 Jun 2022 14:01:23 +0000 Original-Received: from localhost ([127.0.0.1]:39346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1TaE-0006wy-G1 for submit@debbugs.gnu.org; Wed, 15 Jun 2022 10:01:22 -0400 Original-Received: from mail-qk1-f177.google.com ([209.85.222.177]:36532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1TaB-0006wj-MX for 55970@debbugs.gnu.org; Wed, 15 Jun 2022 10:01:21 -0400 Original-Received: by mail-qk1-f177.google.com with SMTP id c83so8779848qke.3 for <55970@debbugs.gnu.org>; Wed, 15 Jun 2022 07:01:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qCRt+4RPiPSXNxJmcYDWOKkG7PvPNOjGmwQZyCzNmHo=; b=VZi2vaVPlXyqHh8Q+6VHtRm6wIce0cO/k7kniRNO9TB9F9A7Gpr4X/x22fYJ6BnaMg Y6ecF0wBWR+zqcGH3eAz/RiI9Zy/7RPuVQrOHJOpjkrxW7bNfoh7IW/gYt1N18gQQVsX 228td/I3ZbTiOx95gaR+lhA5NjMKSdpIDFqM+DJ/Bj8Co5bVr5AIXnm23xQ1/+TW6EGo SASy4dNM3/CiP2u9+M+ESefzvngMlRJpr9jNOH1ZudzeUvWysPy8eGI5u6D4a88JzOVG 0cfYQ6UCxnfDJuJlXyo0D0r2iMzYcnGjjJLUoco78Su2Bwwg3KGnyBpd5SDWb3xF3/mp 0ejw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qCRt+4RPiPSXNxJmcYDWOKkG7PvPNOjGmwQZyCzNmHo=; b=NWFVMPhGvzPxx9g2qieXsjLUjaIKjai1bzAdY4CT4nxLFPIJmD8Hus+TlZO+5q+1Cg BidtGMHJuPg/IlHDhBcXxfW5lnai1zD8OrN+9/Ucq/MdfdwnwXiExtAYLu8jrTI+Vc6S DGGOZLwZX1WthDsFMJXsibfHUevxkDGBvoUiEftHOcEhxLKwrEwzVuG4B4JCnfEXIsR6 UIi9gM2bBc8nXtmL1R/aldZwhDKq7zDpKk5Q26Ej8RKLvUX2J8/01TpRuFHygzVlhGFE Irm2A7fMGS0tPcd8KYZJgDTWgWK6ODfepzdjP8pD5JS9l+MRo86SU56tGraIW+Y+jg34 Qlvw== X-Gm-Message-State: AOAM532U0/6o9ZQ0lM3bcb/DkALipu1qM9/taZ/WbZt5BK4owPDlMrl0 jyCFZeDGcEWmLVmXlZg7DfSqYC7sAjhN2Vb2Enk= X-Google-Smtp-Source: ABdhPJy7ulgTw3uU5GIsWL3C+UMOSm6SOQzq9VjWfzHXmV3kodxMKCY07oRLDbJnSDxfoPYlshNx4Zuzs0kwXhDHA6k= X-Received: by 2002:a37:e202:0:b0:6a6:ab87:113d with SMTP id g2-20020a37e202000000b006a6ab87113dmr8117568qki.605.1655301673946; Wed, 15 Jun 2022 07:01:13 -0700 (PDT) In-Reply-To: <875yl2yr0s.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234585 Archived-At: --00000000000045930905e17cf402 Content-Type: text/plain; charset="UTF-8" configure is written in sh, not in C, so you need diff --git a/configure.ac b/configure.ac index 5b86e90925..c91b7de322 100644 --- a/configure.ac +++ b/configure.ac @@ -3436,7 +3436,7 @@ AC_DEFUN AC_DEFINE(USE_TOOLKIT_SCROLL_BARS) USE_TOOLKIT_SCROLL_BARS=yes fi -elif test "${window_system}" != "x11" && "${window_system}" != "none"; then +elif test "${window_system}" != "x11" && test "${window_system}" != "none"; then AC_MSG_ERROR(Non-toolkit scroll bars are not implemented for your system) fi yes, adding "test" here, correctly produces an error. On Wed, Jun 15, 2022 at 7:20 PM Robert Pluim wrote: > >>>>> On Wed, 15 Jun 2022 08:59:20 +0800, Po Lu said: > > Po> Eli Zaretskii writes: > >> Thanks for testing, I will let it to Po Lu to decide whether that's > >> the proper fix in this case. > > Po> Non-toolkit scroll bars use different kinds of events compared to > Po> toolkit scroll bars. PGTK only implements the latter kind, so > turning > Po> toolkit scroll bars off should trigger this piece of configure.ac: > > Po> elif test "${window_system}" != "x11" && "${window_system}" != > "none"; then > Po> AC_MSG_ERROR(Non-toolkit scroll bars are not implemented for > your system) > Po> fi > > Po> Perhaps Sameer's configure script is out of date and needs to be > Po> regenerated. > > configure is written in sh, not in C, so you need > > diff --git a/configure.ac b/configure.ac > index 5b86e90925..c91b7de322 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -3436,7 +3436,7 @@ AC_DEFUN > AC_DEFINE(USE_TOOLKIT_SCROLL_BARS) > USE_TOOLKIT_SCROLL_BARS=yes > fi > -elif test "${window_system}" != "x11" && "${window_system}" != "none"; > then > +elif test "${window_system}" != "x11" && test "${window_system}" != > "none"; then > AC_MSG_ERROR(Non-toolkit scroll bars are not implemented for your > system) > fi > > > (or use -a to avoid repeating the 'test') > > Robert > -- > --00000000000045930905e17cf402 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

configure is written in sh, not in C, so you need

diff --git a/configure.ac b/configure.ac
index 5b86e90925..c91b7de322 100644
--- a/= configure.ac
+++ b/= configure.ac
@@ -3436,7 +3436,7 @@ AC_DEFUN
=C2=A0 =C2=A0 =C2=A0AC_DEFINE(USE_TOOLKIT_SCROLL_BARS)
=C2=A0 =C2=A0 =C2=A0USE_TOOLKIT_SCROLL_BARS=3Dyes
=C2=A0 =C2=A0fi
-elif test "${window_system}" !=3D "x11" && &qu= ot;${window_system}" !=3D "none"; then
+elif test "${window_system}" !=3D "x11" && tes= t "${window_system}" !=3D "none"; then
=C2=A0 =C2=A0AC_MSG_ERROR(Non-toolkit scroll bars are not implemented for y= our system)
=C2=A0fi

yes, adding "test" here, correctly prod= uces an error.

On Wed, Jun 15, 2022 at 7:20 PM Robert Pluim <rpluim@gmail.com> wrote:
>>>>> On Wed, = 15 Jun 2022 08:59:20 +0800, Po Lu <luangruo@yahoo.com> said:

=C2=A0 =C2=A0 Po> Eli Zaretskii <eliz@gnu.org> writes:
=C2=A0 =C2=A0 >> Thanks for testing, I will let it to Po Lu to decide= whether that's
=C2=A0 =C2=A0 >> the proper fix in this case.

=C2=A0 =C2=A0 Po> Non-toolkit scroll bars use different kinds of events = compared to
=C2=A0 =C2=A0 Po> toolkit scroll bars.=C2=A0 PGTK only implements the la= tter kind, so turning
=C2=A0 =C2=A0 Po> toolkit scroll bars off should trigger this piece of <= a href=3D"http://configure.ac" rel=3D"noreferrer" target=3D"_blank">configu= re.ac:

=C2=A0 =C2=A0 Po>=C2=A0 =C2=A0elif test "${window_system}" != =3D "x11" && "${window_system}" !=3D "none= "; then
=C2=A0 =C2=A0 Po>=C2=A0 =C2=A0 =C2=A0AC_MSG_ERROR(Non-toolkit scroll bar= s are not implemented for your system)
=C2=A0 =C2=A0 Po>=C2=A0 =C2=A0fi

=C2=A0 =C2=A0 Po> Perhaps Sameer's configure script is out of date a= nd needs to be
=C2=A0 =C2=A0 Po> regenerated.

configure is written in sh, not in C, so you need

diff --git a/configure.ac b/configure.ac
index 5b86e90925..c91b7de322 100644
--- a/= configure.ac
+++ b/= configure.ac
@@ -3436,7 +3436,7 @@ AC_DEFUN
=C2=A0 =C2=A0 =C2=A0AC_DEFINE(USE_TOOLKIT_SCROLL_BARS)
=C2=A0 =C2=A0 =C2=A0USE_TOOLKIT_SCROLL_BARS=3Dyes
=C2=A0 =C2=A0fi
-elif test "${window_system}" !=3D "x11" && &qu= ot;${window_system}" !=3D "none"; then
+elif test "${window_system}" !=3D "x11" && tes= t "${window_system}" !=3D "none"; then
=C2=A0 =C2=A0AC_MSG_ERROR(Non-toolkit scroll bars are not implemented for y= our system)
=C2=A0fi


(or use -a to avoid repeating the 'test')

Robert
--
--00000000000045930905e17cf402--