From: "समीर सिंह Sameer Singh" <lumarzeli30@gmail.com>
To: Robert Pluim <rpluim@gmail.com>
Cc: Po Lu <luangruo@yahoo.com>,
55970@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#55970: 29.0.50; Emacs crashes when dragging the scroll bar with "--with-pgtk" and "--without-toolkit-scroll-bars" configure flags
Date: Wed, 15 Jun 2022 19:31:02 +0530 [thread overview]
Message-ID: <CAOR1sLzbAtgK6RHot3sVQiAfiNJGxE8r50+jXLdivgbPp_buJg@mail.gmail.com> (raw)
In-Reply-To: <875yl2yr0s.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2038 bytes --]
configure is written in sh, not in C, so you need
diff --git a/configure.ac b/configure.ac
index 5b86e90925..c91b7de322 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3436,7 +3436,7 @@ AC_DEFUN
AC_DEFINE(USE_TOOLKIT_SCROLL_BARS)
USE_TOOLKIT_SCROLL_BARS=yes
fi
-elif test "${window_system}" != "x11" && "${window_system}" != "none"; then
+elif test "${window_system}" != "x11" && test "${window_system}" !=
"none"; then
AC_MSG_ERROR(Non-toolkit scroll bars are not implemented for your system)
fi
yes, adding "test" here, correctly produces an error.
On Wed, Jun 15, 2022 at 7:20 PM Robert Pluim <rpluim@gmail.com> wrote:
> >>>>> On Wed, 15 Jun 2022 08:59:20 +0800, Po Lu <luangruo@yahoo.com> said:
>
> Po> Eli Zaretskii <eliz@gnu.org> writes:
> >> Thanks for testing, I will let it to Po Lu to decide whether that's
> >> the proper fix in this case.
>
> Po> Non-toolkit scroll bars use different kinds of events compared to
> Po> toolkit scroll bars. PGTK only implements the latter kind, so
> turning
> Po> toolkit scroll bars off should trigger this piece of configure.ac:
>
> Po> elif test "${window_system}" != "x11" && "${window_system}" !=
> "none"; then
> Po> AC_MSG_ERROR(Non-toolkit scroll bars are not implemented for
> your system)
> Po> fi
>
> Po> Perhaps Sameer's configure script is out of date and needs to be
> Po> regenerated.
>
> configure is written in sh, not in C, so you need
>
> diff --git a/configure.ac b/configure.ac
> index 5b86e90925..c91b7de322 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -3436,7 +3436,7 @@ AC_DEFUN
> AC_DEFINE(USE_TOOLKIT_SCROLL_BARS)
> USE_TOOLKIT_SCROLL_BARS=yes
> fi
> -elif test "${window_system}" != "x11" && "${window_system}" != "none";
> then
> +elif test "${window_system}" != "x11" && test "${window_system}" !=
> "none"; then
> AC_MSG_ERROR(Non-toolkit scroll bars are not implemented for your
> system)
> fi
>
>
> (or use -a to avoid repeating the 'test')
>
> Robert
> --
>
[-- Attachment #2: Type: text/html, Size: 3734 bytes --]
next prev parent reply other threads:[~2022-06-15 14:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 14:08 bug#55970: 29.0.50; Emacs crashes when dragging the scroll bar with "--with-pgtk" and "--without-toolkit-scroll-bars" configure flags समीर सिंह Sameer Singh
2022-06-14 17:44 ` Eli Zaretskii
2022-06-14 17:48 ` समीर सिंह Sameer Singh
2022-06-14 18:30 ` Eli Zaretskii
2022-06-14 18:44 ` समीर सिंह Sameer Singh
2022-06-14 18:48 ` Eli Zaretskii
2022-06-15 0:59 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-15 2:28 ` Eli Zaretskii
2022-06-15 3:29 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-15 8:23 ` समीर सिंह Sameer Singh
2022-06-15 12:25 ` Eli Zaretskii
2022-06-15 13:14 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-15 13:50 ` Robert Pluim
2022-06-15 14:01 ` समीर सिंह Sameer Singh [this message]
2022-06-16 0:53 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-16 7:39 ` Robert Pluim
2022-06-15 0:56 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOR1sLzbAtgK6RHot3sVQiAfiNJGxE8r50+jXLdivgbPp_buJg@mail.gmail.com \
--to=lumarzeli30@gmail.com \
--cc=55970@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=luangruo@yahoo.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.