From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0_?= =?UTF-8?Q?=E0=A4=B8=E0=A4=BF=E0=A4=82=E0=A4=B9?= Sameer Singh Newsgroups: gmane.emacs.bugs Subject: bug#55370: [PATCH] Add support for the Syloti Nagri script Date: Thu, 12 May 2022 22:58:43 +0530 Message-ID: References: <83wnerp6p0.fsf@gnu.org> <83bkw2q28v.fsf@gnu.org> <837d6qpvdo.fsf@gnu.org> <831qwyptr7.fsf@gnu.org> <83sfpeoe81.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000cc03c305ded3e59c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28138"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55370@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 12 20:17:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1npDNU-00077A-An for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 May 2022 20:17:32 +0200 Original-Received: from localhost ([::1]:42522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npDNT-00017J-8i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 May 2022 14:17:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npCdW-0002ZW-SY for bug-gnu-emacs@gnu.org; Thu, 12 May 2022 13:30:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48295) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1npCdW-0005lQ-HU for bug-gnu-emacs@gnu.org; Thu, 12 May 2022 13:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1npCdW-0005e2-Ce for bug-gnu-emacs@gnu.org; Thu, 12 May 2022 13:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0_?= =?UTF-8?Q?=E0=A4=B8=E0=A4=BF=E0=A4=82=E0=A4=B9?= Sameer Singh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 May 2022 17:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55370 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55370-submit@debbugs.gnu.org id=B55370.165237656621617 (code B ref 55370); Thu, 12 May 2022 17:30:02 +0000 Original-Received: (at 55370) by debbugs.gnu.org; 12 May 2022 17:29:26 +0000 Original-Received: from localhost ([127.0.0.1]:42191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npCcv-0005cb-QI for submit@debbugs.gnu.org; Thu, 12 May 2022 13:29:26 -0400 Original-Received: from mail-qv1-f42.google.com ([209.85.219.42]:41724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npCcu-0005cJ-0X for 55370@debbugs.gnu.org; Thu, 12 May 2022 13:29:24 -0400 Original-Received: by mail-qv1-f42.google.com with SMTP id jt15so4881207qvb.8 for <55370@debbugs.gnu.org>; Thu, 12 May 2022 10:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BZwrBrOyKI2AOCMw9xDE3kphkrvyttq72F2x4w85WtM=; b=i7MiRB8uBuuONYc2jTMwjv/fXYLTTds5xDPipKp0eFnajRsu7x5SdgJIyNBN98QpJd WAtgzRbl/j0cBkAYdkz4P265uPln/UJdr27pGJWSwyMLh5xSkl8Q2CsGzcXEeNLaRe1m Gj7DU8qQGumblU6Lz9r2rC/oGNvnKTpDnZR28GCuzYLAcDz56OYoenFZA1rYSn11ZA1G A5Oo/yl4PTsbCA6DeF+4BnRflLHDhohOoH7dZRgZV6f+DryMjwOcblCcELJ7+KL4tMQD OrMjV8o84Iitf+UzxZd3kCZLtwNmwuTZx3l0VLpo3MWS7RRdCrx2PlPvi7RtTcHcID0/ 7HFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BZwrBrOyKI2AOCMw9xDE3kphkrvyttq72F2x4w85WtM=; b=0mSALnlI95iI3OKAcHBtqfORlpKVB94cfD8PJ6/2S1hqwwotTYpF2hzlGRyYoLqEeu Typb0G5lbY/ygNWTVYj3ISvdmr5BsoIU3W74mTFegs0ePQ4DL5IYdxD5J4KKWuzPgqY3 aRBa4mbDy3uVsbUhUmgeyiaFt/gWvEcWG06/FRxaSfDJDg2bPlwzFsU2NgKA0uVla10Y l4WMQLYaNrJwX5fCZMXdzpIH+v8qfztI2qO6PgFgoly/qVpAEb6bL0Ioe7DekuINYrB8 F9zGfKBHOxcVSm8ziasRQ+yFk8qLdUlg14gNvNtX86vsDU3bo1pbb5m/659Nq5xYXFzT x6ZQ== X-Gm-Message-State: AOAM531Dk86i49vUHSLG1nBIwe7erbtgMkeV43Ua4t28SeHevXW6iKNI JfRFjMNmyT+PInaOs5WU5BNpvy9nl6ZK5s2M0hfYX0YEBXQ= X-Google-Smtp-Source: ABdhPJxODtOL/NUcsarpNLdaQoO0gwdl9wIKuZzVTbD0e9FNwaXX7vVzIniQ0TROg21DJArF8oLjgmoc2gmsPTBVWHo= X-Received: by 2002:a05:6214:242b:b0:45e:7063:bac2 with SMTP id gy11-20020a056214242b00b0045e7063bac2mr798639qvb.108.1652376558370; Thu, 12 May 2022 10:29:18 -0700 (PDT) In-Reply-To: <83sfpeoe81.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232084 Archived-At: --000000000000cc03c305ded3e59c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ok I will do that, thanks! On Thu, May 12, 2022 at 10:55 PM Eli Zaretskii wrote: > > From: =E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0 =E0=A4=B8=E0=A4=BF=E0=A4=82= =E0=A4=B9 Sameer Singh > > Date: Thu, 12 May 2022 22:40:02 +0530 > > Cc: 55370@debbugs.gnu.org > > > > Yes it was not correct, this seems more appropriate. > > > > ;; Syloti Nagri composition rules > > (let ((consonant "[\xA807-\xA80A\xA80C-\xA822]") > > (independent-vowel "[\xA800\xA801\xA803-\xA805]") > > (vowel "[\xA802\xA823-\xA827]") > > (nasal "[\xA80B]") > > (virama "[\xA806\xA82C]")) > > (set-char-table-range composition-function-table > > '(#xA802 . #xA82C) > > (list (vector > > ;; Consonant conjunct based syllables > > (concat independent-vowel "?" consonant > "\\(?:" virama consonant "\\)+" > > vowel "?" nasal "?") > > 1 'font-shape-gstring)))) > > > > btw this range does not cause emacs to slow down, right? > > It might, because the range is very large, and so any character in the > range #xA802..#xA82C will cause Emacs to try to match the regexp. > > So if there's a way of having the rules on fewer characters, that > would be better, even if there will be more rules. > > > also should I send separate patches for the syloti nagri, and the fix > for previous scripts, or combine them into > > one? > > You can combine them into a single patch, just make sure the log > message mentions all the changes. > > Thanks. > --000000000000cc03c305ded3e59c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ok I will do that, thanks!

On Thu, May 12, 2022 at 10:5= 5 PM Eli Zaretskii <eliz@gnu.org>= wrote:
> Fro= m: =E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0 =E0=A4=B8=E0=A4=BF=E0=A4=82=E0=A4= =B9 Sameer Singh <lumarzeli30@gmail.com>
> Date: Thu, 12 May 2022 22:40:02 +0530
> Cc: 55370@d= ebbugs.gnu.org
>
> Yes it was not correct, this seems more appropriate.
>
> ;; Syloti Nagri composition rules
> (let ((consonant=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "[\xA80= 7-\xA80A\xA80C-\xA822]")
>=C2=A0 =C2=A0 =C2=A0 =C2=A0(independent-vowel=C2=A0 =C2=A0 "[\xA80= 0\xA801\xA803-\xA805]")
>=C2=A0 =C2=A0 =C2=A0 =C2=A0(vowel=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 "[\xA802\xA823-\xA827]")
>=C2=A0 =C2=A0 =C2=A0 =C2=A0(nasal=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 "[\xA80B]")
>=C2=A0 =C2=A0 =C2=A0 =C2=A0(virama=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0"[\xA806\xA82C]"))
>=C2=A0 =C2=A0(set-char-table-range composition-function-table
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0'(#xA802 . #xA82C)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0(list (vector
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; Consonant conjunct based sylla= bles
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (concat independent-vowel "?= " consonant "\\(?:" virama consonant "\\)+"
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 vowel= "?" nasal "?")
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1 'font-shape-gstring))))
>
> btw this range does not cause emacs to slow down, right?

It might, because the range is very large, and so any character in the
range #xA802..#xA82C will cause Emacs to try to match the regexp.

So if there's a way of having the rules on fewer characters, that
would be better, even if there will be more rules.

> also should I send separate patches for the syloti nagri, and the fix = for previous scripts, or combine them into
> one?

You can combine them into a single patch, just make sure the log
message mentions all the changes.

Thanks.
--000000000000cc03c305ded3e59c--