bug#58376: [PATCH] Set the PARENTS argument for language environments

bug#58376: [PATCH] Set the PARENTS argument for language environments

[समीर सिंह Sameer Singh]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

I had previously neglected to add the PARENTS argument to
set-language-info-alist due to being ignorant of its function.
This now has been corrected.

Please review the patch.
Thanks.

[-- Attachment #2: Type: text/html, Size: 265 bytes --]

bug#58376: [PATCH] Set the PARENTS argument for language environments

[समीर सिंह Sameer Singh]

[-- Attachment #1.1: Type: text/plain, Size: 309 bytes --]

On Sat, Oct 8, 2022 at 4:42 PM समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
wrote:

> I had previously neglected to add the PARENTS argument to
> set-language-info-alist due to being ignorant of its function.
> This now has been corrected.
>
> Please review the patch.
> Thanks.
>

[-- Attachment #1.2: Type: text/html, Size: 654 bytes --]

[-- Attachment #2: 0001-Set-the-PARENTS-argument-for-language-environments-b.patch --]
[-- Type: text/x-patch, Size: 8225 bytes --]

From 257bdb383f0c936d6dabfd05fd2c974e2bf81f98 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0=20=E0=A4=B8=E0=A4=BF?=
 =?UTF-8?q?=E0=A4=82=E0=A4=B9=20Sameer=20Singh?= <lumarzeli30@gmail.com>
Date: Sat, 8 Oct 2022 15:37:00 +0530
Subject: [PATCH] Set the PARENTS argument for language environments
 (bug#58376)

* lisp/language/indonesian.el
* lisp/language/philippine.el
* lisp/language/misc-lang.el
(set-language-info-alist): Add PARENTS argument.
---
 lisp/language/indonesian.el | 21 ++++++++++++++-------
 lisp/language/misc-lang.el  | 18 ++++++++++++------
 lisp/language/philippine.el | 12 ++++++++----
 3 files changed, 34 insertions(+), 17 deletions(-)

diff --git a/lisp/language/indonesian.el b/lisp/language/indonesian.el
index 699f819254..5afcd27759 100644
--- a/lisp/language/indonesian.el
+++ b/lisp/language/indonesian.el
@@ -34,7 +34,8 @@
               (input-method . "balinese")
               (sample-text . "Balinese (ᬅᬓ᭄ᬱᬭᬩᬮᬶ)	ᬒᬁᬲ᭄ᬯᬲ᭄ᬢ᭄ᬬᬲ᭄ᬢᬸ")
               (documentation . "\
-Balinese language and its script are supported in this language environment.")))
+Balinese language and its script are supported in this language environment."))
+ '("Indonesian"))
 
 (set-language-info-alist
  "Javanese" '((charset unicode)
@@ -43,7 +44,8 @@
               (input-method . "javanese")
               (sample-text . "Javanese (ꦲꦏ꧀ꦱꦫꦗꦮ)	ꦲꦭꦺꦴ")
               (documentation . "\
-Javanese language and its script are supported in this language environment.")))
+Javanese language and its script are supported in this language environment."))
+ '("Indonesian"))
 
 (set-language-info-alist
  "Sundanese" '((charset unicode)
@@ -52,7 +54,8 @@
               (input-method . "sundanese")
               (sample-text . "Sundanese (ᮃᮊ᮪ᮞᮛᮞᮥᮔ᮪ᮓ)    ᮞᮙ᮪ᮕᮥᮛᮞᮥᮔ᮪")
               (documentation . "\
-Sundanese language and its script are supported in this language environment.")))
+Sundanese language and its script are supported in this language environment."))
+ '("Indonesian"))
 
 (set-language-info-alist
  "Batak" '((charset unicode)
@@ -62,7 +65,8 @@
            (sample-text . "Batak (ᯘᯮᯒᯗ᯲ᯅᯗᯂ᯲)    ᯂᯬᯒᯘ᯲ / ᯔᯧᯐᯬᯀᯱᯐᯬᯀᯱ")
            (documentation . "\
 Languages that use the Batak script, such as Karo, Toba, Pakpak, Mandailing
-and Simalungun, are supported in this language environment.")))
+and Simalungun, are supported in this language environment."))
+ '("Indonesian"))
 
 (set-language-info-alist
  "Rejang" '((charset unicode)
@@ -71,7 +75,8 @@
             (input-method . "rejang")
             (sample-text . "Rejang (ꥆꤰ꥓ꤼꤽ ꤽꥍꤺꥏ)    ꤸꥉꥐꤺꥉꥂꥎ")
             (documentation . "\
-Rejang language and its script are supported in this language environment.")))
+Rejang language and its script are supported in this language environment."))
+ '("Indonesian"))
 
 (set-language-info-alist
  "Makasar" '((charset unicode)
@@ -80,7 +85,8 @@
              (input-method . "makasar")
              (sample-text . "Makasar (𑻪𑻢𑻪𑻢)    𑻦𑻤𑻵𑻱")
              (documentation . "\
-Makassarese language and its script Makasar are supported in this language environment.")))
+Makassarese language and its script Makasar are supported in this language environment."))
+ '("Indonesian"))
 
 (set-language-info-alist
  "Buginese" '((charset unicode)
@@ -89,7 +95,8 @@
               (input-method . "lontara")
               (sample-text . "Buginese (ᨒᨚᨈᨑ)    ᨖᨒᨚ")
               (documentation . "\
-Buginese language and its script Lontara are supported in this language environment.")))
+Buginese language and its script Lontara are supported in this language environment."))
+ '("Indonesian"))
 
 ;; Balinese composition rules
 (let ((consonant            "[\x1B13-\x1B33\x1B45-\x1B4B]")
diff --git a/lisp/language/misc-lang.el b/lisp/language/misc-lang.el
index 370be4b4a3..c34017d9b3 100644
--- a/lisp/language/misc-lang.el
+++ b/lisp/language/misc-lang.el
@@ -228,7 +228,8 @@ egyptian-shape-grouping
                      (sample-text . "Hanifi Rohingya (𐴌𐴟𐴇𐴥𐴝𐴚𐴒𐴙𐴝 𐴇𐴝𐴕𐴞𐴉𐴞 𐴓𐴠𐴑𐴤𐴝)	𐴀𐴝𐴏𐴓𐴝𐴀𐴡𐴤𐴛𐴝𐴓𐴝𐴙𐴑𐴟𐴔")
                      (documentation . "\
 Rohingya language and its script Hanifi Rohingya are supported
-in this language environment.")))
+in this language environment."))
+ '("Misc"))
 
 ;; Hanifi Rohingya composition rules
 (set-char-table-range
@@ -251,7 +252,8 @@ egyptian-shape-grouping
                 (sample-text . "Kharoṣṭhī (𐨑𐨪𐨆𐨛𐨁)	𐨣𐨨𐨲𐨪𐨆 𐨐𐨪𐨅𐨨𐨁")
 	        (documentation . "\
 Language environment for Gāndhārī, Sanskrit, and other languages
-using the Kharoṣṭhī script.")))
+using the Kharoṣṭhī script."))
+ '("Misc"))
 
 (let ((consonant     "[\U00010A00\U00010A10-\U00010A35]")
       (vowel         "[\U00010A01-\U00010A06]")
@@ -281,7 +283,8 @@ egyptian-shape-grouping
            (sample-text . "Adlam (𞤀𞤣𞤤𞤢𞤥)	𞤅𞤢𞤤𞤢𞥄𞤥")
            (documentation . "\
 Fulani language and its script Adlam are supported
-in this language environment.")))
+in this language environment."))
+ '("Misc"))
 
 ;; Adlam composition rules
 (set-char-table-range
@@ -303,7 +306,8 @@ egyptian-shape-grouping
                    (sample-text . "Mende Kikakui (𞠀𞠁𞠂)	𞠛𞠉")
                    (documentation . "\
 Mende language and its script Kikakui are supported
-in this language environment.")))
+in this language environment."))
+ '("Misc"))
 
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 ;; Gothic
@@ -317,7 +321,8 @@ egyptian-shape-grouping
             (sample-text . "Gothic (𐌲𐌿𐍄𐌹𐍃𐌺𐌰)	𐌷𐌰𐌹𐌻𐍃 / 𐌷𐌰𐌹𐌻𐌰")
             (documentation . "\
 Ancient Gothic language using the Gothic script is supported in this
-language environment.")))
+language environment."))
+ '("Misc"))
 
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 ;; Coptic
@@ -331,7 +336,8 @@ egyptian-shape-grouping
             (sample-text . "Coptic (ⲘⲉⲧⲢⲉⲙ̀ⲛⲭⲏⲙⲓ)	Ⲛⲟⲩϥⲣⲓ")
             (documentation . "\
 Coptic language using the Coptic script is supported in this
-language environment.")))
+language environment."))
+ '("Misc"))
 
 (provide 'misc-lang)
 
diff --git a/lisp/language/philippine.el b/lisp/language/philippine.el
index e52ad6912c..ce619bdaa1 100644
--- a/lisp/language/philippine.el
+++ b/lisp/language/philippine.el
@@ -35,7 +35,8 @@
              (sample-text . "Tagalog (ᜊᜌ᜔ᜊᜌᜒᜈ᜔)	ᜃᜓᜋᜓᜐ᜔ᜆ")
              (documentation . "\
 Tagalog language using the Baybayin script is supported in
-this language environment.")))
+this language environment."))
+ '("Philippine"))
 
 (set-language-info-alist
  "Hanunoo" '((charset unicode)
@@ -44,7 +45,8 @@
              (input-method . "hanunoo")
              (sample-text . "Hanunoo (ᜱᜨᜳᜨᜳᜢ)	ᜫᜬᜧ᜴ ᜣᜭᜯᜥ᜴ ᜰᜲᜭᜥ᜴")
              (documentation . "\
-Philippine Language Hanunoo is supported in this language environment.")))
+Philippine Language Hanunoo is supported in this language environment."))
+ '("Philippine"))
 
 (set-language-info-alist
  "Buhid" '((charset unicode)
@@ -52,7 +54,8 @@
            (coding-priority utf-8)
            (input-method . "buhid")
            (documentation . "\
-Philippine Language Buhid is supported in this language environment.")))
+Philippine Language Buhid is supported in this language environment."))
+ '("Philippine"))
 
 (set-language-info-alist
  "Tagbanwa" '((charset unicode)
@@ -61,7 +64,8 @@
              (input-method . "tagbanwa")
              (sample-text . "Tagbanwa (ᝦᝪᝯ)	ᝫᝩᝬᝥ ᝣᝮᝧᝯ")
              (documentation . "\
-Philippine Languages Tagbanwa are supported in this language environment.")))
+Philippine Languages Tagbanwa are supported in this language environment."))
+ '("Philippine"))
 
 ;; Tagalog composition rules
 (let ((akshara              "[\x1700-\x1711\x171F]")
-- 
2.37.3

bug#58376: [PATCH] Set the PARENTS argument for language environments

[Eli Zaretskii]

> From: समीर सिंह Sameer Singh
>  <lumarzeli30@gmail.com>
> Date: Sat, 8 Oct 2022 16:45:58 +0530
> 
> On Sat, Oct 8, 2022 at 4:42 PM समीर सिंह Sameer Singh <lumarzeli30@gmail.com> wrote:
> 
>  I had previously neglected to add the PARENTS argument to set-language-info-alist due to being
>  ignorant of its function.
>  This now has been corrected.

Thanks.  However, the PARENTS argument of set-language-info-alist can
be a list.  Did you consider the possibility that we might want some
of these language environments to have more than one parent?  (I don't
myself have an opinion on this, I'm just asking.)

bug#58376: [PATCH] Set the PARENTS argument for language environments

[समीर सिंह Sameer Singh]

[-- Attachment #1: Type: text/plain, Size: 902 bytes --]

Maybe Kharoshthi could also have "Indian" and Gothic could have "European".

Also can we move Cham, Tai Viet and Northern Thai in Misc?

On Sat, Oct 8, 2022 at 8:16 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: समीर सिंह Sameer Singh
> >  <lumarzeli30@gmail.com>
> > Date: Sat, 8 Oct 2022 16:45:58 +0530
> >
> > On Sat, Oct 8, 2022 at 4:42 PM समीर सिंह Sameer Singh <
> lumarzeli30@gmail.com> wrote:
> >
> >  I had previously neglected to add the PARENTS argument to
> set-language-info-alist due to being
> >  ignorant of its function.
> >  This now has been corrected.
>
> Thanks.  However, the PARENTS argument of set-language-info-alist can
> be a list.  Did you consider the possibility that we might want some
> of these language environments to have more than one parent?  (I don't
> myself have an opinion on this, I'm just asking.)
>

[-- Attachment #2: Type: text/html, Size: 1420 bytes --]

bug#58376: [PATCH] Set the PARENTS argument for language environments

[Eli Zaretskii]

> From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> Date: Sat, 8 Oct 2022 21:48:26 +0530
> Cc: 58376@debbugs.gnu.org
> 
> Maybe Kharoshthi could also have "Indian" and Gothic could have "European".

I just asked, I have no opinion on that.

> Also can we move Cham, Tai Viet and Northern Thai in Misc?

Why to Misc?  I could understand moving Cham to Indian and Tai Viet to
Thai.  Misc is not really appropriate for scripts whose similar
scripts are already in some file.

bug#58376: [PATCH] Set the PARENTS argument for language environments

[समीर सिंह Sameer Singh]

[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]

>
> Why to Misc?  I could understand moving Cham to Indian and Tai Viet to
> Thai.  Misc is not really appropriate for scripts whose similar
> scripts are already in some file.


Cham should not be moved to Indian, it inherits its script from India, but
is not an Indian language.
I'll leave them as it is.

For Kharoshthi and Gothic how to define the PARENTS argument so that it
does not overwrite the previous entries in the menu?
I am defining it like this:

(set-language-info-alist
 "Kharoshthi" '((charset unicode)
       (coding-system utf-8)
       (coding-priority utf-8)
       (input-method . "kharoshthi")
                (sample-text . "Kharoṣṭhī (𐨑𐨪𐨆𐨛𐨁) 𐨣𐨨𐨲𐨪𐨆
𐨐𐨪𐨅𐨨𐨁")
       (documentation . "\
Language environment for Gāndhārī, Sanskrit, and other languages
using the Kharoṣṭhī script."))
 '("Misc"
   "Indian"))

On Sat, Oct 8, 2022 at 11:46 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> > Date: Sat, 8 Oct 2022 21:48:26 +0530
> > Cc: 58376@debbugs.gnu.org
> >
> > Maybe Kharoshthi could also have "Indian" and Gothic could have
> "European".
>
> I just asked, I have no opinion on that.
>
> > Also can we move Cham, Tai Viet and Northern Thai in Misc?
>
> Why to Misc?  I could understand moving Cham to Indian and Tai Viet to
> Thai.  Misc is not really appropriate for scripts whose similar
> scripts are already in some file.
>

[-- Attachment #2: Type: text/html, Size: 2323 bytes --]

bug#58376: [PATCH] Set the PARENTS argument for language environments

[Eli Zaretskii]

> From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> Date: Sun, 9 Oct 2022 00:46:10 +0530
> Cc: 58376@debbugs.gnu.org
> 
> For Kharoshthi and Gothic how to define the PARENTS argument so that it does not overwrite the previous
> entries in the menu?

What do you mean by "overwrite"?  What happens if you use a list of
more than one PARENTS?

bug#58376: [PATCH] Set the PARENTS argument for language environments

[समीर सिंह Sameer Singh]

[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]

On Sun, Oct 9, 2022 at 1:59 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> > Date: Sun, 9 Oct 2022 00:46:10 +0530
> > Cc: 58376@debbugs.gnu.org
> >
> > For Kharoshthi and Gothic how to define the PARENTS argument so that it
> does not overwrite the previous
> > entries in the menu?
>
> What do you mean by "overwrite"?  What happens if you use a list of
> more than one PARENTS?
>

If I do something like:

(set-language-info-alist
 "Kharoshthi" '((charset unicode)
       (coding-system utf-8)
       (coding-priority utf-8)
       (input-method . "kharoshthi")
                (sample-text . "Kharoṣṭhī (𐨑𐨪𐨆𐨛𐨁) 𐨣𐨨𐨲𐨪𐨆
𐨐𐨪𐨅𐨨𐨁")
       (documentation . "\
Language environment for Gāndhārī, Sanskrit, and other languages
using the Kharoṣṭhī script."))
 '("Misc" "Indian"))

Then compile and open emacs -Q
Now opening Options>Multilingual Environment>Set Language Environment>Indian
It only has the Kharoshthi entry
Options>Multilingual Environment>Set Language Environment>Misc now also has
an Indian submenu with only Kharoshthi entry.

[-- Attachment #2: Type: text/html, Size: 1871 bytes --]

bug#58376: [PATCH] Set the PARENTS argument for language environments

[Eli Zaretskii]

> From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> Date: Sun, 9 Oct 2022 15:58:48 +0530
> Cc: 58376@debbugs.gnu.org
> 
>  > From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
>  > Date: Sun, 9 Oct 2022 00:46:10 +0530
>  > Cc: 58376@debbugs.gnu.org
>  > 
>  > For Kharoshthi and Gothic how to define the PARENTS argument so that it does not overwrite the
>  previous
>  > entries in the menu?
> 
>  What do you mean by "overwrite"?  What happens if you use a list of
>  more than one PARENTS?
> 
> If I do something like:
> 
> (set-language-info-alist
>  "Kharoshthi" '((charset unicode)
>        (coding-system utf-8)
>        (coding-priority utf-8)
>        (input-method . "kharoshthi")
>                 (sample-text . "Kharoṣṭhī (𐨑𐨪𐨆𐨛𐨁) 𐨣𐨨𐨲𐨪𐨆 𐨐𐨪𐨅𐨨𐨁")
>        (documentation . "\
> Language environment for Gāndhārī, Sanskrit, and other languages
> using the Kharoṣṭhī script."))
>  '("Misc" "Indian"))
> 
> Then compile and open emacs -Q
> Now opening Options>Multilingual Environment>Set Language Environment>Indian
> It only has the Kharoshthi entry
> Options>Multilingual Environment>Set Language Environment>Misc now also has an Indian submenu with
> only Kharoshthi entry.

Hmm...  Either we don't understand what PARENTS mean (could it mean a
hierarchy of several menu levels?), or there is a bug.

If you want to work on that, please do; otherwise I'll just install
your original patch.

bug#58376: [PATCH] Set the PARENTS argument for language environments

[समीर सिंह Sameer Singh]

[-- Attachment #1: Type: text/plain, Size: 1841 bytes --]

You can install the original patch for now, I'll look into this later.

Also can we copy Microsoft keyboard layout for input methods?

Thanks

On Sun, Oct 9, 2022 at 6:52 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> > Date: Sun, 9 Oct 2022 15:58:48 +0530
> > Cc: 58376@debbugs.gnu.org
> >
> >  > From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> >  > Date: Sun, 9 Oct 2022 00:46:10 +0530
> >  > Cc: 58376@debbugs.gnu.org
> >  >
> >  > For Kharoshthi and Gothic how to define the PARENTS argument so that
> it does not overwrite the
> >  previous
> >  > entries in the menu?
> >
> >  What do you mean by "overwrite"?  What happens if you use a list of
> >  more than one PARENTS?
> >
> > If I do something like:
> >
> > (set-language-info-alist
> >  "Kharoshthi" '((charset unicode)
> >        (coding-system utf-8)
> >        (coding-priority utf-8)
> >        (input-method . "kharoshthi")
> >                 (sample-text . "Kharoṣṭhī (𐨑𐨪𐨆𐨛𐨁) 𐨣𐨨𐨲𐨪𐨆
> 𐨐𐨪𐨅𐨨𐨁")
> >        (documentation . "\
> > Language environment for Gāndhārī, Sanskrit, and other languages
> > using the Kharoṣṭhī script."))
> >  '("Misc" "Indian"))
> >
> > Then compile and open emacs -Q
> > Now opening Options>Multilingual Environment>Set Language
> Environment>Indian
> > It only has the Kharoshthi entry
> > Options>Multilingual Environment>Set Language Environment>Misc now also
> has an Indian submenu with
> > only Kharoshthi entry.
>
> Hmm...  Either we don't understand what PARENTS mean (could it mean a
> hierarchy of several menu levels?), or there is a bug.
>
> If you want to work on that, please do; otherwise I'll just install
> your original patch.
>

[-- Attachment #2: Type: text/html, Size: 2750 bytes --]

bug#58376: [PATCH] Set the PARENTS argument for language environments

[Eli Zaretskii]

> From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> Date: Sun, 9 Oct 2022 19:29:21 +0530
> Cc: 58376@debbugs.gnu.org
> 
> You can install the original patch for now, I'll look into this later.

Done.

> Also can we copy Microsoft keyboard layout for input methods?

How do you mean "copy keyboard layout"?  We don't produce keyboard, so
what kind of "copy" is relevant?

bug#58376: [PATCH] Set the PARENTS argument for language environments

[समीर सिंह Sameer Singh]

[-- Attachment #1: Type: text/plain, Size: 773 bytes --]

On Sun, Oct 9, 2022 at 7:53 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> > Date: Sun, 9 Oct 2022 19:29:21 +0530
> > Cc: 58376@debbugs.gnu.org
> >
> > You can install the original patch for now, I'll look into this later.
>
> Done.
>
> > Also can we copy Microsoft keyboard layout for input methods?
>
> How do you mean "copy keyboard layout"?  We don't produce keyboard, so
> what kind of "copy" is relevant?
>

I meant to say that can we have the same input methods as microsoft?
Do they have some copyright on them or is it okay to copy?
I needed them for input methods like Armenian and Syriac.
From here:
https://learn.microsoft.com/en-us/globalization/windows-keyboard-layouts

[-- Attachment #2: Type: text/html, Size: 1400 bytes --]

bug#58376: [PATCH] Set the PARENTS argument for language environments

[Eli Zaretskii]

> From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> Date: Sun, 9 Oct 2022 20:16:53 +0530
> Cc: 58376-done@debbugs.gnu.org
> 
>  > Also can we copy Microsoft keyboard layout for input methods?
> 
>  How do you mean "copy keyboard layout"?  We don't produce keyboard, so
>  what kind of "copy" is relevant?
> 
> I meant to say that can we have the same input methods as microsoft?
> Do they have some copyright on them or is it okay to copy?
> I needed them for input methods like Armenian and Syriac.
> From here: https://learn.microsoft.com/en-us/globalization/windows-keyboard-layouts 

I don't think placement of characters on keys is copyrightable, but
IANAL.  Richard, is there a problem here?

bug#58376: [PATCH] Set the PARENTS argument for language environments

[Visuwesh]

[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]

[ஞாயிறு அக்டோபர் 09, 2022] Eli Zaretskii wrote:

>> If I do something like:
>> 
>> (set-language-info-alist
>>  "Kharoshthi" '((charset unicode)
>>        (coding-system utf-8)
>>        (coding-priority utf-8)
>>        (input-method . "kharoshthi")
>>                 (sample-text . "Kharoṣṭhī (𐨑𐨪𐨆𐨛𐨁) 𐨣𐨨𐨲𐨪𐨆 𐨐𐨪𐨅𐨨𐨁")
>>        (documentation . "\
>> Language environment for Gāndhārī, Sanskrit, and other languages
>> using the Kharoṣṭhī script."))
>>  '("Misc" "Indian"))
>> 
>> Then compile and open emacs -Q
>> Now opening Options>Multilingual Environment>Set Language Environment>Indian
>> It only has the Kharoshthi entry
>> Options>Multilingual Environment>Set Language Environment>Misc now also has an Indian submenu with
>> only Kharoshthi entry.
>
> Hmm...  Either we don't understand what PARENTS mean (could it mean a
> hierarchy of several menu levels?), or there is a bug.
>
> If you want to work on that, please do; otherwise I'll just install
> your original patch.

Attached patch puts the "Kharosthi" item in both Indian and Misc
submenus without overwriting.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: set-language-info-alist.patch --]
[-- Type: text/x-diff, Size: 1977 bytes --]

diff --git a/lisp/international/mule-cmds.el b/lisp/international/mule-cmds.el
index 48e5c9aa1f..f39a4da439 100644
--- a/lisp/international/mule-cmds.el
+++ b/lisp/international/mule-cmds.el
@@ -1208,6 +1208,16 @@ set-language-info-internal
 			  (list 'const lang))
 			(sort (mapcar 'car language-info-alist) 'string<))))))

+(defun set-language-info-setup-keymap (lang-env alist describe-map setup-map)
+  "Setup menu items for LANG-ENV.
+See `set-language-info-alist' for details of other arguments."
+  (let ((doc (assq 'documentation alist)))
+    (when doc
+      (define-key-after describe-map (vector (intern lang-env))
+	(cons lang-env 'describe-specified-language-support))))
+  (define-key-after setup-map (vector (intern lang-env))
+    (cons lang-env 'setup-specified-language-environment)))
+
 (defun set-language-info-alist (lang-env alist &optional parents)
   "Store ALIST as the definition of language environment LANG-ENV.
 ALIST is an alist of KEY and INFO values.  See the documentation of
@@ -1252,16 +1262,11 @@ set-language-info-alist
 		  (define-key-after setup-map (vector parent-symbol)
 		    (cons parent map))))
 	    (setq setup-map (symbol-value map))
-	    (setq l (cdr l)))))
-
-    ;; Set up menu items for this language env.
-    (let ((doc (assq 'documentation alist)))
-      (when doc
-	(define-key-after describe-map (vector (intern lang-env))
-	  (cons lang-env 'describe-specified-language-support))))
-    (define-key-after setup-map (vector (intern lang-env))
-      (cons lang-env 'setup-specified-language-environment))
-
+	    (setq l (cdr l))
+            (set-language-info-setup-keymap lang-env alist describe-map setup-map)
+            (setq describe-map describe-language-environment-map)
+            (setq setup-map setup-language-environment-map)))
+      (set-language-info-setup-keymap lang-env alist describe-map setup-map))
     (dolist (elt alist)
       (set-language-info-internal lang-env (car elt) (cdr elt)))

[-- Attachment #3: Type: text/plain, Size: 279 bytes --]


The problem is that when looping, the variables setup-map and
describe-map gets outdated and causes the overwrite.  The solution I
came up with was to update them both to their default after each
iteration.  This involved moving the keymap-setting forms to a separate
function.

bug#58376: [PATCH] Set the PARENTS argument for language environments

[Visuwesh]

[ஞாயிறு அக்டோபர் 09, 2022] Visuwesh wrote:

> [ஞாயிறு அக்டோபர் 09, 2022] Eli Zaretskii wrote:
>
>>> If I do something like:
>>> 
>>> (set-language-info-alist
>>>  "Kharoshthi" '((charset unicode)
>>>        (coding-system utf-8)
>>>        (coding-priority utf-8)
>>>        (input-method . "kharoshthi")
>>>                 (sample-text . "Kharoṣṭhī (𐨑𐨪𐨆𐨛𐨁) 𐨣𐨨𐨲𐨪𐨆 𐨐𐨪𐨅𐨨𐨁")
>>>        (documentation . "\
>>> Language environment for Gāndhārī, Sanskrit, and other languages
>>> using the Kharoṣṭhī script."))
>>>  '("Misc" "Indian"))
>>> 
>>> Then compile and open emacs -Q
>>> Now opening Options>Multilingual Environment>Set Language Environment>Indian
>>> It only has the Kharoshthi entry
>>> Options>Multilingual Environment>Set Language Environment>Misc now also has an Indian submenu with
>>> only Kharoshthi entry.
>>
>> Hmm...  Either we don't understand what PARENTS mean (could it mean
>> a
>> hierarchy of several menu levels?), or there is a bug.
>>
>> If you want to work on that, please do; otherwise I'll just install
>> your original patch.
>
> Attached patch puts the "Kharosthi" item in both Indian and Misc
> submenus without overwriting.
>
>
>
> The problem is that when looping, the variables setup-map and
> describe-map gets outdated and causes the overwrite.  The solution I
> came up with was to update them both to their default after each
> iteration.  This involved moving the keymap-setting forms to a
> separate
> function.

Hmm, I seethat the function can be cleaned up further.  I will do it
after my dinner.

bug#58376: [PATCH] Set the PARENTS argument for language environments

[Visuwesh]

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

[ஞாயிறு அக்டோபர் 09, 2022] Visuwesh wrote:

>> Attached patch puts the "Kharosthi" item in both Indian and Misc
>> submenus without overwriting.
>>
>>
>>
>> The problem is that when looping, the variables setup-map and
>> describe-map gets outdated and causes the overwrite.  The solution I
>> came up with was to update them both to their default after each
>> iteration.  This involved moving the keymap-setting forms to a
>> separate
>> function.
>
> Hmm, I seethat the function can be cleaned up further.  I will do it
> after my dinner.

Please find attached.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-set-language-info-alist-when-multiple-PARENTS-ar.patch --]
[-- Type: text/x-diff, Size: 5339 bytes --]

From 6e219f98feb19489c82f9bbcc429241131b75c7a Mon Sep 17 00:00:00 2001
From: Visuwesh <visuweshm@gmail.com>
Date: Sun, 9 Oct 2022 20:59:50 +0530
Subject: [PATCH] Fix set-language-info-alist when multiple PARENTS are given

* lisp/international/mule-cmds.el (set-language-info-setup-keymap):
Function factored out from...
(set-language-info-alist): ...here.  Do not mess up the keymaps when
multiple parents are given in PARENTS.  (bug#58376)
---
 lisp/international/mule-cmds.el | 84 ++++++++++++++++-----------------
 1 file changed, 40 insertions(+), 44 deletions(-)

diff --git a/lisp/international/mule-cmds.el b/lisp/international/mule-cmds.el
index 48e5c9aa1f..4ad0d1003b 100644
--- a/lisp/international/mule-cmds.el
+++ b/lisp/international/mule-cmds.el
@@ -1208,6 +1208,16 @@ set-language-info-internal
 			  (list 'const lang))
 			(sort (mapcar 'car language-info-alist) 'string<))))))
 
+(defun set-language-info-setup-keymap (lang-env alist describe-map setup-map)
+  "Setup menu items for LANG-ENV.
+See `set-language-info-alist' for details of other arguments."
+  (let ((doc (assq 'documentation alist)))
+    (when doc
+      (define-key-after describe-map (vector (intern lang-env))
+	(cons lang-env 'describe-specified-language-support))))
+  (define-key-after setup-map (vector (intern lang-env))
+    (cons lang-env 'setup-specified-language-environment)))
+
 (defun set-language-info-alist (lang-env alist &optional parents)
   "Store ALIST as the definition of language environment LANG-ENV.
 ALIST is an alist of KEY and INFO values.  See the documentation of
@@ -1222,51 +1232,37 @@ set-language-info-alist
 	 (setq lang-env (symbol-name lang-env)))
 	((stringp lang-env)
 	 (setq lang-env (purecopy lang-env))))
-  (let ((describe-map describe-language-environment-map)
-	(setup-map setup-language-environment-map))
-    (if parents
-	(let ((l parents)
-	      map parent-symbol parent prompt)
-	  (while l
-	    (if (symbolp (setq parent-symbol (car l)))
-		(setq parent (symbol-name parent))
-	      (setq parent parent-symbol parent-symbol (intern parent)))
-	    (setq map (lookup-key describe-map (vector parent-symbol)))
-	    ;; This prompt string is for define-prefix-command, so
-	    ;; that the map it creates will be suitable for a menu.
-	    (or map (setq prompt (format "%s Environment" parent)))
-	    (if (not map)
-		(progn
-		  (setq map (intern (format "describe-%s-environment-map"
-					    (downcase parent))))
-		  (define-prefix-command map nil prompt)
-		  (define-key-after describe-map (vector parent-symbol)
-		    (cons parent map))))
-	    (setq describe-map (symbol-value map))
-	    (setq map (lookup-key setup-map (vector parent-symbol)))
-	    (if (not map)
-		(progn
-		  (setq map (intern (format "setup-%s-environment-map"
+  (if parents
+      (while parents
+	(let (describe-map setup-map parent-symbol parent prompt)
+	  (if (symbolp (setq parent-symbol (car parents)))
+	      (setq parent (symbol-name parent))
+	    (setq parent parent-symbol parent-symbol (intern parent)))
+	  (setq describe-map (lookup-key describe-language-environment-map (vector parent-symbol)))
+	  ;; This prompt string is for define-prefix-command, so
+	  ;; that the map it creates will be suitable for a menu.
+	  (or describe-map (setq prompt (format "%s Environment" parent)))
+	  (unless describe-map
+	    (setq describe-map (intern (format "describe-%s-environment-map"
+					       (downcase parent))))
+	    (define-prefix-command describe-map nil prompt)
+	    (define-key-after describe-language-environment-map (vector parent-symbol)
+	      (cons parent describe-map)))
+	  (setq setup-map (lookup-key setup-language-environment-map (vector parent-symbol)))
+	  (unless setup-map
+	    (setq setup-map (intern (format "setup-%s-environment-map"
 					    (downcase parent))))
-		  (define-prefix-command map nil prompt)
-		  (define-key-after setup-map (vector parent-symbol)
-		    (cons parent map))))
-	    (setq setup-map (symbol-value map))
-	    (setq l (cdr l)))))
-
-    ;; Set up menu items for this language env.
-    (let ((doc (assq 'documentation alist)))
-      (when doc
-	(define-key-after describe-map (vector (intern lang-env))
-	  (cons lang-env 'describe-specified-language-support))))
-    (define-key-after setup-map (vector (intern lang-env))
-      (cons lang-env 'setup-specified-language-environment))
-
-    (dolist (elt alist)
-      (set-language-info-internal lang-env (car elt) (cdr elt)))
-
-    (if (equal lang-env current-language-environment)
-	(set-language-environment lang-env))))
+	    (define-prefix-command setup-map nil prompt)
+	    (define-key-after setup-language-environment-map (vector parent-symbol)
+	      (cons parent setup-map)))
+	  (setq parents (cdr parents))
+          (set-language-info-setup-keymap lang-env alist (symbol-value describe-map) (symbol-value setup-map))))
+    (set-language-info-setup-keymap lang-env alist
+       describe-language-environment-map setup-language-environment-map))
+  (dolist (elt alist)
+    (set-language-info-internal lang-env (car elt) (cdr elt)))
+  (if (equal lang-env current-language-environment)
+      (set-language-environment lang-env)))
 
 (defun read-language-name (key prompt &optional default)
   "Read a language environment name which has information for KEY.
-- 
2.37.2

bug#58376: [PATCH] Set the PARENTS argument for language environments

[समीर सिंह Sameer Singh]

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

Can you resend the patch?
This one fails to apply.

On Sun, Oct 9, 2022 at 9:00 PM Visuwesh <visuweshm@gmail.com> wrote:

> [ஞாயிறு அக்டோபர் 09, 2022] Visuwesh wrote:
>
> >> Attached patch puts the "Kharosthi" item in both Indian and Misc
> >> submenus without overwriting.
> >>
> >>
> >>
> >> The problem is that when looping, the variables setup-map and
> >> describe-map gets outdated and causes the overwrite.  The solution I
> >> came up with was to update them both to their default after each
> >> iteration.  This involved moving the keymap-setting forms to a
> >> separate
> >> function.
> >
> > Hmm, I seethat the function can be cleaned up further.  I will do it
> > after my dinner.
>
> Please find attached.
>
>

[-- Attachment #2: Type: text/html, Size: 1203 bytes --]

bug#58376: [PATCH] Set the PARENTS argument for language environments

[Visuwesh]

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

[திங்கள் அக்டோபர் 10, 2022] समीर सिंह Sameer Singh wrote:

> On Sun, Oct 9, 2022 at 9:00 PM Visuwesh <visuweshm@gmail.com> wrote:
>
>  [ஞாயிறு அக்டோபர் 09, 2022] Visuwesh wrote:
>
>  >> Attached patch puts the "Kharosthi" item in both Indian and Misc
>  >> submenus without overwriting.
>  >>
>  >>
>  >>
>  >> The problem is that when looping, the variables setup-map and
>  >> describe-map gets outdated and causes the overwrite.  The solution I
>  >> came up with was to update them both to their default after each
>  >> iteration.  This involved moving the keymap-setting forms to a
>  >> separate
>  >> function.
>  >
>  > Hmm, I seethat the function can be cleaned up further.  I will do it
>  > after my dinner.
>
>  Please find attached.
>
>
> Can you resend the patch?
> This one fails to apply.

Hmm weird, the patch applies cleanly for me if I download a fresh copy of
mule-cmds.el from https://git.savannah.gnu.org/cgit/emacs.git/plain/lisp/international/mule-cmds.el.
How about the attached?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: pp --]
[-- Type: text/x-diff, Size: 4799 bytes --]

diff --git a/lisp/international/mule-cmds.el b/lisp/international/mule-cmds.el
index 48e5c9a..4ad0d10 100644
--- a/lisp/international/mule-cmds.el
+++ b/lisp/international/mule-cmds.el
@@ -1208,6 +1208,16 @@ Arguments are the same as `set-language-info'."
 			  (list 'const lang))
 			(sort (mapcar 'car language-info-alist) 'string<))))))

+(defun set-language-info-setup-keymap (lang-env alist describe-map setup-map)
+  "Setup menu items for LANG-ENV.
+See `set-language-info-alist' for details of other arguments."
+  (let ((doc (assq 'documentation alist)))
+    (when doc
+      (define-key-after describe-map (vector (intern lang-env))
+	(cons lang-env 'describe-specified-language-support))))
+  (define-key-after setup-map (vector (intern lang-env))
+    (cons lang-env 'setup-specified-language-environment)))
+
 (defun set-language-info-alist (lang-env alist &optional parents)
   "Store ALIST as the definition of language environment LANG-ENV.
 ALIST is an alist of KEY and INFO values.  See the documentation of
@@ -1222,51 +1232,37 @@ in the European submenu in each of those two menus."
 	 (setq lang-env (symbol-name lang-env)))
 	((stringp lang-env)
 	 (setq lang-env (purecopy lang-env))))
-  (let ((describe-map describe-language-environment-map)
-	(setup-map setup-language-environment-map))
-    (if parents
-	(let ((l parents)
-	      map parent-symbol parent prompt)
-	  (while l
-	    (if (symbolp (setq parent-symbol (car l)))
-		(setq parent (symbol-name parent))
-	      (setq parent parent-symbol parent-symbol (intern parent)))
-	    (setq map (lookup-key describe-map (vector parent-symbol)))
-	    ;; This prompt string is for define-prefix-command, so
-	    ;; that the map it creates will be suitable for a menu.
-	    (or map (setq prompt (format "%s Environment" parent)))
-	    (if (not map)
-		(progn
-		  (setq map (intern (format "describe-%s-environment-map"
-					    (downcase parent))))
-		  (define-prefix-command map nil prompt)
-		  (define-key-after describe-map (vector parent-symbol)
-		    (cons parent map))))
-	    (setq describe-map (symbol-value map))
-	    (setq map (lookup-key setup-map (vector parent-symbol)))
-	    (if (not map)
-		(progn
-		  (setq map (intern (format "setup-%s-environment-map"
+  (if parents
+      (while parents
+	(let (describe-map setup-map parent-symbol parent prompt)
+	  (if (symbolp (setq parent-symbol (car parents)))
+	      (setq parent (symbol-name parent))
+	    (setq parent parent-symbol parent-symbol (intern parent)))
+	  (setq describe-map (lookup-key describe-language-environment-map (vector parent-symbol)))
+	  ;; This prompt string is for define-prefix-command, so
+	  ;; that the map it creates will be suitable for a menu.
+	  (or describe-map (setq prompt (format "%s Environment" parent)))
+	  (unless describe-map
+	    (setq describe-map (intern (format "describe-%s-environment-map"
+					       (downcase parent))))
+	    (define-prefix-command describe-map nil prompt)
+	    (define-key-after describe-language-environment-map (vector parent-symbol)
+	      (cons parent describe-map)))
+	  (setq setup-map (lookup-key setup-language-environment-map (vector parent-symbol)))
+	  (unless setup-map
+	    (setq setup-map (intern (format "setup-%s-environment-map"
 					    (downcase parent))))
-		  (define-prefix-command map nil prompt)
-		  (define-key-after setup-map (vector parent-symbol)
-		    (cons parent map))))
-	    (setq setup-map (symbol-value map))
-	    (setq l (cdr l)))))
-
-    ;; Set up menu items for this language env.
-    (let ((doc (assq 'documentation alist)))
-      (when doc
-	(define-key-after describe-map (vector (intern lang-env))
-	  (cons lang-env 'describe-specified-language-support))))
-    (define-key-after setup-map (vector (intern lang-env))
-      (cons lang-env 'setup-specified-language-environment))
-
-    (dolist (elt alist)
-      (set-language-info-internal lang-env (car elt) (cdr elt)))
-
-    (if (equal lang-env current-language-environment)
-	(set-language-environment lang-env))))
+	    (define-prefix-command setup-map nil prompt)
+	    (define-key-after setup-language-environment-map (vector parent-symbol)
+	      (cons parent setup-map)))
+	  (setq parents (cdr parents))
+          (set-language-info-setup-keymap lang-env alist (symbol-value describe-map) (symbol-value setup-map))))
+    (set-language-info-setup-keymap lang-env alist
+       describe-language-environment-map setup-language-environment-map))
+  (dolist (elt alist)
+    (set-language-info-internal lang-env (car elt) (cdr elt)))
+  (if (equal lang-env current-language-environment)
+      (set-language-environment lang-env)))

 (defun read-language-name (key prompt &optional default)
   "Read a language environment name which has information for KEY.

bug#58376: [PATCH] Set the PARENTS argument for language environments

[समीर सिंह Sameer Singh]

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

This one says: "error: corrupt patch at line 8"

The previous one said:
error: patch failed: lisp/international/mule-cmds.el:1208
error: lisp/international/mule-cmds.el: patch does not apply

On Mon, Oct 10, 2022 at 8:03 PM Visuwesh <visuweshm@gmail.com> wrote:

> [திங்கள் அக்டோபர் 10, 2022] समीर सिंह Sameer Singh wrote:
>
> > On Sun, Oct 9, 2022 at 9:00 PM Visuwesh <visuweshm@gmail.com> wrote:
> >
> >  [ஞாயிறு அக்டோபர் 09, 2022] Visuwesh wrote:
> >
> >  >> Attached patch puts the "Kharosthi" item in both Indian and Misc
> >  >> submenus without overwriting.
> >  >>
> >  >>
> >  >>
> >  >> The problem is that when looping, the variables setup-map and
> >  >> describe-map gets outdated and causes the overwrite.  The solution I
> >  >> came up with was to update them both to their default after each
> >  >> iteration.  This involved moving the keymap-setting forms to a
> >  >> separate
> >  >> function.
> >  >
> >  > Hmm, I seethat the function can be cleaned up further.  I will do it
> >  > after my dinner.
> >
> >  Please find attached.
> >
> >
> > Can you resend the patch?
> > This one fails to apply.
>
> Hmm weird, the patch applies cleanly for me if I download a fresh copy of
> mule-cmds.el from
> https://git.savannah.gnu.org/cgit/emacs.git/plain/lisp/international/mule-cmds.el
> .
> How about the attached?
>
>

[-- Attachment #2: Type: text/html, Size: 2675 bytes --]

bug#58376: [PATCH] Set the PARENTS argument for language environments

[Visuwesh]

[திங்கள் அக்டோபர் 10, 2022] समीर सिंह Sameer Singh wrote:

> This one says: "error: corrupt patch at line 8"
>
> The previous one said:
> error: patch failed: lisp/international/mule-cmds.el:1208
> error: lisp/international/mule-cmds.el: patch does not apply
>

I have no idea why that is the case, and my network connection is too
slow to freshly clone the Emacs repo again.  Can you replace the old
definition of `set-language-info-alist' with the following two forms
instead?

(defun set-language-info-setup-keymap (lang-env alist describe-map setup-map)
  "Setup menu items for LANG-ENV.
See `set-language-info-alist' for details of other arguments."
  (let ((doc (assq 'documentation alist)))
    (when doc
      (define-key-after describe-map (vector (intern lang-env))
	(cons lang-env 'describe-specified-language-support))))
  (define-key-after setup-map (vector (intern lang-env))
    (cons lang-env 'setup-specified-language-environment)))

(defun set-language-info-alist (lang-env alist &optional parents)
  "Store ALIST as the definition of language environment LANG-ENV.
ALIST is an alist of KEY and INFO values.  See the documentation of
`language-info-alist' for the meanings of KEY and INFO.

Optional arg PARENTS is a list of parent menu names; it specifies
where to put this language environment in the
Describe Language Environment and Set Language Environment menus.
For example, (\"European\") means to put this language environment
in the European submenu in each of those two menus."
  (cond ((symbolp lang-env)
	 (setq lang-env (symbol-name lang-env)))
	((stringp lang-env)
	 (setq lang-env (purecopy lang-env))))
  (if parents
      (while parents
	(let (describe-map setup-map parent-symbol parent prompt)
	  (if (symbolp (setq parent-symbol (car parents)))
	      (setq parent (symbol-name parent))
	    (setq parent parent-symbol parent-symbol (intern parent)))
	  (setq describe-map (lookup-key describe-language-environment-map (vector parent-symbol)))
	  ;; This prompt string is for define-prefix-command, so
	  ;; that the map it creates will be suitable for a menu.
	  (or describe-map (setq prompt (format "%s Environment" parent)))
	  (unless describe-map
	    (setq describe-map (intern (format "describe-%s-environment-map"
					       (downcase parent))))
	    (define-prefix-command describe-map nil prompt)
	    (define-key-after describe-language-environment-map (vector parent-symbol)
	      (cons parent describe-map)))
	  (setq setup-map (lookup-key setup-language-environment-map (vector parent-symbol)))
	  (unless setup-map
	    (setq setup-map (intern (format "setup-%s-environment-map"
					    (downcase parent))))
	    (define-prefix-command setup-map nil prompt)
	    (define-key-after setup-language-environment-map (vector parent-symbol)
	      (cons parent setup-map)))
	  (setq parents (cdr parents))
          (set-language-info-setup-keymap lang-env alist (symbol-value describe-map) (symbol-value setup-map))))
    (set-language-info-setup-keymap lang-env alist
                                    describe-language-environment-map setup-language-environment-map))
  (dolist (elt alist)
    (set-language-info-internal lang-env (car elt) (cdr elt)))
  (if (equal lang-env current-language-environment)
      (set-language-environment lang-env)))

bug#58376: [PATCH] Set the PARENTS argument for language environments

[समीर सिंह Sameer Singh]

[-- Attachment #1.1: Type: text/plain, Size: 4088 bytes --]

Thanks, it works this way.
I have created a patch for you, if the ones provided by you do not apply.

I have also created a separate patch adding multiple PARENTs to Kharoshthi
and Gothic.

On Mon, Oct 10, 2022 at 9:29 PM Visuwesh <visuweshm@gmail.com> wrote:

> [திங்கள் அக்டோபர் 10, 2022] समीर सिंह Sameer Singh wrote:
>
> > This one says: "error: corrupt patch at line 8"
> >
> > The previous one said:
> > error: patch failed: lisp/international/mule-cmds.el:1208
> > error: lisp/international/mule-cmds.el: patch does not apply
> >
>
> I have no idea why that is the case, and my network connection is too
> slow to freshly clone the Emacs repo again.  Can you replace the old
> definition of `set-language-info-alist' with the following two forms
> instead?
>
> (defun set-language-info-setup-keymap (lang-env alist describe-map
> setup-map)
>   "Setup menu items for LANG-ENV.
> See `set-language-info-alist' for details of other arguments."
>   (let ((doc (assq 'documentation alist)))
>     (when doc
>       (define-key-after describe-map (vector (intern lang-env))
>         (cons lang-env 'describe-specified-language-support))))
>   (define-key-after setup-map (vector (intern lang-env))
>     (cons lang-env 'setup-specified-language-environment)))
>
> (defun set-language-info-alist (lang-env alist &optional parents)
>   "Store ALIST as the definition of language environment LANG-ENV.
> ALIST is an alist of KEY and INFO values.  See the documentation of
> `language-info-alist' for the meanings of KEY and INFO.
>
> Optional arg PARENTS is a list of parent menu names; it specifies
> where to put this language environment in the
> Describe Language Environment and Set Language Environment menus.
> For example, (\"European\") means to put this language environment
> in the European submenu in each of those two menus."
>   (cond ((symbolp lang-env)
>          (setq lang-env (symbol-name lang-env)))
>         ((stringp lang-env)
>          (setq lang-env (purecopy lang-env))))
>   (if parents
>       (while parents
>         (let (describe-map setup-map parent-symbol parent prompt)
>           (if (symbolp (setq parent-symbol (car parents)))
>               (setq parent (symbol-name parent))
>             (setq parent parent-symbol parent-symbol (intern parent)))
>           (setq describe-map (lookup-key describe-language-environment-map
> (vector parent-symbol)))
>           ;; This prompt string is for define-prefix-command, so
>           ;; that the map it creates will be suitable for a menu.
>           (or describe-map (setq prompt (format "%s Environment" parent)))
>           (unless describe-map
>             (setq describe-map (intern (format
> "describe-%s-environment-map"
>                                                (downcase parent))))
>             (define-prefix-command describe-map nil prompt)
>             (define-key-after describe-language-environment-map (vector
> parent-symbol)
>               (cons parent describe-map)))
>           (setq setup-map (lookup-key setup-language-environment-map
> (vector parent-symbol)))
>           (unless setup-map
>             (setq setup-map (intern (format "setup-%s-environment-map"
>                                             (downcase parent))))
>             (define-prefix-command setup-map nil prompt)
>             (define-key-after setup-language-environment-map (vector
> parent-symbol)
>               (cons parent setup-map)))
>           (setq parents (cdr parents))
>           (set-language-info-setup-keymap lang-env alist (symbol-value
> describe-map) (symbol-value setup-map))))
>     (set-language-info-setup-keymap lang-env alist
>                                     describe-language-environment-map
> setup-language-environment-map))
>   (dolist (elt alist)
>     (set-language-info-internal lang-env (car elt) (cdr elt)))
>   (if (equal lang-env current-language-environment)
>       (set-language-environment lang-env)))
>

[-- Attachment #1.2: Type: text/html, Size: 4866 bytes --]

[-- Attachment #2: 0001-Fix-set-language-info-alist-when-multiple-PARENTS-ar.patch --]
[-- Type: text/x-patch, Size: 5435 bytes --]

From ebb928ca03c5ffd34a815f09825f3d8b40269868 Mon Sep 17 00:00:00 2001
From: Visuwesh <visuweshm@gmail.com>
Date: Mon, 10 Oct 2022 23:49:06 +0530
Subject: [PATCH] Fix set-language-info-alist when multiple PARENTS are given
 (bug#58376)

* lisp/international/mule-cmds.el (set-language-info-setup-keymap):
Function factored out from...
(set-language-info-alist): ...here.  Do not mess up the keymaps when
multiple parents are given in PARENTS.
---
 lisp/international/mule-cmds.el | 86 ++++++++++++++++-----------------
 1 file changed, 41 insertions(+), 45 deletions(-)

diff --git a/lisp/international/mule-cmds.el b/lisp/international/mule-cmds.el
index 48e5c9aa1f..dfd2e1438e 100644
--- a/lisp/international/mule-cmds.el
+++ b/lisp/international/mule-cmds.el
@@ -1208,6 +1208,16 @@ set-language-info-internal
 			  (list 'const lang))
 			(sort (mapcar 'car language-info-alist) 'string<))))))
 
+(defun set-language-info-setup-keymap (lang-env alist describe-map setup-map)
+  "Setup menu items for LANG-ENV.
+See `set-language-info-alist' for details of other arguments."
+  (let ((doc (assq 'documentation alist)))
+    (when doc
+      (define-key-after describe-map (vector (intern lang-env))
+	(cons lang-env 'describe-specified-language-support))))
+  (define-key-after setup-map (vector (intern lang-env))
+    (cons lang-env 'setup-specified-language-environment)))
+
 (defun set-language-info-alist (lang-env alist &optional parents)
   "Store ALIST as the definition of language environment LANG-ENV.
 ALIST is an alist of KEY and INFO values.  See the documentation of
@@ -1222,51 +1232,37 @@ set-language-info-alist
 	 (setq lang-env (symbol-name lang-env)))
 	((stringp lang-env)
 	 (setq lang-env (purecopy lang-env))))
-  (let ((describe-map describe-language-environment-map)
-	(setup-map setup-language-environment-map))
-    (if parents
-	(let ((l parents)
-	      map parent-symbol parent prompt)
-	  (while l
-	    (if (symbolp (setq parent-symbol (car l)))
-		(setq parent (symbol-name parent))
-	      (setq parent parent-symbol parent-symbol (intern parent)))
-	    (setq map (lookup-key describe-map (vector parent-symbol)))
-	    ;; This prompt string is for define-prefix-command, so
-	    ;; that the map it creates will be suitable for a menu.
-	    (or map (setq prompt (format "%s Environment" parent)))
-	    (if (not map)
-		(progn
-		  (setq map (intern (format "describe-%s-environment-map"
-					    (downcase parent))))
-		  (define-prefix-command map nil prompt)
-		  (define-key-after describe-map (vector parent-symbol)
-		    (cons parent map))))
-	    (setq describe-map (symbol-value map))
-	    (setq map (lookup-key setup-map (vector parent-symbol)))
-	    (if (not map)
-		(progn
-		  (setq map (intern (format "setup-%s-environment-map"
-					    (downcase parent))))
-		  (define-prefix-command map nil prompt)
-		  (define-key-after setup-map (vector parent-symbol)
-		    (cons parent map))))
-	    (setq setup-map (symbol-value map))
-	    (setq l (cdr l)))))
-
-    ;; Set up menu items for this language env.
-    (let ((doc (assq 'documentation alist)))
-      (when doc
-	(define-key-after describe-map (vector (intern lang-env))
-	  (cons lang-env 'describe-specified-language-support))))
-    (define-key-after setup-map (vector (intern lang-env))
-      (cons lang-env 'setup-specified-language-environment))
-
-    (dolist (elt alist)
-      (set-language-info-internal lang-env (car elt) (cdr elt)))
-
-    (if (equal lang-env current-language-environment)
-	(set-language-environment lang-env))))
+  (if parents
+      (while parents
+	(let (describe-map setup-map parent-symbol parent prompt)
+	  (if (symbolp (setq parent-symbol (car parents)))
+	      (setq parent (symbol-name parent))
+	    (setq parent parent-symbol parent-symbol (intern parent)))
+	  (setq describe-map (lookup-key describe-language-environment-map (vector parent-symbol)))
+	  ;; This prompt string is for define-prefix-command, so
+	  ;; that the map it creates will be suitable for a menu.
+	  (or describe-map (setq prompt (format "%s Environment" parent)))
+	  (unless describe-map
+	    (setq describe-map (intern (format "describe-%s-environment-map"
+					       (downcase parent))))
+	    (define-prefix-command describe-map nil prompt)
+	    (define-key-after describe-language-environment-map (vector parent-symbol)
+	      (cons parent describe-map)))
+	  (setq setup-map (lookup-key setup-language-environment-map (vector parent-symbol)))
+	  (unless setup-map
+	    (setq setup-map (intern (format "setup-%s-environment-map"
+                                            (downcase parent))))
+	    (define-prefix-command setup-map nil prompt)
+	    (define-key-after setup-language-environment-map (vector parent-symbol)
+	      (cons parent setup-map)))
+	  (setq parents (cdr parents))
+          (set-language-info-setup-keymap lang-env alist (symbol-value describe-map) (symbol-value setup-map))))
+    (set-language-info-setup-keymap lang-env alist
+                                    describe-language-environment-map setup-language-environment-map))
+  (dolist (elt alist)
+    (set-language-info-internal lang-env (car elt) (cdr elt)))
+  (if (equal lang-env current-language-environment)
+      (set-language-environment lang-env)))
 
 (defun read-language-name (key prompt &optional default)
   "Read a language environment name which has information for KEY.
-- 
2.37.3


[-- Attachment #3: 0001-Add-multiple-PARENTs-to-Kharoshthi-and-Gothic-bug-58.patch --]
[-- Type: text/x-patch, Size: 1831 bytes --]

From b6a26326eaf45bd300a2e1ea5886bdf7e09e5224 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0=20=E0=A4=B8=E0=A4=BF?=
 =?UTF-8?q?=E0=A4=82=E0=A4=B9=20Sameer=20Singh?= <lumarzeli30@gmail.com>
Date: Mon, 10 Oct 2022 23:52:24 +0530
Subject: [PATCH] Add multiple PARENTs to Kharoshthi and Gothic (bug#58376)

* lisp/language/misc-lang.el ("Kharoshthi"):
Add "Indian".
* lisp/language/misc-lang.el ("Gothic"):
Add "European".

* lisp/leim/quail/misc-lang.el ("gothic"): Fix typo.
---
 lisp/language/misc-lang.el   | 6 ++++--
 lisp/leim/quail/misc-lang.el | 2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/lisp/language/misc-lang.el b/lisp/language/misc-lang.el
index c34017d9b3..d52f402aca 100644
--- a/lisp/language/misc-lang.el
+++ b/lisp/language/misc-lang.el
@@ -253,7 +253,8 @@ egyptian-shape-grouping
 	        (documentation . "\
 Language environment for Gāndhārī, Sanskrit, and other languages
 using the Kharoṣṭhī script."))
- '("Misc"))
+ '("Misc"
+   "Indian"))
 
 (let ((consonant     "[\U00010A00\U00010A10-\U00010A35]")
       (vowel         "[\U00010A01-\U00010A06]")
@@ -322,7 +323,8 @@ egyptian-shape-grouping
             (documentation . "\
 Ancient Gothic language using the Gothic script is supported in this
 language environment."))
- '("Misc"))
+ '("Misc"
+   "European"))
 
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 ;; Coptic
diff --git a/lisp/leim/quail/misc-lang.el b/lisp/leim/quail/misc-lang.el
index 73287ee784..e9e11ac679 100644
--- a/lisp/leim/quail/misc-lang.el
+++ b/lisp/leim/quail/misc-lang.el
@@ -1526,7 +1526,7 @@
 
 (quail-define-package
  "gothic" "Gothic" "𐌰" nil
- "Input methid for the ancient Gothic script."
+ "Input method for the ancient Gothic script."
  nil t t t t nil nil nil nil nil t)
 
 (quail-define-rules
-- 
2.37.3

bug#58376: [PATCH] Set the PARENTS argument for language environments

[समीर सिंह Sameer Singh]

[-- Attachment #1: Type: text/plain, Size: 4442 bytes --]

Looks like, these patches have not yet been merged, it seems like they were
forgotten among other things,
therefore please install them.

Thanks

On Tue, Oct 11, 2022 at 12:08 AM समीर सिंह Sameer Singh <
lumarzeli30@gmail.com> wrote:

> Thanks, it works this way.
> I have created a patch for you, if the ones provided by you do not apply.
>
> I have also created a separate patch adding multiple PARENTs to Kharoshthi
> and Gothic.
>
> On Mon, Oct 10, 2022 at 9:29 PM Visuwesh <visuweshm@gmail.com> wrote:
>
>> [திங்கள் அக்டோபர் 10, 2022] समीर सिंह Sameer Singh wrote:
>>
>> > This one says: "error: corrupt patch at line 8"
>> >
>> > The previous one said:
>> > error: patch failed: lisp/international/mule-cmds.el:1208
>> > error: lisp/international/mule-cmds.el: patch does not apply
>> >
>>
>> I have no idea why that is the case, and my network connection is too
>> slow to freshly clone the Emacs repo again.  Can you replace the old
>> definition of `set-language-info-alist' with the following two forms
>> instead?
>>
>> (defun set-language-info-setup-keymap (lang-env alist describe-map
>> setup-map)
>>   "Setup menu items for LANG-ENV.
>> See `set-language-info-alist' for details of other arguments."
>>   (let ((doc (assq 'documentation alist)))
>>     (when doc
>>       (define-key-after describe-map (vector (intern lang-env))
>>         (cons lang-env 'describe-specified-language-support))))
>>   (define-key-after setup-map (vector (intern lang-env))
>>     (cons lang-env 'setup-specified-language-environment)))
>>
>> (defun set-language-info-alist (lang-env alist &optional parents)
>>   "Store ALIST as the definition of language environment LANG-ENV.
>> ALIST is an alist of KEY and INFO values.  See the documentation of
>> `language-info-alist' for the meanings of KEY and INFO.
>>
>> Optional arg PARENTS is a list of parent menu names; it specifies
>> where to put this language environment in the
>> Describe Language Environment and Set Language Environment menus.
>> For example, (\"European\") means to put this language environment
>> in the European submenu in each of those two menus."
>>   (cond ((symbolp lang-env)
>>          (setq lang-env (symbol-name lang-env)))
>>         ((stringp lang-env)
>>          (setq lang-env (purecopy lang-env))))
>>   (if parents
>>       (while parents
>>         (let (describe-map setup-map parent-symbol parent prompt)
>>           (if (symbolp (setq parent-symbol (car parents)))
>>               (setq parent (symbol-name parent))
>>             (setq parent parent-symbol parent-symbol (intern parent)))
>>           (setq describe-map (lookup-key
>> describe-language-environment-map (vector parent-symbol)))
>>           ;; This prompt string is for define-prefix-command, so
>>           ;; that the map it creates will be suitable for a menu.
>>           (or describe-map (setq prompt (format "%s Environment" parent)))
>>           (unless describe-map
>>             (setq describe-map (intern (format
>> "describe-%s-environment-map"
>>                                                (downcase parent))))
>>             (define-prefix-command describe-map nil prompt)
>>             (define-key-after describe-language-environment-map (vector
>> parent-symbol)
>>               (cons parent describe-map)))
>>           (setq setup-map (lookup-key setup-language-environment-map
>> (vector parent-symbol)))
>>           (unless setup-map
>>             (setq setup-map (intern (format "setup-%s-environment-map"
>>                                             (downcase parent))))
>>             (define-prefix-command setup-map nil prompt)
>>             (define-key-after setup-language-environment-map (vector
>> parent-symbol)
>>               (cons parent setup-map)))
>>           (setq parents (cdr parents))
>>           (set-language-info-setup-keymap lang-env alist (symbol-value
>> describe-map) (symbol-value setup-map))))
>>     (set-language-info-setup-keymap lang-env alist
>>                                     describe-language-environment-map
>> setup-language-environment-map))
>>   (dolist (elt alist)
>>     (set-language-info-internal lang-env (car elt) (cdr elt)))
>>   (if (equal lang-env current-language-environment)
>>       (set-language-environment lang-env)))
>>
>

[-- Attachment #2: Type: text/html, Size: 5478 bytes --]

bug#58376: [PATCH] Set the PARENTS argument for language environments

[Eli Zaretskii]

> From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> Date: Sun, 30 Oct 2022 13:52:22 +0530
> Cc: 58376@debbugs.gnu.org, Visuwesh <visuweshm@gmail.com>
> 
> Looks like, these patches have not yet been merged, it seems like they were forgotten among other things,
> therefore please install them.

Thanks for the reminder.

However, the second part of those patches makes little sense to me: if
these languages are considered to be part of "Indian" languages, why
leave them in "Misc"?  "Misc" is for languages that have no "parent"
family.

bug#58376: [PATCH] Set the PARENTS argument for language environments

[समीर सिंह Sameer Singh]

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

>
> However, the second part of those patches makes little sense to me: if
> these languages are considered to be part of "Indian" languages, why
> leave them in "Misc"?  "Misc" is for languages that have no "parent"
> family.


Kharoshthi is different from the Brahmic scripts in that it is not derived
from Brahmi but instead from Aramaic.
It was also used in regions not present in modern India.
But it was used to write Indian languages, therefore it made sense to me to
include it in both Indian and Misc.

On Sun, Oct 30, 2022 at 2:13 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> > Date: Sun, 30 Oct 2022 13:52:22 +0530
> > Cc: 58376@debbugs.gnu.org, Visuwesh <visuweshm@gmail.com>
> >
> > Looks like, these patches have not yet been merged, it seems like they
> were forgotten among other things,
> > therefore please install them.
>
> Thanks for the reminder.
>
> However, the second part of those patches makes little sense to me: if
> these languages are considered to be part of "Indian" languages, why
> leave them in "Misc"?  "Misc" is for languages that have no "parent"
> family.
>

[-- Attachment #2: Type: text/html, Size: 1951 bytes --]

bug#58376: [PATCH] Set the PARENTS argument for language environments

[Eli Zaretskii]

> From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> Date: Sun, 30 Oct 2022 15:00:44 +0530
> Cc: 58376@debbugs.gnu.org, visuweshm@gmail.com
> 
>  However, the second part of those patches makes little sense to me: if
>  these languages are considered to be part of "Indian" languages, why
>  leave them in "Misc"?  "Misc" is for languages that have no "parent"
>  family.
> 
> Kharoshthi is different from the Brahmic scripts in that it is not derived from Brahmi but instead from Aramaic.
> It was also used in regions not present in modern India.
> But it was used to write Indian languages, therefore it made sense to me to include it in both Indian and Misc. 

I'm okay with "Indian".  It's "Misc" that I question.  Would it be
okay to have these only in "Indian"?

bug#58376: [PATCH] Set the PARENTS argument for language environments

[समीर सिंह Sameer Singh]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

Yes, that would be okay too.

On Sun, Oct 30, 2022, 3:50 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> > Date: Sun, 30 Oct 2022 15:00:44 +0530
> > Cc: 58376@debbugs.gnu.org, visuweshm@gmail.com
> >
> >  However, the second part of those patches makes little sense to me: if
> >  these languages are considered to be part of "Indian" languages, why
> >  leave them in "Misc"?  "Misc" is for languages that have no "parent"
> >  family.
> >
> > Kharoshthi is different from the Brahmic scripts in that it is not
> derived from Brahmi but instead from Aramaic.
> > It was also used in regions not present in modern India.
> > But it was used to write Indian languages, therefore it made sense to me
> to include it in both Indian and Misc.
>
> I'm okay with "Indian".  It's "Misc" that I question.  Would it be
> okay to have these only in "Indian"?
>

[-- Attachment #2: Type: text/html, Size: 1568 bytes --]

bug#58376: [PATCH] Set the PARENTS argument for language environments

[Eli Zaretskii]

> From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> Date: Sun, 30 Oct 2022 16:01:35 +0530
> Cc: 58376@debbugs.gnu.org, Visuwesh <visuweshm@gmail.com>
> 
> Yes, that would be okay too.

Thanks, done, and closing the bug.

bug#58376: [PATCH] Set the PARENTS argument for language environments

[समीर सिंह Sameer Singh]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

Thanks!

On Sun, Oct 30, 2022, 4:48 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> > Date: Sun, 30 Oct 2022 16:01:35 +0530
> > Cc: 58376@debbugs.gnu.org, Visuwesh <visuweshm@gmail.com>
> >
> > Yes, that would be okay too.
>
> Thanks, done, and closing the bug.
>

[-- Attachment #2: Type: text/html, Size: 861 bytes --]