From: "समीर सिंह Sameer Singh" <lumarzeli30@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 58957@debbugs.gnu.org
Subject: bug#58957: [PATCH] Improve Brahmi composition rules.
Date: Wed, 2 Nov 2022 20:27:42 +0530 [thread overview]
Message-ID: <CAOR1sLwnnq1ADZcEnCCotsngN2a2CqUx3k_y2mXQ9GheohCecA@mail.gmail.com> (raw)
In-Reply-To: <834jvhbkqf.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1360 bytes --]
>
> Should we perhaps introduce tests for compositions? For example, I
> guess you found the problems with the current rules by examining the
> display of some sequences of characters, so why not add a test that
> would make sure we never again break those composable sequences?
Yes, that would be a good idea.
How should I start? Are there some pre-existing examples that checks for
composition,
or even a manual that describes how to write a test?
Thanks
On Wed, Nov 2, 2022 at 6:02 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: समीर सिंह Sameer Singh
> > <lumarzeli30@gmail.com>
> > Date: Wed, 2 Nov 2022 08:14:09 +0530
> >
> > On Wed, Nov 2, 2022 at 8:12 AM समीर सिंह Sameer Singh <
> lumarzeli30@gmail.com> wrote:
> >
> > The present composition rules for Brahmi have a bug where the virama is
> not composed with the
> > consonants, I have fixed that now. I have also added support for
> composing velar and bilabial fricatives in
> > Brahmi.
> >
> > Please review the patch.
>
> Thanks.
>
> Should we perhaps introduce tests for compositions? For example, I
> guess you found the problems with the current rules by examining the
> display of some sequences of characters, so why not add a test that
> would make sure we never again break those composable sequences?
>
[-- Attachment #2: Type: text/html, Size: 2029 bytes --]
next prev parent reply other threads:[~2022-11-02 14:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 2:41 bug#58957: [PATCH] Improve Brahmi composition rules समीर सिंह Sameer Singh
2022-11-02 2:44 ` समीर सिंह Sameer Singh
2022-11-02 12:32 ` Eli Zaretskii
2022-11-02 14:57 ` समीर सिंह Sameer Singh [this message]
2022-11-24 19:40 ` Stefan Kangas
2022-12-11 10:39 ` Eli Zaretskii
2022-12-14 14:48 ` समीर सिंह Sameer Singh
2022-12-14 21:42 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOR1sLwnnq1ADZcEnCCotsngN2a2CqUx3k_y2mXQ9GheohCecA@mail.gmail.com \
--to=lumarzeli30@gmail.com \
--cc=58957@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.