From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0_?= =?UTF-8?Q?=E0=A4=B8=E0=A4=BF=E0=A4=82=E0=A4=B9?= Sameer Singh Newsgroups: gmane.emacs.bugs Subject: bug#55970: 29.0.50; Emacs crashes when dragging the scroll bar with "--with-pgtk" and "--without-toolkit-scroll-bars" configure flags Date: Wed, 15 Jun 2022 13:53:40 +0530 Message-ID: References: <83v8t3rvh7.fsf@gnu.org> <83sfo7rtc4.fsf@gnu.org> <83o7yvrshd.fsf@gnu.org> <87h74m91xz.fsf@yahoo.com> <83k09islqu.fsf@gnu.org> <87bkuu8uzw.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000c0277805e1783de0" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4842"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55970@debbugs.gnu.org, Eli Zaretskii To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 15 10:43:46 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1Ocs-0000xS-H8 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jun 2022 10:43:46 +0200 Original-Received: from localhost ([::1]:57142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1Ocr-0005vz-00 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jun 2022 04:43:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1OKm-0005U7-8N for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2022 04:25:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42551) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o1OKk-0000ZW-IR for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2022 04:25:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o1OKk-0005SK-BN for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2022 04:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0_?= =?UTF-8?Q?=E0=A4=B8=E0=A4=BF=E0=A4=82=E0=A4=B9?= Sameer Singh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jun 2022 08:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55970 X-GNU-PR-Package: emacs Original-Received: via spool by 55970-submit@debbugs.gnu.org id=B55970.165528144520902 (code B ref 55970); Wed, 15 Jun 2022 08:25:02 +0000 Original-Received: (at 55970) by debbugs.gnu.org; 15 Jun 2022 08:24:05 +0000 Original-Received: from localhost ([127.0.0.1]:36448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1OJm-0005R0-Dd for submit@debbugs.gnu.org; Wed, 15 Jun 2022 04:24:05 -0400 Original-Received: from mail-qk1-f172.google.com ([209.85.222.172]:33565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1OJh-0005QT-J7 for 55970@debbugs.gnu.org; Wed, 15 Jun 2022 04:24:01 -0400 Original-Received: by mail-qk1-f172.google.com with SMTP id d23so8244731qke.0 for <55970@debbugs.gnu.org>; Wed, 15 Jun 2022 01:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2boUFHPZXxOVsCT1mJ+pYgjb3MJze/D14KE+WlvdpEQ=; b=gad9i6pRqziXawEClWyuhSjSyEi0uBWeG7/Myego4ZEio+c2+exsExxn7I/VBKLedo 4IGc/HvK76bbdhP+KcQKbXjZR4BOegKEd939znt2XfgMgeZMfhjVc7g8GuDoUOyxdyZv PS38uvxLgIdVCxX3TF3fMLtyHYfppT5myYZB1usrNVxRNjuoc8I8iQZSvwRBAR/daUsN Sd7lE5Xz0orIBV0xGg7cH1MVHMnkDL8KcZiQe10OHsM07xteyvbo/GRAXLRZidU/xjau Yu5HtnxxhaQAiALuy7K25ky2pC5iuNtZBLzYM15cmPR4xyP2niGcdD01MBgBChXbWFur E03w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2boUFHPZXxOVsCT1mJ+pYgjb3MJze/D14KE+WlvdpEQ=; b=enbex38KVvKjGjecoJDwfnMJrVITEykdaQ4co+qxl/UiXKUBvlnZliwzAyyRVfWGLX B0mtKZigLZTsiIBDQNVxlSwyfUsvuuxGcqr0xy+Gi1PGgUyQfhhGnb8ziN8B1aJWIo07 K8APNLeMFT9y5ZwCNEbyJoVlVw+m70FKMqHHuHKxndSU3luftYbO/HFpeekcKb3xHM4Z yz1txaWQi2zdW0fBhqwkbH35YIvEpmu6KKvB31L5CF22N0TTMBLI58MNhL5jVCFK/btC xdBCt75/s7ioZ7nVVLOXpXI2bqozakTwNe9H2h6q8ZCZ02T60X+bRiOEQIjRNtbsxFjb CoQg== X-Gm-Message-State: AOAM533AalO5rOnrPxEPGRXyqSHf0Sjc0gez/DcL/Or1mJg7kx98RgEI oAHNuJB1v/B/aqYpY/o5g25qME9vg0cmN5UWkKfyJHLLrSs= X-Google-Smtp-Source: ABdhPJxzr6DIU1uPGaCKxDqhMxPjIOa9g1i0EeX5nIKKzjTNsAselXgJd1U8GLDfI8KDMFTkRxw7zESVyaJZ6Qxh1OY= X-Received: by 2002:a37:e202:0:b0:6a6:ab87:113d with SMTP id g2-20020a37e202000000b006a6ab87113dmr7135581qki.605.1655281431879; Wed, 15 Jun 2022 01:23:51 -0700 (PDT) In-Reply-To: <87bkuu8uzw.fsf@yahoo.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234559 Archived-At: --000000000000c0277805e1783de0 Content-Type: text/plain; charset="UTF-8" > > Non-toolkit scroll bars use different kinds of events compared to > toolkit scroll bars. PGTK only implements the latter kind, so turning > toolkit scroll bars off should trigger this piece of configure.ac: > > elif test "${window_system}" != "x11" && "${window_system}" != "none"; > then > AC_MSG_ERROR(Non-toolkit scroll bars are not implemented for your > system) > fi > > Perhaps Sameer's configure script is out of date and needs to be > regenerated. > I cloned a fresh copy and configured it with the same flags, but still there was no error, even though my configure.ac has the same lines. AH_TEMPLATE(USE_TOOLKIT_SCROLL_BARS, [Define to 1 if we should use toolkit scroll bars.])dnl USE_TOOLKIT_SCROLL_BARS=no if test "${with_toolkit_scroll_bars}" != "no"; then if test "${USE_X_TOOLKIT}" != "none"; then if test "${USE_X_TOOLKIT}" = "MOTIF"; then AC_DEFINE(USE_TOOLKIT_SCROLL_BARS) HAVE_XAW3D=no USE_TOOLKIT_SCROLL_BARS=yes elif test "${HAVE_XAW3D}" = "yes" || test "${USE_X_TOOLKIT}" = "LUCID"; then AC_DEFINE(USE_TOOLKIT_SCROLL_BARS) USE_TOOLKIT_SCROLL_BARS=yes fi elif test "${HAVE_GTK}" = "yes"; then AC_DEFINE(USE_TOOLKIT_SCROLL_BARS) USE_TOOLKIT_SCROLL_BARS=yes elif test "${HAVE_NS}" = "yes"; then AC_DEFINE(USE_TOOLKIT_SCROLL_BARS) USE_TOOLKIT_SCROLL_BARS=yes elif test "${HAVE_W32}" = "yes"; then AC_DEFINE(USE_TOOLKIT_SCROLL_BARS) USE_TOOLKIT_SCROLL_BARS=yes elif test "${HAVE_BE_APP}" = "yes"; then AC_DEFINE(USE_TOOLKIT_SCROLL_BARS) USE_TOOLKIT_SCROLL_BARS=yes fi elif test "${window_system}" != "x11" && "${window_system}" != "none"; then AC_MSG_ERROR(Non-toolkit scroll bars are not implemented for your system) fi On Wed, Jun 15, 2022 at 8:59 AM Po Lu wrote: > Eli Zaretskii writes: > > > OK, but please explain how come the code in pgtk_send_scroll_bar_event > > leaves the modifiers unset, and that is still OK, notwithstanding the > > code in keyboard.c that expects either up or down modifier for any > > mouse click event? Isn't that a bug regardless? > > The mouse click code that expects an up or down modifier is only used > for scroll bar events when USE_TOOLKIT_SCROLL_BARS isn't defined. The > code actually used with toolkit scroll bars starts at line 6359 of > keyboard.c. > --000000000000c0277805e1783de0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Non= -toolkit scroll bars use different kinds of events compared to
toolkit scroll bars.=C2=A0 PGTK only implements the latter kind, so turning=
toolkit scroll bars off should trigger this piece of configure.ac:

=C2=A0 elif test "${window_system}" !=3D "x11" &&am= p; "${window_system}" !=3D "none"; then
=C2=A0 =C2=A0 AC_MSG_ERROR(Non-toolkit scroll bars are not implemented for = your system)
=C2=A0 fi

Perhaps Sameer's configure script is out of date and needs to be
regenerated.

I cloned a fresh copy an= d configured it with the same flags, but still there was no error,
even though my configure.ac has the s= ame lines.

AH_TEMPLATE(USE_TOOLKIT_SCROLL_BARS, =C2=A0 =C2=A0[Define to 1 if we should use toolkit scroll bars.])dnl
= USE_TOOLKIT_SCROLL_BARS=3Dno
if test "${with_toolkit_scroll_bars}&q= uot; !=3D "no"; then
=C2=A0 if test "${USE_X_TOOLKIT}&quo= t; !=3D "none"; then
=C2=A0 =C2=A0 if test "${USE_X_TOOLK= IT}" =3D "MOTIF"; then
=C2=A0 =C2=A0 =C2=A0 AC_DEFINE(USE= _TOOLKIT_SCROLL_BARS)
=C2=A0 =C2=A0 =C2=A0 HAVE_XAW3D=3Dno
=C2=A0 =C2= =A0 =C2=A0 USE_TOOLKIT_SCROLL_BARS=3Dyes
=C2=A0 =C2=A0 elif test "$= {HAVE_XAW3D}" =3D "yes" || test "${USE_X_TOOLKIT}"= =3D "LUCID"; then
=C2=A0 =C2=A0 =C2=A0 AC_DEFINE(USE_TOOLKIT_= SCROLL_BARS)
=C2=A0 =C2=A0 =C2=A0 USE_TOOLKIT_SCROLL_BARS=3Dyes
=C2= =A0 =C2=A0 fi
=C2=A0 elif test "${HAVE_GTK}" =3D "yes&quo= t;; then
=C2=A0 =C2=A0 AC_DEFINE(USE_TOOLKIT_SCROLL_BARS)
=C2=A0 =C2= =A0 USE_TOOLKIT_SCROLL_BARS=3Dyes
=C2=A0 elif test "${HAVE_NS}"= ; =3D "yes"; then
=C2=A0 =C2=A0 AC_DEFINE(USE_TOOLKIT_SCROLL_B= ARS)
=C2=A0 =C2=A0 USE_TOOLKIT_SCROLL_BARS=3Dyes
=C2=A0 elif test &qu= ot;${HAVE_W32}" =3D "yes"; then
=C2=A0 =C2=A0 AC_DEFINE(U= SE_TOOLKIT_SCROLL_BARS)
=C2=A0 =C2=A0 USE_TOOLKIT_SCROLL_BARS=3Dyes
= =C2=A0 elif test "${HAVE_BE_APP}" =3D "yes"; then
= =C2=A0 =C2=A0 AC_DEFINE(USE_TOOLKIT_SCROLL_BARS)
=C2=A0 =C2=A0 USE_TOOLK= IT_SCROLL_BARS=3Dyes
=C2=A0 fi
elif test "${window_system}"= !=3D "x11" && "${window_system}" !=3D "no= ne"; then
=C2=A0 AC_MSG_ERROR(Non-toolkit scroll bars are not imple= mented for your system)
fi

On Wed, Jun 15, 2022 at 8:59 AM Po Lu &l= t;luangruo@yahoo.com> wrote:
Eli Zaretskii <= ;eliz@gnu.org> wri= tes:

> OK, but please explain how come the code in pgtk_send_scroll_bar_event=
> leaves the modifiers unset, and that is still OK, notwithstanding the<= br> > code in keyboard.c that expects either up or down modifier for any
> mouse click event?=C2=A0 Isn't that a bug regardless?

The mouse click code that expects an up or down modifier is only used
for scroll bar events when USE_TOOLKIT_SCROLL_BARS isn't defined.=C2=A0= The
code actually used with toolkit scroll bars starts at line 6359 of
keyboard.c.
--000000000000c0277805e1783de0--