From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mitchell Newsgroups: gmane.emacs.bugs Subject: bug#71644: 30.0.50; Severe slowdown in larger files with markers beginning in emacs 29+ Date: Sat, 22 Jun 2024 12:03:05 -0600 Message-ID: References: <86ed8tozub.fsf@gnu.org> <86jzijmo5a.fsf@gnu.org> <86y16ylrj9.fsf@gnu.org> <86ed8pjwgc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000052192f061b7e5e3b" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4978"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , 71644@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 22 20:05:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sL56u-00013C-51 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Jun 2024 20:05:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sL56l-0000g1-RH; Sat, 22 Jun 2024 14:05:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sL56k-0000fj-FZ for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 14:05:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sL56k-0007l3-4F for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 14:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sL56j-0006pP-Mj for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 14:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mitchell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jun 2024 18:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71644 X-GNU-PR-Package: emacs Original-Received: via spool by 71644-submit@debbugs.gnu.org id=B71644.171907949126216 (code B ref 71644); Sat, 22 Jun 2024 18:05:01 +0000 Original-Received: (at 71644) by debbugs.gnu.org; 22 Jun 2024 18:04:51 +0000 Original-Received: from localhost ([127.0.0.1]:54946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL56Y-0006oj-Lx for submit@debbugs.gnu.org; Sat, 22 Jun 2024 14:04:51 -0400 Original-Received: from mail-ed1-f51.google.com ([209.85.208.51]:50687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL56W-0006oM-L8 for 71644@debbugs.gnu.org; Sat, 22 Jun 2024 14:04:49 -0400 Original-Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-57cb9a370ddso3408778a12.1 for <71644@debbugs.gnu.org>; Sat, 22 Jun 2024 11:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719079423; x=1719684223; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=su6aDWKFkbQ8+hu0mQki+XFaWw+x3OMrKWBvARUph0E=; b=Bhoays4B6HZupUdsrkfWjPvcF+WmrpF6urmW8RILAur3i7tqOHU27djF17ZOOWDRzC I02UWr+yYexrw+y5Q+P7EdVsDXvF6eqjXQvayeI5+fmzP56fgSjS7c4DkZANCSGlrIk+ d6i1YJ6YBKBtysm9vTKKPX5wwp50Y/AtiHGN+4AEZzOIOasVmBBwJkpK5dzyXSrzqcqG fraOxcXe2f3JQOsEjQAYhTCavRM5d/W4AiQ/WPrVOxKWahA4VwtAaIkLJYLGPrztQWv4 um+KDR/MCe92qtN5x46r8c1lvR41JKGyXJbzfKgVvhyc+DAi0Jm6Vtd9UfeVdZ1qAv5E ihrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719079423; x=1719684223; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=su6aDWKFkbQ8+hu0mQki+XFaWw+x3OMrKWBvARUph0E=; b=s7+mU4HoePgziln+cqtJsT/Gma8qCsLaIIAG4H8uwXzfJgkccdmH0n5R+7wnf/tQFU ztVp7X6K/hWcbn9gKnMo/Hjpgdckm1mOaZnZFM0R1Rvc9R/S7x2CnTnNE8DutWmGdE2Z n+c9/5sDS6tQ3rbXwUC6/69hJYK157HUxUM6LUS0tPY48XMpMihY8OPDCB5grDtvXO0v CbcWK6soYjAN9Vp8WBeB1bNm2/fcJbnhq3Y4zUTsIzSiojoaHkrAfTeTqS9s+IjT7M5o i6F1buW1cUCRenCrb4s1G69bZo1I0U0tJaBdMY5H6JA7PhhC2hos1YGPIHtj27vvdhHe eDmw== X-Forwarded-Encrypted: i=1; AJvYcCWq7dZg4p683su2NLiuJarXFl4MST48AN6LMAQWZAe+eJ7cZN4mLwqXDstMQ+rDAko5bEyJA3H0K+c7uaQZ2JQfXZYdq/s= X-Gm-Message-State: AOJu0Ywl2gfreP0VgN4jrFbRx8Il8ve2y1AqrjXHTDOxJh8h/lCf9aYN vwQdTIAKLwhf6Y1z39L8hu2SeRLaRTpnGiQI5obkDR9nnPHtjOsY9YszsegShE9bfFyC1GX7l6q JIA0fdz/fd+QcgYbQd/twDU9BF/o= X-Google-Smtp-Source: AGHT+IF2OHdHNTh2KkH7ti1SD+yR80Zp0IUlRCxYJGdHjf2ozpPWtJMP+jT4/c7mjJ+8sRmsTPSG4DnI+ZJ9sZOAbN0= X-Received: by 2002:a50:c04f:0:b0:57d:3791:e8e4 with SMTP id 4fb4d7f45d1cf-57d4bdcad8dmr345923a12.32.1719079422529; Sat, 22 Jun 2024 11:03:42 -0700 (PDT) In-Reply-To: <86ed8pjwgc.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287727 Archived-At: --00000000000052192f061b7e5e3b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Jun 22, 2024 at 12:58=E2=80=AFAM Eli Zaretskii wrote= : > > > From: Stefan Monnier > > > Cc: Mitchell , 71644@debbugs.gnu.org > > > Date: Fri, 21 Jun 2024 17:06:31 -0400 > > > > > > > commit 8783700b23e70874c4996908bf02c010ae6f3fe1 > > > > Author: Stefan Monnier > > > > AuthorDate: Tue Aug 2 10:38:53 2022 -0400 > > > > Commit: Stefan Monnier > > > > CommitDate: Tue Aug 2 13:06:51 2022 -0400 > > > > > > > > * src/xdisp.c (redisplay_window): Use BEG rather than hard > coding 1 > > > > > > > > It changed the comparison operator in two places in marker.c. > > > > > > > > Curiously, the log message doesn't even mention the change in > > > > marker.c, which could be a sign that this change was not intended t= o > > > > be installed. Stefan, did you intend to install it, and if so, do > you > > > > have any comments about this bug report? > > > > > > Hmm... can't remember why/how it ended up in the above commit. > > > Looks like an oversight. But the change should be harmless: the > > > `eassert` should make sure that the comparison gives the same answer > > > either way (and AFAICT if/when the new comparison gives a different > > > answer from the old code, the old code will loop until it segfaults). > > > > Mitchell, can you try reverting that change, and see if that affects > > performance in your case? > Eli, after Ihor and Stefan were able to reproduce it now, would it still be helpful for me to do this and report back? I=E2=80=99m more than happy to i= f it would help in any way. Also should I be replying to the renamed thread from now on? (i.e., "chars=3D=3Dbytes (was: bug#71644: 30.0.50; Severe slowdown in larger files with markers beginning in emacs 29+") This is my first bug report, so I=E2= =80=99m not sure the etiquette, haha. --00000000000052192f061b7e5e3b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Jun 22, 2024 at 12:58=E2=80=AFAM Eli Zaretskii <eliz@gnu.org> wrote:
<= /div>
>=20 > From: Stefan Monnier <monnier@iro.umontreal.ca>
>=20 > Cc: Mitchell <mitchellahren@gmail.com>,=C2=A0 71644@debbugs.gnu.org
>=20 > Date: Fri, 21 Jun 2024 17:06:31 -0400
>=20 >
>=20 > >=C2=A0 =C2=A0commit 8783700b23e70874c4996908bf02c010ae6f3fe1
>=20 > >=C2=A0 =C2=A0Author:=C2=A0 =C2=A0 =C2=A0Stefan Monnier <monnier@iro.umontrea= l.ca>
>=20 > >=C2=A0 =C2=A0AuthorDate: Tue Aug 2 10:38:53 2022 -0400
>=20 > >=C2=A0 =C2=A0Commit:=C2=A0 =C2=A0 =C2=A0Stefan Monnier <monnier@iro.umontrea= l.ca>
>=20 > >=C2=A0 =C2=A0CommitDate: Tue Aug 2 13:06:51 2022 -0400
>=20 > >
>=20 > >=C2=A0 =C2=A0 =C2=A0 =C2=A0* src/xdisp.c (redisplay_window): Use B= EG rather than hard coding 1
>=20 > >
>=20 > > It changed the comparison operator in two places in marker.c.
>=20 > >
>=20 > > Curiously, the log message doesn't even mention the change in=
>=20 > > marker.c, which could be a sign that this change was not intended= to
>=20 > > be installed.=C2=A0 Stefan, did you intend to install it, and if = so, do you
>=20 > > have any comments about this bug report?
>=20 >
>=20 > Hmm... can't remember why/how it ended up in the above commit.
>=20 > Looks like an oversight.=C2=A0 But the change should be harmless: the<= br> >=20 > `eassert` should make sure that the comparison gives the same answer >=20 > either way (and AFAICT if/when the new comparison gives a different >=20 > answer from the old code, the old code will loop until it segfaults).<= br> >=20
>=20 Mitchell, can you try reverting that change, and see if that affects
>=20 performance in your case?

Eli, after Ihor and Stefan were able to reproduce it now, would = it still be helpful for me to do this and report back? I=E2=80=99m more than happy = to=20 if it would help in any way.

Also should I be= replying to the renamed thread from now on? (i.e., "chars=3D=3Dbytes = (was: bug#71644: 30.0.50; Severe slowdown in larger files with markers begi= nning in emacs 29+") This is my first bug report, so I=E2=80=99m not s= ure the etiquette, haha.
=C2=A0
--00000000000052192f061b7e5e3b--