From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Liu Hui Newsgroups: gmane.emacs.bugs Subject: bug#62413: 29.0.60; [PATCH] save-place-mode cannot restore saved position Date: Tue, 28 Mar 2023 13:56:05 +0800 Message-ID: References: <83tty9caku.fsf@gnu.org> <83y1nkc3vc.fsf@gnu.org> <83zg809jgv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10673"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62413@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 28 07:57:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ph2Ki-0002SP-LL for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Mar 2023 07:57:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ph2KP-0002dQ-RD; Tue, 28 Mar 2023 01:57:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ph2KO-0002d4-9e for bug-gnu-emacs@gnu.org; Tue, 28 Mar 2023 01:57:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ph2KM-0006wW-C5 for bug-gnu-emacs@gnu.org; Tue, 28 Mar 2023 01:57:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ph2KL-0000GY-Tt for bug-gnu-emacs@gnu.org; Tue, 28 Mar 2023 01:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Liu Hui Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Mar 2023 05:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62413 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62413-submit@debbugs.gnu.org id=B62413.1679982986971 (code B ref 62413); Tue, 28 Mar 2023 05:57:01 +0000 Original-Received: (at 62413) by debbugs.gnu.org; 28 Mar 2023 05:56:26 +0000 Original-Received: from localhost ([127.0.0.1]:48674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ph2Jm-0000Fa-0k for submit@debbugs.gnu.org; Tue, 28 Mar 2023 01:56:26 -0400 Original-Received: from mail-oo1-f46.google.com ([209.85.161.46]:45714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ph2Jj-0000FM-AZ for 62413@debbugs.gnu.org; Tue, 28 Mar 2023 01:56:24 -0400 Original-Received: by mail-oo1-f46.google.com with SMTP id f24-20020a4aeb18000000b0053b78077c9dso1711051ooj.12 for <62413@debbugs.gnu.org>; Mon, 27 Mar 2023 22:56:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679982977; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yJk3zVEwRxasq0gsoXnFfiJSV9GQciWG4MXbQ1IJyJo=; b=hxnJ4xTeuLrL2CrlQUG24I2HXPa0G/xKzg1jwHBJJaBfraZeMVZdxBSDflEeiGcTzu jotma9ukiTaoknBedC+9bRkO9Z1wVHpX3snWwUOoUr4c003bQg9uM6gNjCUmov77T5/1 i4Falu/BUJtFQfRbDB8jR2bB8Noq8tGGGjDroRqzWNeB/BXuND5CiopLv1+Lzlna78MD KQDqOpfNbAupZWHP5kfcmOz+30wkSVjeme7RPpgtITSJoBxG/Fvj1Q3uJ2pLbqN8Zcxe JXm4Ce+iGMNiJ9YmB1nlzaHECvIxpS7t0a2GyPlcDdoEbHtz69X9gvSpERiAYML/x9Uw kHRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679982977; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yJk3zVEwRxasq0gsoXnFfiJSV9GQciWG4MXbQ1IJyJo=; b=5o0gnLJH0zi5jqWN1AVPg0cVFxjP96B1H/MaA0YLrLElzrPhrw5AtQDG1PotyUG4N2 WQ5qKtG9JTCo9b15b4U3HECjZ17hhRhrQsMG68pJKvcg405KQmqZfyiFc8VAKjDvaCxI uTz4BmFryemIQVzWc2oJgGWoEKfQfR6U/Rn2zL1kHTwxdwziJPVGwXtyL5JMcHKhvK7M gYJAx05vcO/WbcAH1jqDJ+1234CojHlUKK/j5NXY4VyGx3GGk6dUjRar8O2dYV9pa5i4 q47/uEfY4v0MlOOnxMRPS/lcV+BTi6Bdclz6IAEGPtN00c365oxt2+YW20yJUcpvT2Ml U39w== X-Gm-Message-State: AO0yUKWIqzPsfyF/Os8cJWR2h66Ib6+dy7ZnNeC0OOAVbQ5TG/XPxWjV Yflk1pk+26v5CrbhBCrIaIKs3fIzhvpY7ou3o6A= X-Google-Smtp-Source: AK7set8LWlcMZaqz0eEvkOSqfb/+S0aK0kT/2fB5UTaV1Z6kvWXIfaqUhyfsmlIEtUrWZbAlj1LQwVQYsLKJJvBUo8E= X-Received: by 2002:a4a:ddd6:0:b0:53b:4b20:b0a7 with SMTP id i22-20020a4addd6000000b0053b4b20b0a7mr4138484oov.1.1679982977495; Mon, 27 Mar 2023 22:56:17 -0700 (PDT) In-Reply-To: <83zg809jgv.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258778 Archived-At: Eli Zaretskii =E4=BA=8E2023=E5=B9=B43=E6=9C=8826=E6=97=A5=E5= =91=A8=E6=97=A5 13:20=E5=86=99=E9=81=93=EF=BC=9A > Ugh! This feature was not thought out well enough when it was > introduced: if the user changes the value half-way through a session, > the history will record visited files twice, under 2 different > file-name formats and with different places recorded. I think > changing the value of save-place-abbreviate-file-names should rewrite > the entire alist in the selected format. I agree that it is better to avoid mixed file name formats, and then save-place-find-file-hook can be fixed simply. The difficult part is how to rewrite save-place-alist automatically. Otherwise users need to convert the format of file names manually, which, I think, is also acceptable.