all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: daniel sutton <danielsutton01@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel <emacs-devel@gnu.org>, Yuri Khan <yuri.v.khan@gmail.com>
Subject: Re: [ELPA] New Package: resize-mode
Date: Sun, 22 Nov 2015 09:52:31 -0600	[thread overview]
Message-ID: <CAOLS0DOM3kmG8F8XnmjApRkhu_ns7HbLQ0JfaRfCDiE68_O5pQ@mail.gmail.com> (raw)
In-Reply-To: <8337vy3v9k.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]

> Why is it called `background-face' if it only sets the foreground?
I was following the style of ace-window as I am new to this. I will update
that.

> Really small nitpick, but this would read better as a cond. (And that
> progn is redundant).
Totally agree

> Is there a reason why this is done like this? Why not just set this
> value inside the defvar?
I was adding things to this and defvar only sets it if it is unbound. I
figured since this is so easy to read and simple, people might add their
own and eval the buffer. This makes it trivial to add more options.

> besides, this package is not a mode.
Totally agree. My thinking drastically changed as I went.

Thanks so much for taking the time to look at my code.

In the elpa wiki it mentioned that if you don't have push rights your code
will be added by someone else after two days. I have an account on Savannah
but I'm I never saw if this includes push rights to elpa, although I would
assume not. Does anyone know what further steps I will need to take?
dan

On Sun, Nov 22, 2015 at 9:32 AM, Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Yuri Khan <yuri.v.khan@gmail.com>
> > Date: Sun, 22 Nov 2015 10:14:05 +0600
> > Cc: emacs-devel <emacs-devel@gnu.org>
> >
> > This might benefit from also binding [Shift+]arrow keys as well.
>
> Which IMO should allow pixel-granular resizing.
>

[-- Attachment #2: Type: text/html, Size: 2778 bytes --]

  reply	other threads:[~2015-11-22 15:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-22  3:56 [ELPA] New Package: resize-mode daniel sutton
2015-11-22  4:14 ` Yuri Khan
2015-11-22 15:32   ` Eli Zaretskii
2015-11-22 15:52     ` daniel sutton [this message]
2015-11-22 19:38       ` Artur Malabarba
2015-11-22 20:14         ` daniel sutton
2015-11-22 20:32           ` Artur Malabarba
2015-11-22  5:19 ` John Wiegley
2015-11-22 12:22 ` Artur Malabarba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOLS0DOM3kmG8F8XnmjApRkhu_ns7HbLQ0JfaRfCDiE68_O5pQ@mail.gmail.com \
    --to=danielsutton01@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=yuri.v.khan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.