From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mitchel Humpherys Newsgroups: gmane.emacs.devel Subject: Re: PATCH: vc-git-grep: force git-grep to disable color and pager Date: Wed, 25 Sep 2013 22:17:34 -0700 Message-ID: References: <52431897.5030104@lanl.gov> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=089e013cbfea04b4ec04e7427ec8 X-Trace: ger.gmane.org 1380172685 22099 80.91.229.3 (26 Sep 2013 05:18:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 26 Sep 2013 05:18:05 +0000 (UTC) Cc: emacs-devel@gnu.org To: Davis Herring Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 26 07:18:09 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VP3xh-0003w8-Kd for ged-emacs-devel@m.gmane.org; Thu, 26 Sep 2013 07:18:01 +0200 Original-Received: from localhost ([::1]:56214 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VP3xh-0005p8-3z for ged-emacs-devel@m.gmane.org; Thu, 26 Sep 2013 01:18:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34731) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VP3xd-0005oz-2w for emacs-devel@gnu.org; Thu, 26 Sep 2013 01:17:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VP3xc-0008TV-0n for emacs-devel@gnu.org; Thu, 26 Sep 2013 01:17:57 -0400 Original-Received: from mail-wg0-x22c.google.com ([2a00:1450:400c:c00::22c]:33811) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VP3xb-0008TC-Mc for emacs-devel@gnu.org; Thu, 26 Sep 2013 01:17:55 -0400 Original-Received: by mail-wg0-f44.google.com with SMTP id b13so589764wgh.11 for ; Wed, 25 Sep 2013 22:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=ja87/p6l5b3lkT3Lu/UDPvrQksBDjszvqLfZLCamPwA=; b=h1xS77fOHPKZqPK+KZgp2Pe61M7e5m24ObPiHL2cZnl34L8Aop6/ljZnZWi5KgaMVb aJfzFxAYo+Ie0+Fg6KATVF5R1fXXLj2Tib7Fdb/Tj77amX2iPtZSpFGHjcO75QTFdaMd +kgMcxCyNivZDJWeBKdmAFCnXutrkK/AGD3NS2np399IXABlnx7fmzD/NZ2jFsoQ/INo yadd8S3Ea08vTEJOhcTFIgtOuykn8FSdg2uoJASYFH/OJFdPwKbKhuG+fTJyJ7BqkCiI pZPjukzTrD1LevyckztaddfRJXJ7jsSR215uK1JFkFQVFwxGald6ig/eOIhho/WgNMx3 rHPA== X-Received: by 10.194.176.163 with SMTP id cj3mr30169389wjc.8.1380172674936; Wed, 25 Sep 2013 22:17:54 -0700 (PDT) Original-Received: by 10.194.56.232 with HTTP; Wed, 25 Sep 2013 22:17:34 -0700 (PDT) In-Reply-To: <52431897.5030104@lanl.gov> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163649 Archived-At: --089e013cbfea04b4ec04e7427ec8 Content-Type: text/plain; charset=ISO-8859-1 On Wed, Sep 25, 2013 at 10:08 AM, Davis Herring wrote: >> This commit adds some command line options to the invocation of `git' >> in `vc-git-grep' so that git disables all coloring and paging. Without >> this, I get a warning about my "terminal" not being fully functional >> and git-grep attempts to use a pager (which means the git-grep process >> never finishes): >> >> git grep -n -e stuff -- * >> WARNING: terminal is not fully functional >> CREDITS:14:D: Alpha systems hacking, IPv6 and other network related stuff >> >> : <-- pager waiting for me to do something > > All this (including the warning) is the use of less, not the coloring > (although git might in theory complain if you try to use coloring with > no TERM variable or so). I'd recommend using --no-pager but trying to > interpret the color rather than suppressing it. > > Davis > You're absolutely right. I've removed the --no-color flag in this version and confirmed that highlighting works in the *grep* results buffer. Thanks, Mitch -- "if i had more time i would have written a shorter letter." --Pascal --089e013cbfea04b4ec04e7427ec8 Content-Type: text/plain; charset=US-ASCII; name="vc-git-grep-V2.txt" Content-Disposition: attachment; filename="vc-git-grep-V2.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hm1j4rkm0 IyBCYXphYXIgbWVyZ2UgZGlyZWN0aXZlIGZvcm1hdCAyIChCYXphYXIgMC45MCkKIyByZXZpc2lv bl9pZDogbWl0Y2guc3BlY2lhbEBnbWFpbC5jb20tMjAxMzA5MjYwNTEzMTUtdDFzenQxMDJ3YmRh a2p3YgojIHRhcmdldF9icmFuY2g6IGJ6cjovL2J6ci5zYXZhbm5haC5nbnUub3JnL2VtYWNzL3Ry dW5rLwojIHRlc3RhbWVudF9zaGExOiBkNWExZDE0Y2ZhNzRkNWM3NzdmZGNhNjYzMDUxYjdhY2Jk ZTA4MTVkCiMgdGltZXN0YW1wOiAyMDEzLTA5LTI1IDIyOjE1OjMyIC0wNzAwCiMgYmFzZV9yZXZp c2lvbl9pZDogZWdnZXJ0QGNzLnVjbGEuZWR1LTIwMTMwOTI1MDM0NDM0LXdid2Y4Y2h3ZzB0ajV3 NDAKIyAKIyBCZWdpbiBwYXRjaAo9PT0gbW9kaWZpZWQgZmlsZSAnbGlzcC92Yy92Yy1naXQuZWwn Ci0tLSBsaXNwL3ZjL3ZjLWdpdC5lbAkyMDEzLTA5LTEyIDA1OjQ1OjQyICswMDAwCisrKyBsaXNw L3ZjL3ZjLWdpdC5lbAkyMDEzLTA5LTI2IDA1OjEzOjE1ICswMDAwCkBAIC0xMDgyLDcgKzEwODIs NyBAQAogCSAgICAgIChzZXRxIGNvbW1hbmQgbmlsKSkKIAkoc2V0cSBkaXIgKGZpbGUtbmFtZS1h cy1kaXJlY3RvcnkgKGV4cGFuZC1maWxlLW5hbWUgZGlyKSkpCiAJKHNldHEgY29tbWFuZAotCSAg ICAgIChncmVwLWV4cGFuZC10ZW1wbGF0ZSAiZ2l0IGdyZXAgLW4gLWUgPFI+IC0tIDxGPiIKKwkg ICAgICAoZ3JlcC1leHBhbmQtdGVtcGxhdGUgImdpdCAtLW5vLXBhZ2VyIGdyZXAgLW4gLWUgPFI+ IC0tIDxGPiIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZ2V4cCBmaWxl cykpCiAJKHdoZW4gY29tbWFuZAogCSAgKGlmIChlcXVhbCBjdXJyZW50LXByZWZpeC1hcmcgJyg0 KSkKCiMgQmVnaW4gYnVuZGxlCkl5QkNZWHBoWVhJZ2NtVjJhWE5wYjI0Z1luVnVaR3hsSUhZMENp TUtRbHBvT1RGQldTWlRXUlZTeEdRQUFaRGZnQkF3VUdmLzkxZEMKRUlDLy8vL3dVQVBPbm5SZWR4 UjBBR1NFbVVlMGFKNnBzbTBUMUU5Umt4TkEwMDlRQWFSVEU5VHhOVFR3cHA2Z2FBQUFBQUdpS2Vu bwpvOUo2VDFBME5BQUFBQUFpcCtUVW1UQk1UQW1Sb3dnd0UwR1FCSklUSTBUYVRRME5UMFEwSms5 S2VrZWsya00xRnJienF1bVRuVnVGCnR2VVhKVTMxUUFQWlJjeTdyVkpXWDhSOE16NWRMTE9WaUlJ SDIwYVRVRUpRSWhDUmRkNjVSQWtmZjdpT1FHa1VyamdFaEpDQkFGVlQKUlFyRDQxdUZhdGZQZVZY S0tJRXhUQ2ZIU3diV2pDNzZQeURGUXpTd2xGalVaazN1RjhkZ091SGVkVjhtZ204MGw5Sk1wZFZS SENtUQpGTlN1QVZhY0JuTUkwNnlJQ3d4VG9qL29KMjhzc0h5TjJxeFJMbk1neXFJcG9CQnhVejM4 bFJYU2hkQlZuSG83WHdGN1JWMlo1WWR1Ck9vd2txcFF1Z0tUZ2d0b0pBUFptS3F3NEZBV3AxYXNR WEhRZ1VObERLbndoUlNDTW5pYjJTSGsyMHhyVlRDY1lHM2JxTVpoSWtLSTgKUmJOeVRoaUZ5WlRI bXNkcFVXRC8zSjFGbll2MnNpd3VaVTR6TEZWeTBhbHBNNGxkNUFXRVZrWExHUW9WdmpTckpqR20y NHEvUjRuNgpWdW9VWjhtSXVudHNEV0VoM3hLb01USUhDV3FBV3NscENsQXd1cVdveGlhSnp5SE1V R0NuVWtmUks4a2pCQTBSZVFKZ3FoTEU3WE1sCkMxRTBITXFkekVwQVY0R2lSV0dMSXdqVlNCd0RY SGFHOEhnZE5IT2FqbzVldkcxeFdTSlRRMUFneXhXdm81aWx6VTVpT1c5ZzdHbDkKNjVjd0drWFNR ay9wK0wyZWJPQUZSVWxmbUxXZW9EWXkyZkZsR1JQRmkxcGN1R1BoNW83dDhNVGo1T2lMaVdPdzAz UFh5YmdaZWg2VQo4M1BIbWxSWG1sMk1hMXlTdmdTWDFTcGdWZjRwKzdGalpZOTNYSy9za29wc2lD eUYxSjBwM2xjcjE3TVpkUGJ3YzB5Wi9ad1UxMkU0CjNiY1ZwU3FlY0NPaHppZGtUTUlDRUtBODN4 TUxhSnk2MlRVK0hHd3craDBUSmVPNGJoSEJvS1Y1ejkrT1phSE94UHk0ZGg1Snp6c00KN2pQcnAw KzhIRVJoMUxWMFMzTE5mMUxZZDVYNWdUaFVldUVnT3JhQndXRDlHZU11dTFZUUlKVUw0My9LYVBj Y2R5VEo1aWFjQVl4QwpIeGJNbHdCc0Q2dmVRQ1MrQ29JdnY0NzFUS0s1aWdDdkZFQ0JGU1pseVNZ SmhOd1FTaXRoSDBZeitPK1hEbVdzM3Nsdis3SmQ1TnErClZ3LzRMaG9kdWR0Y0RVL1lkTFI2VFhP bEZsQUl3SEtPYlM4aUVVTXlvNWFTZTJsWnI0SUoxcGZWOENRZTAxbTlUdjkvR2diYjZONjcKbk1v R3ZtbEtjSXNhc3EzeTFENFZtVEt3T2NJSXlDUEs0ayt2dGVuYkgzdkNBTlRadnBDdkNDZEY4Q2Ey VzFBMFY1NzBvU1VrZFJQeAp2YzdZNjlsbUxVS3JOVmNEQ1FGUStORG51TzVnbExWYlFmdCt5ZEkx QmVHK3R5cW51WE1oMlAzckg4OXBUNWRmanpiN0d2SEx3YkJjCmdpdUhrajRFMnRiVjRwamNjK0V3 em14bmc1MVJWdEZLZi9pN2tpbkNoSUNxbGlNZwo= --089e013cbfea04b4ec04e7427ec8--