From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dave Goel Newsgroups: gmane.emacs.devel Subject: Re: Dired delete(d) the wrong file! Date: Fri, 5 Jul 2024 04:39:29 -0400 Message-ID: References: <86r0c875s4.fsf@gnu.org> <86h6d470oh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000216dcd061c7c0171" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4318"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, emacs-devel@gnu.org To: Eli Zaretskii , Dave Goel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 05 10:40:56 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPeUw-0000vG-NP for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Jul 2024 10:40:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeTq-0007JU-EH; Fri, 05 Jul 2024 04:39:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeTo-0007HW-TC for emacs-devel@gnu.org; Fri, 05 Jul 2024 04:39:45 -0400 Original-Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeTn-0001ZS-6M; Fri, 05 Jul 2024 04:39:44 -0400 Original-Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1fa2ea1c443so9647195ad.0; Fri, 05 Jul 2024 01:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720168781; x=1720773581; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+TWkcdbmuIuOnkaPsbbao02E92MdtqWswdKgSdT/PX0=; b=Imf3ruIt06rwiyCIgT9LYRl/JxQoR0lsbWB4DJbEh000icm0gLVKM/GW+E7syjRxzV dgfsq8QDREb3CTkWHN9rBW0UheTBs5xUDVWZi0wDSH9vf2r3P8BH7zQiHtcnbymF7/k9 cVJVD16DXbyRTNE6J8BAnCjTf7FvkdKYg/co2OXQRfngHSRaczo9umU25qRCRbQ+ae4Z CVE1guM+IMJBjp/JhgBG79OJd4cvoKPDzyUQ+kXhHcAn9yMqxwaPh2M4bCgqeOL2+6an KpGxqS0tj8sUjKdfcGtsjopGCseYGwp7LCOzRNKtpvr5mL7b0GLETopJMFnpB4cGtWTV IjAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168781; x=1720773581; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+TWkcdbmuIuOnkaPsbbao02E92MdtqWswdKgSdT/PX0=; b=h0qDCHZgGBaUC5jy3Hb4WwnLKDkNLAoZy6ioJkFV2f4KlI74RQwG9kVdO7PsgQNo5+ pN5dCKlZ+ROpPdytXdk25tGq4lFGEWu/P2/EjPKEcUQ35F2AGZAPhKtOkXGh7m7uFfRv 8Ok+3zgvhrOTKgw87HDLCnxWpGAPWGqrstDP74wSd98cKF6s7JHyR2xOKFrvGnmp8UfX nxV3Ixgp1aH31tHPzbkqemEcH0s2UPnzUPRMMn1NV5VNTdiZCpvJJz+i38+v6qbyTrWc RQOeXVBbA/8oOvXhD3A23Cce/D90OzsiJeAnhxo2NuHq+qpDLdtZWwW66/7vck4RdejN lRhA== X-Forwarded-Encrypted: i=1; AJvYcCWo5yewCSjOOGlRb1/EJJbw3ryvXSqYGGOLsyKj/s5hpfL0fgQ/QDKwfXcXEtSGH74ixIe8CxGeFxR8XM/cm6d3X1Ew X-Gm-Message-State: AOJu0YyQCDmNTb7zuHO6p5H7KEh8lanK6reVcmfiJdnydoIO+Jtf5TTX TuW6jr0iRxRrV0y4bJSs1YYWI8Wguhs64I++SksTNul5yaS8LGQFzrHdHb+5Rg8k1GI7kbC6b61 mz2PCDWrF/Aeonr3JuFS4sW7UKU3rgHIF X-Google-Smtp-Source: AGHT+IEWU3+ef3Mfvm6rV3figj/7XhZ8AisounfgpEyVf3mOum2/Os19UrY37PATEv5sn0DOkNYpZuq3tVMq3gQkcZI= X-Received: by 2002:a17:90b:a16:b0:2c1:c648:1c50 with SMTP id 98e67ed59e1d1-2c99c556f37mr2615180a91.17.1720168780751; Fri, 05 Jul 2024 01:39:40 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=deego3@gmail.com; helo=mail-pl1-x636.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321386 Archived-At: --000000000000216dcd061c7c0171 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jul 5, 2024 at 4:26=E2=80=AFAM Dave Goel wrote: > > Eli's patch works! > I still don't understand one thing - The problem is now fixed, right? It appears that it's still using a very hacky regexp - see (defvar directory-listing-before-filename-regexp...) during file deletion. which does all kinds of hacky checks, guessing where the timestring ends and where the filename begins. (A) So, is this still a hack? (B) Is the problem fixed for good, or can one still concoct edge cases? (C) If it is fixed, then why does that regex need this massive hack? --000000000000216dcd061c7c0171 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

=

= On Fri, Jul 5, 2024 at 4:26=E2=80=AFAM Dave Goel <deego3@gmail.com> wrote:
>=C2=A0Eli's patch works!

<= /div>
I still don't understand one thing -

The problem is now= fixed, right?

It appears that it's still using a very hacky re= gexp - see (defvar directory-listing-before-filename-regexp...) during file del= etion.
which does all kinds of hacky checks, guessing where the t= imestring ends and where the filename begins.

(A)=C2=A0So, is this still a hack?=C2=A0
(B)=C2=A0Is the pro= blem fixed for good, or can one still concoct edge cases?
(C)=C2=A0If it is fixed, then why does that regex = need this massive hack?

--000000000000216dcd061c7c0171--