Re: elisp--local-variables triggers an error on special input

[Evgeny Zajcev <lg.zevlg@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 902 bytes --]

вт, 1 дек. 2020 г. в 18:45, Stefan Monnier <monnier@iro.umontreal.ca>:

> > I've noticed that sometimes company raises an error in my *scratch*, I've
> > shrinked the case and got:
> > (with-current-buffer (get-buffer-create "pwp")
> >   (erase-buffer)
> >   (insert "((eg \"\C-,\")")
> >   (elisp--local-variables))
> > Evaluating this sexp raises "Invalid modifier in string" error
> > Not sure this is intended, I think elisp--local-variables expects
> > `invalid-read-syntax` error for this input, but got another error and
> does
> > not handle it preventing error from happening
>
> Clearly, `elisp--local-variables` should catch this error, but as you
> point out, maybe the better way to do that is to change the error that
> is signaled so that it is a child of `invalid-read-syntax`.
>
>
I've composed a patch that fixes this, could you please apply it.

-- 
lg

[-- Attachment #1.2: Type: text/html, Size: 1394 bytes --]

[-- Attachment #2: 0002-Make-Invalid-modifier-in-string-ordinary-invalid-rea.patch --]
[-- Type: text/x-patch, Size: 908 bytes --]

From 90647406fbf21d34c5ddd52303f0dc7685862d58 Mon Sep 17 00:00:00 2001
From: Zajcev Evgeny <zevlg@yandex.ru>
Date: Thu, 17 Dec 2020 11:27:20 +0300
Subject: [PATCH 2/2] Make "Invalid modifier in string" ordinary
 invalid-read-syntax error

* src/lread.ec (read1): Raise "Invalid modifier in string" error as
  `invalid-read-syntax'.  This fixes raise of unhandled error in
  `elisp--local-variables'
---
 src/lread.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lread.c b/src/lread.c
index a3d5fd7bb8..3ef874039a 100644
--- a/src/lread.c
+++ b/src/lread.c
@@ -3438,7 +3438,7 @@ read1 (Lisp_Object readcharfun, int *pch, bool first_in_list)
 
 		/* Any modifiers remaining are invalid.  */
 		if (modifiers)
-		  error ("Invalid modifier in string");
+		  invalid_syntax ("Invalid modifier in string");
 		p += CHAR_STRING (ch, (unsigned char *) p);
 	      }
 	    else
-- 
2.25.1