From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Evgeny Zajcev Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix display box cursor under image with margins Date: Sat, 25 Apr 2020 13:48:23 +0300 Message-ID: References: <83imhwk7sr.fsf@gnu.org> <835zdn97k8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000037041705a41b3931" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="30306"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 25 12:49:40 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jSINQ-0007mz-Cc for ged-emacs-devel@m.gmane-mx.org; Sat, 25 Apr 2020 12:49:40 +0200 Original-Received: from localhost ([::1]:34534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSINO-0004HA-9C for ged-emacs-devel@m.gmane-mx.org; Sat, 25 Apr 2020 06:49:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41262) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSIMT-0003j7-Gk for emacs-devel@gnu.org; Sat, 25 Apr 2020 06:48:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSIMS-0003jv-0T for emacs-devel@gnu.org; Sat, 25 Apr 2020 06:48:40 -0400 Original-Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]:33395) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSIMP-0002fm-PL; Sat, 25 Apr 2020 06:48:37 -0400 Original-Received: by mail-lj1-x244.google.com with SMTP id w20so12602242ljj.0; Sat, 25 Apr 2020 03:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xn2ePf1CgCTv9RWdDrUpogknzOZnhWqExCvPShVSyf8=; b=gaVEK/lHgjhQ2J53pB5m0FPdkQ/LFqrTJ9XF1CiaAubql4FhzctMe4u8VDO6IHFaJc enlns1nFkBdFm+8r1IdogpX2S1KK/D4AUW4iOHZd2db0jnnMAVCtSJErsIpGvWCTJ0cZ t7qyLW9K476G14nH5uByujM8MRQp2+Ns2JtWI25Yq6pMA9fY3i33EUSSHwCnwjhumy5f aPCjlbzqzDSFZ1LjbD6pXGLxTtYUHSJ88jWEdsM3zTNraJfkcWM44n3GNZmK83jOJBvn GH7dsy+VeeRHT2Mbu7hwVMvFx3KsLTYxbLZocijMJGYkFOlw52G/dsIRceqHu2RtR0L8 bVdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xn2ePf1CgCTv9RWdDrUpogknzOZnhWqExCvPShVSyf8=; b=pZmqeiz+EVyvWTk84vUGxTmCGxT2JohYwXtwnp02V+QgRMnlrutQaLKr2qTlL+VBzP X/9KhqmJVOIhLcUJhGRahZXn1ujZ5Sa2r2lY7NN8LnmSexSv5HF0+KO//Ojb18frrgKa 5RBURCL+6HfZjBDK6ziqtKjS6xTP66mpuj+aICb8ZD/WXnmpmTlsPwQhMMCmKVQcRRFg zLBtWC5MSIMSbN3yvD1vIeoH56LK/mIuehCr0/UayG4cSeWLHD10TawkrK9veqTspijc B9N1gMeac2s43OoqSCYqdXhjzm4CU4OT+zgMuDofHgh+xBL6GDdEpKl8ypxKiUyrhTDk Kyzg== X-Gm-Message-State: AGi0PuaMF2sBxrDzWEM/nXZx7liMgpEP6Ufv9JWqbbhb2dyFhyZBB5mE HVGp8sFaO+hCabWXmdLkscOLw7hxJ2G0zPlU9/4UtvoC X-Google-Smtp-Source: APiQypJCtK3euv23iS7trQsl14ubbkPO0gYcDgqDQdbXnBT4hQEaImaOJWW0NPNgxNgoFcPcFIsAlfFqEI/BX0YzqxE= X-Received: by 2002:a2e:740f:: with SMTP id p15mr7539189ljc.151.1587811714530; Sat, 25 Apr 2020 03:48:34 -0700 (PDT) In-Reply-To: <835zdn97k8.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::244; envelope-from=lg.zevlg@gmail.com; helo=mail-lj1-x244.google.com X-detected-operating-system: by eggs.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67 X-Received-From: 2a00:1450:4864:20::244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247762 Archived-At: --00000000000037041705a41b3931 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =D1=81=D0=B1, 25 =D0=B0=D0=BF=D1=80. 2020 =D0=B3. =D0=B2 13:35, Eli Zaretsk= ii : > > From: Evgeny Zajcev > > Date: Sat, 18 Apr 2020 21:05:16 +0300 > > Cc: emacs-devel > > > > > Here is the patch to fix issue making cursor hollow under non-mask > image, but containing margins. > > This > > > patch keeps box cursor to be box in case image has margins. > > > > Could you please give an example of such an image and what the results > > look like, before and after the patch? It's hard to understand the > > details of this otherwise. > > > > Here is first screenshot how hollow cursor looks on image with margin - > > http://lgarc.narod.ru/pics/emacs-hollow-cursor.png > > > > And here is how it looks with patch applied - > http://lgarc.narod.ru/pics/emacs-box-cursor.png > > > > Without patch, look of the cursor won't change, it will remain being > hollow > > Thanks. Frankly, I'm not sure the change is for the better. > > Probably, the best we can do is to have box-outline cursor type to make box cursor have that one-line outline box as hollow cursor has. And change cursor type to box-outline when cursor is under the image. It will combine all the prons from box and hollow cursor type --=20 lg --00000000000037041705a41b3931 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
=D1=81=D0=B1, 25 =D0=B0=D0=BF=D1=80. 2020= =D0=B3. =D0=B2 13:35, Eli Zaretskii <el= iz@gnu.org>:
> From: Evgeny Zajcev <lg.zevlg@gmail.com>
> Date: Sat, 18 Apr 2020 21:05:16 +0300
> Cc: emacs-devel <emacs-devel@gnu.org>
>
>=C2=A0 > Here is the patch to fix issue making cursor hollow under n= on-mask image, but containing margins.
>=C2=A0 This
>=C2=A0 > patch keeps box cursor to be box in case image has margins.=
>
>=C2=A0 Could you please give an example of such an image and what the r= esults
>=C2=A0 look like, before and after the patch?=C2=A0 It's hard to un= derstand the
>=C2=A0 details of this otherwise.
>
> Here is first screenshot how hollow cursor looks on image with margin = -
> http://lgarc.narod.ru/pics/emacs-hollow-curso= r.png
>
> And here is how it looks with patch applied - ht= tp://lgarc.narod.ru/pics/emacs-box-cursor.png
>
> Without patch, look of the cursor won't change, it will remain bei= ng hollow

Thanks.=C2=A0 Frankly, I'm not sure the change is for the better.

Probably, the best we can do is to have box-outline c= ursor type to make box cursor have that one-line outline box as hollow curs= or has.=C2=A0 And change cursor type to box-outline when cursor is under th= e image.=C2=A0 It will combine all the prons from box and hollow cursor typ= e

--
lg
--00000000000037041705a41b3931--