Re: [PATCH] Fix display box cursor under image with margins

[Evgeny Zajcev <lg.zevlg@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1698 bytes --]

вс, 10 мая 2020 г. в 15:52, Stefan Kangas <stefankangas@gmail.com>:

> Evgeny Zajcev <lg.zevlg@gmail.com> writes:
>
> > сб, 25 апр. 2020 г. в 15:09, Stefan Monnier <monnier@iro.umontreal.ca>:
> >
> >> > Here is first screenshot how hollow cursor looks on image with margin
> -
> >> > http://lgarc.narod.ru/pics/emacs-hollow-cursor.png
> >> >
> >> > And here is how it looks with patch applied -
> >> > http://lgarc.narod.ru/pics/emacs-box-cursor.png
> >>
> >> Would it be possible to keep the two thin horizontal lines when the
> >> window is active?
> >>
> > I figured out, how to do this in "easy" way.  Here is patches update
> >
> > And screenshots: http://lgarc.narod.ru/pics/emacs-box-margin1.png
> > http://lgarc.narod.ru/pics/emacs-box-margin2.png
>
> I think your second set of screenshots looks better.
>

On second screeshot, image has vertical margin as (10 . 4) specifies, that
is why horizontal lines are not thin

On first screenshot, there is only hmargin as (10 . 0) specifies


> But the horizontal lines are not thin, right?
>
> What happens when you switch the active window?  Will the cursor change
> the size of that line, causing things to move vertically?  And what's
> the result when you have many images in a buffer, as in image-dired?
>

No moves, margins are part of the image size displayed in Emacs window.
Cursor just uses that margins to fulfill with cursor color

In both screenshots below window shows how it looks in inactive window.  It
looks unchanged from how they look in current Emacs without patch

I filmed short video how it looks in dynamic -
http://lgarc.narod.ru/pics/IMG_9721.MOV

-- 
lg

[-- Attachment #2: Type: text/html, Size: 3035 bytes --]