From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Evgeny Zajcev Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix display box cursor under image with margins Date: Sat, 18 Apr 2020 21:05:16 +0300 Message-ID: References: <83imhwk7sr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000c3266e05a39482ae" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="2560"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 18 20:06:28 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jPrrI-0000aH-3q for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Apr 2020 20:06:28 +0200 Original-Received: from localhost ([::1]:60500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPrrH-0002RB-2r for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Apr 2020 14:06:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37588) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPrqO-0001gH-Rt for emacs-devel@gnu.org; Sat, 18 Apr 2020 14:05:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jPrqN-0001tv-Jl for emacs-devel@gnu.org; Sat, 18 Apr 2020 14:05:32 -0400 Original-Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]:43741) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jPrqL-0001qi-Ft; Sat, 18 Apr 2020 14:05:29 -0400 Original-Received: by mail-lf1-x141.google.com with SMTP id k28so4488150lfe.10; Sat, 18 Apr 2020 11:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5NZDrLSQHK0IebbzHW5ObQdBnxWRTaRDAKeACaO+Af4=; b=IYbxl6HPnhSzyL7YOdjJNecMkvfgS1aV2n+SQbNqHT84D+AjmmEMW010s/8MhvjFVS 0PFD7tfmZcDDU0j2fHE+siy3Y/uRMHjfiEy4OtQKed21NYZhlGQq/B+Qs6Jlt65cBBHx CQ+kGUG4ApZ//HLo9urmSb1Xf0/8V1H71i3PZ3yuXM+D4FICxWpwXDBlJJ+uJyZb7ZVC k0vKrm0Z6uSZT+E1ok3LvvXU25gXB2SIR7k7fApzpG/ySsORioIy9KmyyHd2HImphXzW HM9kCdfbGCrdhe6NTjo2+03yJ1eTLsZ+ArCQ4W30fsJUo15601ZmYe2Wb3WRDRF9ORfL /G6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5NZDrLSQHK0IebbzHW5ObQdBnxWRTaRDAKeACaO+Af4=; b=A6BNiHaX/DikWRKowYdO8ac0N2zesouDAkn5tH2lLJo4AEeRRpiiBNTs2uYCdrq40J swTPePsgVJPeDvKY4jBjo4gAlGhBb1IsaSMZq7fwjf8dH2v3tl6aWmHyYvqGb1R2WUTF tvEE5f9T2i+TLuCU82WYpQLsUcFPauDEGRqBuAodAdQnWt2EdTTeGqfJU38iAXbRI2Sk PTH/7NaqEFhNc3viXJ8hLfcf5qYVxhO6zeD2QmkDqe6eBnwVghsOCTpLZdq6BxdkAujO vxY7qhqRq30OcWLb6AdpJKe7xVlUA1U7oIZvEk/Ilf2iRknVKGs7wowud6SJJx7xgoYc I5Nw== X-Gm-Message-State: AGi0PuZRYqlkGJszgNGQxEPgkL74envqBpOztsvJSZCcM110RRj+uc5L RT0xqsjKYCpMuY3eSkVA5Cj/SYiiWfdd7DbWiC6ubmv02G8= X-Google-Smtp-Source: APiQypK4j1VVFFf/RfOPHw8L/KJi57QkV+motWO9NF4cvBTDYhBT4Q3G3vxoDia4bSqTFPPvDCkV5ElWUccjmDiDhBA= X-Received: by 2002:ac2:48b1:: with SMTP id u17mr5372337lfg.187.1587233127866; Sat, 18 Apr 2020 11:05:27 -0700 (PDT) In-Reply-To: <83imhwk7sr.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::141 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247239 Archived-At: --000000000000c3266e05a39482ae Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =D1=81=D0=B1, 18 =D0=B0=D0=BF=D1=80. 2020 =D0=B3. =D0=B2 20:44, Eli Zaretsk= ii : > > From: Evgeny Zajcev > > Date: Sat, 18 Apr 2020 20:28:26 +0300 > > > > Here is the patch to fix issue making cursor hollow under non-mask > image, but containing margins. This > > patch keeps box cursor to be box in case image has margins. > > Could you please give an example of such an image and what the results > look like, before and after the patch? It's hard to understand the > details of this otherwise. > Here is first screenshot how hollow cursor looks on image with margin - http://lgarc.narod.ru/pics/emacs-hollow-cursor.png And here is how it looks with patch applied - http://lgarc.narod.ru/pics/emacs-box-cursor.png Without patch, look of the cursor won't change, it will remain being hollow --=20 lg --000000000000c3266e05a39482ae Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
=D1=81=D0=B1, 18 =D0=B0=D0=BF=D1=80. = 2020 =D0=B3. =D0=B2 20:44, Eli Zaretskii <eliz@gnu.org>:
> From: Evgeny Zajcev <lg.zevlg@gmail.com>
> Date: Sat, 18 Apr 2020 20:28:26 +0300
>
> Here is the patch to fix issue making cursor hollow under non-mask ima= ge, but containing margins.=C2=A0 This
> patch keeps box cursor to be box in case image has margins.

Could you please give an example of such an image and what the results
look like, before and after the patch?=C2=A0 It's hard to understand th= e
details of this otherwise.

Here is first screenshot how hollow cursor= looks on image with margin - http://lgarc.narod.ru/pics/emacs-hollow-cursor.png

And here is how it looks with patch applied - http://lgarc.narod.ru= /pics/emacs-box-cursor.png

Without patch, look= of the cursor won't change, it will remain being hollow

--
lg
--000000000000c3266e05a39482ae--