From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao!not-for-mail From: Evgeny Zajcev Newsgroups: gmane.emacs.bugs Subject: bug#39133: 28.0.50; Emacs slowdown on special char Date: Wed, 15 Jan 2020 13:47:45 +0300 Message-ID: References: <83lfqa5aa2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000fb3db2059c2b7043" Injection-Info: ciao.gmane.io; posting-host="ciao:159.69.161.202"; logging-data="70865"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39133@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 15 15:53:37 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1irhqZ-00028a-LD for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jan 2020 13:32:31 +0100 Original-Received: from localhost ([::1]:51906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irgEi-0001Pd-Om for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jan 2020 05:49:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34637) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irgET-0001PP-Qb for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 05:49:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irgEQ-0005mm-MK for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 05:49:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56566) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1irgEQ-0005ld-JE for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 05:49:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1irgEQ-0002w7-AQ for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 05:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Evgeny Zajcev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jan 2020 10:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39133 X-GNU-PR-Package: emacs Original-Received: via spool by 39133-submit@debbugs.gnu.org id=B39133.157908529211221 (code B ref 39133); Wed, 15 Jan 2020 10:49:02 +0000 Original-Received: (at 39133) by debbugs.gnu.org; 15 Jan 2020 10:48:12 +0000 Original-Received: from localhost ([127.0.0.1]:34302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1irgDY-0002up-RR for submit@debbugs.gnu.org; Wed, 15 Jan 2020 05:48:12 -0500 Original-Received: from mail-lf1-f45.google.com ([209.85.167.45]:36891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1irgDS-0002u4-Lk for 39133@debbugs.gnu.org; Wed, 15 Jan 2020 05:48:06 -0500 Original-Received: by mail-lf1-f45.google.com with SMTP id b15so12326925lfc.4 for <39133@debbugs.gnu.org>; Wed, 15 Jan 2020 02:48:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KHIrum8UYIZHije9xKDhi8QeT0sE0KqLXvNDZNdYHZ4=; b=T0e9kj8sVw//Swis/LSAhjoZjh3z1FPDx+kdB9c96khY4iDT+y69yQm6XXDaW2vGUw 68oAXOHsqyTdZlUf/P10Nw4Ig+Grd6q2mHOTiacYPfJ0rqtaUlmrQT5rflibodQdWsJz XHQSs6W5j9k78EXHJS4amLyY65xRlEQoH7eGOY4gSJR72cvGO0b5jtrAExzP76cZU4tv TP9dewgFIikzlRVDFBUUKNxSQUIvUsKQtPdecEbvI88bG+SlqBjpEqyNufNTgUQSiDHZ ADPNzMgn1/YyHUIF+M70aM1aztVueZ3/uuEe1HsDLDlznOSLqQhG/D7IcV14hOEOnNBU 92kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KHIrum8UYIZHije9xKDhi8QeT0sE0KqLXvNDZNdYHZ4=; b=cJ4ahAcHHCxGnsF4icrsWbsbUrX2Yyve05uaAX0kasZ6SPAZ2TAxyr6LsfYsuf4Nhb 0XJb2FTFm9P3ugIXJR+Ioo+hlPrb0+ZyXEdwu7SarVl3W0CnpTPPsrIQut22JbdzYRbi lpSa+ZTl1vO2Y9QrEi25gq2Nvw44SwNh75KAJPFX4fiu7U4TJC47RnbdZEajhZszt7Rp SurX+5VMsvhTRw7StoQMsh4Mwc/1/gFNNLwI6WdkR0WFwT9BVF2MO+3xNjLv1qdn1xNx HQVMyugMzty/wgJvAHpk0ToSPvvQFcKK5PqPev2KBSjtXV3sGExE1k4/bhaw+F8Hg4zL hpYA== X-Gm-Message-State: APjAAAUSBnlDUKZdj128UkCVwkdScBITSDMpCzPCPHjmD1/4Tfydcf3j TY782D/QRbIQFz2EpaaIA9Fh6yUr+plmoHXVFqI= X-Google-Smtp-Source: APXvYqwNj2lNR8zkPP5TVPxY/VATfIT/aJe3quSYOm4zQswBRn0+u5KzYy1RDfjjdgLE7Q0aw/ZzSkZkvOwKf+EbbDU= X-Received: by 2002:ac2:5b41:: with SMTP id i1mr4361174lfp.82.1579085276592; Wed, 15 Jan 2020 02:47:56 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174622 Archived-At: --000000000000fb3db2059c2b7043 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =D1=81=D1=80, 15 =D1=8F=D0=BD=D0=B2. 2020 =D0=B3. =D0=B2 11:25, Robert Plui= m : > >>>>> On Wed, 15 Jan 2020 13:26:11 +0900, YAMAMOTO Mitsuharu < > mituharu@math.s.chiba-u.ac.jp> said: > > YAMAMOTO> 0xFFFFFFFF comes from FONT_INVALID_CODE. > font->driver->text_extents > YAMAMOTO> shouldn't be called if font->font->driver->encode_char > returns it. > > YAMAMOTO> diff --git a/src/font.c b/src/font.c > YAMAMOTO> index 2b90903c90..03e6176220 100644 > YAMAMOTO> --- a/src/font.c > YAMAMOTO> +++ b/src/font.c > YAMAMOTO> @@ -4420,15 +4420,19 @@ font_fill_lglyph_metrics > (Lisp_Object glyph, Lisp_Object font_object) > YAMAMOTO> { > YAMAMOTO> struct font *font =3D XFONT_OBJECT (font_object); > YAMAMOTO> unsigned code =3D font->driver->encode_char (font, > LGLYPH_CHAR (glyph)); > YAMAMOTO> - struct font_metrics metrics; > YAMAMOTO> - > YAMAMOTO> - LGLYPH_SET_CODE (glyph, code); > YAMAMOTO> - font->driver->text_extents (font, &code, 1, &metrics); > YAMAMOTO> - LGLYPH_SET_LBEARING (glyph, metrics.lbearing); > YAMAMOTO> - LGLYPH_SET_RBEARING (glyph, metrics.rbearing); > YAMAMOTO> - LGLYPH_SET_WIDTH (glyph, metrics.width); > YAMAMOTO> - LGLYPH_SET_ASCENT (glyph, metrics.ascent); > YAMAMOTO> - LGLYPH_SET_DESCENT (glyph, metrics.descent); > YAMAMOTO> + > YAMAMOTO> + if (code !=3D FONT_INVALID_CODE) > YAMAMOTO> + { > YAMAMOTO> + struct font_metrics metrics; > YAMAMOTO> + > YAMAMOTO> + LGLYPH_SET_CODE (glyph, code); > YAMAMOTO> + font->driver->text_extents (font, &code, 1, &metrics= ); > YAMAMOTO> + LGLYPH_SET_LBEARING (glyph, metrics.lbearing); > YAMAMOTO> + LGLYPH_SET_RBEARING (glyph, metrics.rbearing); > YAMAMOTO> + LGLYPH_SET_WIDTH (glyph, metrics.width); > YAMAMOTO> + LGLYPH_SET_ASCENT (glyph, metrics.ascent); > YAMAMOTO> + LGLYPH_SET_DESCENT (glyph, metrics.descent); > YAMAMOTO> + } > YAMAMOTO> } > > > YAMAMOTO> But I'm not sure if it is ok to leave the code and > metrics-related > YAMAMOTO> fields nil when encode_char returns FONT_INVALID_CODE. > Handa-san? > > I don=CA=BCt know either, but your patch fixes the slowdown and I=CA=BCve= seen > no negative effects yet. > Yeah, this patch fixes the slowdown! --=20 lg --000000000000fb3db2059c2b7043 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
=D1=81=D1=80, 15 =D1=8F=D0=BD=D0=B2. = 2020 =D0=B3. =D0=B2 11:25, Robert Pluim <rpluim@gmail.com>:
>>>>> On Wed, 15 Jan 2020 13:26:11 +0900, YAM= AMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> said:

=C2=A0 =C2=A0 YAMAMOTO> 0xFFFFFFFF comes from FONT_INVALID_CODE. font-&g= t;driver->text_extents
=C2=A0 =C2=A0 YAMAMOTO> shouldn't be called if font->font->dri= ver->encode_char returns it.

=C2=A0 =C2=A0 YAMAMOTO> diff --git a/src/font.c b/src/font.c
=C2=A0 =C2=A0 YAMAMOTO> index 2b90903c90..03e6176220 100644
=C2=A0 =C2=A0 YAMAMOTO> --- a/src/font.c
=C2=A0 =C2=A0 YAMAMOTO> +++ b/src/font.c
=C2=A0 =C2=A0 YAMAMOTO> @@ -4420,15 +4420,19 @@ font_fill_lglyph_metrics= (Lisp_Object glyph, Lisp_Object font_object)
=C2=A0 =C2=A0 YAMAMOTO>=C2=A0 {
=C2=A0 =C2=A0 YAMAMOTO>=C2=A0 =C2=A0 struct font *font =3D XFONT_OBJECT = (font_object);
=C2=A0 =C2=A0 YAMAMOTO>=C2=A0 =C2=A0 unsigned code =3D font->driver-&= gt;encode_char (font, LGLYPH_CHAR (glyph));
=C2=A0 =C2=A0 YAMAMOTO> -=C2=A0 struct font_metrics metrics;
=C2=A0 =C2=A0 YAMAMOTO> -
=C2=A0 =C2=A0 YAMAMOTO> -=C2=A0 LGLYPH_SET_CODE (glyph, code);
=C2=A0 =C2=A0 YAMAMOTO> -=C2=A0 font->driver->text_extents (font, = &code, 1, &metrics);
=C2=A0 =C2=A0 YAMAMOTO> -=C2=A0 LGLYPH_SET_LBEARING (glyph, metrics.lbea= ring);
=C2=A0 =C2=A0 YAMAMOTO> -=C2=A0 LGLYPH_SET_RBEARING (glyph, metrics.rbea= ring);
=C2=A0 =C2=A0 YAMAMOTO> -=C2=A0 LGLYPH_SET_WIDTH (glyph, metrics.width);=
=C2=A0 =C2=A0 YAMAMOTO> -=C2=A0 LGLYPH_SET_ASCENT (glyph, metrics.ascent= );
=C2=A0 =C2=A0 YAMAMOTO> -=C2=A0 LGLYPH_SET_DESCENT (glyph, metrics.desce= nt);
=C2=A0 =C2=A0 YAMAMOTO> +
=C2=A0 =C2=A0 YAMAMOTO> +=C2=A0 if (code !=3D FONT_INVALID_CODE)
=C2=A0 =C2=A0 YAMAMOTO> +=C2=A0 =C2=A0 {
=C2=A0 =C2=A0 YAMAMOTO> +=C2=A0 =C2=A0 =C2=A0 struct font_metrics metric= s;
=C2=A0 =C2=A0 YAMAMOTO> +
=C2=A0 =C2=A0 YAMAMOTO> +=C2=A0 =C2=A0 =C2=A0 LGLYPH_SET_CODE (glyph, co= de);
=C2=A0 =C2=A0 YAMAMOTO> +=C2=A0 =C2=A0 =C2=A0 font->driver->text_e= xtents (font, &code, 1, &metrics);
=C2=A0 =C2=A0 YAMAMOTO> +=C2=A0 =C2=A0 =C2=A0 LGLYPH_SET_LBEARING (glyph= , metrics.lbearing);
=C2=A0 =C2=A0 YAMAMOTO> +=C2=A0 =C2=A0 =C2=A0 LGLYPH_SET_RBEARING (glyph= , metrics.rbearing);
=C2=A0 =C2=A0 YAMAMOTO> +=C2=A0 =C2=A0 =C2=A0 LGLYPH_SET_WIDTH (glyph, m= etrics.width);
=C2=A0 =C2=A0 YAMAMOTO> +=C2=A0 =C2=A0 =C2=A0 LGLYPH_SET_ASCENT (glyph, = metrics.ascent);
=C2=A0 =C2=A0 YAMAMOTO> +=C2=A0 =C2=A0 =C2=A0 LGLYPH_SET_DESCENT (glyph,= metrics.descent);
=C2=A0 =C2=A0 YAMAMOTO> +=C2=A0 =C2=A0 }
=C2=A0 =C2=A0 YAMAMOTO>=C2=A0 }


=C2=A0 =C2=A0 YAMAMOTO> But I'm not sure if it is ok to leave the co= de and metrics-related
=C2=A0 =C2=A0 YAMAMOTO> fields nil when encode_char returns FONT_INVALID= _CODE.=C2=A0 Handa-san?

I don=CA=BCt know either, but your patch fixes the slowdown and I=CA=BCve s= een
no negative effects yet.

Yeah, this pat= ch fixes the slowdown!

--
lg
--000000000000fb3db2059c2b7043--