From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#62621: 29.0.60; uniquify can't make buffers unique based on things other than filename Date: Thu, 3 Aug 2023 07:54:22 -0400 Message-ID: References: <87bkgfjugn.fsf@catern.com> <83edlb3t0t.fsf@gnu.org> <22ee6190-5946-9bde-b648-a55dd2188576@gutov.dev> <83mszt7a1a.fsf@gnu.org> <5c266c9b-a719-41d9-327e-6a2152adaffe@gutov.dev> <838rbc5c8v.fsf@gnu.org> <83v8eg3ue7.fsf@gnu.org> <83a5vpbaa6.fsf@gnu.org> <83cz0eog5a.fsf@gnu.org> <83v8dwy2qc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000007363cc06020371e1" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16340"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , 62621@debbugs.gnu.org, Spencer Baugh To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 03 13:55:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRWvE-000417-Ot for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Aug 2023 13:55:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRWv3-0005Cp-1M; Thu, 03 Aug 2023 07:55:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRWv1-0005Ch-CH for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 07:55:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRWv1-0002Hd-1g for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 07:55:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRWv0-0002Si-By for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 07:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Aug 2023 11:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62621 X-GNU-PR-Package: emacs Original-Received: via spool by 62621-submit@debbugs.gnu.org id=B62621.16910636879438 (code B ref 62621); Thu, 03 Aug 2023 11:55:02 +0000 Original-Received: (at 62621) by debbugs.gnu.org; 3 Aug 2023 11:54:47 +0000 Original-Received: from localhost ([127.0.0.1]:50989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRWuh-0002S6-Do for submit@debbugs.gnu.org; Thu, 03 Aug 2023 07:54:47 -0400 Original-Received: from mxout1.mail.janestreet.com ([38.105.200.78]:47757) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRWuc-0002Rr-6P for 62621@debbugs.gnu.org; Thu, 03 Aug 2023 07:54:42 -0400 Original-Received: from mail-ej1-f69.google.com ([209.85.218.69]) by mxgoog2.mail.janestreet.com with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) (Exim 4.96) id 1qRWuW-00BD1V-1n for 62621@debbugs.gnu.org; Thu, 03 Aug 2023 07:54:32 -0400 Original-Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-978a991c3f5so62165266b.0 for <62621@debbugs.gnu.org>; Thu, 03 Aug 2023 04:54:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=google; t=1691063672; x=1691668472; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Lm12sEKIPqDaJfYXCprs9JpyQINhat4RLCHHpHIYvHE=; b=uFdc5mmNS0zX7evrS46M51Bx1U/Gtm+4fa6iOXgHipvSWjaFWIBXO31XRuPsyTwD6a 2i0eM6Pml3Gii2zgZul6kTArsV3it78Gp4jibhV4/3aoUMzEjrhy3V6KBmA4bWgrraMp aeuveGFhiSses3o+a7HR/aJM6CQ8Ek0niXssg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691063672; x=1691668472; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Lm12sEKIPqDaJfYXCprs9JpyQINhat4RLCHHpHIYvHE=; b=LTM86BvwDC0GxcrcjJui+xbFmmrXXzpyMT6YBk+Ev4jFI7wI5VCIpUI15HjyBlcdsD BzWFNeKcb3Zb5Gc8mSfVwKtIjrko+801LGIaUP9DypSxo6B470dWP12QzQ1Hq9byg4qk udVSfqw4RQa3ZGm0YffB9gFaFcpwj7l/FbfVnhvXjfOhTtR2l/Y+4lm+hs0XIrb0vvC5 mKd9sIb27HZeW/h81psBz7FnH1psYXsTwtTDvaxaDOGyfF51sf34+QRP8F6HJxJAqlDH hA+h9D8Q8+WCmJWYm0F7GsdpSc49isCuaIdY5W4/do3TH6j0ETc1zF0aPVCvbbXK9n0L /dug== X-Gm-Message-State: ABy/qLYvtsVsH7zw1N9zKEoqmmVuvdtJXnm3LyDkvh4UaeBOVCFgQERc 6OpbrzsHUO48hPk8w/dNK1/oCgqn5QH4lWutacMcbh+DWTASVR2k/D4/xp6EdBJYRC6DBvxP34F tsk2/cNSJGQoJ/SVcC1nEYeZ/NtAMjw== X-Received: by 2002:a17:906:84:b0:99b:bf8d:b7e1 with SMTP id 4-20020a170906008400b0099bbf8db7e1mr7192466ejc.17.1691063672135; Thu, 03 Aug 2023 04:54:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlG+o2tFso35Z+sr3gn1IK57W3TPrB2egjQ0+vYtP2uksa1B/uqhCTdlvmfgPzFGuKHSVAsSKV3SGnX37CFffUw= X-Received: by 2002:a17:906:84:b0:99b:bf8d:b7e1 with SMTP id 4-20020a170906008400b0099bbf8db7e1mr7192456ejc.17.1691063671802; Thu, 03 Aug 2023 04:54:31 -0700 (PDT) In-Reply-To: <83v8dwy2qc.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266585 Archived-At: --0000000000007363cc06020371e1 Content-Type: text/plain; charset="UTF-8" On reflection that specific test case is of dubious value, and since it's failing on Windows it means the behavior isn't even consistent anyway. So just delete it. On Thu, Aug 3, 2023, 04:00 Eli Zaretskii wrote: > Ping! Can this test failure be fixed, please? > > > Cc: dmitry@gutov.dev, 62621@debbugs.gnu.org, sbaugh@catern.com > > Date: Wed, 26 Jul 2023 18:18:25 +0300 > > From: Eli Zaretskii > > > > > From: Spencer Baugh > > > Cc: dmitry@gutov.dev, 62621@debbugs.gnu.org, sbaugh@catern.com > > > Date: Mon, 24 Jul 2023 15:18:23 -0400 > > > > > > > OK, how about this? > > > > > > Oops, that one didn't include the updated > > > project-uniquify-dirname-transform docstring. The right patch now: > > > > Thanks, installed, with some minor changes as followup. > > > > The new test uniquify-home fails for me on MS-Windows: > > > > Test uniquify-home backtrace: > > signal(ert-test-failed (((should (equal (mapcar #'buffer-name bufs) > > ert-fail(((should (equal (mapcar #'buffer-name bufs) '("~" "~< > > (if (unwind-protect (setq value-27 (apply fn-25 args-26)) (setq form > > (let (form-description-29) (if (unwind-protect (setq value-27 (apply > > (let ((value-27 'ert-form-evaluation-aborted-28)) (let (form-descrip > > (let* ((fn-25 #'equal) (args-26 (condition-case err (let ((signal-ho > > (save-excursion (setq bufs (cons (find-file-noselect "~") bufs)) (se > > (let (bufs) (save-excursion (setq bufs (cons (find-file-noselect "~" > > (closure (t) nil (let (bufs) (save-excursion (setq bufs (cons (find- > > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > > ert-run-test(#s(ert-test :name uniquify-home :documentation "uniquif > > ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [... > > ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil > > ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) > > ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco > > eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n > > command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/uniquify-tests.el" " > > command-line() > > normal-top-level() > > Test uniquify-home condition: > > (ert-test-failed > > ((should (equal (mapcar ... bufs) '("~" "~<>"))) :form > > (equal ("~" "nonexistent") ("~" "~<>")) :value nil > > :explanation > > (list-elt 0 > > (arrays-of-different-length 1 7 "~" "~" > > first-mismatch-at 1)))) > > > > The idea of the test is not clear to me, so I cannot tell what could > > be the reasons. Feel free to ask me to test changes or ask questions > > about what happens on this Windows system while running the test. > > > > > > > > > --0000000000007363cc06020371e1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On reflection that specific test case is of dubious = value, and since it's failing on Windows it means the behavior isn'= t even consistent anyway. So just delete it.

On Thu, Aug 3, 2023, 04:00 Eli Za= retskii <eliz@gnu.org> wrote:
=
Ping!=C2=A0 Can this test failure be f= ixed, please?

> Cc: dmitry@gutov.dev, 62621@debbugs.gnu.org, sbaugh@catern.com=
> Date: Wed, 26 Jul 2023 18:18:25 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > From: Spencer Baugh <sbaugh@janestreet.com>
> > Cc: dmitry@gutov.dev,=C2=A0 62621@debbugs.gnu.org,=C2=A0= = sbaugh@catern.com
> > Date: Mon, 24 Jul 2023 15:18:23 -0400
> >
> > > OK, how about this?
> >
> > Oops, that one didn't include the updated
> > project-uniquify-dirname-transform docstring.=C2=A0 The right pat= ch now:
>
> Thanks, installed, with some minor changes as followup.
>
> The new test uniquify-home fails for me on MS-Windows:
>
>=C2=A0 =C2=A0Test uniquify-home backtrace:
>=C2=A0 =C2=A0 =C2=A0signal(ert-test-failed (((should (equal (mapcar #&#= 39;buffer-name bufs)
>=C2=A0 =C2=A0 =C2=A0ert-fail(((should (equal (mapcar #'buffer-name = bufs) '("~<test>" "~<
>=C2=A0 =C2=A0 =C2=A0(if (unwind-protect (setq value-27 (apply fn-25 arg= s-26)) (setq form
>=C2=A0 =C2=A0 =C2=A0(let (form-description-29) (if (unwind-protect (set= q value-27 (apply
>=C2=A0 =C2=A0 =C2=A0(let ((value-27 'ert-form-evaluation-aborted-28= )) (let (form-descrip
>=C2=A0 =C2=A0 =C2=A0(let* ((fn-25 #'equal) (args-26 (condition-case= err (let ((signal-ho
>=C2=A0 =C2=A0 =C2=A0(save-excursion (setq bufs (cons (find-file-noselec= t "~") bufs)) (se
>=C2=A0 =C2=A0 =C2=A0(let (bufs) (save-excursion (setq bufs (cons (find-= file-noselect "~"
>=C2=A0 =C2=A0 =C2=A0(closure (t) nil (let (bufs) (save-excursion (setq = bufs (cons (find-
>=C2=A0 =C2=A0 =C2=A0ert--run-test-internal(#s(ert--test-execution-info = :test #s(ert-test
>=C2=A0 =C2=A0 =C2=A0ert-run-test(#s(ert-test :name uniquify-home :docum= entation "uniquif
>=C2=A0 =C2=A0 =C2=A0ert-run-or-rerun-test(#s(ert--stats :selector (not = ...) :tests [...
>=C2=A0 =C2=A0 =C2=A0ert-run-tests((not (or (tag :unstable) (tag :native= comp))) #f(compil
>=C2=A0 =C2=A0 =C2=A0ert-run-tests-batch((not (or (tag :unstable) (tag := nativecomp))))
>=C2=A0 =C2=A0 =C2=A0ert-run-tests-batch-and-exit((not (or (tag :unstabl= e) (tag :nativeco
>=C2=A0 =C2=A0 =C2=A0eval((ert-run-tests-batch-and-exit '(not (or (t= ag :unstable) (tag :n
>=C2=A0 =C2=A0 =C2=A0command-line-1(("-L" ";." "= ;-l" "ert" "-l" "lisp/uniquify-tests.el"= "
>=C2=A0 =C2=A0 =C2=A0command-line()
>=C2=A0 =C2=A0 =C2=A0normal-top-level()
>=C2=A0 =C2=A0Test uniquify-home condition:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0(ert-test-failed
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 ((should (equal (mapcar ... bufs) '(&qu= ot;~<test>" "~<>"))) :form
>=C2=A0 =C2=A0 =C2=A0 =C2=A0(equal ("~" "nonexistent"= ;) ("~<test>" "~<>")) :value nil
>=C2=A0 =C2=A0 =C2=A0 =C2=A0:explanation
>=C2=A0 =C2=A0 =C2=A0 =C2=A0(list-elt 0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(arrays-o= f-different-length 1 7 "~" "~<test>"
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0first-mismatch-at 1))))
>
> The idea of the test is not clear to me, so I cannot tell what could > be the reasons.=C2=A0 Feel free to ask me to test changes or ask quest= ions
> about what happens on this Windows system while running the test.
>
>
>
>
--0000000000007363cc06020371e1--