[PATCH] Use flat-button style for inactive modeline

[PATCH] Use flat-button style for inactive modeline

[Pedro Andres Aranda Gutierrez]

[-- Attachment #1.1: Type: text/plain, Size: 465 bytes --]

When the background colour of a face is the same as the colour specified
for a :box with :style nil, it is quicker to specify :style flat-button. It
will choose the face background colour automatically.

Best, /PA
-- 
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run
a leader-deposed hook here, but we can't yet

[-- Attachment #1.2: Type: text/html, Size: 722 bytes --]

[-- Attachment #2: 0001-flat-button-box-doesn-t-need-color.patch --]
[-- Type: text/x-patch, Size: 1357 bytes --]

From b353ceb3e735448a5b36deed42ab91851fcb41ee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pedro=20A=2E=20Aranda=20Guti=C3=A9rrez?= <paaguti@gmail.com>
Date: Sat, 18 Feb 2023 11:38:04 +0000
Subject: [PATCH] flat-button box doesn't need :color

Box style flat-button is an alternative to create a broader
mode-line and you don't need to repeat the background color.
---
 etc/themes/whiteboard-theme.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/themes/whiteboard-theme.el b/etc/themes/whiteboard-theme.el
index adbd69f1c6f..4350d7a1213 100644
--- a/etc/themes/whiteboard-theme.el
+++ b/etc/themes/whiteboard-theme.el
@@ -80,7 +80,7 @@ whiteboard
    `(minibuffer-prompt ((,class (:foreground "DodgerBlue4"))))
    `(mode-line ((,class (:background "gray75" :foreground "black" :box (:line-width 1 :style released-button)))))
    `(mode-line-buffer-id ((,class (:weight bold :background nil :foreground "blue4"))))
-   `(mode-line-inactive ((,class (:background "gray40" :foreground "black" :box (:line-width 1 :color "gray40" :style nil)))))
+   `(mode-line-inactive ((,class (:background "gray40" :foreground "black" :box (:line-width 1 :style flat-button)))))
    `(outline-1 ((,class (:foreground "Blue3"))))
    `(outline-2 ((,class (:foreground "DodgerBlue"))))
    `(outline-3 ((,class (:foreground "SteelBlue"))))
-- 
2.34.1

Re: [PATCH] Use flat-button style for inactive modeline

[Manuel Uberti]

On 18/02/23 16:16, Pedro Andres Aranda Gutierrez wrote:
> When the background colour of a face is the same as the colour specified 
> for a :box with :style nil, it is quicker to specify :style flat-button. 
> It will choose the face background colour automatically.
Just a tip, since it was given to me in the past: it is better to submit 
patches on the bug tracker by using `M-x report-emacs-bug`, in order to 
have one place to discuss and keep track of them.

-- 
Manuel Uberti
https://manueluberti.eu

bug#61608: Fwd: [PATCH] Use flat-button style for inactive modeline

[Pedro Andres Aranda Gutierrez]

[-- Attachment #1.1: Type: text/plain, Size: 837 bytes --]

From: Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
Subject: [PATCH] Use flat-button style for inactive modeline

When the background colour of a face is the same as the colour specified
for a :box with :style nil, it is quicker to specify :style flat-button. It
will choose the face background colour automatically.

Best, /PA
-- 
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run
a leader-deposed hook here, but we can't yet



-- 
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run
a leader-deposed hook here, but we can't yet

[-- Attachment #1.2: Type: text/html, Size: 1530 bytes --]

[-- Attachment #2: 0001-flat-button-box-doesn-t-need-color.patch --]
[-- Type: application/x-patch, Size: 1357 bytes --]